[GitHub] [incubator-druid] viongpanzi commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec
viongpanzi commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r287784384 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java ## @@ -196,7 +246,7 @@ static BaseFloatColumnValueSelector makeColumnValueSelectorWithFloatDefault( if (fieldName != null) { return metricFactory.makeColumnValueSelector(fieldName); } else { - final Expr expr = Parser.parse(fieldExpression, macroTable); + final Expr expr = parseIfAbsent(fieldExpression, macroTable); Review comment: @himanshug sorry for the delayed update! Can you review this patch again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] viongpanzi commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec
viongpanzi commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r287909479 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java ## @@ -196,7 +246,7 @@ static BaseFloatColumnValueSelector makeColumnValueSelectorWithFloatDefault( if (fieldName != null) { return metricFactory.makeColumnValueSelector(fieldName); } else { - final Expr expr = Parser.parse(fieldExpression, macroTable); + final Expr expr = parseIfAbsent(fieldExpression, macroTable); Review comment: @himanshug Thanks for your review. Sorry for the misunderstood! I need to learn more about github and I'll pay attention next time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org