[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups
vogievetsky commented on a change in pull request #7725: Web-Console: add
actions icon to lookups
URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287539358
##
File path: web-console/src/views/task-view/tasks-view.tsx
##
@@ -219,12 +219,12 @@ export class TasksView extends
React.Component {
// FAILED => 1
this.taskQueryManager.runQuery(`SELECT
- "task_id", "type", "datasource", "created_time",
+ "task_id", "type", "datasource", "created_time", "location",
Review comment:
can you remove this change?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups
vogievetsky commented on a change in pull request #7725: Web-Console: add
actions icon to lookups
URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287539425
##
File path: web-console/src/views/lookups-view/lookups-view.tsx
##
@@ -326,33 +351,35 @@ export class LookupsView extends
React.Component
-
- this.lookupsGetQueryManager.rerunLastQuery()}
-/>
-{
- !lookupsError &&
+return<>
+
+
this.openLookupEditDialog('', '')}
+icon={IconNames.REFRESH}
+text="Refresh"
+onClick={() => this.lookupsGetQueryManager.rerunLastQuery()}
/>
-}
-
tableColumnSelectionHandler.changeTableColumnSelection(column)}
- tableColumnsHidden={tableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderLookupsTable()}
- {this.renderLookupEditDialog()}
- {this.renderDeleteLookupAction()}
-;
+ {
+!lookupsError &&
+ this.openLookupEditDialog('', '')}
+/>
+ }
+
tableColumnSelectionHandler.changeTableColumnSelection(column)}
+tableColumnsHidden={tableColumnSelectionHandler.hiddenColumns}
+ />
+
+{this.renderLookupsTable()}
+{this.renderLookupEditDialog()}
+{this.renderDeleteLookupAction()}
+ ;
+;
Review comment:
why is this wrapped in a fragment?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups
vogievetsky commented on a change in pull request #7725: Web-Console: add
actions icon to lookups
URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287183690
##
File path: web-console/src/views/task-view/tasks-view.tsx
##
@@ -648,6 +656,7 @@ ORDER BY "rank" DESC, "created_time" DESC`);
width: 70,
filterable: false,
Cell: row => {
+ console.log(row);
Review comment:
no log please
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups
vogievetsky commented on a change in pull request #7725: Web-Console: add
actions icon to lookups
URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287172048
##
File path: web-console/src/views/lookups-view/lookups-view.tsx
##
@@ -54,9 +56,11 @@ export interface LookupsViewState {
lookupEditSpec: string;
isEdit: boolean;
allLookupTiers: string[];
+ lookupActionDialogId: string | null;
Review comment:
clean this up, not needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups
vogievetsky commented on a change in pull request #7725: Web-Console: add
actions icon to lookups
URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287171719
##
File path: web-console/src/dialogs/table-action-dialog/table-action-dialog.scss
##
@@ -36,6 +36,9 @@ $side-bar-width: 120px;
}
}
+ .bp3-button{
+text-align: center;
Review comment:
what is this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
