[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-561382604 Hi @leventov I rebased this PR to resolve code conflicts. Are you free to take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-554727725 thank you, @leventov get comments addressed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-550104154 thank you, @leventov comments addressed did a force push, put this work on top of https://github.com/apache/incubator-druid/pull/8700, so that compiles with forbidden-apis only the 2nd commit for review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
