[GitHub] clintropolis commented on a change in pull request #6923: Adding a Unified web console.
clintropolis commented on a change in pull request #6923: Adding a Unified web
console.
URL: https://github.com/apache/incubator-druid/pull/6923#discussion_r252441990
##
File path:
services/src/main/java/org/apache/druid/cli/CoordinatorJettyServerInitializer.java
##
@@ -89,24 +88,17 @@ public void initialize(Server server, Injector injector)
{
final ServletContextHandler root = new
ServletContextHandler(ServletContextHandler.SESSIONS);
root.setInitParameter("org.eclipse.jetty.servlet.Default.dirAllowed",
"false");
+root.setInitParameter("org.eclipse.jetty.servlet.Default.redirectWelcome",
"true");
+root.setWelcomeFiles(new String[]{"index.html",
"legacy-coordinator-console.html"});
Review comment:
Yeah, i see so that `/old-console` will drop on `/old-console/index.html`,
nevermind, makes sense 🙃
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] clintropolis commented on a change in pull request #6923: Adding a Unified web console.
clintropolis commented on a change in pull request #6923: Adding a Unified web
console.
URL: https://github.com/apache/incubator-druid/pull/6923#discussion_r252441234
##
File path:
services/src/main/java/org/apache/druid/cli/CoordinatorJettyServerInitializer.java
##
@@ -89,24 +88,17 @@ public void initialize(Server server, Injector injector)
{
final ServletContextHandler root = new
ServletContextHandler(ServletContextHandler.SESSIONS);
root.setInitParameter("org.eclipse.jetty.servlet.Default.dirAllowed",
"false");
+root.setInitParameter("org.eclipse.jetty.servlet.Default.redirectWelcome",
"true");
+root.setWelcomeFiles(new String[]{"index.html",
"legacy-coordinator-console.html"});
Review comment:
Oh, is `old-console`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] clintropolis commented on a change in pull request #6923: Adding a Unified web console.
clintropolis commented on a change in pull request #6923: Adding a Unified web
console.
URL: https://github.com/apache/incubator-druid/pull/6923#discussion_r252440105
##
File path:
services/src/main/java/org/apache/druid/cli/CoordinatorJettyServerInitializer.java
##
@@ -89,24 +88,17 @@ public void initialize(Server server, Injector injector)
{
final ServletContextHandler root = new
ServletContextHandler(ServletContextHandler.SESSIONS);
root.setInitParameter("org.eclipse.jetty.servlet.Default.dirAllowed",
"false");
+root.setInitParameter("org.eclipse.jetty.servlet.Default.redirectWelcome",
"true");
+root.setWelcomeFiles(new String[]{"index.html",
"legacy-coordinator-console.html"});
Review comment:
What is the `index.html` entry for? I don't see an `index.html` page in the
project, as far as I can tell from docs, the paths in the welcome files list
will be appended, in order, to any partial request path until it finds a static
resource that matches.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] clintropolis commented on a change in pull request #6923: Adding a Unified web console.
clintropolis commented on a change in pull request #6923: Adding a Unified web console. URL: https://github.com/apache/incubator-druid/pull/6923#discussion_r252194584 ## File path: server/pom.xml ## @@ -47,6 +47,11 @@ druid-console Review comment: Is the old `io.druid` dependency still needed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
