jihoonson commented on issue #6676: Handoff should ignore segments that are
dropped by drop rules
URL: https://github.com/apache/incubator-druid/pull/6676#issuecomment-446013303
@QiuMM, thank you for updating quickly and sorry for the delayed review.
I've checked the latest changes, and would like to make one more suggestion.
The changed coordinator API (`getSegmentServerview`) now returns a list of
`ImmutableSegmentLoadInfo`s with a `dropped` flag. This is an incompatible
change because this is a documented public API and its return type has been
changed. (Sorry, I didn't notice that before and recommended to change the
existing one.) It means this PR should be labelled Design Review.
However, I think it's not necessary and there might be an easier way to fix
this issue. I would suggest to add a new API for only this internal use case
without changing the existing one. If you do this, you don't have to worry
about compatibility. Also, if the new API just returns a boolean result which
indicates that the given segment is handed off, is waiting for hand off, or
will never be handed off, the API is lighter than returning the entire server
view which is better in terms of efficiency. What do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
