This is an automated email from the ASF dual-hosted git repository. kexianjun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push: new fca31c4 Create constants for 'hash.names' and 'hash.arguments' (#3744) (#3758) fca31c4 is described below commit fca31c45f47da0dbc1cf0a85ad5d87b2384a5c36 Author: Daniela Marques de Morais <danielamor...@tuta.io> AuthorDate: Wed Mar 27 22:22:20 2019 -0300 Create constants for 'hash.names' and 'hash.arguments' (#3744) (#3758) --- .../rpc/cluster/loadbalance/ConsistentHashLoadBalance.java | 7 +++++-- .../src/main/java/org/apache/dubbo/common/Constants.java | 10 ++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalance.java b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalance.java index 83d6f8c..03c0dc9 100644 --- a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalance.java +++ b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalance.java @@ -31,6 +31,9 @@ import java.util.TreeMap; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; +import static org.apache.dubbo.common.Constants.HASH_ARGUMENTS; +import static org.apache.dubbo.common.Constants.HASH_NODES; + /** * ConsistentHashLoadBalance */ @@ -67,8 +70,8 @@ public class ConsistentHashLoadBalance extends AbstractLoadBalance { this.virtualInvokers = new TreeMap<Long, Invoker<T>>(); this.identityHashCode = identityHashCode; URL url = invokers.get(0).getUrl(); - this.replicaNumber = url.getMethodParameter(methodName, "hash.nodes", 160); - String[] index = Constants.COMMA_SPLIT_PATTERN.split(url.getMethodParameter(methodName, "hash.arguments", "0")); + this.replicaNumber = url.getMethodParameter(methodName, HASH_NODES, 160); + String[] index = Constants.COMMA_SPLIT_PATTERN.split(url.getMethodParameter(methodName, HASH_ARGUMENTS, "0")); argumentIndex = new int[index.length]; for (int i = 0; i < index.length; i++) { argumentIndex[i] = Integer.parseInt(index[i]); diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java b/dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java index 28bc2e0..3f48821 100644 --- a/dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java +++ b/dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java @@ -793,6 +793,16 @@ public class Constants { public static final String TELNET = "telnet"; /** + * Hash nodes name + */ + public static final String HASH_NODES = "hash.nodes"; + + /** + * Hash arguments name + */ + public static final String HASH_ARGUMENTS = "hash.arguments"; + + /** * Application name; */ public static final String NAME = "name";