date:20210822

[GitHub] [echarts] Sanitha-11224 opened a new issue #15580: I think you can try , where you can use callba

2021-08-22 Thread GitBox



Sanitha-11224 opened a new issue #15580:
URL: https://github.com/apache/echarts/issues/15580


   I think you can try 
,
 where you can use callback function to `return '';` for zero value.
   
   _Originally posted by @100pah in 
https://github.com/apache/echarts/issues/4968#issuecomment-274275863_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] closed issue #15580: I think you can try , where you can use callback

2021-08-22 Thread GitBox



echarts-bot[bot] closed issue #15580:
URL: https://github.com/apache/echarts/issues/15580


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on issue #15580: I think you can try , where you can use cal

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15580:
URL: https://github.com/apache/echarts/issues/15580#issuecomment-903455367


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。
   为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。
   如果您愿意，请使用 issue 模板重新创建 issue。
   
   如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] ammmmmms edited a comment on issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



amms edited a comment on issue #15578:
URL: https://github.com/apache/echarts/issues/15578#issuecomment-903443040


   > This is not a bug. This is because the default 
[symbol](https://echarts.apache.org/en/option.html#series-tree.symbol) is 
`'emptyCircle'`. You can set it to be `'circle'` and it will use `color` as 
filling color.
   
   I just tried it，but I still have a question. the tree node can't show the 
collapsing and expansion state color when I set the symbol to 'circle'， and 
`color` does not seem to support callback functions like this ` (params: 
Object) => Color`， is there any other way to make the `borderColor` work？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] ammmmmms commented on issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



amms commented on issue #15578:
URL: https://github.com/apache/echarts/issues/15578#issuecomment-903443040


   > This is not a bug. This is because the default 
[symbol](https://echarts.apache.org/en/option.html#series-tree.symbol) is 
`'emptyCircle'`. You can set it to be `'circle'` and it will use `color` as 
filling color.
   
   I just tried it，but I still have a little doubt. the tree node can't show 
the collapsing and expansion state color when I set the symbol to 'circle'， and 
`color` does not seem to support callback functions like this ` (params: 
Object) => Color`， is there any other way to make the `borderColor` work？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] htr3n opened a new issue #15579: Null values with category-based Y-axis don't render correctly

2021-08-22 Thread GitBox



htr3n opened a new issue #15579:
URL: https://github.com/apache/echarts/issues/15579


   ### Version
   5.1.2
   
   ### Reproduction link
   [https://codepen.io/htr3n/pen/YzQKMrq](https://codepen.io/htr3n/pen/YzQKMrq)
   
   ### Steps to reproduce
   1. Define a chart with the following options
   - A-axis with type "category", set `data` to some kind of category such as 
`["6:00", "6:30", "7:00", "7:30"]`
   - Y-axis with type "category", set `data` to some sort of category for 
instance `["A", "B", "C", "D"]`
   - A series with a list of null input data: `data: [null, null, null, null],` 
   
   ### What is expected?
   The chart should not render any values because they are all null.
   
   ### What is actually happening?
   The chart renders the first value at the position of the first Y-axis 
category.
   
   ---
   Replace `null` with `undefined`, the chart seems to render correctly.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on issue #15579: Null values with category-based Y-axis don't render correctly

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15579:
URL: https://github.com/apache/echarts/issues/15579#issuecomment-903428547


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible 
demo** and necessary **images** to illustrate. Otherwise, our committers will 
ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components 
as possible but can still illustrate your problem. This is the best way for us 
to reproduce it and solve the problem faster.
   
   You may also check out the [API](http://echarts.apache.org/api.html) and 
[chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe to our [mailing 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] plainheart commented on issue #15577: ECharts 中支持的图表行为 highlight 不能高亮多个系列吗

2021-08-22 Thread GitBox



plainheart commented on issue #15577:
URL: https://github.com/apache/echarts/issues/15577#issuecomment-903419727


   我补充一下：有个 PR #15207 修复了这个"bug"。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] ammmmmms closed issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



amms closed issue #15578:
URL: https://github.com/apache/echarts/issues/15578


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] ammmmmms commented on issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



amms commented on issue #15578:
URL: https://github.com/apache/echarts/issues/15578#issuecomment-903413146


   > This is not a bug. This is because the default 
[symbol](https://echarts.apache.org/en/option.html#series-tree.symbol) is 
`'emptyCircle'`. You can set it to be `'circle'` and it will use `color` as 
filling color.
   
   thanks for your answer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] Ovilia closed issue #15560: Echarts graph force update node problem. Echart力导图节点更新问题。

2021-08-22 Thread GitBox



Ovilia closed issue #15560:
URL: https://github.com/apache/echarts/issues/15560


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] Ovilia commented on issue #15577: ECharts 中支持的图表行为 highlight 不能高亮多个系列吗

2021-08-22 Thread GitBox



Ovilia commented on issue #15577:
URL: https://github.com/apache/echarts/issues/15577#issuecomment-903411493


   highlight 语义上表示鼠标引起的高亮，所以逻辑上并不支持多个系列高亮。如果有这个需求，可以监听鼠标事件，然后通过 setOption 
把相应系列设为高亮。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] Ovilia commented on issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



Ovilia commented on issue #15578:
URL: https://github.com/apache/echarts/issues/15578#issuecomment-903410981


   This is not a bug. This is because the default 
[symbol](https://echarts.apache.org/en/option.html#series-tree.symbol) is 
`'emptyCircle'`. You can set it to be `'circle'` and it will use `color` as 
filling color.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] ammmmmms opened a new issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



amms opened a new issue #15578:
URL: https://github.com/apache/echarts/issues/15578


   ### Version
   5.1.2
   
   ### Reproduction link
   [https://jsfiddle.net/zhtk7mw1/](https://jsfiddle.net/zhtk7mw1/)
   
   ### Steps to reproduce
   In tree chart, I want to set borderColor without filling color, but setting 
borderColor did not work, and then found that the value of color will be 
regarded as borderColor
   
   itemStyle: {
color: "rgba(225, 99, 99, 1)",
   borderColor: "rgba(111, 238, 26, 1)",
   borderWidth: 2
   }
   
   ### What is expected?
   need the same effect as in V4
   
   ### What is actually happening?
   set borderColor and borderWidth in tree chart will be work
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on issue #15578: borderWidth and borderColor in the tree chart doesn't work

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15578:
URL: https://github.com/apache/echarts/issues/15578#issuecomment-903403811


   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible 
demo** and necessary **images** to illustrate. Otherwise, our committers will 
ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components 
as possible but can still illustrate your problem. This is the best way for us 
to reproduce it and solve the problem faster.
   
   You may also check out the [API](http://echarts.apache.org/api.html) and 
[chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org. Please 
attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe to our [mailing 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] yang201806 opened a new issue #15577: ECharts 中支持的图表行为 highlight 不能高亮多个系列吗

2021-08-22 Thread GitBox



yang201806 opened a new issue #15577:
URL: https://github.com/apache/echarts/issues/15577


   ### Version
   5.0.2
   
   ### Steps to reproduce
   官网文档如下
   
   // 如果要高亮系列：
   dispatchAction({
   type: 'highlight',
   
   // 用 index 或 id 或 name 来指定系列。
   // 可以使用数组指定多个系列。
   seriesIndex?: number | number[],
   seriesId?: string | string[],
   seriesName?: string | string[],
   
   // 数据项的 index，如果不指定也可以通过 name 属性根据名称指定数据项
   dataIndex?: number | number[],
   // 可选，数据项名称，在有 dataIndex 的时候忽略
   name?: string | string[],
   });
   
   我测试也下
   dispatchAction({
   type: 'highlight',
   seriesName:["系列1","系列2"]
   });
   
   ### What is expected?
   预期：系列1和系列2都高亮
   
   ### What is actually happening?
   只有 “系列2” 高度了
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on issue #15577: ECharts 中支持的图表行为 highlight 不能高亮多个系列吗

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15577:
URL: https://github.com/apache/echarts/issues/15577#issuecomment-903401122






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on issue #15576: Use emoji as spirit

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15576:
URL: https://github.com/apache/echarts/issues/15576#issuecomment-903395890


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。
   为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。
   如果您愿意，请使用 issue 模板重新创建 issue。
   
   如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] Chandler-Zhu opened a new issue #15576: Use emoji as spirit

2021-08-22 Thread GitBox



Chandler-Zhu opened a new issue #15576:
URL: https://github.com/apache/echarts/issues/15576


   I tried to use an emoji as spirit but it doesn't work
   `var spirit = ''`
   and the result looks like this 
   
![image](https://user-images.githubusercontent.com/61914365/130381674-ec178fe5-c4ef-4da8-bee2-9e318845b48f.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] closed issue #15576: Use emoji as spirit

2021-08-22 Thread GitBox



echarts-bot[bot] closed issue #15576:
URL: https://github.com/apache/echarts/issues/15576


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on issue #15575: Cannot create property 'event' on string 'xxx'

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15575:
URL: https://github.com/apache/echarts/issues/15575#issuecomment-903380042


   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。
   为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。
   如果您愿意，请使用 issue 模板重新创建 issue。
   
   如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] closed issue #15575: Cannot create property 'event' on string 'xxx'

2021-08-22 Thread GitBox



echarts-bot[bot] closed issue #15575:
URL: https://github.com/apache/echarts/issues/15575


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] SilverBeats opened a new issue #15575: Cannot create property 'event' on string 'xxx'

2021-08-22 Thread GitBox



SilverBeats opened a new issue #15575:
URL: https://github.com/apache/echarts/issues/15575


   I now use the example provided on the official website: stacked line chart
   I copied the sample code, minimal bundle, and ran without problem.
   However, after the package is completed, the following error will be printed 
on the console:
   Cannot create property 'event' on string 'dataZoom'
   Cannot create property 'event' on string 'legendToggleSelected
   Later, I imported all of echarts instead of minimal bundle. This problem no 
longer occurs.
   So, how do I write code if I want to introduce the echarts components I use 
on demand


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] plainheart edited a comment on pull request #13929: feat(symbol): various clipping on the symbol.

2021-08-22 Thread GitBox



plainheart edited a comment on pull request #13929:
URL: https://github.com/apache/echarts/pull/13929#issuecomment-754638144


   > I think we don't have to implement the string expression of CSS clip-path. 
It's too complex and not easy to debug. Also, it's not friendly for type 
checking. We prefer to express the clipping by object configuration like color 
gradient, for example:
   > 
   > ```ts
   > clipPath: { type: 'rect', shape: {x} }
   > ```
   > 
   > I think we have similar configurations in the `graphic` component.
   > 
   
   @pissang No problem. The object configuration rule is my very first 
implementation scheme.
   But after a short time, I think it may be better to follow the CSS rule 
because the developers needn't make extra conversions and changes. So I made a 
refactor for this.
   If making an object for `clip-path` is better, I will revert the 
implementation and dive into it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] plainheart closed issue #15568: echartsInstance. clear 无法清空series中设置的lines

2021-08-22 Thread GitBox



plainheart closed issue #15568:
URL: https://github.com/apache/echarts/issues/15568


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] locinus commented on issue #3637: Lines and mark areas disappear during zooming

2021-08-22 Thread GitBox



locinus commented on issue #3637:
URL: https://github.com/apache/echarts/issues/3637#issuecomment-903303988


   Other workaround proposed on the other topic: 
https://github.com/apache/echarts/issues/14835#issuecomment-903303711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] locinus edited a comment on issue #14835: Lines and mark areas disappear during zooming

2021-08-22 Thread GitBox



locinus edited a comment on issue #14835:
URL: https://github.com/apache/echarts/issues/14835#issuecomment-903303711


   I indeed believe this issue still exists: markLines defined by two points 
disappear when zooming in, as at least one of the points is out of the zoomed 
window, and even with the filterMode: 'none' option.
   
   A possible workaround could be to hook on the 'datazoom' event and save the 
zoom state:
   
   ```
   const zoomState = {};
   
   echartsInstance.on('datazoom', (event) => {
 const option = echartsInstance.getOption();
 if(option.dataZoom && Array.isArray(option.dataZoom) && 
option.dataZoom.length > 0) {
   zoomState.startValue = option.dataZoom[0].startValue;
   zoomState.endValue = option.dataZoom[0].endValue;
 }
   });
   ```
   
   and then proceed to recalculate the chart's options, using the 
zoomState.startValue and zoomState.endValue as the boundaries of the markLines 
(I would add +1 to the startValue and -1 to the endValue to make sure we're 
within the zoomed window). Not ideal, but does the job.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] locinus edited a comment on issue #14835: Lines and mark areas disappear during zooming

2021-08-22 Thread GitBox



locinus edited a comment on issue #14835:
URL: https://github.com/apache/echarts/issues/14835#issuecomment-903303711


   I indeed believe this issue still exists: markLines defined by two points 
disappear when zooming in, as at least one of the points is out of the zoomed 
window, and even with the filterMode: 'none' option.
   
   A possible workaround could be to hook on the 'datazoom' event and save the 
zoom state:
   
   const zoomState = {};
   
   ```
   echartsInstance.on('datazoom', (event) => {
 const option = echartsInstance.getOption();
 if(option.dataZoom && Array.isArray(option.dataZoom) && 
option.dataZoom.length > 0) {
   zoomState.startValue = option.dataZoom[0].startValue;
   zoomState.endValue = option.dataZoom[0].endValue;
 }
   });
   ```
   
   and then proceed to recalculate the chart's options, using the 
zoomState.startValue and zoomState.endValue as the boundaries of the markLines 
(I would add +1 to the startValue and -1 to the endValue to make sure we're 
within the zoomed window). Not ideal, but does the job.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] locinus commented on issue #14835: Lines and mark areas disappear during zooming

2021-08-22 Thread GitBox



locinus commented on issue #14835:
URL: https://github.com/apache/echarts/issues/14835#issuecomment-903303711


   I indeed believe this issue still exists: markLines defined by two points 
disappear when zooming in, as at least one of the points is out of the zoomed 
window, and even with the filterMode: 'none' option.
   
   A possible workaround could be to hook on the 'datazoom' event and save the 
zoom state:
   
   const zoomState = {};
   
   echartsInstance.on('datazoom', (event) => {
 const option = echartsInstance.getOption();
 if(option.dataZoom && Array.isArray(option.dataZoom) && 
option.dataZoom.length > 0) {
   zoomState.startValue = option.dataZoom[0].startValue;
   zoomState.endValue = option.dataZoom[0].endValue;
 }
   });
   
   and then proceed to recalculate the chart's options, using the 
zoomState.startValue and zoomState.endValue as the boundaries of the markLines 
(I would add +1 to the startValue and -1 to the endValue to make sure we're 
within the zoomed window). Not ideal, but does the job.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15573: fix(bar): optimize label distance when using round cap

2021-08-22 Thread GitBox



echarts-bot[bot] commented on pull request #15573:
URL: https://github.com/apache/echarts/pull/15573#issuecomment-903267317


   Congratulations! Your PR has been merged. Thanks for your contribution! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts] branch master updated (4569dc1 -> 78d20e1)

2021-08-22 Thread sushuang

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git.


from 4569dc1  Merge pull request #15355 from apache/dataset-perf
 add 8ee3fed  fix(bar): optimize label distance when using round cap
 new 78d20e1  Merge pull request #15573 from 
apache/fix-sausage-label-distance

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/chart/bar/BarView.ts  |  8 --
 src/label/sectorLabel.ts  | 72 ---
 test/bar-polar-label.html |  5 +++-
 3 files changed, 53 insertions(+), 32 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts] 01/01: Merge pull request #15573 from apache/fix-sausage-label-distance

2021-08-22 Thread sushuang

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 78d20e15d3e195fab7dcd8e63a7bb195336d1010
Merge: 4569dc1 8ee3fed
Author: sushuang 
AuthorDate: Sun Aug 22 21:13:21 2021 +0800

Merge pull request #15573 from apache/fix-sausage-label-distance

fix(bar): optimize label distance when using round cap

 src/chart/bar/BarView.ts  |  8 --
 src/label/sectorLabel.ts  | 72 ---
 test/bar-polar-label.html |  5 +++-
 3 files changed, 53 insertions(+), 32 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] 100pah merged pull request #15573: fix(bar): optimize label distance when using round cap

2021-08-22 Thread GitBox



100pah merged pull request #15573:
URL: https://github.com/apache/echarts/pull/15573


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] 100pah merged pull request #15355: dataset: fix dataset performance drops signifcantly on high dimensions data.

2021-08-22 Thread GitBox



100pah merged pull request #15355:
URL: https://github.com/apache/echarts/pull/15355


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15355: dataset: fix dataset performance drops signifcantly on high dimensions data.

2021-08-22 Thread GitBox



echarts-bot[bot] commented on pull request #15355:
URL: https://github.com/apache/echarts/pull/15355#issuecomment-903267022


   Congratulations! Your PR has been merged. Thanks for your contribution! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts] 01/01: Merge pull request #15355 from apache/dataset-perf

2021-08-22 Thread sushuang

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 4569dc1d8b712dafb80b16e31c4fed0118e3acbd
Merge: 0d5496f 53fa03d
Author: sushuang 
AuthorDate: Sun Aug 22 21:10:52 2021 +0800

Merge pull request #15355 from apache/dataset-perf

dataset: fix dataset performance drops signifcantly on high dimensions data.

 package-lock.json  |  204 +-
 package.json   |4 +-
 src/animation/universalTransition.ts   |   18 +-
 src/chart/bar/BarSeries.ts |   10 +-
 src/chart/bar/BarView.ts   |   24 +-
 src/chart/bar/BaseBarSeries.ts |8 +-
 src/chart/bar/PictorialBarView.ts  |   16 +-
 src/chart/boxplot/BoxplotView.ts   |8 +-
 src/chart/candlestick/CandlestickSeries.ts |4 +-
 src/chart/candlestick/CandlestickView.ts   |8 +-
 src/chart/candlestick/candlestickLayout.ts |   61 +-
 src/chart/custom/CustomSeries.ts   |8 +-
 src/chart/custom/CustomView.ts |   22 +-
 src/chart/effectScatter/EffectScatterSeries.ts |   10 +-
 src/chart/funnel/FunnelSeries.ts   |8 +-
 src/chart/funnel/FunnelView.ts |   10 +-
 src/chart/funnel/funnelLayout.ts   |6 +-
 src/chart/gauge/GaugeSeries.ts |8 +-
 src/chart/gauge/GaugeView.ts   |4 +-
 src/chart/graph/GraphSeries.ts |   14 +-
 src/chart/graph/GraphView.ts   |4 +-
 src/chart/graph/circularLayoutHelper.ts|4 +-
 src/chart/heatmap/HeatmapSeries.ts |8 +-
 src/chart/helper/EffectLine.ts |   14 +-
 src/chart/helper/EffectPolyline.ts |4 +-
 src/chart/helper/EffectSymbol.ts   |6 +-
 src/chart/helper/LargeLineDraw.ts  |4 +-
 src/chart/helper/LargeSymbolDraw.ts|   12 +-
 src/chart/helper/Line.ts   |   12 +-
 src/chart/helper/LineDraw.ts   |   10 +-
 src/chart/helper/Polyline.ts   |   12 +-
 src/chart/helper/Symbol.ts |   12 +-
 src/chart/helper/SymbolDraw.ts |   12 +-
 src/chart/helper/createGraphFromNodeEdge.ts|   23 +-
 ...{createListFromArray.ts => createSeriesData.ts} |  147 +-
 ...eateListSimply.ts => createSeriesDataSimply.ts} |   20 +-
 src/chart/helper/labelHelper.ts|   12 +-
 src/chart/helper/whiskerBoxCommon.ts   |8 +-
 src/chart/line/LineSeries.ts   |8 +-
 src/chart/line/LineView.ts |   22 +-
 src/chart/line/helper.ts   |6 +-
 src/chart/line/lineAnimationDiff.ts|6 +-
 src/chart/lines/LinesSeries.ts |4 +-
 src/chart/lines/LinesView.ts   |6 +-
 src/chart/lines/linesVisual.ts |6 +-
 src/chart/map/MapSeries.ts |   10 +-
 src/chart/map/mapDataStatistic.ts  |4 +-
 src/chart/parallel/ParallelSeries.ts   |8 +-
 src/chart/parallel/ParallelView.ts |   10 +-
 src/chart/pie/PieSeries.ts |8 +-
 src/chart/pie/PieView.ts   |   10 +-
 src/chart/radar/RadarSeries.ts |8 +-
 src/chart/radar/RadarView.ts   |   10 +-
 src/chart/sankey/SankeySeries.ts   |7 +-
 src/chart/sankey/SankeyView.ts |4 +-
 src/chart/scatter/ScatterSeries.ts |   10 +-
 src/chart/scatter/ScatterView.ts   |4 +-
 src/chart/sunburst/SunburstSeries.ts   |4 +-
 src/chart/themeRiver/ThemeRiverSeries.ts   |   10 +-
 src/chart/themeRiver/themeRiverLayout.ts   |4 +-
 src/chart/tree/TreeSeries.ts   |8 +-
 src/chart/tree/TreeView.ts |   12 +-
 src/chart/treemap/TreemapSeries.ts |4 +-
 src/component/dataZoom/AxisProxy.ts|   14 +-
 src/component/helper/MapDraw.ts|4 +-
 src/component/marker/MarkAreaView.ts   |   26 +-
 src/component/marker/MarkLineView.ts   |   24 +-
 src/component/marker/MarkPointView.ts  |   19 +-
 src/component/marker/MarkerModel.ts|   10 +-
 src/component/marker/markerHelper.ts   |   55 +-
 src/component/timeline/SliderTimelineModel.ts  |4 +-
 src/component/timeline/TimelineModel.ts|6 +-
 src/component/tooltip/TooltipHTMLContent.ts|2 +-

[echarts] branch master updated (0d5496f -> 4569dc1)

2021-08-22 Thread sushuang

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git.


from 0d5496f  fix typos, clarify (#15512)
 add 8e1c0fe  perf(dataset): improve name-gen perf for high dim data.
 add 85ee886  refact(data): separate List to DataStorage and SeriesData
 add deafca7  refact(data): fix some typo bugs
 add 973b70d  refact(data): fix downsample
 add ed75a2e  refact(data): indices should not keep after clone
 add 6c07c45  refact(data): share storage on same dataset.
 add 1d4be90  refact: optimize createDimensions. update test
 add 63c4177  refact(data): fix several issues in storage sharing
 add 027cf16  refact(data): cant reuse storage if ordinalMeta is different
 add 2cac7ca  refact(data): fix seriesLayoutBy and sourceHeader
 add 2a8b198  refact(data): fix chunk not exists when data is empty.
 add 8b2e48b  refact(dim): remove completeDimensions
 add 7739a95  refact(data): only pick necessary dimensions when using 
dataset
 add ff7498a  refact(data): add back appendValues. fix ut
 add 83bc2d9  refact(data): fix createDimensions multiple times cause 
default encode  wrong.
 add bf059ad  refact(data): share source instance with dataset
 add 50d430d  refact(data): not clone store if possible
 add 53113c4  refact(data): omit unused dimensions in createDimensions
 add 7573ceb  refact(data): try to cache dim name map in complete dimensions
 add 0349b87  refact(data): fix type from dataset may incorrect.
 add e9e6077  refact(data): fix storage clone lost indices.
 add 325a5c9  Merge branch 'master' into dataset-perf
 add 345402d  refact: don't recreate data storage when converting float to 
time
 add e026f3f  refact(data): fix marker
 add 3475b9c  refact(data): fix some extent calc issues
 add 23548b8  test(ut): add path alias for root dir
 add 1d8da4a  refact(data): getValues from storage. add unit test
 add 7dd81e1  refact(data): add missing unit test update
 add 48044f0  Merge branch 'master' into dataset-perf
 add 8abf642  merge from master
 add d0217e1  Merge branch 'master' into dataset-perf
 add 015e272  fix(series): only get encode from series. not from global
 add 3b6857f  refact(data): tweak some misleading code
 add cfcb981  style: update comments
 add 4ea973b  style: improve comments
 add 8766830  Merge branch 'master' into dataset-perf
 add 3de73ab  chore: update zrender to latest nightly version
 add 3c09b59  fix(data): fix some code review issues
 add 0d5886b  refact(data): create data storage after dimensions prepared.
 add 5bc0c51  refact(data): optimize stack on high dimension data
 add 90a369c  refact(data): add ordinaMeta to the dimensions key
 add c91d711  fix typo
 add b785031  refact(data): reverse the optimization of genName
 add 690647c  refact(data): remove duplication of name generally
 add 6bed301  refact(data): create default dimensions for dataset
 add e252249  refact(data): add dimension name to the key.
 add 9d6c597  refact(data): tweak dimension hash generation
 add bfeb495  revert name gen logic
 add 40e9590  fix wrong fromZero logic in createDimensions
 add ae9226e  refact(data): compatibility with exists echarts-gl code.
 add 7819423  Merge branch 'master' into dataset-perf
 add 8e6bd68  refact(data): fix wrong index when only using part of the 
dimensions in SeriesData
 add 2bf188f  refact(data): fix unexpected code removement
 add 10aed78  fix: fix createDimension result might container 
name:undefined when dimensions more than 30.
 add dffeb3a  **There are these issues existing before this commit:** (1). 
If no dimensions specified on dataset, series can not really share one storage 
instance. (Because the each series will create its own dimension name (like 
['x', 'y', 'value'], ['x', 'value', 'y'], and the storage hash is based on 
those names. So the hash can not match). (2). Each time `setOption` update 
series (but not change `dataset`), new data stack dimensions (and corresponding 
chunks) will be keep added to [...]
 add 5e38220  update eslint-plugin version
 add c7d5734  Merge branch 'master' into dataset-perf
 add 39c7111  fix: rename `SeriesDimensionRequest` to `SeriesDataSchema`.
 add 8aacfd1  fix: remove deprecated of some method of SeriesData. They are 
widely used by extensions.
 add 15f217a  fix: revert dis/echarts.js.map (mistakenly committed 
previously)
 add 6e0a254  fix: update package-lock to fix ci fail (previous commit only 
commit package.json, for update eslint-plugin version, for npm run checktype 
fail, for old tslib that the eslint-plugin used in the old version).
 add 1e3f1ad  fix: rename to make name shorter.
 add dd48619  fix: rename shorter.
 add f26ccae  fix: rename DataStorage ->

[echarts] branch dataset-perf updated (c0bb629 -> 53fa03d)

2021-08-22 Thread sushuang

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a change to branch dataset-perf
in repository https://gitbox.apache.org/repos/asf/echarts.git.


from c0bb629  fix: tweak test case.
 add 53fa03d  fix: fix ut.

No new revisions were added by this update.

Summary of changes:
 test/ut/spec/data/createDimensions.test.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts] branch dataset-perf updated (dd48619 -> c0bb629)

2021-08-22 Thread sushuang

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a change to branch dataset-perf
in repository https://gitbox.apache.org/repos/asf/echarts.git.


from dd48619  fix: rename shorter.
 add f26ccae  fix: rename DataStorage -> dataStore and some other renames.
 add 136a97c  fix: fix some issues brought by refactor.
 add afafc7b  fix: other rename of data storage -> data store
 add ea7b2ec  fix: fix and add test cases.
 add 75dc3ab  fix: add test case.
 add 4d1b252  fix: fix issue brought by previous refactor.
 add c0bb629  fix: tweak test case.

No new revisions were added by this update.

Summary of changes:
 src/chart/candlestick/candlestickLayout.ts  |  34 +--
 src/chart/custom/CustomView.ts  |   4 +-
 src/chart/helper/createGraphFromNodeEdge.ts |   4 +-
 src/chart/helper/createSeriesData.ts|  14 +-
 src/chart/helper/createSeriesDataSimply.ts  |   8 +-
 src/chart/radar/RadarView.ts|   2 +-
 src/chart/sankey/SankeySeries.ts|   3 -
 src/chart/themeRiver/ThemeRiverSeries.ts|   4 +-
 src/chart/tree/TreeSeries.ts|   2 -
 src/component/dataZoom/AxisProxy.ts |   4 +-
 src/component/visualMap/ContinuousView.ts   |   2 +-
 src/data/{DataStorage.ts => DataStore.ts}   | 108 +
 src/data/Graph.ts   |   2 +-
 src/data/SeriesData.ts  |  65 ++---
 src/data/SeriesDimensionDefine.ts   |   8 +-
 src/data/Tree.ts|   6 +-
 src/data/helper/SeriesDataSchema.ts |  42 ++--
 src/data/helper/createDimensions.ts |  16 +-
 src/data/helper/dataProvider.ts |  83 ---
 src/data/helper/dataStackHelper.ts  |  26 +-
 src/data/helper/dimensionHelper.ts  |  10 +-
 src/data/helper/sourceManager.ts|  38 +--
 src/layout/barGrid.ts   |  20 +-
 src/layout/points.ts|   2 +-
 src/util/types.ts   |   7 +-
 src/visual/aria.ts  |   2 +-
 src/visual/visualSolution.ts|   4 +-
 test/bar-stack.html | 358 ++--
 test/dataset-case.html  |  38 +--
 test/lib/reset.css  |   1 +
 test/runTest/actions/__meta__.json  |   2 +-
 test/runTest/actions/bar-stack.json |   2 +-
 test/sankey.html|  90 +--
 test/ut/spec/data/SeriesData.test.ts|  26 +-
 34 files changed, 665 insertions(+), 372 deletions(-)
 rename src/data/{DataStorage.ts => DataStore.ts} (94%)

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts-handbook] branch gh-pages updated (102af38 -> 0ddfa49)

2021-08-22 Thread github-bot

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/echarts-handbook.git.


 discard 102af38  Deploying to gh-pages from @ 
apache/echarts-handbook@1b670e21c275540147a59060ced0a3aa1d7e3f1f 
 new 0ddfa49  Deploying to gh-pages from @ 
apache/echarts-handbook@af33fefec3705e9205e1eb341c05a0d9ffe570f4 

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (102af38)
\
 N -- N -- N   refs/heads/gh-pages (0ddfa49)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 docs/200.html  |   6 +-
 docs/_nuxt/{4e5def6.js => 6e18985.js}  |   2 +-
 .../content/{db-8eaf3253.json => db-fd5d137d.json} |   2 +-
 docs/_nuxt/js/8de064f3c3690eed5632.js  |   1 -
 docs/_nuxt/js/c92fdaafd1d284223ca0.js  |   1 +
 docs/_nuxt/js/eb7795a682aca6e977bd.js  |   1 +
 docs/_nuxt/js/f08bb75ad7ce29db0955.js  |   1 -
 .../chart-types/bar/basic-bar/index.html   |  51 
 .../chart-types/bar/stacked-bar/index.html |  21 ++
 .../chart-types/line/area-line/index.html  |  16 ++
 .../chart-types/line/basic-line/index.html |  41 
 .../chart-types/line/smooth-line/index.html|  15 ++
 .../chart-types/line/stacked-line/index.html   |  17 ++
 .../chart-types/line/step-line/index.html  |  19 ++
 .../chart-types/pie/basic-pie/index.html   |  27 +++
 .../chart-types/pie/doughnut/index.html|  24 ++
 .../en/application/chart-types/pie/rose/index.html |  16 ++
 .../chart-types/scatter/basic-scatter/index.html   |  38 +++
 .../application/cross-platform/server/index.html   |  23 ++
 docs/en/application/data/dynamic-data/index.html   |  32 +++
 docs/en/application/interaction/drag/index.html|  38 +++
 docs/en/application/label/rich-text/index.html |  98 
 docs/en/basics/download/index.html |   6 +-
 docs/en/basics/help/index.html |   6 +-
 docs/en/basics/import/index.html   |   6 +-
 docs/en/basics/inspiration/index.html  |   6 +-
 docs/en/basics/release-note/v5-feature/index.html  | 109 +
 .../release-note/v5-upgrade-guide/index.html   | 256 
 docs/en/best-practice/aria/index.html  |   6 +-
 docs/en/best-practice/canvas-vs-svg/index.html |   6 +-
 docs/en/concepts/axis/index.html   |   6 +-
 docs/en/concepts/chart-size/index.html |   6 +-
 docs/en/concepts/data-transform/index.html |   6 +-
 docs/en/concepts/dataset/index.html|   6 +-
 docs/en/concepts/event/index.html  |   6 +-
 docs/en/concepts/legend/index.html |   6 +-
 docs/en/concepts/style/index.html  |   6 +-
 docs/en/concepts/visual-map/index.html |   6 +-
 docs/en/get-started/index.html |   6 +-
 docs/en/index.html |   4 +-
 docs/en/meta/edit-guide/index.html |   6 +-
 docs/index.html|   4 +-
 .../chart-types/bar/basic-bar/index.html   |  50 
 .../chart-types/bar/stacked-bar/index.html |  21 ++
 .../chart-types/line/area-line/index.html  |  16 ++
 .../chart-types/line/basic-line/index.html |  41 
 .../chart-types/line/smooth-line/index.html|  15 ++
 .../chart-types/line/stacked-line/index.html   |  17 ++
 .../chart-types/line/step-line/index.html  |  19 ++
 .../chart-types/pie/basic-pie/index.html   |  27 +++
 .../chart-types/pie/doughnut/index.html|  24 ++
 .../zh/application/chart-types/pie/rose/index.html |  16 ++
 .../chart-types/scatter/basic-scatter/index.html   |  39 
 .../cross-platform/baidu-app/index.html|  21 ++
 .../application/cross-platform/server/index.html   |  22 ++
 .../cross-platform/wechat-app/index.html   |  25 ++
 docs/zh/application/data/dynamic-data/index.html   |  32 +++
 docs/zh/application/interaction/drag/index.html|  39 
 docs/zh/application/label/rich-text/index.html

[echarts-handbook] branch master updated: fix echarts version. fix crawler of nav not shown.

2021-08-22 Thread shenyi

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts-handbook.git


The following commit(s) were added to refs/heads/master by this push:
 new af33fef  fix echarts version. fix crawler of nav not shown.
af33fef is described below

commit af33fefec3705e9205e1eb341c05a0d9ffe570f4
Author: pissang 
AuthorDate: Sun Aug 22 17:08:32 2021 +0800

fix echarts version. fix crawler of nav not shown.
---
 components/markdown/Live.vue | 5 -
 components/partials/SidebarNavItem.vue   | 2 +-
 contents/zh/basics/release-note/5-2-0.md | 1 +
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/components/markdown/Live.vue b/components/markdown/Live.vue
index 0094223..4af5545 100644
--- a/components/markdown/Live.vue
+++ b/components/markdown/Live.vue
@@ -41,7 +41,10 @@ declare const echarts: any
 function ensureECharts() {
   if (typeof echarts === 'undefined') {
 return loadScriptsAsync([
-  '//localhost/echarts/dist/echarts.js'
+  // 'https://cdn.jsdelivr.net/npm/echarts/dist/echarts.js'
+  process.env.NUXT_ENV_DEPLOY === 'asf'
+? 'https://cdn.jsdelivr.net/npm/echarts/dist/echarts.js'
+: 'https://cdn.jsdelivr.net/npm/echarts-nightly/dist/echarts.min.js'
 ]).then(() => {})
   }
   return Promise.resolve()
diff --git a/components/partials/SidebarNavItem.vue 
b/components/partials/SidebarNavItem.vue
index da6b9b1..0c74fab 100644
--- a/components/partials/SidebarNavItem.vue
+++ b/components/partials/SidebarNavItem.vue
@@ -20,7 +20,7 @@

[echarts-handbook] branch gh-pages updated (964d2e8 -> 102af38)

2021-08-22 Thread github-bot

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/echarts-handbook.git.


 discard 964d2e8  Deploying to gh-pages from @ 
apache/echarts-handbook@339e1a395e7db3e1f599a6a2fa86cb17692eafd4 
 new 102af38  Deploying to gh-pages from @ 
apache/echarts-handbook@1b670e21c275540147a59060ced0a3aa1d7e3f1f 

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (964d2e8)
\
 N -- N -- N   refs/heads/gh-pages (102af38)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 docs/200.html |   2 +-
 .../content/{db-cb14a3b6.json => db-8eaf3253.json}|   2 +-
 docs/en/basics/download/index.html|   2 +-
 docs/en/basics/help/index.html|   2 +-
 docs/en/basics/import/index.html  |   2 +-
 docs/en/basics/inspiration/index.html |   2 +-
 docs/en/best-practice/aria/index.html |   2 +-
 docs/en/best-practice/canvas-vs-svg/index.html|   2 +-
 docs/en/concepts/axis/index.html  |   2 +-
 docs/en/concepts/chart-size/index.html|   2 +-
 docs/en/concepts/data-transform/index.html|   2 +-
 docs/en/concepts/dataset/index.html   |   2 +-
 docs/en/concepts/event/index.html |   2 +-
 docs/en/concepts/legend/index.html|   2 +-
 docs/en/concepts/style/index.html |   2 +-
 docs/en/concepts/visual-map/index.html|   2 +-
 docs/en/get-started/index.html|   2 +-
 docs/en/index.html|   2 +-
 docs/en/meta/edit-guide/index.html|   2 +-
 docs/images/5-2-0/group-transition-2.gif  | Bin 0 -> 1821177 bytes
 docs/images/5-2-0/group-transition.gif| Bin 0 -> 1039853 bytes
 docs/images/5-2-0/polar-bar-label.jpg | Bin 0 -> 131245 bytes
 docs/index.html   |   2 +-
 docs/zh/basics/download/index.html|   2 +-
 docs/zh/basics/help/index.html|   2 +-
 docs/zh/basics/import/index.html  |   2 +-
 docs/zh/basics/inspiration/index.html |   2 +-
 docs/zh/best-practice/aria/index.html |   2 +-
 docs/zh/best-practice/canvas-vs-svg/index.html|   2 +-
 docs/zh/concepts/axis/index.html  |   2 +-
 docs/zh/concepts/chart-size/index.html|   2 +-
 docs/zh/concepts/data-transform/index.html|   2 +-
 docs/zh/concepts/dataset/index.html   |   2 +-
 docs/zh/concepts/event/index.html |   2 +-
 docs/zh/concepts/legend/index.html|   2 +-
 docs/zh/concepts/style/index.html |   2 +-
 docs/zh/concepts/visual-map/index.html|   2 +-
 docs/zh/get-started/index.html|   2 +-
 docs/zh/index.html|   2 +-
 docs/zh/meta/edit-guide/index.html|   2 +-
 40 files changed, 37 insertions(+), 37 deletions(-)
 rename docs/_nuxt/content/{db-cb14a3b6.json => db-8eaf3253.json} (52%)
 create mode 100644 docs/images/5-2-0/group-transition-2.gif
 create mode 100644 docs/images/5-2-0/group-transition.gif
 create mode 100644 docs/images/5-2-0/polar-bar-label.jpg

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts-handbook] branch master updated: update 5.2.0 feature

2021-08-22 Thread shenyi

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts-handbook.git


The following commit(s) were added to refs/heads/master by this push:
 new 1b670e2  update 5.2.0 feature
1b670e2 is described below

commit 1b670e21c275540147a59060ced0a3aa1d7e3f1f
Author: pissang 
AuthorDate: Sun Aug 22 16:54:31 2021 +0800

update 5.2.0 feature
---
 contents/zh/basics/release-note/5-2-0.md   | 223 -
 static/images/5-2-0/group-transition-2.gif | Bin 0 -> 1821177 bytes
 static/images/5-2-0/group-transition.gif   | Bin 0 -> 1039853 bytes
 static/images/5-2-0/polar-bar-label.jpg| Bin 0 -> 131245 bytes
 4 files changed, 216 insertions(+), 7 deletions(-)

diff --git a/contents/zh/basics/release-note/5-2-0.md 
b/contents/zh/basics/release-note/5-2-0.md
index f112258..5e60b6b 100644
--- a/contents/zh/basics/release-note/5-2-0.md
+++ b/contents/zh/basics/release-note/5-2-0.md
@@ -122,7 +122,126 @@ setInterval(() => {
 
 ### 数据的分裂和合并动画
 
-除了常见的数据更新，有时候我们还会碰到数据的聚合，下钻等交互后的更新，这个时候我们就不能直接应用一对一的动画过渡，而需要使用更多分裂，合并这样的动画效果，来能够正确的通过图形的动画变换表达出数据的变换。
+除了常见的数据更新，有时候我们还会碰到数据的聚合，下钻等交互后的更新，这个时候我们就不能直接应用一对一的动画过渡，而需要使用更多像分裂，合并这样的动画效果，来能够正确的通过图形的动画变换表达出数据的变换。
+
+为了能够表达数据之间多对多的联系，在 5.2.0 中我们新引入了一个数据组`groupId`的概念，我们可以通过 
[series.dataGroupId](${optionPath}series-bar.dataGroupId) 设置整个系列所属的组，或者更细粒度的通过 
[series.data.groupId](${optionPath}series-bar.dataGroupId) 
设置每个数据所属的组。如果你使用了`dataset`管理数据则更方便了，可以使用`encode.itemGroupId`来指定一个维度编码成`groupId`。
+
+比如我们要实现一个柱状图下钻的动画，可以将下钻后的整个系列的数据都设置同一个`groupId`，然后跟下钻前的数据对应起来：
+
+```js [live-lr]
+option = {
+  xAxis: {
+data: ['Animals', 'Fruits', 'Cars']
+  },
+  yAxis: {},
+  dataGroupId: '',
+  animationDurationUpdate: 500,
+  series: {
+type: 'bar',
+id: 'sales',
+data: [
+  {
+value: 5,
+groupId: 'animals'
+  },
+  {
+value: 2,
+groupId: 'fruits'
+  },
+  {
+value: 4,
+groupId: 'cars'
+  }
+],
+universalTransition: {
+  enabled: true,
+  divideShape: 'clone'
+}
+  }
+};
+
+const drilldownData = [
+  {
+dataGroupId: 'animals',
+data: [
+  ['Cats', 4],
+  ['Dogs', 2],
+  ['Cows', 1],
+  ['Sheep', 2],
+  ['Pigs', 1]
+]
+  },
+  {
+dataGroupId: 'fruits',
+data: [
+  ['Apples', 4],
+  ['Oranges', 2]
+]
+  },
+  {
+dataGroupId: 'cars',
+data: [
+  ['Toyota', 4],
+  ['Opel', 2],
+  ['Volkswagen', 2]
+]
+  }
+];
+
+myChart.on('click', function(event) {
+  if (event.data) {
+const subData = drilldownData.find(function(data) {
+  return data.dataGroupId === event.data.groupId;
+});
+if (!subData) {
+  return;
+}
+myChart.setOption({
+  xAxis: {
+data: subData.data.map(function(item) {
+  return item[0];
+})
+  },
+  series: {
+type: 'bar',
+id: 'sales',
+dataGroupId: subData.dataGroupId,
+data: subData.data.map(function(item) {
+  return item[1];
+}),
+universalTransition: {
+  enabled: true,
+  divideShape: 'clone'
+}
+  },
+  graphic: [
+{
+  type: 'text',
+  left: 50,
+  top: 20,
+  style: {
+text: 'Back',
+fontSize: 18
+  },
+  onclick: function() {
+myChart.setOption(option, true);
+  }
+}
+  ]
+});
+  }
+});
+```
+
+通过`groupId`，我们还可以实现更丰富的聚合，下钻动画。
+
+数据的聚合：
+
+![](images/5-2-0/group-transition.gif)
+
+单系列下钻成两个系列：
+
+![](images/5-2-0/group-transition-2.gif)
 
 ## 不同粒度的调色盘取色
 
@@ -184,17 +303,74 @@ option = {
 };
 ```
 
-从而避免了减少我们去找调色盘颜色然去一一设置的麻烦。
+从而避免了减少我们去找调色盘颜色然去一一设置的麻烦。后续我们会对这个配置项做进一步的增强，提供更多粒度的调色盘取色的配置。
+
+## 极坐标柱状图的标签显示
+
+这个版本中我们给极坐标上的柱状图添加了标签的显示，并且支持丰富的标签定位配置。下面是一个最常见的标签显示在端点的进度图：
+
+```js [live-lr]
+option = {
+  angleAxis: {
+show: false,
+max: 10
+  },
+  radiusAxis: {
+show: false,
+type: 'category',
+data: ['AAA', 'BBB', 'CCC', 'DDD']
+  },
+  polar: {},
+  series: [
+{
+  type: 'bar',
+  data: [3, 4, 5, 6],
+  colorBy: 'data',
+  roundCap: true,
+  label: {
+show: true,
+position: 'start',
+formatter: '{b}'
+  },
+  coordinateSystem: 'polar'
+}
+  ]
+};
+```
 
-## 更丰富的极坐标柱状图和饼图的标签显示
+更多标签位置的配置：
 
-这个版本中我们给极坐标上的柱状图添加了标签的显示，并且支持丰富使用的标签定位配置。
+![](images/5-2-0/polar-bar-label.jpg)
 
-对于饼图，我们现在会默认在无可显示数据的时候显示一个灰色的圆以防止画面中完全空白，如果你不想要显示这个灰色的圆，可以设置`showEmptyCircle: 
false`关闭
+## 空数据饼图样式
+
+在之前，如果饼图没有数据，画面中可能就是完全空白的，因为没有任何的反馈，所以用户会疑惑是不是出 bug 了导致图中没有内容。
+
+为了解决这个问题，这个版本我们会默认在无可显示数据的时候显示一个灰色的占位圆以防止画面中完全空白。我们可以通过`emptyCircleStyle`配置这个占位圆的样式。
+
+```js [live-lr]
+option = {
+  series: [
+{
+  type: 'pie',
+  data: [],
+  // showEmptyCircle: false,
+  emptyCircleStyle: {
+// 将样式改为空心圆
+color: 'transparent',
+

[GitHub] [echarts] echarts-bot[bot] commented on issue #15574: echarts-gl.min.js ，15个图后报错

2021-08-22 Thread GitBox



echarts-bot[bot] commented on issue #15574:
URL: https://github.com/apache/echarts/issues/15574#issuecomment-903227959






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] cn17173 opened a new issue #15574: echarts-gl.min.js ，15个图后报错

2021-08-22 Thread GitBox



cn17173 opened a new issue #15574:
URL: https://github.com/apache/echarts/issues/15574


   ### Version
   5.1.2
   
   ### Steps to reproduce
   echarts-gl.min.js无论是否dispos,都只能创建15个图，继续绘制第16个图会导致页面中其他WebGL奔溃
   
   echarts-gl.min.js:1 WARNING: Too many active WebGL contexts. Oldest context 
will be lost.
   
   ### What is expected?
   active WebGL在dispos时自动清理
   
   ### What is actually happening?
   Too many active WebGL contexts. Oldest context will be lost.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] pissang opened a new pull request #15573: fix(bar): optimize label distance when using round cap

2021-08-22 Thread GitBox



pissang opened a new pull request #15573:
URL: https://github.com/apache/echarts/pull/15573


   
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix the distance is not included the extra round cap in the sausage shape.
   
   
   ## Details
   
   ### Before: What was the problem?
   
   
![image](https://user-images.githubusercontent.com/841551/130345381-176cd0b5-d1be-4609-9815-b5384a9935e1.png)
   
   ### After: How is it fixed in this PR?
   
   
![image](https://user-images.githubusercontent.com/841551/130345406-521a2251-ecb9-4ab3-b5dd-cc55f2af7af6.png)
   
   
   ## Misc
   
   
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15573: fix(bar): optimize label distance when using round cap

2021-08-22 Thread GitBox



echarts-bot[bot] commented on pull request #15573:
URL: https://github.com/apache/echarts/pull/15573#issuecomment-903222547


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a 
committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts] branch fix-sausage-label-distance created (now 8ee3fed)

2021-08-22 Thread shenyi

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch fix-sausage-label-distance
in repository https://gitbox.apache.org/repos/asf/echarts.git.


  at 8ee3fed  fix(bar): optimize label distance when using round cap

This branch includes the following new commits:

 new 8ee3fed  fix(bar): optimize label distance when using round cap

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[echarts] 01/01: fix(bar): optimize label distance when using round cap

2021-08-22 Thread shenyi

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch fix-sausage-label-distance
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 8ee3fed524f6562cda9399688f58a4872bb9629b
Author: pissang 
AuthorDate: Sun Aug 22 14:38:38 2021 +0800

fix(bar): optimize label distance when using round cap
---
 src/chart/bar/BarView.ts  |  8 --
 src/label/sectorLabel.ts  | 72 ---
 test/bar-polar-label.html |  5 +++-
 3 files changed, 53 insertions(+), 32 deletions(-)

diff --git a/src/chart/bar/BarView.ts b/src/chart/bar/BarView.ts
index b948582..faa4adb 100644
--- a/src/chart/bar/BarView.ts
+++ b/src/chart/bar/BarView.ts
@@ -755,14 +755,18 @@ const elementCreator: {
 const ShapeClass = (!isRadial && roundCap) ? Sausage : Sector;
 
 const sector = new ShapeClass({
-shape: defaults({clockwise: clockwise}, layout),
+shape: defaults({
+clockwise: clockwise
+}, layout),
 z2: 1
 });
 
 sector.name = 'item';
 
 const positionMap = createPolarPositionMapping(isRadial);
-sector.calculateTextPosition = 
createSectorCalculateTextPosition(positionMap);
+sector.calculateTextPosition = 
createSectorCalculateTextPosition(positionMap, {
+isRoundCap: ShapeClass === Sausage
+});
 
 // Animation
 if (animationModel) {
diff --git a/src/label/sectorLabel.ts b/src/label/sectorLabel.ts
index ba75e03..6ed74d2 100644
--- a/src/label/sectorLabel.ts
+++ b/src/label/sectorLabel.ts
@@ -24,8 +24,18 @@ export type SectorLike = {
 };
 
 export function createSectorCalculateTextPosition(
-positionMapping: (seriesLabelPosition: T) => SectorTextPosition
+positionMapping: (seriesLabelPosition: T) => SectorTextPosition,
+opts?: {
+/**
+ * If has round cap on two ends. If so, label should have an extra 
offset
+ */
+isRoundCap?: boolean
+}
 ): ElementCalculateTextPosition {
+
+opts = opts || {};
+const isRoundCap = opts.isRoundCap;
+
 return function (
 this: Sector,
 out: TextPositionCalculationResult,
@@ -57,82 +67,86 @@ export function createSectorCalculateTextPosition

49 matches

Mail list logo