[echarts] branch fix-aria created (now 04b2d1d)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch fix-aria in repository https://gitbox.apache.org/repos/asf/echarts.git. at 04b2d1d fix(aria): fix aria label with dataset #15734 This branch includes the following new commits: new 04b2d1d fix(aria): fix aria label with dataset #15734 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: fix(aria): fix aria label with dataset #15734
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch fix-aria
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 04b2d1d2492ae3476ac2cfdafcad3cfd6ad6c0e7
Author: Ovilia
AuthorDate: Fri Sep 24 13:57:07 2021 +0800
fix(aria): fix aria label with dataset #15734
---
src/visual/aria.ts | 8
test/aria-pie.html | 26 ++
2 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/src/visual/aria.ts b/src/visual/aria.ts
index 9d2afa6..9208248 100644
--- a/src/visual/aria.ts
+++ b/src/visual/aria.ts
@@ -210,22 +210,22 @@ export default function ariaVisual(ecModel: GlobalModel,
api: ExtensionAPI) {
seriesLabel += labelModel.get(['data', 'allData']);
}
+const middleSeparator = labelModel.get(['data',
'separator', 'middle']);
+const endSeparator = labelModel.get(['data', 'separator',
'end']);
const dataLabels = [];
for (let i = 0; i < data.count(); i++) {
if (i < maxDataCnt) {
const name = data.getName(i);
-const value = retrieveRawValue(data, i);
+const value = data.getValues(i);
const dataLabel = labelModel.get(['data', name ?
'withName' : 'withoutName']);
dataLabels.push(
replace(dataLabel, {
name: name,
-value: value
+value: value.join(middleSeparator)
})
);
}
}
-const middleSeparator = labelModel.get(['data',
'separator', 'middle']);
-const endSeparator = labelModel.get(['data', 'separator',
'end']);
seriesLabel += dataLabels.join(middleSeparator) +
endSeparator;
seriesLabels.push(seriesLabel);
diff --git a/test/aria-pie.html b/test/aria-pie.html
index ec4fa32..789724d 100644
--- a/test/aria-pie.html
+++ b/test/aria-pie.html
@@ -45,6 +45,10 @@ under the License.
+
+
+
+
require(['echarts'],
@@ -95,11 +99,25 @@ under the License.
]
});
-chart.on('pieselectchanged', function (e) {
-console.log(e);
-});
+document.getElementById('aria-1').innerText =
chart.getDom().getAttribute('aria-label');
+
+var chart2 = echarts.init(document.getElementById('main2'));
-window.onresize = chart.resize;
+chart2.setOption(
+{
+"dataset": {
+"dimensions": ["c_0", "c_1"],
+"source": [{"c_0": "Amount used", "c_1": 1699.0},
{"c_0": "Amount left", "c_1": 2301.0}]
+},
+"series": [{
+"type": "pie", "silent": true,
+"encode": {"itemName": "c_0", "value": "c_1"},
+"radius": ["30%", "60%"]
+}],
+"aria": {"show": true}
+}
+);
+document.getElementById('aria-2').innerText =
chart2.getDom().getAttribute('aria-label');
}
);
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cjlhll commented on issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
cjlhll commented on issue #15774: URL: https://github.com/apache/echarts/issues/15774#issuecomment-926312930 > 默认是这么判断语言的 > > ```js > document.documentElement.lang || navigator.language || navigator.browserLanguage > ``` > > 可能你的 html 声明的语言是 `en` 明白了。感谢。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
plainheart commented on issue #15774: URL: https://github.com/apache/echarts/issues/15774#issuecomment-926312536 默认是这么判断语言的 ```js document.documentElement.lang || navigator.language || navigator.browserLanguage ``` 可能你的 html 声明的语言是 `en` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cjlhll closed issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
cjlhll closed issue #15774: URL: https://github.com/apache/echarts/issues/15774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cjlhll commented on issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
cjlhll commented on issue #15774: URL: https://github.com/apache/echarts/issues/15774#issuecomment-926281597 > 现在默认是使用你的系统语言，可以在 init 的时候设置 locale: 'zh' 谢谢。已解决。关键是我默认系统语言是中文。并不是英文 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #15763: Enable more dimensions (more than x & y) visualmap for line chart
pissang commented on issue #15763: URL: https://github.com/apache/echarts/issues/15763#issuecomment-926279841 @qiangxinglin I will suggest you create three separate series. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] weiwxg opened a new issue #15776: 如何限定当type="time"是缩放的最小维度
weiwxg opened a new issue #15776: URL: https://github.com/apache/echarts/issues/15776 我希望在这种情况下限制缩放的最小维度到1天的，不希望继续缩放显示小时乃至分秒维度的数据 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15776: 如何限定当type="time"是缩放的最小维度
echarts-bot[bot] commented on issue #15776: URL: https://github.com/apache/echarts/issues/15776#issuecomment-926272930 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，请使用 issue 模板重新创建 issue。 如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #15776: 如何限定当type="time"是缩放的最小维度
echarts-bot[bot] closed issue #15776: URL: https://github.com/apache/echarts/issues/15776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah edited a comment on pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah edited a comment on pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#issuecomment-926140050
I have made a "draggable" [test
case](https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html) to
cover scenarios as much as possible.
# Functional defects summary
1. In some of the angle the direction of the self-loop edge is not expected.
https://user-images.githubusercontent.com/1956569/134580288-71affdc1-28b2-4828-af21-a4cb718c11aa.png;>
2. When scaling the graph, the label fly to wrong place.
3. The rotate of the the arrows are not correct.
https://user-images.githubusercontent.com/1956569/134580529-4be3639b-bf37-4a3a-a5d1-4c2ed056212b.png;>
---
# A PR-fix: https://github.com/HCLacids/echarts/pull/1 to fix this PR
This [PR-fix](https://github.com/HCLacids/echarts/pull/1) fixed the issue
`1` above, and add test cases.
Before that PR-fix:
https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html
After that PR-fix:
https://echarts-try.surge.sh/graph-self-loop/graph-self-loop.html
---
# About curveness
At present, the curveness can be controlled by two ways:
(A) [autoCurveness:
true](https://echarts.apache.org/zh/option.html#series-graph.autoCurveness)
(B)
[lineStyle.curveness](https://echarts.apache.org/zh/option.html#series-graph.lineStyle.curveness).
`lineStyle.curveness` can be set on the whole series:
```js
series: {
type: 'graph',
lineStyle: {
curveness: 0.5
}
}
```
or on some certain edges:
```js
series: {
type: 'graph',
edges: [{
source: 1,
target: 4,
lineStyle: {
curveness: 0.7
}
}, {
source: 1
target: 4
}]
}
```
When `lineStyle.curveness` is set to some edge, `autoCurveness` will not be
accepted to that edge. Basically it's implemented by code like this:
```js
const curveness = zrUtil.retrieve3(
edge.getModel().get(['lineStyle', 'curveness']),
-getCurvenessForEdge(edge, seriesModel, index, true),
0
);
```
+ `focus: 'adjacency'`
```js
emphasis: {
focus: 'adjacency'
},
```
But I think we do not need to support `autoCurveness` in self-loop edges if
the we accept the layout in this
[PR-fix](https://github.com/HCLacids/echarts/pull/1).
---
@HCLacids Could the [PR-fix](https://github.com/HCLacids/echarts/pull/1) be
approved ?
Any issue can be discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah edited a comment on pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah edited a comment on pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#issuecomment-926140050
I have made a "draggable" [test
case](https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html) to
cover scenarios as much as possible.
# Defects
1. In some of the angle the direction of the self-loop edge is not expected.
https://user-images.githubusercontent.com/1956569/134580288-71affdc1-28b2-4828-af21-a4cb718c11aa.png;>
2. When scaling the graph, the label fly to wrong place.
3. The rotate of the the arrows are not correct.
https://user-images.githubusercontent.com/1956569/134580529-4be3639b-bf37-4a3a-a5d1-4c2ed056212b.png;>
---
# A PR-fix: https://github.com/HCLacids/echarts/pull/1 to fix this PR
This [PR-fix](https://github.com/HCLacids/echarts/pull/1) fixed the issue
`1` above, and add test cases.
Before that PR-fix:
https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html
After that PR-fix:
https://echarts-try.surge.sh/graph-self-loop/graph-self-loop.html
---
# About curveness
At present, the curveness can be controlled by two ways:
(A) [autoCurveness:
true](https://echarts.apache.org/zh/option.html#series-graph.autoCurveness)
(B)
[lineStyle.curveness](https://echarts.apache.org/zh/option.html#series-graph.lineStyle.curveness).
`lineStyle.curveness` can be set on the whole series:
```js
series: {
type: 'graph',
lineStyle: {
curveness: 0.5
}
}
```
or on some certain edges:
```js
series: {
type: 'graph',
edges: [{
source: 1,
target: 4,
lineStyle: {
curveness: 0.7
}
}, {
source: 1
target: 4
}]
}
```
When `lineStyle.curveness` is set to some edge, `autoCurveness` will not be
accepted to that edge. Basically it's implemented by code like this:
```js
const curveness = zrUtil.retrieve3(
edge.getModel().get(['lineStyle', 'curveness']),
-getCurvenessForEdge(edge, seriesModel, index, true),
0
);
```
+ `focus: 'adjacency'`
```js
emphasis: {
focus: 'adjacency'
},
```
But I think we do not need to support `autoCurveness` in self-loop edges if
the we accept the layout in this
[PR-fix](https://github.com/HCLacids/echarts/pull/1).
---
@HCLacids Could the [PR-fix](https://github.com/HCLacids/echarts/pull/1) be
approved ?
Any issue can be discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah commented on a change in pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah commented on a change in pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#discussion_r709497973
##
File path: src/chart/graph/simpleLayoutHelper.ts
##
@@ -49,7 +69,80 @@ export function simpleLayoutEdge(graph: Graph, seriesModel:
GraphSeriesModel) {
const p1 = vec2.clone(edge.node1.getLayout());
const p2 = vec2.clone(edge.node2.getLayout());
const points = [p1, p2];
-if (+curveness) {
+if (edge.node1 === edge.node2) {
+const curve = getCurvenessForEdge(edge, seriesModel, index, true);
+const curveness = curve >= 1 ? curve : 1 - curve;
+const symbolSize = seriesModel.get('symbolSize');
+const size = zrUtil.isArray(symbolSize) ? Number((symbolSize[0] +
symbolSize[1]) / 2) : Number(symbolSize);
+const radius = getNodeGlobalScale(seriesModel) * size / 2 *
curveness;
+const inEdges = edge.node1.inEdges.filter((edge) => {
+return edge.node1 !== edge.node2;
+});
+const outEdges = edge.node1.outEdges.filter((edge) => {
+return edge.node1 !== edge.node2;
+});
+const allNodes: GraphNode[] = [];
+inEdges.forEach((edge) => {
+allNodes.push(edge.node1);
+});
+outEdges.forEach((edge) => {
+allNodes.push(edge.node2);
+});
+const vectors: any[][] = [];
+let d = -Infinity;
+let pt1: number[] = [];
+let pt2: number[] = [];
+if (allNodes.length > 1) {
+allNodes.forEach(node => {
+const v: any[] = [];
+vec2.sub(v, node.getLayout(), edge.node1.getLayout());
+vec2.normalize(v, v);
+vectors.push(v);
+});
+// find the max angle
+for (let i = 0; i < vectors.length; i++) {
+for (let j = i + 1; j < vectors.length; j++) {
+if (vec2.distSquare(vectors[i], vectors[j]) > d) {
+d = vec2.distSquare(vectors[i], vectors[j]);
+pt1 = vectors[i];
+pt2 = vectors[j];
+}
+}
+}
Review comment:
I think we need to find `the max angle of two adjacent edges` rather
than `the max angle of any two edges`.
The latter one probably make the self-loop edge intersect with some other
edge between the found edges.
https://user-images.githubusercontent.com/1956569/133443745-333a18a0-e2c5-4ae0-970d-a1bf8f7f4fa9.png;>
And I think we should better take into account every edges rather than only
every nodes:
https://user-images.githubusercontent.com/1956569/133629659-20565517-a394-4a3b-94ca-f48c7fdbccb4.png;>
And when there are more than one self-loop edges, the strategy probably
complicated to make it look good. For example, consider these cases:
https://user-images.githubusercontent.com/1956569/133634612-a346a3d5-423c-457c-bf31-8372d66bf052.png;>
https://user-images.githubusercontent.com/1956569/133634670-a07afb9f-0d81-4118-9ef8-e459db13d02e.png;>
Some other cases:
https://user-images.githubusercontent.com/1956569/134038784-e6dd8435-7be9-4c5c-858e-163a6beae536.png;>
So wrap up this above, I think we should better to find the max `n`
intersection angles for the next step to arrange the self-loop edges. May be we
could:
0. Do this step after all of the non-self-loop-edges layout finished.
1. Use `Math.atan2` to get the radians to x positive.
2. sort the edges by their radians
3. Get a list of intersection angles by `sortedEdges[n+1].radian -
sortedEdges[n].radian`, and sort desc.
---
See [PR-fix](https://github.com/HCLacids/echarts/pull/1) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah commented on a change in pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah commented on a change in pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#discussion_r709371843
##
File path: src/chart/graph/simpleLayoutHelper.ts
##
@@ -49,7 +69,80 @@ export function simpleLayoutEdge(graph: Graph, seriesModel:
GraphSeriesModel) {
const p1 = vec2.clone(edge.node1.getLayout());
const p2 = vec2.clone(edge.node2.getLayout());
const points = [p1, p2];
-if (+curveness) {
+if (edge.node1 === edge.node2) {
+const curve = getCurvenessForEdge(edge, seriesModel, index, true);
+const curveness = curve >= 1 ? curve : 1 - curve;
+const symbolSize = seriesModel.get('symbolSize');
+const size = zrUtil.isArray(symbolSize) ? Number((symbolSize[0] +
symbolSize[1]) / 2) : Number(symbolSize);
+const radius = getNodeGlobalScale(seriesModel) * size / 2 *
curveness;
Review comment:
1. Here we `* curveness` and latter we `10 * radius`.
I think we should better make those code in one place.
2. The user specified or auto calculated (by `autoCurveness: true`)
curveness should be fetched by :
```ts
const curveness = zrUtil.retrieve3(
edge.getModel().get(['lineStyle',
'curveness']),
-getCurvenessForEdge(edge, seriesModel, index, true),
0
);
```
See this [PR-fix](https://github.com/HCLacids/echarts/pull/1) for more
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah edited a comment on pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah edited a comment on pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#issuecomment-926140050
I have made a "draggable" [test
case](https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html) to
cover scenarios as much as possible.
# I've found that there are those issues:
1. In some of the angle the direction of the self-loop edge is not expected.
https://user-images.githubusercontent.com/1956569/134580288-71affdc1-28b2-4828-af21-a4cb718c11aa.png;>
2. When scaling the graph, the label fly to wrong place.
3. The rotate of the the arrows are not correct.
https://user-images.githubusercontent.com/1956569/134580529-4be3639b-bf37-4a3a-a5d1-4c2ed056212b.png;>
# A PR-fix: https://github.com/HCLacids/echarts/pull/1 to fix this PR
This [PR-fix](https://github.com/HCLacids/echarts/pull/1) fixed the issue
`1` above, and add test cases.
Before that PR-fix:
https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html
After that PR-fix:
https://echarts-try.surge.sh/graph-self-loop/graph-self-loop.html
# About curveness
At present, the curveness can be controlled by two ways:
(A) [autoCurveness:
true](https://echarts.apache.org/zh/option.html#series-graph.autoCurveness)
(B)
[lineStyle.curveness](https://echarts.apache.org/zh/option.html#series-graph.lineStyle.curveness).
`lineStyle.curveness` can be set on the whole series:
```js
series: {
type: 'graph',
lineStyle: {
curveness: 0.5
}
}
```
or on some certain edges:
```js
series: {
type: 'graph',
edges: [{
source: 1,
target: 4,
lineStyle: {
curveness: 0.7
}
}, {
source: 1
target: 4
}]
}
```
When `lineStyle.curveness` is set to some edge, `autoCurveness` will not be
accepted to that edge. Basically it's implemented by code like this:
```js
const curveness = zrUtil.retrieve3(
edge.getModel().get(['lineStyle', 'curveness']),
-getCurvenessForEdge(edge, seriesModel, index, true),
0
);
```
+ `focus: 'adjacency'`
```js
emphasis: {
focus: 'adjacency'
},
```
But I think we do not need to support `autoCurveness` in self-loop edges if
the we accept the layout in this
[PR-fix](https://github.com/HCLacids/echarts/pull/1).
---
@HCLacids Could the [PR-fix](https://github.com/HCLacids/echarts/pull/1) be
approved ?
Any issue can be discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah edited a comment on pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah edited a comment on pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#issuecomment-926140050
I have made a "draggable" [test
case](https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html) to
cover scenarios as much as possible.
## I've found that there are those issues:
1. In some of the angle the direction of the self-loop edge is not expected.
https://user-images.githubusercontent.com/1956569/134580288-71affdc1-28b2-4828-af21-a4cb718c11aa.png;>
2. When scaling the graph, the label fly to wrong place.
3. The rotate of the the arrows are not correct.
https://user-images.githubusercontent.com/1956569/134580529-4be3639b-bf37-4a3a-a5d1-4c2ed056212b.png;>
## A PR-fix: https://github.com/HCLacids/echarts/pull/1 to fix this PR
This [PR-fix](https://github.com/HCLacids/echarts/pull/1) fixed the issue
`1` above, and add test cases.
Before that PR-fix:
https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html
After that PR-fix:
https://echarts-try.surge.sh/graph-self-loop/graph-self-loop.html
## About curveness
At present, the curveness can be controlled by two ways:
(A) [autoCurveness:
true](https://echarts.apache.org/zh/option.html#series-graph.autoCurveness)
(B)
[lineStyle.curveness](https://echarts.apache.org/zh/option.html#series-graph.lineStyle.curveness).
`lineStyle.curveness` can be set on the whole series:
```js
series: {
type: 'graph',
lineStyle: {
curveness: 0.5
}
}
```
or on some certain edges:
```js
series: {
type: 'graph',
edges: [{
source: 1,
target: 4,
lineStyle: {
curveness: 0.7
}
}, {
source: 1
target: 4
}]
}
```
When `lineStyle.curveness` is set to some edge, `autoCurveness` will not be
accepted to that edge. Basically it's implemented by code like this:
```js
const curveness = zrUtil.retrieve3(
edge.getModel().get(['lineStyle', 'curveness']),
-getCurvenessForEdge(edge, seriesModel, index, true),
0
);
```
+ `focus: 'adjacency'`
```js
emphasis: {
focus: 'adjacency'
},
```
But I think we do not need to support `autoCurveness` in self-loop edges if
the we accept the layout in this
[PR-fix](https://github.com/HCLacids/echarts/pull/1).
---
@HCLacids Could the [PR-fix](https://github.com/HCLacids/echarts/pull/1) be
approved ?
Any issue can be discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah commented on pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah commented on pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#issuecomment-926140050
I have made a "draggable" [test
case](https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html) to
cover scenarios as much as possible.
## I've found that there are those issues:
1. In some of the angle the direction of the self-loop edge is not expected.
https://user-images.githubusercontent.com/1956569/134580288-71affdc1-28b2-4828-af21-a4cb718c11aa.png;>
2. When scaling the graph, the label fly to wrong place.
3. The rotate of the the arrows are not correct.
https://user-images.githubusercontent.com/1956569/134580529-4be3639b-bf37-4a3a-a5d1-4c2ed056212b.png;>
## A PR-fix: https://github.com/HCLacids/echarts/pull/1 to fix this PR
This [PR-fix](https://github.com/HCLacids/echarts/pull/1) fixed the issue
`1` above, and add test cases.
Before that PR-fix:
https://echarts-try.surge.sh/graph-self-loop-old/graph-self-loop.html
After that PR-fix:
https://echarts-try.surge.sh/graph-self-loop/graph-self-loop.html
## About curveness
At present, the curveness can be controlled by two ways:
(A) [autoCurveness:
true](https://echarts.apache.org/zh/option.html#series-graph.autoCurveness)
(B)
[lineStyle.curveness](https://echarts.apache.org/zh/option.html#series-graph.lineStyle.curveness).
`lineStyle.curveness` can be set on the whole series:
```js
series: {
type: 'graph',
lineStyle: {
curveness: 0.5
}
}
```
or on some certain edges:
```js
series: {
type: 'graph',
edges: [{
source: 1,
target: 4,
lineStyle: {
curveness: 0.7
}
}, {
source: 1
target: 4
}]
}
```
When `lineStyle.curveness` is set to some edge, `autoCurveness` will not be
accepted to that edge. Basically it's implemented by code like this:
```js
const curveness = zrUtil.retrieve3(
edge.getModel().get(['lineStyle', 'curveness']),
-getCurvenessForEdge(edge, seriesModel, index, true),
0
);
```
+ `focus: 'adjacency'`
```js
emphasis: {
focus: 'adjacency'
},
```
But I think we do not need to support `autoCurveness` in self-loop edges if
the we accept the layout in this
[PR-fix](https://github.com/HCLacids/echarts/pull/1).
---
@HCLacids Could the [PR-fix](https://github.com/HCLacids/echarts/pull/1) be
approved ?
Any issue can be discuessed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 100pah commented on a change in pull request #15405: fix:node self pointed -add cubicBezierCurve
100pah commented on a change in pull request #15405:
URL: https://github.com/apache/echarts/pull/15405#discussion_r708867851
##
File path: src/chart/graph/edgeVisual.ts
##
@@ -75,6 +79,26 @@ export default function graphEdgeVisual(ecModel:
GlobalModel) {
symbolType[1] && edge.setVisual('toSymbol', symbolType[1]);
symbolSize[0] && edge.setVisual('fromSymbolSize', symbolSize[0]);
symbolSize[1] && edge.setVisual('toSymbolSize', symbolSize[1]);
+
+
+if (edge.node1 === edge.node2 && toSymbol && toSymbol !== 'none') {
+const edgeData = edge.getLayout();
+const size = getSymbolSize(edge.node1);
+const radius = getNodeGlobalScale(seriesModel) * size / 2;
+
+let t = intersectCurveCircle(edgeData, edgeData[0], radius);
+if (t < 0.5) {
+t = 1 - t;
+}
+const tdx = cubicDerivativeAt(edgeData[0][0], edgeData[1][0],
edgeData[2][0], edgeData[3][0], t);
+const tdy = cubicDerivativeAt(edgeData[0][1], edgeData[1][1],
edgeData[2][1], edgeData[3][1], t);
+const degree = Math.atan2(tdy, tdx) / Math.PI * 180;
+if( degree > 90 || degree < 0 && degree > -90) {
Review comment:
eslint error
##
File path: test/force.html
##
@@ -92,7 +91,7 @@
edges: item.edges.map(function (e) {
return {
source: e[0],
-target: e[1]
+target: e[0]
Review comment:
I think we'd better not to change the original force case,
otherwise the previous force case does not exits any more.
We could create a new force case in `test/graphSimple.html`.
##
File path: src/chart/graph/forceLayout.ts
##
@@ -144,7 +146,80 @@ export default function graphForceLayout(ecModel:
GlobalModel) {
points[1] = points[1] || [];
vec2.copy(points[0], p1);
vec2.copy(points[1], p2);
-if (+e.curveness) {
+if (e.n1 === e.n2) {
+const size = getSymbolSize(edge.node1);
+const radius = getNodeGlobalScale(graphSeries) * size
/ 2;
+const inEdges = edge.node1.inEdges.filter((edge) => {
+return edge.node1 !== edge.node2;
+});
+const outEdges = edge.node1.outEdges.filter((edge) => {
+return edge.node1 !== edge.node2;
+});
+const allNodes: GraphNode[] = [];
+inEdges.forEach((edge) => {
+allNodes.push(edge.node1);
+});
+outEdges.forEach((edge) => {
+allNodes.push(edge.node2);
+});
+const vectors: any[][] = [];
Review comment:
Should not be `any` if we known the type.
##
File path: src/chart/graph/circularLayoutHelper.ts
##
@@ -88,16 +89,82 @@ export function circularLayout(
const p1 = vec2.clone(edge.node1.getLayout());
const p2 = vec2.clone(edge.node2.getLayout());
let cp1;
+let cp2;
const x12 = (p1[0] + p2[0]) / 2;
const y12 = (p1[1] + p2[1]) / 2;
-if (+curveness) {
+if (edge.node1 === edge.node2) {
Review comment:
I think the entire logic below (find the proper direction for the
self-loop edge) or part of them should be put in a separate helper method and
shared by `circularLayoutHelper`, `simpleLayoutHelper` and `forceLayoutHelper`,
rather than repeat them.
##
File path: src/chart/graph/simpleLayoutHelper.ts
##
@@ -49,7 +69,80 @@ export function simpleLayoutEdge(graph: Graph, seriesModel:
GraphSeriesModel) {
const p1 = vec2.clone(edge.node1.getLayout());
const p2 = vec2.clone(edge.node2.getLayout());
const points = [p1, p2];
-if (+curveness) {
+if (edge.node1 === edge.node2) {
+const curve = getCurvenessForEdge(edge, seriesModel, index, true);
+const curveness = curve >= 1 ? curve : 1 - curve;
+const symbolSize = seriesModel.get('symbolSize');
+const size = zrUtil.isArray(symbolSize) ? Number((symbolSize[0] +
symbolSize[1]) / 2) : Number(symbolSize);
+const radius = getNodeGlobalScale(seriesModel) * size / 2 *
curveness;
+const inEdges = edge.node1.inEdges.filter((edge) => {
+return edge.node1 !== edge.node2;
+});
+const outEdges = edge.node1.outEdges.filter((edge) => {
+return edge.node1 !== edge.node2;
+
[echarts] 04/04: fix: (1) Fix the self-loop edge layout strategy in 'simple' layout. (2) Add test case `test/graph-self-loop.html`. (3) Remove some necessary code.
This is an automated email from the ASF dual-hosted git repository.
sushuang pushed a commit to branch feat/HCLacids-NodeSelf-fix
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 0566c7b0d7ca8216adf0e197bf89f118d0a7d126
Author: sushuang
AuthorDate: Fri Sep 24 02:31:05 2021 +0800
fix:
(1) Fix the self-loop edge layout strategy in 'simple' layout.
(2) Add test case `test/graph-self-loop.html`.
(3) Remove some necessary code.
---
src/chart/graph/GraphView.ts| 20 +-
src/chart/graph/edgeVisual.ts | 24 --
src/chart/graph/graphHelper.ts | 6 +
src/chart/graph/layoutHelper.ts | 262 ++
src/chart/graph/simpleLayoutHelper.ts | 88 +
src/chart/helper/multipleGraphEdgeHelper.ts | 3 +-
test/graph-self-loop.html | 355 +++
test/lib/enableGraphEditRoughly.js | 512
8 files changed, 1165 insertions(+), 105 deletions(-)
diff --git a/src/chart/graph/GraphView.ts b/src/chart/graph/GraphView.ts
index 1c8d10f..98b5e3b 100644
--- a/src/chart/graph/GraphView.ts
+++ b/src/chart/graph/GraphView.ts
@@ -36,6 +36,7 @@ import Symbol from '../helper/Symbol';
import List from '../../data/List';
import Line from '../helper/Line';
import { getECData } from '../../util/innerStore';
+import { layoutSelfLoopEdges } from './layoutHelper';
function isViewCoordSys(coordSys: CoordinateSystem): coordSys is View {
return coordSys.type === 'view';
@@ -102,7 +103,7 @@ class GraphView extends ChartView {
}
}
// Fix edge contact point with node
-adjustEdge(seriesModel.getGraph(), getNodeGlobalScale(seriesModel));
+postLayoutEdges(seriesModel);
const data = seriesModel.getData();
symbolDraw.updateData(data as ListForSymbolDraw);
@@ -274,7 +275,7 @@ class GraphView extends ChartView {
originY: e.originY
});
this._updateNodeAndLinkScale();
-adjustEdge(seriesModel.getGraph(),
getNodeGlobalScale(seriesModel));
+postLayoutEdges(seriesModel);
this._lineDraw.updateLayout();
// Only update label layout on zoom
api.updateLabelLayout();
@@ -293,7 +294,7 @@ class GraphView extends ChartView {
}
updateLayout(seriesModel: GraphSeriesModel) {
-adjustEdge(seriesModel.getGraph(), getNodeGlobalScale(seriesModel));
+postLayoutEdges(seriesModel);
this._symbolDraw.updateLayout();
this._lineDraw.updateLayout();
@@ -305,4 +306,17 @@ class GraphView extends ChartView {
}
}
+function postLayoutEdges(seriesModel: GraphSeriesModel): void {
+const graph = seriesModel.getGraph();
+
+// PENDING:
+// `scaleOnCoordSys` will be changed when zooming.
+// At present the layout stage will not be called when zooming. So
+// we put these process here.
+const nodeScaleOnCoordSys = getNodeGlobalScale(seriesModel);
+
+layoutSelfLoopEdges(graph, nodeScaleOnCoordSys);
+adjustEdge(graph, nodeScaleOnCoordSys);
+}
+
export default GraphView;
\ No newline at end of file
diff --git a/src/chart/graph/edgeVisual.ts b/src/chart/graph/edgeVisual.ts
index f0d0208..7107399 100644
--- a/src/chart/graph/edgeVisual.ts
+++ b/src/chart/graph/edgeVisual.ts
@@ -20,9 +20,6 @@
import GlobalModel from '../../model/Global';
import GraphSeriesModel, { GraphEdgeItemOption } from './GraphSeries';
import { extend } from 'zrender/src/core/util';
-import { intersectCurveCircle } from './adjustEdge'
-import { getNodeGlobalScale, getSymbolSize } from './graphHelper';
-import { cubicDerivativeAt } from 'zrender/src/core/curve';
function normalize(a: string | string[]): string[];
function normalize(a: number | number[]): number[];
@@ -53,7 +50,6 @@ export default function graphEdgeVisual(ecModel: GlobalModel)
{
edgeData.each(function (idx) {
const itemModel = edgeData.getItemModel(idx);
const edge = graph.getEdgeByIndex(idx);
-const toSymbol = edge.getVisual('toSymbol');
const symbolType = normalize(itemModel.getShallow('symbol', true));
const symbolSize = normalize(itemModel.getShallow('symbolSize',
true));
// Edge visual must after node visual
@@ -79,26 +75,6 @@ export default function graphEdgeVisual(ecModel:
GlobalModel) {
symbolType[1] && edge.setVisual('toSymbol', symbolType[1]);
symbolSize[0] && edge.setVisual('fromSymbolSize', symbolSize[0]);
symbolSize[1] && edge.setVisual('toSymbolSize', symbolSize[1]);
-
-
-if (edge.node1 === edge.node2 && toSymbol && toSymbol !== 'none') {
-const edgeData = edge.getLayout();
-const size = getSymbolSize(edge.node1);
-const radius = getNodeGlobalScale(seriesModel) * size / 2;
-
[echarts] 03/04: Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a commit to branch feat/HCLacids-NodeSelf-fix in repository https://gitbox.apache.org/repos/asf/echarts.git commit 6b6d6d45c41798103fb3f2926d5c2b66aeeb022b Merge: 52f292d eee6878 Author: sushuang AuthorDate: Wed Sep 15 19:59:43 2021 +0800 Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf src/chart/graph/circularLayoutHelper.ts | 14 +-- src/chart/graph/forceLayout.ts | 20 src/chart/graph/simpleLayoutHelper.ts | 18 +++ src/chart/helper/multipleGraphEdgeHelper.ts | 36 ++--- 4 files changed, 44 insertions(+), 44 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 02/04: Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a commit to branch feat/HCLacids-NodeSelf-fix in repository https://gitbox.apache.org/repos/asf/echarts.git commit 52f292d74c55d81ad8d5886c9222d818daf197fb Merge: 4028577 9d44975 Author: sushuang AuthorDate: Tue Aug 24 21:43:45 2021 +0800 Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf package-lock.json | 10985 ++ src/chart/graph/adjustEdge.ts | 167 +- src/chart/graph/circularLayoutHelper.ts |74 +- src/chart/graph/edgeVisual.ts |24 + src/chart/graph/forceLayout.ts |74 +- src/chart/graph/simpleLayoutHelper.ts | 106 +- src/chart/helper/Line.ts| 5 +- src/chart/helper/LinePath.ts| 4 +- src/chart/helper/multipleGraphEdgeHelper.ts |50 +- test/force.html | 3 +- test/graph-circular.html| 4 + test/graph-multiple-edges.html | 2 +- 12 files changed, 11366 insertions(+), 132 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch feat/HCLacids-NodeSelf-fix created (now 0566c7b)
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a change to branch feat/HCLacids-NodeSelf-fix in repository https://gitbox.apache.org/repos/asf/echarts.git. at 0566c7b fix: (1) Fix the self-loop edge layout strategy in 'simple' layout. (2) Add test case `test/graph-self-loop.html`. (3) Remove some necessary code. This branch includes the following new commits: new 4028577 Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf new 52f292d Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf new 6b6d6d4 Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf new 0566c7b fix: (1) Fix the self-loop edge layout strategy in 'simple' layout. (2) Add test case `test/graph-self-loop.html`. (3) Remove some necessary code. The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/04: Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a commit to branch feat/HCLacids-NodeSelf-fix in repository https://gitbox.apache.org/repos/asf/echarts.git commit 4028577c1670637ffb0e37f0dc72a553a3b4f7f0 Merge: 997f839 60e8a01 Author: sushuang AuthorDate: Mon Aug 2 20:09:10 2021 +0800 Merge branch 'NodeSelf' of https://github.com/HCLacids/echarts into HCLacids-NodeSelf package-lock.json | 10985 -- src/chart/graph/adjustEdge.ts | 246 +- src/chart/graph/circularLayoutHelper.ts |13 +- src/chart/graph/forceLayout.ts | 9 +- src/chart/graph/simpleLayoutHelper.ts |19 +- src/chart/helper/Line.ts| 8 + src/chart/helper/LinePath.ts| 2 + test/force.html | 4 +- test/graph-multiple-edges.html | 2 +- test/graph-simple.html | 8 + 10 files changed, 227 insertions(+), 11069 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] tmtron opened a new issue #15775: dataZoom click not working
tmtron opened a new issue #15775:
URL: https://github.com/apache/echarts/issues/15775
### Version
5.2.1
### Reproduction link
[https://jsfiddle.net/tmtron/9y0xtqs7/11/](https://jsfiddle.net/tmtron/9y0xtqs7/11/)
### Steps to reproduce
click on the dataZoom
### What is expected?
click event should be invoked
### What is actually happening?
click event is not invoked
---
The example from the [documentation: echartsInstance.
on](https://echarts.apache.org/en/api.html#echartsInstance.on) is also not
working:
```javascript
chart.on('click', 'dataZoom', function () {...});
```
* Other click events work: e.g. on the series, axis-labels (when
`triggerEvent` is set to `true`)
* but for [dataZoom](https://echarts.apache.org/en/option.html#dataZoom),
`triggerEvent` does not exist
* Maybe someone knows a temporary workaround?
* I thought about using
[echartsInstance.containPixel](https://echarts.apache.org/en/api.html#echartsInstance.containPixel),
but it seems, that this does also not support `dataZoom`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15775: dataZoom click not working
echarts-bot[bot] commented on issue #15775: URL: https://github.com/apache/echarts/issues/15775#issuecomment-925860705 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so. *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe to our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #15769: 关系图节点为图片时，下载截图功能失效。
plainheart commented on issue #15769: URL: https://github.com/apache/echarts/issues/15769#issuecomment-925842078 注意图片的跨域问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] qiangxinglin commented on issue #15763: Enable more dimensions (more than x & y) visualmap for line chart
qiangxinglin commented on issue #15763:
URL: https://github.com/apache/echarts/issues/15763#issuecomment-925825352
@Ovilia I know this option, but it only colored the data point rather than
the **_line segment_** between them.
```
visualMap: {
type: 'continuous',
inRange: {
color: ['orange', 'green', 'red'],
},
dimension: 3 // For line chart, it will only highlight the point if set
the dimension > 1
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
pissang commented on issue #15774: URL: https://github.com/apache/echarts/issues/15774#issuecomment-925726882 现在默认是使用你的系统语言，可以在 init 的时候设置 locale: 'zh' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15755: 折线图使用visualMap时,颜色错乱，图元颜色改变，线段颜色错误
Ovilia commented on issue #15755: URL: https://github.com/apache/echarts/issues/15755#issuecomment-925703122 Then you should debug to see the exact data to reproduce this problem. Otherwise, it's impossible to learn what's going on here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sophia1024 removed a comment on issue #15755: 折线图使用visualMap时,颜色错乱，图元颜色改变，线段颜色错误
sophia1024 removed a comment on issue #15755: URL: https://github.com/apache/echarts/issues/15755#issuecomment-925697718 minimum data is not a problem, but a large amount of data will have this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sophia1024 commented on issue #15755: 折线图使用visualMap时,颜色错乱，图元颜色改变，线段颜色错误
sophia1024 commented on issue #15755: URL: https://github.com/apache/echarts/issues/15755#issuecomment-925698104 > Please refer to [this example](https://www.makeapie.com/editor.html?c=x7AFiJ06e). If you still have questions, please minify your demo with minimum data. minimum data is not a problem, but a large amount of data will have this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] sophia1024 commented on issue #15755: 折线图使用visualMap时,颜色错乱，图元颜色改变，线段颜色错误
sophia1024 commented on issue #15755: URL: https://github.com/apache/echarts/issues/15755#issuecomment-925697718 minimum data is not a problem, but a large amount of data will have this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cjlhll opened a new issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
cjlhll opened a new issue #15774: URL: https://github.com/apache/echarts/issues/15774 ### Version 5.2.1 ### Steps to reproduce 我从4.9.0更新到5.2.1后，toolbox的提示文字变成英文了。请问如何切换回中文呢？ ### What is expected? 切换回中文 ### What is actually happening? 是英文 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15774: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
echarts-bot[bot] commented on issue #15774: URL: https://github.com/apache/echarts/issues/15774#issuecomment-925654699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cjlhll opened a new issue #15773: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
cjlhll opened a new issue #15773: URL: https://github.com/apache/echarts/issues/15773 请问如何默认设置中文呢？文档没有看到可以配置的地方啊 This issue is not created by [echarts-issue-helper](https://ecomfe.github.io/echarts-issue-helper) and will be soon closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15773: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
echarts-bot[bot] commented on issue #15773: URL: https://github.com/apache/echarts/issues/15773#issuecomment-925653314 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，请使用 issue 模板重新创建 issue。 如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #15773: 4.9.0更新到5.2.1后，toolbox的提示文字变成英文了?
echarts-bot[bot] closed issue #15773: URL: https://github.com/apache/echarts/issues/15773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15772: Axis click events data
echarts-bot[bot] commented on issue #15772: URL: https://github.com/apache/echarts/issues/15772#issuecomment-925638991 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so. *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe to our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pierrebonny opened a new issue #15772: Axis click events data
pierrebonny opened a new issue #15772: URL: https://github.com/apache/echarts/issues/15772 ### What problem does this feature solve? When you click on an axis label you cannot know its index. For example if I have 10 categories I would like to know if I clicked on the first one or the fifth. Before V5 I was able to pass an object to axis data and set an id or index that was passed by the event. Now it is impossible so I am blocked ### What does the proposed API look like? Just like dataindex for component click event: dataIndex: number, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] leekbillow opened a new issue #15771: 饼图label设置宽度，居中无效
leekbillow opened a new issue #15771:
URL: https://github.com/apache/echarts/issues/15771
### Version
5.2.1
### Reproduction link
[https://www.makeapie.com/editor.html?c=xd370ntR39=1](https://www.makeapie.com/editor.html?c=xd370ntR39=1)
### Steps to reproduce
1.设置width
2.设置align:'center'
### What is expected?
label文字居中
### What is actually happening?
文字未居中，align属性不生效
### 详细描述
```js
option = {
series: [
{
type: 'pie',
radius: [20, 60],
roseType: 'radius',
data: [
{
value: 25,
name: '男'
},
{
value: 75,
name: '女'
},
],
label: {
shadowColor: '#0050',
shadowBlur: 10,
height: 30,
width: 80,
align: 'center',
verticalAlign: 'middle',
backgroundColor: '#fff'
}
}
]
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15771: 饼图label设置宽度，居中无效
echarts-bot[bot] commented on issue #15771: URL: https://github.com/apache/echarts/issues/15771#issuecomment-925628179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia edited a comment on issue #15743: 移动端使用柱状图，水平方向滑动时，自定义tooltip不消失
Ovilia edited a comment on issue #15743: URL: https://github.com/apache/echarts/issues/15743#issuecomment-925623174 trigger axis 的情况下，在图表范围内都会显示的。如果有问题，提供一下复现代码吧，链接的例子里没有 hideTip。 > 看github上说5.0.1会解决这个问题，5.2.0有没有改善这个问题呢 这个是哪个 issue 可以链接一下，不一定是同一个问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15743: 移动端使用柱状图，水平方向滑动时，自定义tooltip不消失
Ovilia commented on issue #15743: URL: https://github.com/apache/echarts/issues/15743#issuecomment-925623174 trigger axis 的情况下，在图表范围内都会显示的。如果有问题，提供一下复现代码吧，链接的例子里没有 hideTip。 > 看github上说5.0.1会解决这个问题，5.2.0有没有改善这个问题呢 这个是哪个 issue 可以链接一下，不一定是同一个问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15770: 折线图中设置symbol为emptycircle，无法设置itemStyle-borderWidth？
echarts-bot[bot] commented on issue #15770: URL: https://github.com/apache/echarts/issues/15770#issuecomment-925622862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] ayrikiya opened a new issue #15770: 折线图中设置symbol为emptycircle，无法设置itemStyle-borderWidth？
ayrikiya opened a new issue #15770:
URL: https://github.com/apache/echarts/issues/15770
### Version
5.2.1
### Steps to reproduce
```
{
name: 'xxx',
type: 'line',
data: [4, 55, 88, 32, 80, 86, 46, 72, 54, 78, 19, 75],
symbol:'emptyCircle',//空心圆
symbolSize:6,
showSymbol: false,
legendHoverLink: false,
animation:true,
label : {show: false},
lineStyle:{
color: '#588FF8',
width: 1,
},
itemStyle:{
color: '#FF',
// borderColor:'#FF',
borderWidth: 10,//拐点边框大小 无效
},
emphasis:{
scale: false,
lineStyle:{
width: 1
},
itemStyle:{
color:'#FF',//拐点颜色
borderColor:'#588FF8',//拐点边框颜色
borderWidth: 10,//拐点边框大小
}
},
}
```
### What is expected?
希望可以设置emptyCircle的border，出于其他原因不想用circle来模拟emptyCircle
### What is actually happening?
不管设置什么数值，无法修改emptyCircle的border宽度。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15755: 折线图使用visualMap时,颜色错乱，图元颜色改变，线段颜色错误
Ovilia commented on issue #15755: URL: https://github.com/apache/echarts/issues/15755#issuecomment-925619162 Please refer to [this example](https://www.makeapie.com/editor.html?c=x7AFiJ06e). If you still have questions, please minify your demo with minimum data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch feat-legend updated (2ec01be -> d95f7b8)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch feat-legend in repository https://gitbox.apache.org/repos/asf/echarts.git. from 2ec01be feat(legend): show legend based on series.colorBy add d95f7b8 feat(colorBy): legend filter for colorBy No new revisions were added by this update. Summary of changes: src/chart/pie/install.ts | 2 -- src/component/legend/legendFilter.ts | 22 +- 2 files changed, 21 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15756: ThemeRiver type cannot be vertical
Ovilia commented on issue #15756: URL: https://github.com/apache/echarts/issues/15756#issuecomment-925610506 Is this a feature request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15757: Graph tooltips do not show when all input values are null but all will show given at least one valid input
echarts-bot[bot] commented on issue #15757: URL: https://github.com/apache/echarts/issues/15757#issuecomment-925608536 This issue is labeled with `difficulty: easy`. @htr3n Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix. Please have a look at [How to debug ECharts](https://github.com/apache/echarts/blob/master/CONTRIBUTING.md#how-to-debug-echarts) if you'd like to give a try. 邏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15768: Strange logarithmic behaviour yAxis
Ovilia commented on issue #15768: URL: https://github.com/apache/echarts/issues/15768#issuecomment-925604400 Seems to be a bug to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia closed issue #15759: ThemeRiver series click has incorrect data
Ovilia closed issue #15759: URL: https://github.com/apache/echarts/issues/15759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15759: ThemeRiver series click has incorrect data
Ovilia commented on issue #15759: URL: https://github.com/apache/echarts/issues/15759#issuecomment-925603037 Duplicate of #13758. Please follow that issue. We will put it to a higher priority. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15763: Enable more dimensions (more than x & y) visualmap for line chart
Ovilia commented on issue #15763: URL: https://github.com/apache/echarts/issues/15763#issuecomment-925599957 This feature is supported right now. Checkout [visualMap.dimension](https://echarts.apache.org/en/option.html#visualMap-continuous.dimension). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] mmm2006 commented on issue #6302: so much [Violation] requestAnimationFrame handler took 90ms when render more chart instances
mmm2006 commented on issue #6302: URL: https://github.com/apache/echarts/issues/6302#issuecomment-925561274 我是在使用force的时候，如果点数比较多的情况下，就会出现不断的刷，判断是node比较多（400以上）的时候，关系图要稳定下来，需要不断刷屏，更新位置。这个估计没有办法解决吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] nba20416 commented on issue #8319: 3D绘制surface曲面中的问题
nba20416 commented on issue #8319: URL: https://github.com/apache/echarts/issues/8319#issuecomment-925543384 > 所有散点都有了，就是用data，而不是用方程 您好，我也有这个问题，我有三维的点，但是出不来曲面图是空白。不知道怎么处理Z轴的数据。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] ngoc308 commented on issue #12097: ScatterGL doesn't work with with datazoom.filterMode = 'none'
ngoc308 commented on issue #12097: URL: https://github.com/apache/echarts/issues/12097#issuecomment-925526176 @Ovilia , @pissang Could you comment on this? I also deal with the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
