[GitHub] [echarts] billychinglh opened a new issue, #17814: [Feature] Control the zoom/drag-to-zoom speed on large data

2022-10-23 Thread GitBox


billychinglh opened a new issue, #17814:
URL: https://github.com/apache/echarts/issues/17814

   ### What problem does this feature solve?
   
   Hi,
   
   I wanna ask if there any way to control the speed/sensitivity of the zoom 
in/out function, because for the large data, its quite hard to zoom to the 
specific location in the chart.
   
   Thanks
   
   ### What does the proposed API look like?
   
   Can we have a props in dataZoom like sensitivity/ speed in order to have 
more control on zoom function. 
   
   For example, adding the speed and sensitivity props like chartjs-plugin-zoom 
did: 
   `zoom: { enabled: true, drag: false, mode: "x", speed: 0.1, sensitivity: 
0.01 },`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] MeetzhDing commented on issue #17711: [Bug] dataset DataStore['_initDataFromProvider'] cost too many memory when using encode

2022-10-23 Thread GitBox


MeetzhDing commented on issue #17711:
URL: https://github.com/apache/echarts/issues/17711#issuecomment-1288396052

   @pissang @susiwen8 @100pah 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] shiboqingning opened a new issue, #17813: [Bug] ScatterChart brush selection with large amount of data is invalid

2022-10-23 Thread GitBox


shiboqingning opened a new issue, #17813:
URL: https://github.com/apache/echarts/issues/17813

   ### Version
   
   5.3
   
   ### Link to Minimal Reproduction
   
   https://echarts.apache.org/examples/zh/editor.html?c=scatter-large
   
   ### Steps to Reproduce
   
   1. Create a scatter chart of a large amount of data
   2. Add brush configuration items to scatter chart
   3. Brush selected data
   
   The specific code is as follows:
   ```
   function genData(len, offset) {
 let arr = new Float32Array(len * 2);
 let off = 0;
 for (let i = 0; i < len; i++) {
   let x = +Math.random() * 10;
   let y =
 +Math.sin(x) -
 x * (len % 2 ? 0.1 : -0.1) * Math.random() +
 (offset || 0) / 10;
   arr[off++] = x;
   arr[off++] = y;
 }
 return arr;
   }
   const data1 = genData(5e5);
   const data2 = genData(5e5, 10);
   option = {
 title: {
   text:
 echarts.format.addCommas(data1.length / 2 + data2.length / 2) + ' 
Points'
 },
 tooltip: {},
 toolbox: {
   left: 'center',
   feature: {
 dataZoom: {}
   }
 },
 legend: {
   orient: 'vertical',
   right: 10
 },
 xAxis: [{}],
 yAxis: [{}],
 dataZoom: [
   {
 type: 'inside',
 xAxisIndex: [0]
   },
   {
 type: 'inside',
 yAxisIndex: [0]
   }
 ],
 animation: false,
 brush: {
   brushLink: 'all',
   toolbox: ['rect', 'polygon' , 'clear'],
   seriesIndex: 'all',
   xAxisIndex: 0,
   inBrush: {
 opacity: 1
   },
   throttleType: 'debounce',
   throttleDelay: 1000
 },
 series: [
   {
 name: 'A',
 type: 'scatter',
 data: data1,
 dimensions: ['x', 'y'],
 symbolSize: 3,
 itemStyle: {
   opacity: 0.4
 },
 large: true,
   },
   {
 name: 'B',
 type: 'scatter',
 data: data2,
 dimensions: ['x', 'y'],
 symbolSize: 3,
 itemStyle: {
   opacity: 0.4
 },
 large: true
   }
 ]
   };
   ```
   The renderings are as follows:
   
![image](https://user-images.githubusercontent.com/102708847/197439522-c75437c7-2c0d-4c9b-ad00-3b2709b4.png)
   
   
   ### Current Behavior
   
   Does not get the value of the brush selection and has no visual effects
   
   ### Expected Behavior
   
   Can get the brush selected data and have a visual effect
   
   ### Environment
   
   ```markdown
   - OS:
   - Browser:
   - Framework:
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[echarts] branch next updated (7a12c0ba8 -> 1dadcabe2)

2022-10-23 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch next
in repository https://gitbox.apache.org/repos/asf/echarts.git


from 7a12c0ba8 Merge pull request #17796 from apache/master
 new 6f500be79 test(universalTransition): a possible test file
 new 0f850296a wip: successfully get childGroupId (a possible new interface)
 new 4d4634fd4 wip: can decide "parent2child" or "child2parent"
 new a4cf7f9f2 wip: new createKeyGetters that suppot multi-drill (but only 
get key from dim)
 new 788daecc1 wip: should consider getting direction from more ways & 
using groupId only when direction is 'nodirection'
 new 5063c519f refactor: rename "KeyDim" to "GroupIdDim"
 new 01ba523a7 learning: add some comments
 new 5e475a208 fix: incorrect dataGroupId for old data items in 
universalTransition
 new 6e555b754 feat: multiple level drill down (alpha)
 new 9fcbc7c58 refactor: more readable 
universalTransition-multiLevelDrillDown.html
 new ce89ee778 docs: add comments for code
 new b123f35e3 docs: improve comments in test html
 new 6168f98e2 docs: update universalTransition-multiLevelDrilldown.html
 new e5b9be310 Merge branch 'master' into feat/multi-drill
 new d6895216a revert changes introduced by a merge in mistake
 new 938e4152b rename `childGroupId` to `itemChildGroupId` to make it 
consistent with `itemGroupId`
 new 8e80c0116 no need to return undefined, just return
 new 55ba82589 use `!= null` to test if equal to `undefined` or `null`
 new ffbc6afaf not use enum, just use const variables
 new 5321c2d8d merge `getGroupId` and `getChildGroupId` into one function
 new dc9a3f68c use createHashMap() to improve performance
 new 6f7a395ac add another test case
 new edd2d3cf3 slow down animation update in test cases
 new 9d52862cb fix unexpected appearance of xAxis.name after switching 
options
 new 3d5b32c42 simplify code
 new 1dadcabe2 Merge pull request #17611 from tyn1998/feat/multi-drill

The 8931 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/animation/universalTransition.ts  | 174 +---
 src/util/types.ts |   5 +-
 test/universalTransition-multiLevelDrillDown.html | 476 ++
 3 files changed, 606 insertions(+), 49 deletions(-)
 create mode 100644 test/universalTransition-multiLevelDrillDown.html


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] echarts-bot[bot] commented on pull request #17611: feat: multiple level drill down support for universalTransition

2022-10-23 Thread GitBox


echarts-bot[bot] commented on PR #17611:
URL: https://github.com/apache/echarts/pull/17611#issuecomment-1288303190

   Congratulations! Your PR has been merged. Thanks for your contribution! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] pissang merged pull request #17611: feat: multiple level drill down support for universalTransition

2022-10-23 Thread GitBox


pissang merged PR #17611:
URL: https://github.com/apache/echarts/pull/17611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] github-actions[bot] commented on issue #7802: echarts在设置geo且为世界地图的情况下,使用nameMap后无法针对特殊区域(regions属性无效)产生样式变更

2022-10-23 Thread GitBox


github-actions[bot] commented on issue #7802:
URL: https://github.com/apache/echarts/issues/7802#issuecomment-1288200918

   This issue has been automatically marked as stale because it did not have 
recent activity. It will be closed in 7 days if no further activity occurs. If 
you wish not to mark it as stale, please leave a comment in this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts-doc] quillblue commented on a diff in pull request #295: docs: update documents for multiple level drilldown - `childGroupId`

2022-10-23 Thread GitBox


quillblue commented on code in PR #295:
URL: https://github.com/apache/echarts-doc/pull/295#discussion_r1002719329


##
en/option/partial/group-id.md:
##
@@ -3,15 +3,59 @@
 
 ## dataGroupId(string)
 
-A groupID common to all data in the series. the groupID will be used to 
classify the data and determine how merge and split animations are performed in 
the universal transition animation.
-
-If you are using the [dataset](~dataset) component to represent the data, it 
is recommended to use `encode.itemGroupID` to specify which dimension is 
encoded as the groupID.
+A group ID assigned to all data items in the series.
 
+This option has a lower priority than `groupId`, which means when `groupId` is 
specified for a certain data item the `dataGroupId` will be simply ignored for 
that data item. For more information, please see `series.data.groupId`.
 
 
 {{ target: partial-data-group-id }}
 
 #${prefix} groupId(string)
 
-The groupID of this data item. groupID will be used to classify the data.
+The group ID of a data item. When `universalTransition` is enabled, the data 
items from the old option and those from the new one, if sharing a same group 
ID, will then be matched and applied to a proper animation after `setOption` is 
called.
+
+If a data item is not specified with a `groupId`, Echarts will try to use 
`series.dataGroupId` as the group ID for the data item. If `series.dataGroupId` 
is not specified either, Echarts will fall back to using the data item's ID as 
its group ID.

Review Comment:
   Please be kind to use `Apache ECharts` as official name of ECharts 
(especially take care on letter C is in upper case)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts-doc] quillblue commented on a diff in pull request #295: docs: update documents for multiple level drilldown - `childGroupId`

2022-10-23 Thread GitBox


quillblue commented on code in PR #295:
URL: https://github.com/apache/echarts-doc/pull/295#discussion_r1002719170


##
en/option/partial/group-id.md:
##
@@ -3,15 +3,59 @@
 
 ## dataGroupId(string)
 
-A groupID common to all data in the series. the groupID will be used to 
classify the data and determine how merge and split animations are performed in 
the universal transition animation.
-
-If you are using the [dataset](~dataset) component to represent the data, it 
is recommended to use `encode.itemGroupID` to specify which dimension is 
encoded as the groupID.
+A group ID assigned to all data items in the series.
 
+This option has a lower priority than `groupId`, which means when `groupId` is 
specified for a certain data item the `dataGroupId` will be simply ignored for 
that data item. For more information, please see `series.data.groupId`.
 
 
 {{ target: partial-data-group-id }}
 
 #${prefix} groupId(string)
 
-The groupID of this data item. groupID will be used to classify the data.
+The group ID of a data item. When `universalTransition` is enabled, the data 
items from the old option and those from the new one, if sharing a same group 
ID, will then be matched and applied to a proper animation after `setOption` is 
called.
+
+If a data item is not specified with a `groupId`, Echarts will try to use 
`series.dataGroupId` as the group ID for the data item. If `series.dataGroupId` 
is not specified either, Echarts will fall back to using the data item's ID as 
its group ID.
+
+If you are using the [dataset](~dataset) component to represent data, you are 
recommended to use `encode.itemGroupId` to specify the dimension that is to be 
encoded as the group ID.
+
+
+{{ target: partial-data-child-group-id }}
+
+#${prefix} childGroupId(string)
+
+The group ID of the child data of a data item. This option is introduced to 
make multiple levels drilldown and aggregation animation possilbe.
+
+~[700x300](${galleryViewPath}doc-example/bar-drilldown=1=1)
+
+Before `childGroupId` is introduced, developers actually can use `groupId` to 
make drilldown and aggregation animation already, but with the limit on the 
times that a continious drilldown or aggregation can happen, which is only one 
time.
+
+`childGroupId`, together with `groupId`, help to form "father-child" 
relationships between data items of different options, such as:

Review Comment:
   it would be better using `parent-child relationships`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] quillblue commented on pull request #17611: feat: multiple level drill down support for universalTransition

2022-10-23 Thread GitBox


quillblue commented on PR #17611:
URL: https://github.com/apache/echarts/pull/17611#issuecomment-1288123740

   Looks great to me. Thanks @tyn1998 for your excellent contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org