[echarts] branch next-thumbnail created (now 1dadcabe2)
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a change to branch next-thumbnail in repository https://gitbox.apache.org/repos/asf/echarts.git at 1dadcabe2 Merge pull request #17611 from tyn1998/feat/multi-drill No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17845: incorrect emphasis on hover near wide lines ends
Ovilia commented on issue #17845: URL: https://github.com/apache/echarts/issues/17845#issuecomment-1296509311 I think this is probably by design because when there are multiple stops in a line (e.g., add the `[1,5,'ccc']` to your first series), the joint point should be considered rather than the line itself. May I ask what problem does this cause in your case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17851: [Bug] 树图官方第一个例图触摸label可以展示tooltip,且label文案没有被线条穿过
echarts-bot[bot] commented on issue #17851: URL: https://github.com/apache/echarts/issues/17851#issuecomment-1296505666 @CodeCat01 It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 珞 TRANSLATED **TITLE** [Bug] The first official example of the tree map can display the tooltip by touching the label, and the label copy is not crossed by the line **BODY** ### Version 5.4.0 ### Link to Minimal Reproduction _No response_ ### Steps to Reproduce 1. Chrome browser, vite (2.6.8) react (17.0.2) 2. In react v17 & echarts5.4 version, the label touch does not respond and the label is crossed by the line ### Current Behavior x ### Expected Behavior x ### Environment markdown - OS: - Browser: - Framework: ### Any additional comments? _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] CodeCat01 opened a new issue, #17851: [Bug] 树图官方第一个例图触摸label可以展示tooltip,且label文案没有被线条穿过
CodeCat01 opened a new issue, #17851: URL: https://github.com/apache/echarts/issues/17851 ### Version 5.4.0 ### Link to Minimal Reproduction _No response_ ### Steps to Reproduce 1、chrome浏览器、vite(2.6.8) react(17.0.2) 2、我在react v17 & echarts5.4 版本中label触摸没反应且label被线条穿过 ### Current Behavior x ### Expected Behavior x ### Environment ```markdown - OS: - Browser: - Framework: ``` ### Any additional comments? _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17844: [Bug] When add the slider to the heat map the data will overlap
echarts-bot[bot] commented on issue #17844: URL: https://github.com/apache/echarts/issues/17844#issuecomment-1296504125 @sarlemon Please provide a demo for the issue either with [Official Editor](https://echarts.apache.org/examples/editor.html), [CodePen](https://codepen.io/Ovilia/pen/dyYWXWM), [CodeSandbox](https://codesandbox.io/s/echarts-basic-example-template-mpfz1s) or [JSFiddle](https://jsfiddle.net/plainheart/e46ozpqj/7/). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17842: [Bug] 饼图百分比格式化错误
Ovilia commented on issue #17842: URL: https://github.com/apache/echarts/issues/17842#issuecomment-1296495547 I don't think this is a bug. `382206/382208` is `0.9477`. When the precision is 2, it should be rounded to be 100% rather than 99.99%. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17847: [Bug] 使用dataset x轴数据会自动合并
Ovilia commented on issue #17847: URL: https://github.com/apache/echarts/issues/17847#issuecomment-1296492088 Data with the same name is expected to be the same group. You may use different names in data and then use `label.formatter` to change the text for display. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17850: dataZoom slider trend incorrect on multiple line series
Ovilia commented on issue #17850: URL: https://github.com/apache/echarts/issues/17850#issuecomment-1296490764 Please follow #17143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] jiankafei commented on issue #10918: xAxis.axisLabel.rich.align不起作用
jiankafei commented on issue #10918: URL: https://github.com/apache/echarts/issues/10918#issuecomment-1296446694 > 我理解错xAxis.axisLabel.rich.align的作用了 怎么解决的? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] jiankafei commented on issue #10918: xAxis.axisLabel.rich.align不起作用
jiankafei commented on issue #10918: URL: https://github.com/apache/echarts/issues/10918#issuecomment-1296446491 > > 您好 我也遇到一样的问题 请问怎么单独设置axisLabel的对齐方式? > > 需要width和align一同使用才会看到效果 一起使用也不起作用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] helgasoft opened a new issue, #17850: dataZoom slider trend incorrect on multiple line series
helgasoft opened a new issue, #17850: URL: https://github.com/apache/echarts/issues/17850 ### Version 5.4.0 ### Link to Minimal Reproduction [example code](https://echarts.apache.org/examples/en/editor.html?c=line-simple=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMgL4A0asAnjvkUmRQEYCGAxgNYDmATsAK7QAJgGFgAG2DciAckZi27aeXR4AptwirCsANoV0SWGEohVMsRGiqlsQczDMiOnQEYAzKVguAdG4C6njoATACsnv5-sAzoBkYmZrDSFlY2dg5OOmFe3iEBui4AnJ4ADN5BfpHRsAEUacwAWsDAALZ0sPqweA7cYERBxZ4dAPRDdQBCCjz8QnTM3KrMAMrGYglIoGwQxkTFZLDJqsuUq3QbrFuUO8RV6CNqq6xgqoIAIvbMExxTAoKz80srNZnC5XTwHI4nZDA7awXbECjw4gAbiAA) ### Steps to Reproduce see example link above ### Current Behavior dataZoom slider shows the trend of the **first line only**. But there could be many more lines. ### Expected Behavior **Not showing a trend** at all, in our opinion, would be best in complex scenarios like multiple overlapping lines, or large data spans as in #15688 ### Environment ```markdown - OS: Win 10 - Browser: Chrome - Framework: JS ``` ### Any additional comments? A workaround is to hide the trend with _dataBackground.areaStyle.opacity: 0_ and _selectedDataBackground.areaStyle.opacity: 0_. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] branch next-funnel updated (6781a9ec -> 6413d9b2)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next-funnel in repository https://gitbox.apache.org/repos/asf/echarts-doc.git from 6781a9ec docs: update documents for multiple level drilldown - `childGroupId` (#295) new 195c1478 feat(funnel): set prop to flaten the exit piece new 53673830 feat(funnel): add dynamicHegiht prop new 6d224c23 feat(funnel):add exitWidth prop new 1359abf4 feat(funnel):add transform rate between each data new e671605f feat(funnel): add attr explains new 92efefb3 feat(funnel): supplt doc new 6f9d7ad9 feat(funnel): use formatter to set funnel rate label new 308121b8 feat(funnel): prefect the api of rate label formatter new 6cdff619 feat(funnel): del tpl from rate label formatter new 84158a0c feat(funnel) add precision to funnl conversion rate new 6413d9b2 Merge pull request #281 from pe-3/feat-funnel-newProp The 2426 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: en/option/series/funnel.md | 74 ++-- zh/option/series/funnel.md | 76 -- 2 files changed, 146 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts-doc] pissang merged pull request #281: feat(funnel): add funnel new styles and props
pissang merged PR #281: URL: https://github.com/apache/echarts-doc/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] branch next-funnel created (now 6781a9ec)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next-funnel in repository https://gitbox.apache.org/repos/asf/echarts-doc.git at 6781a9ec docs: update documents for multiple level drilldown - `childGroupId` (#295) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17461: feat(funnel): add funnel new styles #14863
echarts-bot[bot] commented on PR #17461: URL: https://github.com/apache/echarts/pull/17461#issuecomment-1296425830 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch next-funnel updated (1dadcabe2 -> 3034a94ea)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next-funnel in repository https://gitbox.apache.org/repos/asf/echarts.git from 1dadcabe2 Merge pull request #17611 from tyn1998/feat/multi-drill new c80384b5d feat(funnel): set prop to flatten the funnel exit #14863 new 4605cfca3 feat(funnel): add dynamic height new prop #16445 new cf4166c38 feat(funnel): add dynamic height new prop #16445 new 5d65776d1 feat(funnel): fix code styles error new 903f00e02 feat(funnel): add exitWidth prop new a67891c0b feat(funnel):add transform rate between each data new 8703c20d0 feat(funnel):add transform rate between each data new 94ad84bce feat(funnel): add dynamic size mapping mode new 4e0842e85 feat(funnel): fix funnel code style new fa55aca4e feat(funnel): change lastWidth as thickDegree which mean dynamicHeight funnel thick new 5aaf7b45c feat(funnel): fix the bug thay exit width can greater than 100% new 18a0dea34 feat(funnel):add auto test, and change dynamciSize into dynamciArea new 0ca2b9ebf feat(funnel): use formatter to set rate label text new 151de1dbd chore(workflow): dump github context object for debug new 06f50559e Merge branch 'master' into 'feat-funnel-newStyle' new a236499bc chore(workflow): remove debug step new d128b3fe9 Merge branch 'feat-funnel-newStyle' of github.com:pe-3/echarts-funnel-newfeat into feat-funnel-newStyle new fe14b3ba7 feat(funnel): use formatter to set rate label text new 646736cb5 feat(funnel): run test visual of funnel new feat new 83d6a844c feat(funnle): visual test of all funnel new feat new f5b1065e3 feat(funnel): rename test case file, delete dynamicArea new b7a2e5ca2 feat(funnel): remove unnecessary data from label format params new 19d9b6b14 feat(funnel): remove tpl from rate label fomatter new f4d568148 feat(funnel): fix overall rate label set styles separately new ebda31ab0 feat(funnel): give formatter in params new 3034a94ea Merge pull request #17461 from pe-3/feat-funnel-newStyle The 8957 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/funnel/FunnelSeries.ts | 20 ++ src/chart/funnel/FunnelView.ts | 201 --- src/chart/funnel/funnelLayout.ts | 327 - test/funnel-dynamicHeight.html | 162 test/funnel-showRate.html | 159 test/runTest/actions/__meta__.json | 2 + test/runTest/actions/funnel-dynamicHeight.json | 1 + test/runTest/actions/funnel-showRate.json | 1 + 8 files changed, 779 insertions(+), 94 deletions(-) create mode 100644 test/funnel-dynamicHeight.html create mode 100644 test/funnel-showRate.html create mode 100644 test/runTest/actions/funnel-dynamicHeight.json create mode 100644 test/runTest/actions/funnel-showRate.json - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #17461: feat(funnel): add funnel new styles #14863
pissang merged PR #17461: URL: https://github.com/apache/echarts/pull/17461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch next-funnel created (now 1dadcabe2)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next-funnel in repository https://gitbox.apache.org/repos/asf/echarts.git at 1dadcabe2 Merge pull request #17611 from tyn1998/feat/multi-drill No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #13514: Web GL Rendered
github-actions[bot] commented on issue #13514: URL: https://github.com/apache/echarts/issues/13514#issuecomment-1296350692 This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] closed issue #7802: echarts在设置geo且为世界地图的情况下,使用nameMap后无法针对特殊区域(regions属性无效)产生样式变更
github-actions[bot] closed issue #7802: echarts在设置geo且为世界地图的情况下,使用nameMap后无法针对特殊区域(regions属性无效)产生样式变更 URL: https://github.com/apache/echarts/issues/7802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #7802: echarts在设置geo且为世界地图的情况下,使用nameMap后无法针对特殊区域(regions属性无效)产生样式变更
github-actions[bot] commented on issue #7802: URL: https://github.com/apache/echarts/issues/7802#issuecomment-1296350635 This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #11185: 中国地图实现如何实现鼠标滑过省,省单独的区域regionHeight发生变化?
github-actions[bot] commented on issue #11185: URL: https://github.com/apache/echarts/issues/11185#issuecomment-1296350645 This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17849: feat(dataView): add dataViewOpend and dataViewClosed event, close #17840
echarts-bot[bot] commented on PR #17849: URL: https://github.com/apache/echarts/pull/17849#issuecomment-1296267778 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] MainHou opened a new pull request, #17849: feat(dataView): add dataViewOpend and dataViewClosed event, close #17840
MainHou opened a new pull request, #17849: URL: https://github.com/apache/echarts/pull/17849 ## Brief Information This pull request is in the type of: - [ ] bug fixing - [x] new feature - [ ] others ### What does this PR do? add toolbox enter and close event listener ### Fixed issues #17840 ## Details ### Before: What was the problem? Open and close dataview without event listening ### After: How does it behave after the fixing? The API look like ```js chart.on('dataViewOpend', function (params) { console.log('dataViewOpend', params) }); chart.on('dataViewClosed', function (params) { console.log('dataViewClosed', params) }); ``` ## Document Info One of the following should be checked. - [ ] This PR doesn't relate to document changes - [x] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs N.A. ## Others ### Merging options - [ ] Please squash the commits into a single one when merging. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] MainHou closed pull request #17848: feat(dataView): add dataViewOpend and dataViewClosed event, close #17840
MainHou closed pull request #17848: feat(dataView): add dataViewOpend and dataViewClosed event, close #17840 URL: https://github.com/apache/echarts/pull/17848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17848: feat(dataView): add dataViewOpend and dataViewClosed event, close #17840
echarts-bot[bot] commented on PR #17848: URL: https://github.com/apache/echarts/pull/17848#issuecomment-1296253235 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] MainHou opened a new pull request, #17848: feat(dataView): add dataViewOpend and dataViewClosed event, close #17840
MainHou opened a new pull request, #17848: URL: https://github.com/apache/echarts/pull/17848 ## Brief Information This pull request is in the type of: - [ ] bug fixing - [x] new feature - [ ] others ### What does this PR do? add toolbox enter and close event listener ### Fixed issues #17840 ## Details ### Before: What was the problem? Open and close dataview without event listening ### After: How does it behave after the fixing? The API look like ```js chart.on('dataViewOpend', function (params) { console.log('dataViewOpend', params) }); chart.on('dataViewClosed', function (params) { console.log('dataViewClosed', params) }); ``` ## Document Info One of the following should be checked. - [ ] This PR doesn't relate to document changes - [x] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs N.A. ## Others ### Merging options - [ ] Please squash the commits into a single one when merging. ### Other information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org