[echarts-handbook] branch dependabot/npm_and_yarn/nuxt-3.4.3 deleted (was 2f55113)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/nuxt-3.4.3 in repository https://gitbox.apache.org/repos/asf/echarts-handbook.git was 2f55113 build(deps): bump nuxt from 2.15.8 to 3.4.3 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts-handbook] dependabot[bot] commented on pull request #95: build(deps): bump nuxt from 2.15.8 to 3.4.3
dependabot[bot] commented on PR #95: URL: https://github.com/apache/echarts-handbook/pull/95#issuecomment-1614204999 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts-handbook] plainheart closed pull request #95: build(deps): bump nuxt from 2.15.8 to 3.4.3
plainheart closed pull request #95: build(deps): bump nuxt from 2.15.8 to 3.4.3 URL: https://github.com/apache/echarts-handbook/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-examples] branch gh-pages updated: fix(editor): fix wrong link to target branch in PR preview tab
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/echarts-examples.git
The following commit(s) were added to refs/heads/gh-pages by this push:
new d3e261d5 fix(editor): fix wrong link to target branch in PR preview tab
d3e261d5 is described below
commit d3e261d5cfe564b06f5dc703bb33ec2678fa04e4
Author: plainheart
AuthorDate: Fri Jun 30 14:43:40 2023 +0800
fix(editor): fix wrong link to target branch in PR preview tab
---
src/editor/Editor.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/editor/Editor.vue b/src/editor/Editor.vue
index a9640537..9c1bd50d 100644
--- a/src/editor/Editor.vue
+++ b/src/editor/Editor.vue
@@ -226,7 +226,7 @@
{{ pr.base.ref }}
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] ShiyiWei1995 commented on issue #18818: [Bug] series.bar.emphasis.itemStyle.color 在同系列 stack bars 高亮状态下不起作用
ShiyiWei1995 commented on issue #18818: URL: https://github.com/apache/echarts/issues/18818#issuecomment-1613994818 > 你是怎么不加Link to Minimal Reproduction发出bug issue的？ 填的 "默认" 两个字符，我看不少人这么做的哇😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] ulee19 commented on issue #18818: [Bug] series.bar.emphasis.itemStyle.color 在同系列 stack bars 高亮状态下不起作用
ulee19 commented on issue #18818: URL: https://github.com/apache/echarts/issues/18818#issuecomment-1613952892 你是怎么不加Link to Minimal Reproduction发出bug issue的？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] closed issue #15202: IE10 Bar3D Component series.bar3D not exists. Load it first
github-actions[bot] closed issue #15202: IE10 Bar3D Component series.bar3D not exists. Load it first URL: https://github.com/apache/echarts/issues/15202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #15202: IE10 Bar3D Component series.bar3D not exists. Load it first
github-actions[bot] commented on issue #15202: URL: https://github.com/apache/echarts/issues/15202#issuecomment-1613807759 This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] closed issue #10830: tree关系边显示内容
github-actions[bot] closed issue #10830: tree关系边显示内容 URL: https://github.com/apache/echarts/issues/10830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #10830: tree关系边显示内容
github-actions[bot] commented on issue #10830: URL: https://github.com/apache/echarts/issues/10830#issuecomment-1613807577 This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] ulee19 commented on issue #18830: the graph's width can't be full in a layui crousal container
ulee19 commented on issue #18830: URL: https://github.com/apache/echarts/issues/18830#issuecomment-1613403649 i am sorry there is a typing error in line 6 of the code. this is the code render the current chart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] ulee19 opened a new issue, #18830: the graph's width can't be full in a layui crousal container
ulee19 opened a new issue, #18830:
URL: https://github.com/apache/echarts/issues/18830
### Version
V 5.4.2
### Link to Minimal Reproduction
https://codesandbox.io/s/trusting-stallman-5m2vpw?file=/test.php
### Steps to Reproduce
when i put a chart in a layui card, it can be reponsive and displayed
normally. but when i add a layui crousal in the card container, it only paint
the left side of the the canvas.i have checked css of layui.crousal, and the
atrribute width is set as "100%".So i think it might be something wrong with
echarts.
```
个人已完成工作统计
var difficulty_evaluation_Series = {
// name: '难度评价图',
type: 'heatmap',
itemStyle: {},
label: {
show: true
},
emphasis: {
itemStyle: {
shadowBlur: 10,
shadowColor: 'rgba(0, 0, 0, 0.5)'
}
},
data: []
};
var options = {
title: {},
tooltip: {
axisPointer: {
type: 'shadow'
},
position: 'right',
formatter: function (obj) {
var value = obj.value;
// prettier-ignore
return "难度" + '：' + value[1] + '
'
+ "评价" + '：' + value[0] + '
'
+ "数量" + '：' + value[2] + '
';
}
},
visualMap: {
min: 0,
max: 25,
calculable: true,
orient: 'horizontal',
left: 'center',
bottom: '0%',
// inRange: {
// color: ['blue', 'red'] // Specify the color range for
values above zero
// },
// pieces: [
// // Add an additional visual mapping for zero value
// { value: 0, color: 'white' }
// ]
},
toolbox: {
show: true,
orient: 'vertical',
left: 'right',
top: '5%',
feature: {
mark: {show: true},
dataView: {show: true, readOnly: true},
// magicType: {show: true, type: ['bar', 'line']},
restore: {show: true},
saveAsImage: {show: true}
}
},
legend: {},
grid: {
height: '70%',
top: '13%',
containLabel: true
},
xAxis: {
name: '评价',
type: 'category',
axisLabel: {
formatter: '{value} 星'
},
nameTextStyle: {
fontSize: 16
},
splitLine: {
show: true
},
data:["未评价没","1","2","3","4","5"]
},
yAxis: {
name: '难度',
type: 'category',
axisLabel: {
formatter: '{value} 级'
},
nameTextStyle: {
fontSize: 16
},
splitArea: {
show: true
},
data:[1,2,3,4,5,6,7,8,9,10]
},
series: [difficulty_evaluation_Series]
};
//渲染chart
options && chart1.setOption(options);
//界面尺寸自适应
window.addEventListener('resize', function () {
chart1.resize();
});
layui.use(function(){
var carousel = layui.carousel;
// 渲染 - 常规轮播
carousel.render({
elem: '#ID-carousel-demo',
// width: '100%',
height: '400px',
width: 'auto',
indicator: 'card_head',
autoplay: 'true'
});
});
```
### Current Behavior
### Expected Behavior
### Environment
```markdown
- OS: win 10
- Browser: Microsoft Edge 版本 114.0.1823.58 (正式版本) (64 位)
- Framework: layui 2.7.6
```
### Any additional comments?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubs
[GitHub] [echarts] linghaoSu commented on a diff in pull request #18820: feat(pie): add angleRange for control pie range
linghaoSu commented on code in PR #18820: URL: https://github.com/apache/echarts/pull/18820#discussion_r1246786963 ## src/chart/pie/PieSeries.ts: ## @@ -112,6 +112,7 @@ export interface PieSeriesOption extends clockwise?: boolean startAngle?: number +angleRange?: number Review Comment: Sorry, I ignored this option, I use `endAngle` instead of `angleRange`, and default value is `'auto'`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on pull request #18815: feat(line): show single symbol when pre and next data is null
github-actions[bot] commented on PR #18815: URL: https://github.com/apache/echarts/pull/18815#issuecomment-1613277647 The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18815@b668fcb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch workflow/pr-preview deleted (was 497c756ef)
This is an automated email from the ASF dual-hosted git repository. wangzx pushed a change to branch workflow/pr-preview in repository https://gitbox.apache.org/repos/asf/echarts.git was 497c756ef chore(workflow): refactor pr review workflow The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-examples] branch gh-pages updated: fix(editor): fetch latest review comment when a review has no comment.
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/echarts-examples.git
The following commit(s) were added to refs/heads/gh-pages by this push:
new 7b97ba18 fix(editor): fetch latest review comment when a review has no
comment.
7b97ba18 is described below
commit 7b97ba188c69f629fdfeb9caf0ce9163251acbde
Author: plainheart
AuthorDate: Thu Jun 29 22:04:47 2023 +0800
fix(editor): fetch latest review comment when a review has no comment.
---
src/editor/Editor.vue | 35 +--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git a/src/editor/Editor.vue b/src/editor/Editor.vue
index d499b502..a9640537 100644
--- a/src/editor/Editor.vue
+++ b/src/editor/Editor.vue
@@ -713,8 +713,39 @@ export default {
},
dataType: 'json',
success: (reviews) => {
- this.prLatestReview = reviews[reviews.length - 1];
- this.isPRReviewLoading = 0;
+ const prLatestReview = (this.prLatestReview =
+reviews[reviews.length - 1]);
+ if (
+prLatestReview &&
+prLatestReview.state === 'COMMENTED' &&
+!prLatestReview.body
+ ) {
+$.ajax({
+ url:
+prURL +
+'/reviews/' +
+prLatestReview.id +
+'/comments?direction=desc&sort=created&per_page=100',
+ headers: {
+Accept: 'application/json'
+ },
+ dataType: 'json',
+ success: (comments) => {
+const comment = comments[0];
+prLatestReview.body = comment.body;
+prLatestReview.submitted_at = comment.created_at;
+prLatestReview.html_url = comment.html_url;
+ },
+ error: (xhr, status, err) => {
+console.error('failed to fetch PR review comment', err);
+ },
+ complete: () => {
+this.isPRReviewLoading = 0;
+ }
+});
+ } else {
+this.isPRReviewLoading = 0;
+ }
},
error: (xhr, status, err) => {
this.isPRReviewLoading = false;
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on pull request #18820: feat(pie): add angleRange for control pie range
github-actions[bot] commented on PR #18820: URL: https://github.com/apache/echarts/pull/18820#issuecomment-1613185083 The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18820@11e4386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: Merge pull request #18829 from apache/workflow/pr-preview
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git commit 82153b647e8a0838b36248d4d50a8fc76a9e9bd9 Merge: 78f56df4f 497c756ef Author: Wenli Zhang AuthorDate: Thu Jun 29 21:19:57 2023 +0800 Merge pull request #18829 from apache/workflow/pr-preview chore(workflow): refactor pr review workflow .github/workflows/ci.yml | 102 -- .github/workflows/pr-preview.yml | 76 ++ .github/workflows/teardown-pr-preview.yml | 30 + 3 files changed, 134 insertions(+), 74 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (78f56df4f -> 82153b647)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from 78f56df4f Merge pull request #18828 from apache/fix/workflow-env-var add 497c756ef chore(workflow): refactor pr review workflow new 82153b647 Merge pull request #18829 from apache/workflow/pr-preview The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/ci.yml | 102 -- .github/workflows/pr-preview.yml | 76 ++ .github/workflows/teardown-pr-preview.yml | 30 + 3 files changed, 134 insertions(+), 74 deletions(-) create mode 100644 .github/workflows/pr-preview.yml create mode 100644 .github/workflows/teardown-pr-preview.yml - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18829: chore(workflow): refactor pr review workflow
echarts-bot[bot] commented on PR #18829: URL: https://github.com/apache/echarts/pull/18829#issuecomment-1613172511 Congratulations! Your PR has been merged. Thanks for your contribution! 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #18829: chore(workflow): refactor pr review workflow
Ovilia merged PR #18829: URL: https://github.com/apache/echarts/pull/18829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: chore(workflow): refactor pr review workflow
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch workflow/pr-preview
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 497c756ef37c23e479939d17c49188379e5381cd
Author: plainheart
AuthorDate: Thu Jun 29 18:06:54 2023 +0800
chore(workflow): refactor pr review workflow
---
.github/workflows/ci.yml | 102 --
.github/workflows/pr-preview.yml | 76 ++
.github/workflows/teardown-pr-preview.yml | 30 +
3 files changed, 134 insertions(+), 74 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9d64c3492..d11e9faa6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2,15 +2,16 @@ name: Node CI
on:
pull_request:
-types: [opened, reopened, synchronize, closed]
+types: [opened, reopened, synchronize]
concurrency:
+ # Note that the `teardown-pr-preview` workflow needs the same group name
+ # to cancel the running `ci` workflows
group: ${{ github.workflow }}-${{ github.event.number }}
cancel-in-progress: true
jobs:
lint:
-if: ${{ github.event.action != 'closed' }}
runs-on: ubuntu-latest
strategy:
@@ -59,7 +60,6 @@ jobs:
run: npm run checktype
build:
-if: ${{ github.event.action != 'closed' }}
runs-on: ubuntu-latest
strategy:
@@ -97,79 +97,33 @@ jobs:
run: npm run test:dts
- name: Pack npm tarball
+if: ${{ github.repository_owner == 'apache' }}
id: pack-tarball
run: |
- export NPM_PKG_DIR='.npm-pkg'
- mkdir $NPM_PKG_DIR
- npm pack -pack-destination $NPM_PKG_DIR
- cd $NPM_PKG_DIR
- find . -type f -regex ".*\.tgz" -exec tar xvzf {} \;
- echo "PR_DIST_DIR=$NPM_PKG_DIR/package" >> $GITHUB_OUTPUT
- echo "PR_DIST_CACHE_KEY=echarts-pr-dist-cache-${{
github.event.number }}@${{ github.event.pull_request.head.sha }}" >>
$GITHUB_OUTPUT
-
- - name: Cache PR dist files
-uses: actions/cache@v3
-id: cache-pr-dist
-with:
- key: ${{ steps.pack-tarball.outputs.PR_DIST_CACHE_KEY }}
- path: ${{ steps.pack-tarball.outputs.PR_DIST_DIR }}
-
-outputs:
- PR_DIST_CACHE_KEY: ${{ steps.pack-tarball.outputs.PR_DIST_CACHE_KEY }}
- PR_DIST_DIR: ${{ steps.pack-tarball.outputs.PR_DIST_DIR }}
-
- pr-preview:
-runs-on: ubuntu-latest
-if: ${{ github.repository_owner == 'apache' && needs.build.result ==
'success' }}
-needs: ['build']
-
-steps:
- - name: Fetch cached PR dist files
-uses: actions/cache@v3
-with:
- key: ${{ needs.build.outputs.PR_DIST_CACHE_KEY }}
- path: ${{ needs.build.outputs.PR_DIST_DIR }}
- fail-on-cache-miss: true
-
- - name: Deploy dist files
-run: |
- cd ${{ needs.build.outputs.PR_DIST_DIR }}
- export SURGE_DOMAIN='https://echarts-pr-${{ github.event.number
}}.surge.sh'
- npx surge --project ./ --domain $SURGE_DOMAIN --token ${{
secrets.SURGE_TOKEN }}
-
- - name: Install action dependencies
+ export PR_PREVIEW_DIR='echarts-pr-preview'
+ mkdir -p $PR_PREVIEW_DIR
+ npm pack -pack-destination $PR_PREVIEW_DIR
+ echo "PR_PREVIEW_DIR=$PR_PREVIEW_DIR" >> $GITHUB_ENV
+
+ - name: Save PR metadata and dist files
+if: ${{ steps.pack-tarball.outcome == 'success' }}
+id: save-pr-data
+env:
+ PR_NUMBER: ${{ github.event.number }}
+ PR_COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
+ PR_PREVIEW_DIR: ${{ env.PR_PREVIEW_DIR }}
run: |
- mkdir .actions
- cd .actions
- git clone --depth=1
https://github.com/actions-cool/maintain-one-comment.git
-
- echo "GH_SHA_SHORT=$(echo ${{ github.event.pull_request.head.sha }}
| cut -c 1-7)" >> $GITHUB_ENV
-
- - name: Create comment for PR preview
-uses: ./.actions/maintain-one-comment
-with:
- body: |
-
-The changes brought by this PR can be previewed at:
https://echarts.apache.org/examples/editor?version=PR-${{ github.event.number
}}@${{ env.GH_SHA_SHORT }}
- body-include: ''
- number: ${{ github.event.number }}
-
- teardown-preview:
-runs-on: ubuntu-latest
-if: ${{ github.repository_owner == 'apache' && github.event.action ==
'closed' && github.event.pull_request.merged != true }}
-continue-on-error: true
-steps:
- - name: Install action dependencies
-run: git clone --depth=1
https://github.com/actions-cool/maintain-one-comment.git
+ cd $PR_PREVIEW_DIR
+ echo $PR_NUMBER > ./pr_number
+ echo $PR_COMMIT_SHA > ./pr_commit_sha
+ find . -type f -regex ".*\.tgz" -exec tar xvzf {} \;
+ rm -f *.tgz
+ echo -e "Dist files: \n$(ls -l)"
- - name: Delete
[echarts] branch workflow/pr-preview updated (d512db477 -> 497c756ef)
This is an automated email from the ASF dual-hosted git repository. wangzx pushed a change to branch workflow/pr-preview in repository https://gitbox.apache.org/repos/asf/echarts.git omit d512db477 chore(workflow): refactor pr review workflow new 497c756ef chore(workflow): refactor pr review workflow This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d512db477) \ N -- N -- N refs/heads/workflow/pr-preview (497c756ef) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch workflow/pr-preview updated (368b6f337 -> d512db477)
This is an automated email from the ASF dual-hosted git repository. wangzx pushed a change to branch workflow/pr-preview in repository https://gitbox.apache.org/repos/asf/echarts.git omit 368b6f337 chore(workflow): refactor pr review workflow new d512db477 chore(workflow): refactor pr review workflow This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (368b6f337) \ N -- N -- N refs/heads/workflow/pr-preview (d512db477) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/ci.yml | 10 +++--- .github/workflows/pr-preview.yml | 17 + .github/workflows/teardown-pr-preview.yml | 7 ++- 3 files changed, 22 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: chore(workflow): refactor pr review workflow
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch workflow/pr-preview
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit d512db477277cda6c08d9ff6577392161f430fe6
Author: plainheart
AuthorDate: Thu Jun 29 18:06:54 2023 +0800
chore(workflow): refactor pr review workflow
---
.github/workflows/ci.yml | 101 --
.github/workflows/pr-preview.yml | 76 ++
.github/workflows/teardown-pr-preview.yml | 30 +
3 files changed, 133 insertions(+), 74 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9d64c3492..d32b2b59f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2,15 +2,16 @@ name: Node CI
on:
pull_request:
-types: [opened, reopened, synchronize, closed]
+types: [opened, reopened, synchronize]
concurrency:
+ # Note that the `teardown-pr-preview` workflow needs the same group name
+ # to cancel the running `ci` workflows
group: ${{ github.workflow }}-${{ github.event.number }}
cancel-in-progress: true
jobs:
lint:
-if: ${{ github.event.action != 'closed' }}
runs-on: ubuntu-latest
strategy:
@@ -59,7 +60,6 @@ jobs:
run: npm run checktype
build:
-if: ${{ github.event.action != 'closed' }}
runs-on: ubuntu-latest
strategy:
@@ -97,79 +97,32 @@ jobs:
run: npm run test:dts
- name: Pack npm tarball
+if: ${{ github.repository_owner == 'apache' }}
id: pack-tarball
run: |
- export NPM_PKG_DIR='.npm-pkg'
- mkdir $NPM_PKG_DIR
- npm pack -pack-destination $NPM_PKG_DIR
- cd $NPM_PKG_DIR
- find . -type f -regex ".*\.tgz" -exec tar xvzf {} \;
- echo "PR_DIST_DIR=$NPM_PKG_DIR/package" >> $GITHUB_OUTPUT
- echo "PR_DIST_CACHE_KEY=echarts-pr-dist-cache-${{
github.event.number }}@${{ github.event.pull_request.head.sha }}" >>
$GITHUB_OUTPUT
-
- - name: Cache PR dist files
-uses: actions/cache@v3
-id: cache-pr-dist
-with:
- key: ${{ steps.pack-tarball.outputs.PR_DIST_CACHE_KEY }}
- path: ${{ steps.pack-tarball.outputs.PR_DIST_DIR }}
-
-outputs:
- PR_DIST_CACHE_KEY: ${{ steps.pack-tarball.outputs.PR_DIST_CACHE_KEY }}
- PR_DIST_DIR: ${{ steps.pack-tarball.outputs.PR_DIST_DIR }}
-
- pr-preview:
-runs-on: ubuntu-latest
-if: ${{ github.repository_owner == 'apache' && needs.build.result ==
'success' }}
-needs: ['build']
-
-steps:
- - name: Fetch cached PR dist files
-uses: actions/cache@v3
-with:
- key: ${{ needs.build.outputs.PR_DIST_CACHE_KEY }}
- path: ${{ needs.build.outputs.PR_DIST_DIR }}
- fail-on-cache-miss: true
-
- - name: Deploy dist files
-run: |
- cd ${{ needs.build.outputs.PR_DIST_DIR }}
- export SURGE_DOMAIN='https://echarts-pr-${{ github.event.number
}}.surge.sh'
- npx surge --project ./ --domain $SURGE_DOMAIN --token ${{
secrets.SURGE_TOKEN }}
-
- - name: Install action dependencies
+ export PR_PREVIEW_DIR='echarts-pr-preview'
+ mkdir -p $PR_PREVIEW_DIR
+ npm pack -pack-destination $PR_PREVIEW_DIR
+ echo "PR_PREVIEW_DIR=$PR_PREVIEW_DIR" >> $GITHUB_ENV
+
+ - name: Save PR metadata and dist files
+if: ${{ steps.pack-tarball.outcome == 'success' }}
+id: save-pr-data
+env:
+ PR_NUMBER: ${{ github.event.number }}
+ PR_COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
+ PR_PREVIEW_DIR: ${{ env.PR_PREVIEW_DIR }}
run: |
- mkdir .actions
- cd .actions
- git clone --depth=1
https://github.com/actions-cool/maintain-one-comment.git
-
- echo "GH_SHA_SHORT=$(echo ${{ github.event.pull_request.head.sha }}
| cut -c 1-7)" >> $GITHUB_ENV
-
- - name: Create comment for PR preview
-uses: ./.actions/maintain-one-comment
-with:
- body: |
-
-The changes brought by this PR can be previewed at:
https://echarts.apache.org/examples/editor?version=PR-${{ github.event.number
}}@${{ env.GH_SHA_SHORT }}
- body-include: ''
- number: ${{ github.event.number }}
-
- teardown-preview:
-runs-on: ubuntu-latest
-if: ${{ github.repository_owner == 'apache' && github.event.action ==
'closed' && github.event.pull_request.merged != true }}
-continue-on-error: true
-steps:
- - name: Install action dependencies
-run: git clone --depth=1
https://github.com/actions-cool/maintain-one-comment.git
+ cd $PR_PREVIEW_DIR
+ echo $PR_NUMBER > ./pr_number
+ echo $PR_COMMIT_SHA > ./pr_commit_sha
+ find . -type f -regex ".*\.tgz" -exec tar xvzf {} \;
+ echo -e "Dist files: \n$(ls -l)"
- - name: Delete PR preview comment
-
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18829: chore(workflow): refactor pr review workflow
echarts-bot[bot] commented on PR #18829: URL: https://github.com/apache/echarts/pull/18829#issuecomment-1612775282 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged` This message is shown because the PR description doesn't contain the document related template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart opened a new pull request, #18829: chore(workflow): refactor pr review workflow
plainheart opened a new pull request, #18829: URL: https://github.com/apache/echarts/pull/18829 ## Brief Information This pull request is in the type of: - [ ] bug fixing - [ ] new feature - [x] others ### What does this PR do? Refactor the PR preview action and make it work for every PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch workflow/pr-preview created (now 368b6f337)
This is an automated email from the ASF dual-hosted git repository. wangzx pushed a change to branch workflow/pr-preview in repository https://gitbox.apache.org/repos/asf/echarts.git at 368b6f337 chore(workflow): refactor pr review workflow This branch includes the following new commits: new 368b6f337 chore(workflow): refactor pr review workflow The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: chore(workflow): refactor pr review workflow
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch workflow/pr-preview
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 368b6f3371bfffb40838169394bb3b5a2bcfcf63
Author: plainheart
AuthorDate: Thu Jun 29 18:06:54 2023 +0800
chore(workflow): refactor pr review workflow
---
.github/workflows/ci.yml | 91 +++
.github/workflows/pr-preview.yml | 75 +
.github/workflows/teardown-pr-preview.yml | 25 +
3 files changed, 120 insertions(+), 71 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9d64c3492..1cc2de6f7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2,7 +2,7 @@ name: Node CI
on:
pull_request:
-types: [opened, reopened, synchronize, closed]
+types: [opened, reopened, synchronize]
concurrency:
group: ${{ github.workflow }}-${{ github.event.number }}
@@ -99,77 +99,26 @@ jobs:
- name: Pack npm tarball
id: pack-tarball
run: |
- export NPM_PKG_DIR='.npm-pkg'
- mkdir $NPM_PKG_DIR
- npm pack -pack-destination $NPM_PKG_DIR
- cd $NPM_PKG_DIR
- find . -type f -regex ".*\.tgz" -exec tar xvzf {} \;
- echo "PR_DIST_DIR=$NPM_PKG_DIR/package" >> $GITHUB_OUTPUT
- echo "PR_DIST_CACHE_KEY=echarts-pr-dist-cache-${{
github.event.number }}@${{ github.event.pull_request.head.sha }}" >>
$GITHUB_OUTPUT
-
- - name: Cache PR dist files
-uses: actions/cache@v3
-id: cache-pr-dist
-with:
- key: ${{ steps.pack-tarball.outputs.PR_DIST_CACHE_KEY }}
- path: ${{ steps.pack-tarball.outputs.PR_DIST_DIR }}
-
-outputs:
- PR_DIST_CACHE_KEY: ${{ steps.pack-tarball.outputs.PR_DIST_CACHE_KEY }}
- PR_DIST_DIR: ${{ steps.pack-tarball.outputs.PR_DIST_DIR }}
-
- pr-preview:
-runs-on: ubuntu-latest
-if: ${{ github.repository_owner == 'apache' && needs.build.result ==
'success' }}
-needs: ['build']
-
-steps:
- - name: Fetch cached PR dist files
-uses: actions/cache@v3
-with:
- key: ${{ needs.build.outputs.PR_DIST_CACHE_KEY }}
- path: ${{ needs.build.outputs.PR_DIST_DIR }}
- fail-on-cache-miss: true
+ export PR_PREVIEW_DIR='echarts-pr-preview'
+ mkdir -p $PR_PREVIEW_DIR
+ npm pack -pack-destination $PR_PREVIEW_DIR
+ echo "PR_PREVIEW_DIR=$PR_PREVIEW_DIR" >> $GITHUB_ENV
- - name: Deploy dist files
-run: |
- cd ${{ needs.build.outputs.PR_DIST_DIR }}
- export SURGE_DOMAIN='https://echarts-pr-${{ github.event.number
}}.surge.sh'
- npx surge --project ./ --domain $SURGE_DOMAIN --token ${{
secrets.SURGE_TOKEN }}
-
- - name: Install action dependencies
+ - name: Save PR number and dist files
+env:
+ PR_NUMBER: ${{ github.event.number }}
+ PR_COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
+ PR_PREVIEW_DIR: ${{ env.PR_PREVIEW_DIR }}
run: |
- mkdir .actions
- cd .actions
- git clone --depth=1
https://github.com/actions-cool/maintain-one-comment.git
-
- echo "GH_SHA_SHORT=$(echo ${{ github.event.pull_request.head.sha }}
| cut -c 1-7)" >> $GITHUB_ENV
-
- - name: Create comment for PR preview
-uses: ./.actions/maintain-one-comment
-with:
- body: |
-
-The changes brought by this PR can be previewed at:
https://echarts.apache.org/examples/editor?version=PR-${{ github.event.number
}}@${{ env.GH_SHA_SHORT }}
- body-include: ''
- number: ${{ github.event.number }}
-
- teardown-preview:
-runs-on: ubuntu-latest
-if: ${{ github.repository_owner == 'apache' && github.event.action ==
'closed' && github.event.pull_request.merged != true }}
-continue-on-error: true
-steps:
- - name: Install action dependencies
-run: git clone --depth=1
https://github.com/actions-cool/maintain-one-comment.git
+ cd $PR_PREVIEW_DIR
+ echo $PR_NUMBER > ./pr_number
+ echo $PR_COMMIT_SHA > ./pr_commit_sha
+ find . -type f -regex ".*\.tgz" -exec tar xvzf {} \;
+ echo -e "Dist files: \n$(ls -l)"
- - name: Delete PR preview comment
-uses: ./maintain-one-comment
+ - uses: actions/upload-artifact@v3
with:
- body-include: ''
- delete: true
- number: ${{ github.event.number }}
-
- - name: Teardown closed PR preview
-run: |
- export SURGE_DOMAIN='https://echarts-pr-${{ github.event.number
}}.surge.sh'
- npx surge teardown $SURGE_DOMAIN --token ${{ secrets.SURGE_TOKEN }}
+ name: pr_preview
+ path: ${{ env.PR_PREVIEW_DIR }}
+ retention-days: 1
+ if-no-files-found: error
diff --git a/.github/workflows/pr-preview.ym
[GitHub] [echarts] lzpone7 commented on issue #17414: [Bug] radar.axisName.width Setting is invalid
lzpone7 commented on issue #17414: URL: https://github.com/apache/echarts/issues/17414#issuecomment-1612639621 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zxhycxq commented on issue #18063: [Bug] yAxis设置alignTicks: true,很可能出现数值精度问题
zxhycxq commented on issue #18063: URL: https://github.com/apache/echarts/issues/18063#issuecomment-1612528329 我也遇到这个问题了，不知道题主最后怎么解决了? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Dylanb-dev closed issue #18662: [Bug] Chart color is incorrect (darkened)
Dylanb-dev closed issue #18662: [Bug] Chart color is incorrect (darkened) URL: https://github.com/apache/echarts/issues/18662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Dylanb-dev commented on issue #18662: [Bug] Chart color is incorrect (darkened)
Dylanb-dev commented on issue #18662: URL: https://github.com/apache/echarts/issues/18662#issuecomment-1612527834 Recently I checked this and think the colors are correct, maybe my color tooling was bad before so I will close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
