[GitHub] [echarts] cvSoldier commented on pull request #18379: fix(lines): Lines series symbolSize cannot be updated. close #18350
cvSoldier commented on PR #18379: URL: https://github.com/apache/echarts/pull/18379#issuecomment-1487986305 Hi @Ovilia. Since all checks have passed, may I ask if it's ready for merging now？ (kind of exciting for becoming a contributor) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cvSoldier commented on pull request #18379: fix(lines): Lines series symbolSize cannot be updated. close #18350
cvSoldier commented on PR #18379: URL: https://github.com/apache/echarts/pull/18379#issuecomment-1482200819 found that ci failed again,:worried: but I didn't understand the reason. Do I need to commit any changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] cvSoldier commented on pull request #18379: fix(lines): Lines series symbolSize cannot be updated. close #18350
cvSoldier commented on PR #18379: URL: https://github.com/apache/echarts/pull/18379#issuecomment-1477748976 Test case was added, but I'm a bit confused, in [Run test cases](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#run-test-cases) it is written that just need Run the related tests of the modified view, but after running all the test cases, I found that some of them reported errors:  After debug , they did not involve the code I modified, so it is a bit strange whether this is my problem？ And another question, is there no document showing how to add action in the test case, because I didn't find the relevant content, it took me a lot of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
