[GitHub] [echarts] pissang edited a comment on pull request #16760: fix: issue#16749 colorAlpha check
pissang edited a comment on pull request #16760: URL: https://github.com/apache/echarts/pull/16760#issuecomment-1081512450 @jiawulin001 Sure, we can deprecate it progressively. For example, we can remove it in the doc at first. Then using `warning` method to tell developers not to use it anymore. Finally we can remove it in the major versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16760: fix: issue#16749 colorAlpha check
pissang edited a comment on pull request #16760: URL: https://github.com/apache/echarts/pull/16760#issuecomment-1081366779 It will bring `colorAlpha`(and `colorSaturation`) to `itemStyle` of all series. I think we need further discussion if it's necessary. First of all these two only do modification on the `color` property. It's a work that can be easily done by developers by changing the alpha value in `rgba` / 'hsl' string or using `echarts.color.modifyAlpha` and `echarts.color.modifyHSL` utility methods. I can't think of other benefits, or I may have missed something here, remind me if so. We tend to be very conservative in adding this kind of features. If we do so, we need to do more work to keep the consistent. For example, `areaStyle` and `lineStyle` should also provide this ability. And what about `borderColor`, or even `textStyle.color`, `shadowColor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16760: fix: issue#16749 colorAlpha check
pissang edited a comment on pull request #16760: URL: https://github.com/apache/echarts/pull/16760#issuecomment-1081366779 It will bring `colorAlpha`(and `colorSaturation`) to `itemStyle` of all series. I think we need further discussion if it's necessary. First of all these two only do modification on the `color` property. It's a work that can be easily done by developers by changing the alpha value in `rgba` / 'hsl' string or using `echarts.color.modifyAlpha` and `echarts.color.modifyHSL` utility methods. I can't think of other benefits, or I may missing something here, remind me if so. We tend to be very conservative in adding this kind of features. If we do so, we need to do more work to keep the consistent. For example, `areaStyle` and `lineStyle` should also provide this ability. And what about `borderColor`, or even `textStyle.color`, `shadowColor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16760: fix: issue#16749 colorAlpha check
pissang edited a comment on pull request #16760: URL: https://github.com/apache/echarts/pull/16760#issuecomment-1081366779 It will bring `colorAlpha`(and `colorSaturation`) to `itemStyle` of all series. I think we need further discussion if it's necessary. First of all these two only do modification on the `color` property. It's a work that can be easily done by developers by changing the alpha value in `rgba` / 'hsl' string or using `echarts.color.modifyAlpha` and `echarts.color.modifyHSL` utility methods. I can't think of other benefits. Or I may missing something here, remind me if so. We tend to be very conservative in adding this kind of features. If we do so, we need to do more work to keep the consistent. For example, `areaStyle` and `lineStyle` should also provide this ability. And what about `borderColor`, or even `textStyle.color`, `shadowColor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
