Re: [PR] fix(labelLine):emphasis.labelLine not work in pie chart [echarts]
Ovilia merged PR #19180: URL: https://github.com/apache/echarts/pull/19180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(labelLine):emphasis.labelLine not work in pie chart [echarts]
echarts-bot[bot] commented on PR #19180: URL: https://github.com/apache/echarts/pull/19180#issuecomment-1772248343 Congratulations! Your PR has been merged. Thanks for your contribution! 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(labelLine):emphasis.labelLine not work in pie chart [echarts]
shiersansi commented on PR #19180: URL: https://github.com/apache/echarts/pull/19180#issuecomment-1761013494 > Please fix the lint problems and [this demo](https://echarts.apache.org/examples/zh/editor.html?version=PR-19180%40c984f16&code=PYBwLglsB2AEC8sDeAoWsA2BTA5l6AJgFzJrqzABOE-YJA5AG5aWQDGAhhvQDRnrYAZnVj0hYXv1gEOYDiQDa9AIIgQ2XqIDilDiCwBnTfQAKEaFj3rDxgPK7oeIz1EAhDtA8cjAXTIBfPnQDFhoDRSlUcnIwAE99BhAaSWj0LABbEAALbwhw0lTyDA4AIywMEijC8gMs4AB3EkEuEKlowLai0vKAGXMsSs7o2oaSMEoAVywh2H9OjsLisow-i0Hq2BHG2GaMVsKF1Jk5CI2qjcYuKZIAZhuAViCN2E90gdFVa3oZw8Lz6suGGusBuAEYAAxPDavd70HR6Gw_KGpf6FQHAgBMNwALMjCjCGGYLFZsEYkTNUal0e9QQ88akCaJ7B4nN8Nr8UTN0NSSKD7tiABz06KM-juTyeMnszp-dpkPz-ADcQA) also fails. In this section of the code comment, it is mentioned that if label is false, labelLine will not be displayed. So, should we modify it to mean that lableLine will not be affected no matter what the label is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(labelLine):emphasis.labelLine not work in pie chart [echarts]
github-actions[bot] commented on PR #19180: URL: https://github.com/apache/echarts/pull/19180#issuecomment-1760996203 The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19180@c984f16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(labelLine):emphasis.labelLine not work in pie chart [echarts]
Ovilia commented on PR #19180: URL: https://github.com/apache/echarts/pull/19180#issuecomment-1752570100 Please fix the failed test case in the CI and run [visual tests](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#run-test-cases) of all cases to make sure it doesn't break any changes. Please also note that #18800 was also trying to fix the same problem. The first PR that finds the correct solution will be merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(labelLine):emphasis.labelLine not work in pie chart [echarts]
echarts-bot[bot] commented on PR #19180: URL: https://github.com/apache/echarts/pull/19180#issuecomment-1752531106 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
