[GitHub] [fineract] vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
vorburger commented on a change in pull request #629: Swagger documentation
gsoc2019
URL: https://github.com/apache/fineract/pull/629#discussion_r368295849
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/self/shareaccounts/api/SelfShareAccountsApiResource.java
##
@@ -139,7 +152,11 @@ public String createAccount(final String
apiRequestBodyAsJson) {
@Path("{accountId}")
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveShareAccount(@PathParam("accountId") final Long
accountId, @Context final UriInfo uriInfo) {
+ /*
+@ApiOperation(value = "Retrieve a share application/account", httpMethod =
"GET", notes = "\n" +
+"\n" + "\n" + "Example Requests:\n" + "\n" +
"self/shareaccounts/12\n")
+@ApiResponses({@ApiResponse(code = 200, message = "OK", responseContainer
= "List", response
SelfShareAccountsApiResourceSwagger.GetShareAccountResponse.class)})*/
Review comment:
@Sanyam96 FYI I've fixed this one in my swagger-squash branch which I'll
merge ASAP as much as possible. @kangbreder the problem is that
SelfShareAccountsApiResourceSwagger.GetShareAccountResponse seems to be
missing- would you like to raise a small new PR just adding that and fixing
this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
vorburger commented on a change in pull request #629: Swagger documentation
gsoc2019
URL: https://github.com/apache/fineract/pull/629#discussion_r366189471
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/floatingrates/api/FloatingRatesApiResource.java
##
@@ -45,7 +45,11 @@
@Path("/floatingrates")
@Component
@Scope("singleton")
-@Api(value = "Floating Rates", description = "It lets you create, list,
retrieve and upload the floating rates")
+@Api(tags = {"Floating Rates"})
+@SwaggerDefinition(tags = {
+ @Tag(name = "Floating Rates", description = "It lets you
create, list, retrieve and upload the floating rates")
Review comment:
@Sanyam96 I would not worry too much about this kind of thing (whitespace
and indent), we're about to have a general solution for this, please watch
[FINERACT-821](https://issues.apache.org/jira/browse/FINERACT-821). (Help from
you on that one would be very welcome BTW!)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
vorburger commented on a change in pull request #629: Swagger documentation gsoc2019 URL: https://github.com/apache/fineract/pull/629#discussion_r366188664 ## File path: fineract-provider/build.gradle ## @@ -59,6 +60,8 @@ apply plugin: 'eclipse' apply plugin: 'idea' apply plugin: 'com.bmuschko.tomcat' apply plugin: 'project-report' +apply plugin: 'java' Review comment: @kangbreder do you happen to remember why you had to add `apply plugin: 'java'` here? Does it work without it as well? I guess it's a bit strange to have a project use BOTH `apply plugin: 'java-library'` AND `apply plugin: 'java'` - it's either or the other. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
