[1/2] git commit: [flex-sdk] [refs/heads/new_android_skins] - Fixed bug in current CalloutArrow
Repository: flex-sdk
Updated Branches:
refs/heads/new_android_skins 81da04b06 - 5c1f4904b
Fixed bug in current CalloutArrow
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/19312c51
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/19312c51
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/19312c51
Branch: refs/heads/new_android_skins
Commit: 19312c512c20da2a2ad6ae4c2c2f5aee3b3d3b02
Parents: 81da04b
Author: Om bigosma...@gmail.com
Authored: Fri May 2 15:27:09 2014 -0700
Committer: Om bigosma...@gmail.com
Committed: Fri May 2 15:27:09 2014 -0700
--
frameworks/projects/mobiletheme/android4x.css| 11 +++
.../spark/skins/mobile/supportClasses/CalloutArrow.as| 2 +-
2 files changed, 12 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/19312c51/frameworks/projects/mobiletheme/android4x.css
--
diff --git a/frameworks/projects/mobiletheme/android4x.css
b/frameworks/projects/mobiletheme/android4x.css
index 790a655..1c5bb4d 100644
--- a/frameworks/projects/mobiletheme/android4x.css
+++ b/frameworks/projects/mobiletheme/android4x.css
@@ -41,6 +41,7 @@ application-dpi=240.
global
{
+ primaryAccentColor: #33B5E5;
fontFamily: RobotoRegular;
fontWeight: normal;
fontSize: 24;
@@ -100,6 +101,16 @@ ButtonBar
fontWeight: bold;
}
+Callout
+{
+backgroundColor: #484848;
+contentBackgroundColor: #FF;
+gap: 12;
+skinClass: ClassReference(spark.skins.android4.CalloutSkin);
+borderThickness: 0;
+borderColor: 0;
+}
+
CheckBox
{
skinClass: ClassReference(spark.skins.android4.CheckBoxSkin);
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/19312c51/frameworks/projects/mobiletheme/src/spark/skins/mobile/supportClasses/CalloutArrow.as
--
diff --git
a/frameworks/projects/mobiletheme/src/spark/skins/mobile/supportClasses/CalloutArrow.as
b/frameworks/projects/mobiletheme/src/spark/skins/mobile/supportClasses/CalloutArrow.as
index ea4bcf0..34f896b 100644
---
a/frameworks/projects/mobiletheme/src/spark/skins/mobile/supportClasses/CalloutArrow.as
+++
b/frameworks/projects/mobiletheme/src/spark/skins/mobile/supportClasses/CalloutArrow.as
@@ -61,7 +61,7 @@ public class CalloutArrow extends UIComponent
// Copy DPI-specific values from CalloutSkin
switch (applicationDPI)
{
- case DPIClassification.DPI_320:
+ case DPIClassification.DPI_640:
{
// Note provisional may need changes
gap = 32;
flex-sdk_mustella - Build # 925 - Still Failing!
flex-sdk_mustella - Build # 925 - Still Failing: http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/925/ Changes for Build #918 [labriola] Fix for issue FLEX-34320 Changes for Build #919 Changes for Build #920 Changes for Build #921 [jmclean] FLEX-369 stop text flowing outside of Alert box [jmclean] updated documentation [darrell.loverin] Fix for FLEX-34323. [jmclean] FLEX-34222 fix selection reverting to previous typed values when second value (not in list) is entered [jmclean] FLEX-34193 fixed selectedColor to actually contain the selected colour [jmclean] FLEX-34078 fix callouts closing when selecting dates in DateFields Changes for Build #923 [nk] Now XMLListCollection behaves closer to be expected -- does not update parent from updated XMLList. I guess it should be debated wether it should... [darrell.loverin] Revert Fix for FLEX-34323. [nk] Update to XMLListCollection. Added docs to XMLListAdapter to better represent what is happening. Changes for Build #924 Changes for Build #925 [...truncated 11548 lines...] [java] Choosing local runner bitmap save [java] okey doke, going to compile C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml [java] Loading configuration file C:\jenkins_slave\workspace\flex-sdk_mustella\frameworks\flex-config.xml [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Label\SWFs\Label_basic3.swf (1935029 bytes) [java] Choosing local runner bitmap save [java] okey doke, going to compile C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\spark\effects\interpolation\RGBInterpolator\SWFs\../SWFs/RGBInterpolator_main.mxml [java] Loading configuration file C:\jenkins_slave\workspace\flex-sdk_mustella\frameworks\flex-config.xml [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(182): Warning: The CSS type selector 'mx.containers.Accordion' was not processed, because the type was not used in the application. [java] [java] mx|Accordion, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(183): Warning: The CSS type selector 'mx.controls.RadioButton' was not processed, because the type was not used in the application. [java] [java] mx|RadioButton, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(184): Warning: The CSS type selector 'mx.controls.CheckBox' was not processed, because the type was not used in the application. [java] [java] mx|CheckBox, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(185): Warning: The CSS type selector 'mx.controls.List' was not processed, because the type was not used in the application. [java] [java] mx|List, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(186): Warning: The CSS type selector 'mx.controls.DataGrid' was not processed, because the type was not used in the application. [java] [java] mx|DataGrid, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(187): Warning: The CSS type selector 'mx.controls.Button' was not processed, because the type was not used in the application. [java] [java] mx|Button, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(188): Warning: The CSS type selector 'mx.controls.Text' was not processed, because the type was not used in the application. [java] [java] mx|Text, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(189): Warning: The CSS type selector 'mx.controls.TextInput' was not processed, because the type was not used in the application. [java] [java] mx|TextInput, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(191): Warning: The CSS type selector 'mx.controls.NumericStepper' was not processed, because the type was not used in the application. [java] [java] mx|NumericStepper, [java] [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\TitleWindow\SWFs\TitleWindow_basic4.mxml(192): Warning: The CSS type selector
[2/3] git commit: [flex-tlf] [refs/heads/FlexUnit4TestsTLF] - Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-tlf into FlexUnit4TestsTLF
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-tlf into FlexUnit4TestsTLF Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/98bebb26 Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/98bebb26 Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/98bebb26 Branch: refs/heads/FlexUnit4TestsTLF Commit: 98bebb2697ffd85b1ebdbea757c0cfa356f74585 Parents: cad064e 592b45f Author: piotrz piotrzarzyck...@gmail.com Authored: Thu May 22 08:16:57 2014 +0200 Committer: piotrz piotrzarzyck...@gmail.com Committed: Thu May 22 08:16:57 2014 +0200 -- .../src/flashx/textLayout/compose/BaseCompose.as | 7 --- .../src/flashx/textLayout/compose/ComposeState.as| 15 +-- .../textLayout/container/ContainerController.as | 1 + 3 files changed, 14 insertions(+), 9 deletions(-) --
[1/3] git commit: [flex-tlf] [refs/heads/FlexUnit4TestsTLF] - FLEX-34247 improve TLF performance. I added a flag in case some scenario really needs composition to start from the beginning, but the def
Repository: flex-tlf Updated Branches: refs/heads/FlexUnit4TestsTLF cad064e08 - 2b0067b7d FLEX-34247 improve TLF performance. I added a flag in case some scenario really needs composition to start from the beginning, but the default is now more like the TLF version that shipped with Adobe Flex 4.6 Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/592b45fa Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/592b45fa Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/592b45fa Branch: refs/heads/FlexUnit4TestsTLF Commit: 592b45fa219af46592f30ad712b739ac606ed296 Parents: 41fc042 Author: Alex Harui aha...@apache.org Authored: Wed May 21 20:52:45 2014 -0700 Committer: Alex Harui aha...@apache.org Committed: Wed May 21 20:52:45 2014 -0700 -- .../src/flashx/textLayout/compose/BaseCompose.as | 7 --- .../src/flashx/textLayout/compose/ComposeState.as| 15 +-- .../textLayout/container/ContainerController.as | 1 + 3 files changed, 14 insertions(+), 9 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/592b45fa/textLayout/src/flashx/textLayout/compose/BaseCompose.as -- diff --git a/textLayout/src/flashx/textLayout/compose/BaseCompose.as b/textLayout/src/flashx/textLayout/compose/BaseCompose.as index 2ad0506..b7c4b02 100644 --- a/textLayout/src/flashx/textLayout/compose/BaseCompose.as +++ b/textLayout/src/flashx/textLayout/compose/BaseCompose.as @@ -30,6 +30,7 @@ package flashx.textLayout.compose import flash.text.engine.TextLineValidity; import flash.utils.Dictionary; + import flashx.textLayout.tlf_internal; import flashx.textLayout.container.ContainerController; import flashx.textLayout.debug.Debugging; import flashx.textLayout.debug.assert; @@ -69,7 +70,6 @@ package flashx.textLayout.compose import flashx.textLayout.formats.TextLayoutFormat; import flashx.textLayout.formats.VerticalAlign; import flashx.textLayout.property.Property; - import flashx.textLayout.tlf_internal; import flashx.textLayout.utils.LocaleUtil; import flashx.textLayout.utils.Twips; @@ -892,8 +892,9 @@ package flashx.textLayout.compose resetControllerBounds(); - // Bug, needs to remove - _startComposePosition = _startController.absoluteStart; + // Bug, needs to remove + if (ContainerController.tlf_internal::startComposeFromBeginning) + _startComposePosition = _startController.absoluteStart; // This is where we will start composing from _curElement = _textFlow.findLeaf(_startComposePosition); http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/592b45fa/textLayout/src/flashx/textLayout/compose/ComposeState.as -- diff --git a/textLayout/src/flashx/textLayout/compose/ComposeState.as b/textLayout/src/flashx/textLayout/compose/ComposeState.as index ce7bddc..d40dc2b 100644 --- a/textLayout/src/flashx/textLayout/compose/ComposeState.as +++ b/textLayout/src/flashx/textLayout/compose/ComposeState.as @@ -27,6 +27,7 @@ package flashx.textLayout.compose import flash.text.engine.TextLineCreationResult; import flash.text.engine.TextLineValidity; + import flashx.textLayout.tlf_internal; import flashx.textLayout.container.ContainerController; import flashx.textLayout.debug.Debugging; import flashx.textLayout.debug.assert; @@ -46,7 +47,6 @@ package flashx.textLayout.compose import flashx.textLayout.formats.ListStylePosition; import flashx.textLayout.formats.TextAlign; import flashx.textLayout.formats.VerticalAlign; - import flashx.textLayout.tlf_internal; import flashx.textLayout.utils.Twips; use namespace tlf_internal; @@ -340,11 +340,14 @@ package flashx.textLayout.compose var line:TextFlowLine = _curLineIndex _flowComposer.numLines ? (_flowComposer as StandardFlowComposer).lines[_curLineIndex] : null; var useExistingLine:Boolean = line (!line.isDamaged() || line.validity == FlowDamageType.GEOMETRY); - // if the line ends with a hyphen, don't use existing line because the player seems to mis-handle - // starting the next line. - if (useExistingLine line.textLength 0 -
[3/3] git commit: [flex-tlf] [refs/heads/FlexUnit4TestsTLF] - Migrate AllCharAttributeTest to Flex Unit 4
Migrate AllCharAttributeTest to Flex Unit 4
Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/2b0067b7
Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/2b0067b7
Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/2b0067b7
Branch: refs/heads/FlexUnit4TestsTLF
Commit: 2b0067b7de49ec926def1d65711c95917d2dc89e
Parents: 98bebb2
Author: piotrz piotrzarzyck...@gmail.com
Authored: Mon May 26 23:15:38 2014 +0200
Committer: piotrz piotrzarzyck...@gmail.com
Committed: Mon May 26 23:15:38 2014 +0200
--
automation_tests/src/AllTestsSuite.as | 3 +
automation_tests/src/AutomationTestClasses.as | 2 +-
.../src/UnitTest/Tests/AllAttributeTest.as | 691 +++
.../src/UnitTest/Tests/AllCharAttributeTest.as | 136 ++--
4 files changed, 435 insertions(+), 397 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/2b0067b7/automation_tests/src/AllTestsSuite.as
--
diff --git a/automation_tests/src/AllTestsSuite.as
b/automation_tests/src/AllTestsSuite.as
index ab31501..2134fcd 100644
--- a/automation_tests/src/AllTestsSuite.as
+++ b/automation_tests/src/AllTestsSuite.as
@@ -20,6 +20,7 @@ package
{
import UnitTest.Tests.AccessibilityMethodsTest;
+import UnitTest.Tests.AllCharAttributeTest;
import UnitTest.Tests.AllEventTest;
import UnitTest.Tests.AttributeTest;
import UnitTest.Tests.BoxTest;
@@ -40,6 +41,8 @@ package
public var floatTest:FloatTest;
public var operationTest:OperationTest;
public var scrollingTest:ScrollingTest;
+public var allAttributeTest:AllCharAttributeTest;
+ // public var allParagraphTest:AllParaAttributeTest;
}
}
http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/2b0067b7/automation_tests/src/AutomationTestClasses.as
--
diff --git a/automation_tests/src/AutomationTestClasses.as
b/automation_tests/src/AutomationTestClasses.as
index db74742..3079ccf 100644
--- a/automation_tests/src/AutomationTestClasses.as
+++ b/automation_tests/src/AutomationTestClasses.as
@@ -35,7 +35,7 @@ package
*/
import AllTestsSuite; AllTestsSuite;
import MinimalTestsSuite; MinimalTestsSuite;
-import UnitTest.Tests.AccessibilityMethodsTest;
AccessibilityMethodsTest;
+ // import UnitTest.Tests.AccessibilityMethodsTest;
AccessibilityMethodsTest;
/*import UnitTest.Tests.AllAttributeTest; AllAttributeTest;
import UnitTest.Tests.AllCharAttributeTest;
AllCharAttributeTest;
import UnitTest.Tests.AllContAttributeTest;
AllContAttributeTest;
http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/2b0067b7/automation_tests/src/UnitTest/Tests/AllAttributeTest.as
--
diff --git a/automation_tests/src/UnitTest/Tests/AllAttributeTest.as
b/automation_tests/src/UnitTest/Tests/AllAttributeTest.as
index 44bca88..4402025 100644
--- a/automation_tests/src/UnitTest/Tests/AllAttributeTest.as
+++ b/automation_tests/src/UnitTest/Tests/AllAttributeTest.as
@@ -18,310 +18,397 @@
package UnitTest.Tests
{
- import UnitTest.ExtendedClasses.TestDescriptor;
- import UnitTest.ExtendedClasses.TestSuiteExtended;
- import UnitTest.ExtendedClasses.VellumTestCase;
- import UnitTest.Fixtures.TestConfig;
-
- import flash.display.Sprite;
-
- import flashx.textLayout.debug.assert;
- import flashx.textLayout.formats.Category;
- import flashx.textLayout.formats.FormatValue;
- import flashx.textLayout.formats.TextLayoutFormat;
- import flashx.textLayout.property.*;
+import UnitTest.ExtendedClasses.VellumTestCase;
+import UnitTest.Fixtures.TestConfig;
+
+import flash.display.Sprite;
+
+import flashx.textLayout.elements.FlowLeafElement;
+import flashx.textLayout.elements.TextFlow;
+import flashx.textLayout.formats.Category;
+import flashx.textLayout.formats.FormatValue;
+import flashx.textLayout.formats.TextLayoutFormat;
+import flashx.textLayout.property.*;
import org.flexunit.asserts.assertTrue;
/** Base class for All*AttributeTest */
- public class AllAttributeTest extends VellumTestCase
- {
- // test specific configuration
- protected var testProp:Property;
- protected var testValue:*;
- protected var expectedValue:*;
-
- public function AllAttributeTest(methodName:String,
flex-sdk_mustella - Build # 926 - Still Failing!
flex-sdk_mustella - Build # 926 - Still Failing: http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/926/ Changes for Build #918 [labriola] Fix for issue FLEX-34320 Changes for Build #919 Changes for Build #920 Changes for Build #921 [jmclean] FLEX-369 stop text flowing outside of Alert box [jmclean] updated documentation [darrell.loverin] Fix for FLEX-34323. [jmclean] FLEX-34222 fix selection reverting to previous typed values when second value (not in list) is entered [jmclean] FLEX-34193 fixed selectedColor to actually contain the selected colour [jmclean] FLEX-34078 fix callouts closing when selecting dates in DateFields Changes for Build #923 [nk] Now XMLListCollection behaves closer to be expected -- does not update parent from updated XMLList. I guess it should be debated wether it should... [darrell.loverin] Revert Fix for FLEX-34323. [nk] Update to XMLListCollection. Added docs to XMLListAdapter to better represent what is happening. Changes for Build #924 Changes for Build #925 Changes for Build #926 [jmclean] FLEX-369 new baselines so test pass [jmclean] FLEX-369 take gadding into account and always display at least one line of text even if it overlaps the buttons [...truncated 83011 lines...] [java] unpacked result: gumbo/core/DataGroup/events/DataGroup_Events_itemIndex DataGroup_events_itemIndex_move Failed Timed out 0 Mon May 26 18:00:48 ACT 2014 0.0 [java] Total Results so far: 45 [java] Grab log, do parse = false [java] Grabbing the log from: C:\Users\ApacheFlex\AppData/Roaming\Macromedia/Flash Player/Logs/flashlog.txt to: C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\core\DataGroup\swfs\DataGroupBasic.log [java] Grablog: never saw the ScriptDone for C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\core\DataGroup\swfs\DataGroupBasic.swf [java] new test file: C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs\ShaderFilterApp3_Components.swf [java] cmdArr before: [java] C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer13_0r0_214_win_sa_debug.exe [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs\ShaderFilterApp3_Components.swf [java] moreParameters before: [java] cmdArr after: [java] C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer13_0r0_214_win_sa_debug.exe [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs\ShaderFilterApp3_Components.swf [java] getting directory from the swf file [java] derived directory: C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs [java] Launching: [java] C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer13_0r0_214_win_sa_debug.exe C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs\ShaderFilterApp3_Components.swf Launching: C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer13_0r0_214_win_sa_debug.exe C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs\ShaderFilterApp3_Components.swf [java] USING directory: C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs [java] time: 18:01:48.322 [java] Wrote file: c:/jenkins_slave/workspace/flex-sdk_mustella/mustella/tests/gumbo/filters/ShaderFilter/SWFs/../Integration/Baselines/integration_popup_test2.png.bad.png length: 1446 [java] FAIL: gumbo/filters/ShaderFilter/Integration/ShaderFilter_integration integration_popup_test2 [java] SCRIPTDONE! 18:01:52.518 [java] GET /ScriptComplete?0 HTTP/1.1 [java] Before Wait loop 18:01:52.518 waiting = 0 [java] After Wait loop 18:01:52.518 waiting = 0 [java] clobberProcess false [java] Total Results so far: 46 [java] Grab log, do parse = false [java] Grabbing the log from: C:\Users\ApacheFlex\AppData/Roaming\Macromedia/Flash Player/Logs/flashlog.txt to: C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\filters\ShaderFilter\SWFs\ShaderFilterApp3_Components.log [java] new test file: C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\itemRenderers\Halo\List\SWFs\List_itemEditorTests.swf [java] cmdArr before: [java] C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer13_0r0_214_win_sa_debug.exe [java] C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\itemRenderers\Halo\List\SWFs\List_itemEditorTests.swf [java] moreParameters before: [java] cmdArr after: [java] C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer13_0r0_214_win_sa_debug.exe [java]
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix callouts closing when selecting dates in DateFields
This change broke Falcon, although Falcon is not reporting the failure correctly. And I'm sort of surprised it didn't break the SDK build because it introduces a dependency from spark.swc to mx.swc and mx.swc is not listed in the set of libraries used to build experimental.swc. It is also not a good idea to start dragging mx stuff into spark-only apps. Might affect mobile app sizes and might affect those with spark-only build setups. I'm not familiar with Callout, but in other components with drop downs, the drop down's owner property is set to the base component, then you check to see if the component owns the clicked item. Can similar logic be used here and eliminate the mx.swc dependency? Thanks, -Alex On 5/18/14 12:30 PM, jmcl...@apache.org jmcl...@apache.org wrote: Repository: flex-sdk Updated Branches: refs/heads/develop 3a087a60e - 080f5e64d FLEX-34078 fix callouts closing when selecting dates in DateFields Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/080f5e64 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/080f5e64 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/080f5e64 Branch: refs/heads/develop Commit: 080f5e64d5718d76c51ecf6b07552b8bfc1b112e Parents: 3a087a6 Author: Justin Mclean jmcl...@apache.org Authored: Sun May 18 12:30:41 2014 -0700 Committer: Justin Mclean jmcl...@apache.org Committed: Sun May 18 12:30:41 2014 -0700 -- .../src/spark/components/supportClasses/DropDownController.as | 3 +++ 1 file changed, 3 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/080f5e64/frameworks/p rojects/spark/src/spark/components/supportClasses/DropDownController.as -- diff --git a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownCo ntroller.as b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownCo ntroller.as index e1ff2fd..364 100644 --- a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownCo ntroller.as +++ b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownCo ntroller.as @@ -38,6 +38,7 @@ import mx.managers.ISystemManager; import spark.components.DropDownList; import spark.events.DropDownEvent; +import mx.controls.CalendarLayout; use namespace mx_internal; @@ -613,6 +614,8 @@ public class DropDownController extends EventDispatcher var document:Object = (target as IUIComponent).document; if ((hostComponent in document) document.hostComponent is DropDownList) return; + if (target.parent is CalendarLayout) + return; } if (hitAreaAdditions != null)
