git commit: [flex-asjs] [refs/heads/develop] - Added debug runtime checking for ArrayBuffer initializer

2017-07-11 Thread harbs 
Repository: flex-asjs
Updated Branches:
  refs/heads/develop 5031bfa4c -> efd4372d4


Added debug runtime checking for ArrayBuffer initializer


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/efd4372d
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/efd4372d
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/efd4372d

Branch: refs/heads/develop
Commit: efd4372d4e9e3cae6e10346a3310abd447612526
Parents: 5031bfa
Author: Harbs 
Authored: Wed Jul 12 09:56:35 2017 +0300
Committer: Harbs 
Committed: Wed Jul 12 09:56:35 2017 +0300

--
 .../Core/src/main/flex/org/apache/flex/utils/BinaryData.as  | 9 +
 1 file changed, 9 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/efd4372d/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
--
diff --git 
a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as 
b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
index 4516f85..6d3a4d9 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
@@ -23,6 +23,10 @@ COMPILE::SWF
 {
 import flash.utils.ByteArray;
 }
+COMPILE::JS
+{
+import goog.DEBUG;
+}
 
 
 /**
@@ -58,6 +62,11 @@ public class BinaryData implements IBinaryDataInput, 
IBinaryDataOutput
 COMPILE::JS
 public function BinaryData(bytes:Object = null)
 {
+if(goog.DEBUG)
+{
+if(bytes && typeof bytes.byteLength != "number")
+throw new TypeError("BinaryData can only be initialized with 
ArrayBuffer");
+}
 ba = bytes ? bytes as ArrayBuffer : new ArrayBuffer(0);
 _len = ba.byteLength;
 }

git commit: [flex-asjs] [refs/heads/feature/mouseenter] - Added debug runtime checking for ArrayBuffer initializer

2017-07-11 Thread harbs 
Repository: flex-asjs
Updated Branches:
  refs/heads/feature/mouseenter 173858c7d -> d299b76af


Added debug runtime checking for ArrayBuffer initializer


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/d299b76a
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/d299b76a
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/d299b76a

Branch: refs/heads/feature/mouseenter
Commit: d299b76afb49b563447f3d2a38122eca280d1832
Parents: 173858c
Author: Harbs 
Authored: Wed Jul 12 09:51:34 2017 +0300
Committer: Harbs 
Committed: Wed Jul 12 09:51:34 2017 +0300

--
 .../Core/src/main/flex/org/apache/flex/utils/BinaryData.as  | 9 +
 1 file changed, 9 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/d299b76a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
--
diff --git 
a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as 
b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
index 4516f85..6d3a4d9 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/BinaryData.as
@@ -23,6 +23,10 @@ COMPILE::SWF
 {
 import flash.utils.ByteArray;
 }
+COMPILE::JS
+{
+import goog.DEBUG;
+}
 
 
 /**
@@ -58,6 +62,11 @@ public class BinaryData implements IBinaryDataInput, 
IBinaryDataOutput
 COMPILE::JS
 public function BinaryData(bytes:Object = null)
 {
+if(goog.DEBUG)
+{
+if(bytes && typeof bytes.byteLength != "number")
+throw new TypeError("BinaryData can only be initialized with 
ArrayBuffer");
+}
 ba = bytes ? bytes as ArrayBuffer : new ArrayBuffer(0);
 _len = ba.byteLength;
 }

[2/2] git commit: [flex-asjs] [refs/heads/develop] - Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop

2017-07-11 Thread gregdove 
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs 
into develop


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/5031bfa4
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/5031bfa4
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/5031bfa4

Branch: refs/heads/develop
Commit: 5031bfa4c9b49b1cbb45c9fc6ae3d4367e4bf8da
Parents: 0ef43fa 46a07ec
Author: greg-dove 
Authored: Wed Jul 12 11:27:47 2017 +1200
Committer: greg-dove 
Committed: Wed Jul 12 11:27:47 2017 +1200

--
 .../apache/flex/html/accessories/ToolTipBead.as |  53 +
 .../flex/html/beads/AccessibilityAltBead.as | 114 +++
 .../supportClasses/AccordionItemRenderer.as |   1 -
 .../Basic/src/main/resources/basic-manifest.xml |   1 +
 .../main/flex/org/apache/flex/file/FileProxy.as |   9 ++
 .../org/apache/flex/file/beads/FileBrowser.as   |  26 ++---
 .../flex/file/beads/FileBrowserWithFilter.as|  63 ++
 .../org/apache/flex/file/beads/FileLoader.as|   2 +-
 .../flex/file/beads/FileLoaderAndUploader.as|  28 +++--
 .../org/apache/flex/file/beads/FileModel.as |   2 +-
 .../org/apache/flex/file/beads/FileUploader.as  |   2 +
 .../src/main/resources/basic-manifest.xml   |   1 +
 12 files changed, 254 insertions(+), 48 deletions(-)
--

[1/2] git commit: [flex-asjs] [refs/heads/develop] - Additional fixes for missing js build scope Event imports, as per discussion on list.

2017-07-11 Thread gregdove 
Repository: flex-asjs
Updated Branches:
  refs/heads/develop 46a07ec95 -> 5031bfa4c


Additional fixes for missing js build scope Event imports, as per discussion on 
list.


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0ef43fa0
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0ef43fa0
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0ef43fa0

Branch: refs/heads/develop
Commit: 0ef43fa0fad6ae4902cef2c2d681299eb9b43b88
Parents: 54d00a0
Author: greg-dove 
Authored: Wed Jul 12 11:27:34 2017 +1200
Committer: greg-dove 
Committed: Wed Jul 12 11:27:34 2017 +1200

--
 .../Basic/src/main/flex/org/apache/flex/core/ApplicationBase.as| 1 +
 .../org/apache/flex/html/beads/layouts/HorizontalFlexLayout.as | 2 +-
 .../flex/org/apache/flex/html/beads/layouts/VerticalFlexLayout.as  | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/0ef43fa0/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ApplicationBase.as
--
diff --git 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ApplicationBase.as
 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ApplicationBase.as
index a3ca917..7d5ffd7 100644
--- 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ApplicationBase.as
+++ 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ApplicationBase.as
@@ -26,6 +26,7 @@ package org.apache.flex.core
 COMPILE::JS
 {
 import org.apache.flex.utils.CSSUtils;
+import org.apache.flex.events.Event;
 }
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/0ef43fa0/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/HorizontalFlexLayout.as
--
diff --git 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/HorizontalFlexLayout.as
 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/HorizontalFlexLayout.as
index bbdeceb..d6d2449 100644
--- 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/HorizontalFlexLayout.as
+++ 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/HorizontalFlexLayout.as
@@ -28,11 +28,11 @@ package org.apache.flex.html.beads.layouts
import org.apache.flex.core.IStrand;
import org.apache.flex.core.IParentIUIBase;
import org.apache.flex.core.UIBase;
+   import org.apache.flex.events.Event;
 
COMPILE::SWF {
import org.apache.flex.core.IUIBase;
import org.apache.flex.core.ValuesManager;
-   import org.apache.flex.events.Event;
import org.apache.flex.events.IEventDispatcher;
import org.apache.flex.geom.Rectangle;
import org.apache.flex.utils.CSSUtils;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/0ef43fa0/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/VerticalFlexLayout.as
--
diff --git 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/VerticalFlexLayout.as
 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/VerticalFlexLayout.as
index 4d86f14..2126616 100644
--- 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/VerticalFlexLayout.as
+++ 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/VerticalFlexLayout.as
@@ -28,11 +28,11 @@ package org.apache.flex.html.beads.layouts
import org.apache.flex.core.IStrand;
import org.apache.flex.core.UIBase;
import org.apache.flex.core.IParentIUIBase;
+   import org.apache.flex.events.Event;
 
COMPILE::SWF {
import org.apache.flex.core.IUIBase;
import org.apache.flex.core.ValuesManager;
-   import org.apache.flex.events.Event;
import org.apache.flex.events.IEventDispatcher;
import org.apache.flex.geom.Rectangle;
import org.apache.flex.utils.CSSUtils;

Jenkins build is back to normal : flex-asjs #2389

2017-07-11 Thread flex . ci . builds 
See

git commit: [flex-asjs] [refs/heads/feature/mouseenter] - Change rollover and rollout to mouseenter and mouseleave Needs testing before merge

2017-07-11 Thread harbs 
Repository: flex-asjs
Updated Branches:
  refs/heads/feature/mouseenter [created] 173858c7d


Change rollover and rollout to mouseenter and mouseleave
Needs testing before merge


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/173858c7
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/173858c7
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/173858c7

Branch: refs/heads/feature/mouseenter
Commit: 173858c7df421b1c61ea5f6fd656155ccc3d502f
Parents: 46a07ec
Author: Harbs 
Authored: Tue Jul 11 22:47:28 2017 +0300
Committer: Harbs 
Committed: Tue Jul 11 22:47:28 2017 +0300

--
 .../org/apache/flex/events/ElementEvents.as |   4 +-
 .../flex/org/apache/flex/events/MouseEvent.as   | 125 +++
 .../textLayout/events/FlowElementMouseEvent.as  |   8 ++
 3 files changed, 26 insertions(+), 111 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/173858c7/frameworks/projects/Core/src/main/flex/org/apache/flex/events/ElementEvents.as
--
diff --git 
a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/ElementEvents.as
 
b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/ElementEvents.as
index fc1353b..3d6e5f6 100644
--- 
a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/ElementEvents.as
+++ 
b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/ElementEvents.as
@@ -64,8 +64,8 @@ package org.apache.flex.events
'mouseup': 1,
'mousedown': 1,
'mousemove': 1,
-   'rollover': 1,
-   'rollout': 1
+   'mouseenter': 1,
+   'mouseleave': 1
};
}
 }

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/173858c7/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
--
diff --git 
a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as 
b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
index 3392d55..d4f28e5 100644
--- 
a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
+++ 
b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
@@ -46,18 +46,14 @@ package org.apache.flex.events
COMPILE::SWF
public class MouseEvent extends flash.events.MouseEvent implements 
IFlexJSEvent
{
-private static function platformConstant(s:String):String
-{
-return s;
-}
-
-   public static const MOUSE_DOWN:String = 
platformConstant("mouseDown");
-public static const MOUSE_MOVE:String = platformConstant("mouseMove");
-   public static const MOUSE_UP:String = 
platformConstant("mouseUp");
-   public static const MOUSE_OUT:String = 
platformConstant("mouseOut");
-   public static const MOUSE_OVER:String = 
platformConstant("mouseOver");
-   public static const ROLL_OVER:String = 
platformConstant("rollOver");
-   public static const ROLL_OUT:String = 
platformConstant("rollOut");
+   //SWF constants are different than the JS ones
+   public static const MOUSE_DOWN:String = "mouseDown";
+public static const MOUSE_MOVE:String = "mouseMove";
+   public static const MOUSE_UP:String = "mouseUp";
+   public static const MOUSE_OUT:String = "mouseOut";
+   public static const MOUSE_OVER:String = "mouseOver";
+   public static const ROLL_OVER:String = "rollOver";
+   public static const ROLL_OUT:String = "rollOut";
 public static const CLICK:String = "click";
public static const DOUBLE_CLICK:String = "doubleClick";
public static const WHEEL : String = "mouseWheel";
@@ -203,18 +199,14 @@ package org.apache.flex.events
COMPILE::JS
public class MouseEvent extends Event implements IFlexJSEvent
{
-   private static function platformConstant(s:String):String
-   {
-   return s.toLowerCase();
-   }
-
-   public static const MOUSE_DOWN:String = 
platformConstant("mouseDown");
-   public static const MOUSE_MOVE:String = 
platformConstant("mouseMove");
-   public static const MOUSE_UP:String = 
platformConstant("mouseUp");
-   public static const MOUSE_OUT:String = 
platformConstant("mouseOut");
-   public static const MOUSE_OVER:String = 
platformConstant("mouseOver");

git commit: [flex-asjs] [refs/heads/develop] - Should be reading the file as an ArrayBuffer

2017-07-11 Thread harbs 
Repository: flex-asjs
Updated Branches:
  refs/heads/develop e019d1c11 -> 46a07ec95


Should be reading the file as an ArrayBuffer


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/46a07ec9
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/46a07ec9
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/46a07ec9

Branch: refs/heads/develop
Commit: 46a07ec95ceeca1fe65ae521ea5d899db27fc09b
Parents: e019d1c
Author: Harbs 
Authored: Tue Jul 11 21:47:59 2017 +0300
Committer: Harbs 
Committed: Tue Jul 11 21:47:59 2017 +0300

--
 .../Network/src/main/flex/org/apache/flex/file/beads/FileLoader.as | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/46a07ec9/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileLoader.as
--
diff --git 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileLoader.as
 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileLoader.as
index 0110719..20e7f73 100644
--- 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileLoader.as
+++ 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileLoader.as
@@ -67,7 +67,7 @@ package org.apache.flex.file.beads
{
var reader:FileReader = new FileReader();
goog.events.listen(reader, 'load', 
fileLoadHandler);
-   reader.readAsBinaryString(fileModel.file);
+   reader.readAsArrayBuffer(fileModel.file);
}
}

Build failed in Jenkins: flex-asjs #2388

2017-07-11 Thread flex . ci . builds 
apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/asdoc-output>
 [echo] compiler.source-path = 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks/projects/*/src/main/flex>

clean:

super-clean:
   [delete] Deleting directory 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/mustella/tests/basicTests/bin>

create-description:
 [echo] build.number is 20170711

create-config:

playerglobal-setswfversion:

flex-config:
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks>

playerglobal-setswfversion:

air-config:
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks>

playerglobal-setswfversion:

js-config:
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks>

playerglobal-setswfversion:

jquery-config:
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks>

playerglobal-setswfversion:

createjs-config:
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks>

playerglobal-setswfversion:

node-config:
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks>

check-flex-home:
 [echo] FLEX_HOME is C:\Jenkins\workspace\flex-sdk
[available] DEPRECATED -  used to override an existing property.
[available]   Build file should not reuse the same property name for different 
values.

stage-source-no-scripts:

clean-temp:
[mkdir] Created dir: 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp>
 [copy] Copying 18 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp>

stage-framework-as:
 [copy] Copying 1806 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/frameworks>
 [echo] Updating config file air-config.xml with version 0.9.0.20170711
 [echo] Updating config file flex-config.xml with version 0.9.0.20170711
 [echo] Updating config file js-config.xml with version 0.9.0.20170711
 [echo] Updating config file jquery-config.xml with version 0.9.0.20170711
 [echo] Updating config file createjs-config.xml with version 0.9.0.20170711
 [echo] Updating config file node-config.xml with version 0.9.0.20170711
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/asdoc>
 [copy] Copying 3 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp>
 [copy] Copying 12 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/ide>
 [copy] Copying 14 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/js/bin>
 [copy] Copying 521 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/examples>
 [copy] Copying 1 file to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/templates>

copy-maven-archetypes:
 [echo] Copying Maven archetypes folder
 [copy] Copying 28 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/archetypes>

copy-maven-distribution:
 [echo] Copying Maven distribution folder
 [copy] Copying 65 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/distribution>

stage-source:

stage-scripts:
 [copy] Copying 4 files to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/temp/scripts>

source-package-zip:
[mkdir] Created dir: 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/out>
  [zip] Building zip: 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/2388/artifact/out/apache-flex-flexjs-0.9.0-src.zip>

source-package-tgz:
  [tar] Building tar: 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/2388/artifact/out/apache-flex-flexjs-0.9.0-src.tar.gz>

source-package:

source-release:

setup-binary-release:

check-for-airsdk:

ask-or-fail:

check-git:
 [echo] Checking for Git...
 [exec] git version 1.9.0.msysgit.0

get-download-folder:

download-all:

ask-about-downloading-repos:

block-main:

check-if-ide:

thirdparty-downloads:

thirdparty-downloads:

pixelbender-check:

pixelbender-download:
[mkdir] Created dir: 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/in>

get_from_mirror:

download_using_mirror:
  [get] Getting: 
http://www.apache.org/dyn/mirrors/mirrors.cgi/flex/pixelbender/1.0/binaries/apache-flex-sdk-pixel-bender-1.0.0-bin.zip?asjson=true
  [get] To: 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks/mirror.json>
  [get] Error getting 
http://www.apache.org/dyn/mirrors/mirrors.cgi/flex/pixelbender/1.0/binaries/apache-flex-sdk-pixel-bender-1.0.0-bin.zip?asjson=true
 to 
<http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/ws/frameworks/mirror.j

git commit: [flex-asjs] [refs/heads/develop] - Add FileBrowserWithFilter plus some doc fixes

2017-07-11 Thread yishayw 
Repository: flex-asjs
Updated Branches:
  refs/heads/develop 771010510 -> e019d1c11


Add FileBrowserWithFilter plus some doc fixes


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/e019d1c1
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/e019d1c1
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/e019d1c1

Branch: refs/heads/develop
Commit: e019d1c11179cefd7868fc952a1332c322802a91
Parents: 7710105
Author: DESKTOP-RH4S838\Yishay 
Authored: Tue Jul 11 14:46:23 2017 +0300
Committer: DESKTOP-RH4S838\Yishay 
Committed: Tue Jul 11 14:46:23 2017 +0300

--
 .../main/flex/org/apache/flex/file/FileProxy.as |  9 +++
 .../org/apache/flex/file/beads/FileBrowser.as   | 26 
 .../flex/file/beads/FileBrowserWithFilter.as| 63 
 .../org/apache/flex/file/beads/FileModel.as |  2 +-
 .../src/main/resources/basic-manifest.xml   |  1 +
 5 files changed, 87 insertions(+), 14 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/e019d1c1/frameworks/projects/Network/src/main/flex/org/apache/flex/file/FileProxy.as
--
diff --git 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/FileProxy.as 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/FileProxy.as
index 38c2fe8..f71ce67 100644
--- 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/FileProxy.as
+++ 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/FileProxy.as
@@ -63,16 +63,25 @@ package org.apache.flex.file
}
}
 
+   /**
+*  @copy org.apache.flex.core.IAlertModel#lastModified
+*/
public function get lastModified():uint
{
return (model as FileModel).lastModified;
}

+   /**
+*  @copy org.apache.flex.file.IFileModel#name
+*/
public function get name():String
{
return (model as FileModel).name;
}

+   /**
+*  @copy org.apache.flex.file.IFileModel#type
+*/
public function get type():String
{
return (model as FileModel).type;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/e019d1c1/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileBrowser.as
--
diff --git 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileBrowser.as
 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileBrowser.as
index 5d48c00..523f619 100644
--- 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileBrowser.as
+++ 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileBrowser.as
@@ -50,11 +50,11 @@ package org.apache.flex.file.beads
private var _strand:IStrand;
COMPILE::SWF 
{
-   private var _delegate:flash.net.FileReference;
+   protected var delegate:flash.net.FileReference;
}
COMPILE::JS 
{
-   private var _delegate:WrappedHTMLElement;
+   protected var delegate:WrappedHTMLElement;
}
 
/**
@@ -76,9 +76,9 @@ package org.apache.flex.file.beads
COMPILE::JS
public function createDelegate():void
{
-   _delegate = document.createElement('input') as 
WrappedHTMLElement;
-   _delegate.setAttribute('type', 'file');
-   goog.events.listen(_delegate, 'change', 
fileChangeHandler);
+   delegate = document.createElement('input') as 
WrappedHTMLElement;
+   delegate.setAttribute('type', 'file');
+   goog.events.listen(delegate, 'change', 
fileChangeHandler);
}

/**
@@ -87,8 +87,8 @@ package org.apache.flex.file.beads
COMPILE::SWF
public function createDelegate():void
{
-   _delegate = new flash.net.FileReference();
-   _delegate.addEventListener(flash.events.Event.SELECT, 
fileSelectHandler);
+   delegate = new flash.net.FileReference();
+   delegate.addEventListener(flash.events.Event.SELECT, 
fileSelectHandler);
}

/**
@@ -97,9 +97,9 @@ p

Build failed in Jenkins: flex-utilities_installer #1222

2017-07-11 Thread flex . ci . builds 
See 


--
Started by timer
Building remotely on flex_sdk_slave2 in workspace 

 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse --is-inside-work-tree # 
 > timeout=10
Fetching changes from the remote Git repository
 > C:\Program Files (x86)\Git\cmd\git.exe config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/flex-utilities.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/flex-utilities.git
 > C:\Program Files (x86)\Git\cmd\git.exe --version # timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/flex-utilities.git 
 > +refs/heads/*:refs/remotes/origin/*
 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse "origin/develop^{commit}" # 
 > timeout=10
Checking out Revision 8b168c154b5fba0eeba3e7a064f64b4d4d930e47 (origin/develop)
 > C:\Program Files (x86)\Git\cmd\git.exe config core.sparsecheckout # 
 > timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe checkout -f 
 > 8b168c154b5fba0eeba3e7a064f64b4d4d930e47
 > C:\Program Files (x86)\Git\cmd\git.exe rev-list 
 > 8b168c154b5fba0eeba3e7a064f64b4d4d930e47 # timeout=10
[ant_on_air] $ cmd.exe /C 
"c:\Jenkins\tools\hudson.tasks.Ant_AntInstallation\c_apache-ant-1.9.3\bin\ant.bat
 -file build.xml -Dplayerglobal.version=11.7 main && exit %%ERRORLEVEL%%"
Buildfile: 


clean:
   [delete] Deleting directory 


init:

check-as3commons.swc:

get-as3commons.swc:

third-party:
  [get] Destination already exists (skipping): 

  [get] Destination already exists (skipping): 

  [get] Destination already exists (skipping): 

  [get] Destination already exists (skipping): 

  [get] Destination already exists (skipping): 

  [get] Destination already exists (skipping): 

  [get] Destination already exists (skipping): 


compile:
[compc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\air-config.xml
[compc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[compc] 
C:\Jenkins\workspace\flex-utilities_installer\flex-installer\ant_on_air\bin\ant_on_air.swc
 (134439 bytes)

test:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\air-config.xml
[mxmlc] 
C:\Jenkins\workspace\flex-utilities_installer\flex-installer\ant_on_air\tests\AntOnAir.swf
 (1147468 bytes)
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

failuretests:

main:

BUILD SUCCESSFUL
Total time: 1 minute 22 seconds
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[flex-installer] $ cmd.exe /C 
"c:\Jenkins\tools\hudson.tasks.Ant_AntInstallation\c_apache-ant-1.9.3\bin\ant.bat
 -file build.xml -Dplayerglobal.version=11.7 clean build source-package 
create-md5s copy-misc && exit %%ERRORLEVEL%%"
Buildfile: 


clean:
   [delete] Deleting directory 

   [delete] Deleting directory 

   [delete] Deleting directory 

   [delete] Deleting directory 


clean:

createDirs:
 [echo] ***
 [echo] Execute the update-version target once,
 [echo] and only once, when you modifiy

git commit: [flex-asjs] [refs/heads/develop] - ClippingViewport is no longer necessary since Panel is a Group which clips anyway.

2017-07-11 Thread yishayw 
Repository: flex-asjs
Updated Branches:
  refs/heads/develop 3b5053f91 -> 771010510


ClippingViewport is no longer necessary since Panel is a Group which
clips anyway.


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/77101051
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/77101051
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/77101051

Branch: refs/heads/develop
Commit: 7710105109abaf3335698b18176746a055dc06f0
Parents: 3b5053f
Author: DESKTOP-RH4S838\Yishay 
Authored: Tue Jul 11 11:45:05 2017 +0300
Committer: DESKTOP-RH4S838\Yishay 
Committed: Tue Jul 11 11:45:05 2017 +0300

--
 .../org/apache/flex/html/supportClasses/AccordionItemRenderer.as| 1 -
 1 file changed, 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/77101051/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
--
diff --git 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
index ff5ec2b..e5951f2 100644
--- 
a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
+++ 
b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/AccordionItemRenderer.as
@@ -39,7 +39,6 @@ package org.apache.flex.html.supportClasses
{
super();
percentWidth = 100;
-   addBead(new ClippingViewport());
}

public function get selected():Boolean

git commit: [flex-asjs] [refs/heads/develop] - Uploads are assumed to be POST

2017-07-11 Thread yishayw 
Repository: flex-asjs
Updated Branches:
  refs/heads/develop cc098932c -> 3b5053f91


Uploads are assumed to be POST


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/3b5053f9
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/3b5053f9
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/3b5053f9

Branch: refs/heads/develop
Commit: 3b5053f91f869a7fd4cd1eccf80e696e5171b532
Parents: cc09893
Author: DESKTOP-RH4S838\Yishay 
Authored: Tue Jul 11 11:08:32 2017 +0300
Committer: DESKTOP-RH4S838\Yishay 
Committed: Tue Jul 11 11:08:32 2017 +0300

--
 .../src/main/flex/org/apache/flex/file/beads/FileUploader.as| 1 +
 1 file changed, 1 insertion(+)
--


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/3b5053f9/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileUploader.as
--
diff --git 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileUploader.as
 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileUploader.as
index e9aad3c..194a1d6 100644
--- 
a/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileUploader.as
+++ 
b/frameworks/projects/Network/src/main/flex/org/apache/flex/file/beads/FileUploader.as
@@ -80,6 +80,7 @@ package org.apache.flex.file.beads
 // }
var binaryUploader:URLBinaryLoader = new 
URLBinaryLoader();
var req:URLRequest = new URLRequest();
+   req.method = "POST";
req.data = (host.model as FileModel).blob;
req.url = url;
binaryUploader.addEventListener(Event.COMPLETE, 
completeHandler);

Build failed in Jenkins: flex-blazeds #1013

2017-07-11 Thread flex . ci . builds 
See 

--
Started by timer
Building remotely on flex_sdk_slave2 in workspace 

 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse --is-inside-work-tree # 
 > timeout=10
Fetching changes from the remote Git repository
 > C:\Program Files (x86)\Git\cmd\git.exe config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/flex-blazeds.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/flex-blazeds.git
 > C:\Program Files (x86)\Git\cmd\git.exe --version # timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/flex-blazeds.git 
 > +refs/heads/*:refs/remotes/origin/*
 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse 
 > "refs/remotes/origin/develop^{commit}" # timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse 
 > "refs/remotes/origin/origin/develop^{commit}" # timeout=10
Checking out Revision 98e50204b0da67392cff211c07d88096fbf17625 
(refs/remotes/origin/develop)
 > C:\Program Files (x86)\Git\cmd\git.exe config core.sparsecheckout # 
 > timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe checkout -f 
 > 98e50204b0da67392cff211c07d88096fbf17625
 > C:\Program Files (x86)\Git\cmd\git.exe rev-list 
 > 98e50204b0da67392cff211c07d88096fbf17625 # timeout=10
Parsing POMs
Modules changed, recalculating dependency graph
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[flex-blazeds] $ "C:\Program Files\Java\jdk1.7.0_67/bin/java" -cp 
c:\Jenkins\maven32-agent.jar;c:\Jenkins\tools\hudson.tasks.Maven_MavenInstallation\Maven_3.2.1\boot\plexus-classworlds-2.5.1.jar;c:\Jenkins\tools\hudson.tasks.Maven_MavenInstallation\Maven_3.2.1/conf/logging
 jenkins.maven3.agent.Maven32Main 
c:\Jenkins\tools\hudson.tasks.Maven_MavenInstallation\Maven_3.2.1 
C:\Users\apacheflexbuild\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\2\32f78882-5bca442d
 c:\Jenkins\maven32-interceptor.jar c:\Jenkins\maven3-interceptor-commons.jar 
62191
<===[JENKINS REMOTING CAPACITY]===>   channel started
Executing Maven:  -B -f 
 clean 
verify
[INFO] Scanning for projects...
[INFO] 
[INFO] Reactor Build Order:
[INFO] 
[INFO] Apache Flex - BlazeDS
[INFO] flex-messaging-archetypes
[INFO] blazeds-spring-boot-example-archetype
[INFO] flex-messaging-common
[INFO] flex-messaging-core
[INFO] flex-messaging-proxy
[INFO] flex-messaging-remoting
[INFO] flex-messaging-opt
[INFO] flex-messaging-opt-tomcat
[INFO] flex-messaging-opt-tomcat-base
[INFO] flex-messaging-opt-tomcat-4
[INFO] flex-messaging-opt-tomcat-6
[INFO] flex-messaging-opt-tomcat-7
[INFO] blazeds-spring-boot-starter
[INFO] 
[INFO] Using the builder 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder
 with a thread count of 1
[INFO] 
[INFO] 
[INFO] Building Apache Flex - BlazeDS 4.7.4-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ blazeds ---
[INFO] Deleting 

[INFO] 
[INFO] --- jacoco-maven-plugin:0.7.6.201602180812:prepare-agent (pre-unit-test) 
@ blazeds ---
[INFO] surefireArgLine set to 
-javaagent:C:\\Users\\apacheflexbuild\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.7.6.201602180812\\org.jacoco.agent-0.7.6.201602180812-runtime.jar=destfile=c:\\Jenkins\\workspace\\flex-blazeds\\target\\coverage-reports\\jacoco-ut.exec
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ blazeds ---
[INFO] 
[INFO] --- jacoco-maven-plugin:0.7.6.201602180812:report (post-unit-test) @ 
blazeds ---
[INFO] Skipping JaCoCo execution due to missing execution data 
file:
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.15:check (check-jdk-1.6) @ blazeds ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.1
[INFO] 
[INFO] --- maven-site-plugin:3.5.1:attach-descriptor (attach-descriptor) @ 
blazeds ---
[INFO] 
[INFO] --- jacoco-maven-plugin:0.7.6.201602180812:prepare-agent 
(pre-integration-test) @ blazeds ---
[INFO] failsafeArgLine set to 
-javaagent:C:\\Users\\apacheflexbuild\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.7.6.201602180812\\org.jacoco.agent-0.7.6.201602180812-runtime.jar=destfile=c:\\Jenkins\\workspace\\flex-blazeds\\target\\coverage-reports\\jacoco-it.exec
[INFO] 
[INFO] --- jacoco-ma

Build failed in Jenkins: flex-tlf #1128

2017-07-11 Thread flex . ci . builds 
See 

--
Started by timer
Building remotely on flex_sdk_slave2 in workspace 

 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse --is-inside-work-tree # 
 > timeout=10
Fetching changes from the remote Git repository
 > C:\Program Files (x86)\Git\cmd\git.exe config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/flex-tlf.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/flex-tlf.git
 > C:\Program Files (x86)\Git\cmd\git.exe --version # timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/flex-tlf.git 
 > +refs/heads/*:refs/remotes/origin/*
 > C:\Program Files (x86)\Git\cmd\git.exe rev-parse "origin/develop^{commit}" # 
 > timeout=10
Checking out Revision 7fe228452bf7aff8bd670dbdc7cb4e6858628bab (origin/develop)
 > C:\Program Files (x86)\Git\cmd\git.exe config core.sparsecheckout # 
 > timeout=10
 > C:\Program Files (x86)\Git\cmd\git.exe checkout -f 
 > 7fe228452bf7aff8bd670dbdc7cb4e6858628bab
 > C:\Program Files (x86)\Git\cmd\git.exe rev-list 
 > 7fe228452bf7aff8bd670dbdc7cb4e6858628bab # timeout=10
[flex-tlf] $ cmd.exe /C 
"c:\Jenkins\tools\hudson.tasks.Ant_AntInstallation\c_apache-ant-1.9.3\bin\ant.bat
 -file build.xml all && exit %%ERRORLEVEL%%"
Buildfile: 
 [echo] FLEX_HOME is 

 [echo] Minimal test is set false

clean:
   [delete] Deleting directory 

   [delete] Deleting: 


textLayout:
[compc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[compc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[compc] C:\Jenkins\workspace\flex-tlf\bin\textLayout.swc (550069 bytes)

main:

asTestApps:
 [echo] FLEX_HOME is 

 [echo] Minimal test is set false

asTestApp:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[mxmlc] 
C:\Jenkins\workspace\flex-tlf\bin\apps\asTestApps\bin\ExplicitFormField.swf 
(521422 bytes)
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
 [echo] FLEX_HOME is 

 [echo] Minimal test is set false

asTestApp:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[mxmlc] 
C:\Jenkins\workspace\flex-tlf\bin\apps\asTestApps\bin\TCMTestFocus2.swf (528618 
bytes)
 [echo] FLEX_HOME is 

 [echo] Minimal test is set false

asTestApp:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[mxmlc] 
C:\Jenkins\workspace\flex-tlf\bin\apps\asTestApps\bin\AliceScroll.swf (589428 
bytes)
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
 [echo] FLEX_HOME is 

 [echo] Minimal test is set false

asTestApp:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[mxmlc] C:\Jenkins\workspace\flex-tlf\bin\apps\asTestApps\bin\KeyLogger.swf 
(2165 bytes)
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
 [echo] FLEX_HOME is 

 [echo] Minimal test is set false

asTestApp:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[mxmlc] C:\Jenkins\workspace\flex-tlf\bin\apps\asTestApps\bin\OpHammer.swf 
(531610 bytes)
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

textLayout_editBar:
[compc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[compc] 
C:\Jenkins\workspace\flex-tlf\bin\apps\testApps\bin\textLayout_editBar.swc 
(23173 bytes)
[compc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

textLayout_ui:
[compc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[compc] 
C:\Jenkins\workspace\flex-tlf\bin\apps\testApps\bin\textLayout_ui.swc (112811 
bytes)
[compc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

testApps:
[mxmlc] Loading configuration file 
C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
[mxmlc] C:\Jenkins\workspace\flex-tlf\bin\apps\automation_apps\bin\Flow.swf 
(2191216 bytes)
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

automation_core

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

2017-07-11 Thread Alex Harui 
This seems like "just-in-case" code.  I could see that it might be needed
in a different bead for Express though.

Without this change, is there an infinite loop somewhere?

Thanks,
-Alex

On 7/10/17, 10:40 PM, "jmcl...@apache.org"  wrote:

>FLEX-35338 stop cursor from spinning / CPU from spiking
>
>
>Project: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7C%7C8e2e2d5b3b3
>54f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363534
>84318029070&sdata=32hEJB%2BTNsWKG8MY%2FdPr3d0RWT5Xr1tECWWpVTlM270%3D&reser
>ved=0
>Commit: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F549a10d8&data=02%7C01%7C%
>7C8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>7C0%7C636353484318029070&sdata=dcNhAGu8WspafZBZCRxb%2FN0z7D%2Fym3tuv%2BAaq
>G280z0%3D&reserved=0
>Tree: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F549a10d8&data=02%7C01%7C%7C
>8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636353484318029070&sdata=0p89CGQLSv0Pp0yscOBNjKRJ1HUMhHrDngm4xxixalc%3
>D&reserved=0
>Diff: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F549a10d8&data=02%7C01%7C%7C
>8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636353484318029070&sdata=%2FclUp4scfr0z%2B%2FTPjBMlVw2kScADTcLPMwop5J4
>7cIU%3D&reserved=0
>
>Branch: refs/heads/develop
>Commit: 549a10d82da5835c61a2b1247b65f7bfbc2f9a36
>Parents: 3891820
>Author: Justin Mclean 
>Authored: Tue Jul 11 14:57:04 2017 +1000
>Committer: Justin Mclean 
>Committed: Tue Jul 11 14:57:04 2017 +1000
>
>--
> .../main/flex/org/apache/flex/html/accessories/ToolTipBead.as   | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>--
>
>
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F549a10d8%2Fframeworks%2Fpro
>jects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Faccessori
>es%2FToolTipBead.as&data=02%7C01%7C%7C8e2e2d5b3b354f54848508d4c81f5768%7Cf
>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636353484318029070&sdata=hifp5T8
>xFlL4zov22P5qOUYtZqrYuPqTqOJg2x4X5lo%3D&reserved=0
>--
>diff --git 
>a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as 
>b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as
>index 03ce21e..bdf0b68 100644
>--- 
>a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as
>+++ 
>b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as
>@@ -100,7 +100,10 @@ package org.apache.flex.html.accessories
>* @private
>*/
>   protected function rollOverHandler( event:MouseEvent ):void
>-  {   
>+  {
>+  if (!toolTip)
>+  return;
>+
> 
>IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OUT,
>rollOutHandler, false);
> 
> var comp:IUIBase = _strand as IUIBase
>