from:"Alex Harui"

RE: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-09 Thread Alex Harui

Update:  I synced up and ran the FTETextField tests on my Windows box and got 
the same 2 errors (FP11.1).

I'll be doing some digging...  Won't need the Mustella VM.

-Alex

From: flex.muste...@gmail.com [flex.muste...@gmail.com]
Sent: Tuesday, October 08, 2013 9:42 PM
To: commits@flex.apache.org; jmcl...@apache.org; maurice.amsel...@systar.com
Subject: Build failed in Jenkins: flex-sdk_mustella #460

See http://localhost:8080/job/flex-sdk_mustella/460/changes

Changes:

[jmclean] Renamed supportClazzes package to be called supoortClasses

[jmclean] Renamed supportClazzes package to be called supoortClasses

[maurice.amsellem] temp commit move experimental callout to spark

[jmclean] fixed revert to release notes

[maurice.amsellem] FIXED https://issues.apache.org/jira/browse/FLEX-33350

[maurice.amsellem] Merge branch 'develop' of 
https://git-wip-us.apache.org/repos/asf/flex-sdk into callout

[jmclean] added mention of 11.9 beta support

[jmclean] added line about mobile callout

[jmclean] FLEX-32728 set initial anchor up so that shift works after selection 
has been programatically set

[jmclean] moved mustella shell scripts to mustella directory

[maurice.amsellem] UPDATED https://issues.apache.org/jira/browse/FLEX-33350

[maurice.amsellem] https://issues.apache.org/jira/browse/FLEX-33777 Dagrid for 
mobile

[jmclean] FLEX-33807 fixed parsing of dates with no seperators

--
[...truncated 86463 lines...]
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 [java]  moreParameters before:
 [java]  cmdArr after:
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 [java] getting directory from the swf file
 [java] derived directory: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs
 [java] Launching:
 [java]  
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe

C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 Launching: 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe

C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 [java] USING directory: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs
 [java] time: 23:41:23.875
 [java] FAIL: 
gumbo/components/FTETextField/Properties/FTETextField_Properties_tester 
autoSize_left5
 [java] FAIL: 
gumbo/components/FTETextField/Properties/FTETextField_Properties_tester 
autoSize_left7
 [java] SCRIPTDONE! 23:41:29.125
 [java] GET /ScriptComplete?0 HTTP/1.1
 [java] Before Wait loop 23:41:29.125 waiting = 0
 [java] After Wait loop 23:41:29.125 waiting = 0
 [java] clobberProcess false
 [java] waited 5000
 [java] ClobberProcess, destroying process
 [java] Grab log, do parse = false
 [java] Grabbing the log from: 
C:\Users\ApacheFlex\AppData/Roaming\Macromedia/Flash Player/Logs/flashlog.txt 
to: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.log
 [java] new test file: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java]  cmdArr before:
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java]  moreParameters before:
 [java]  cmdArr after:
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java] getting directory from the swf file
 [java] derived directory: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs
 [java] Launching:
 [java]  
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe

C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 Launching: 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe

C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java] USING directory:

RE: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-09 Thread Alex Harui

Update:  These same two tests fail for me on OSX.

My investigation has discovered that after a git pull on both my Windows and 
Mac, neither show the revert of Nick's change to FTETextField, and the git log 
doesn't show it either.  What do you guys see when you look at 
frameworks/projects/spark/src/mx/core/FTETextField.as?

-Alex

From: Alex Harui
Sent: Wednesday, October 09, 2013 8:33 PM
To: d...@flex.apache.org; d...@flex.apache.org; commits@flex.apache.org; 
jmcl...@apache.org; maurice.amsel...@systar.com
Subject: RE: Build failed in Jenkins: flex-sdk_mustella #460

Update:  I synced up and ran the FTETextField tests on my Windows box and got 
the same 2 errors (FP11.1).

I'll be doing some digging...  Won't need the Mustella VM.

-Alex

From: flex.muste...@gmail.com [flex.muste...@gmail.com]
Sent: Tuesday, October 08, 2013 9:42 PM
To: commits@flex.apache.org; jmcl...@apache.org; maurice.amsel...@systar.com
Subject: Build failed in Jenkins: flex-sdk_mustella #460

See http://localhost:8080/job/flex-sdk_mustella/460/changes

Changes:

[jmclean] Renamed supportClazzes package to be called supoortClasses

[jmclean] Renamed supportClazzes package to be called supoortClasses

[maurice.amsellem] temp commit move experimental callout to spark

[jmclean] fixed revert to release notes

[maurice.amsellem] FIXED https://issues.apache.org/jira/browse/FLEX-33350

[maurice.amsellem] Merge branch 'develop' of 
https://git-wip-us.apache.org/repos/asf/flex-sdk into callout

[jmclean] added mention of 11.9 beta support

[jmclean] added line about mobile callout

[jmclean] FLEX-32728 set initial anchor up so that shift works after selection 
has been programatically set

[jmclean] moved mustella shell scripts to mustella directory

[maurice.amsellem] UPDATED https://issues.apache.org/jira/browse/FLEX-33350

[maurice.amsellem] https://issues.apache.org/jira/browse/FLEX-33777 Dagrid for 
mobile

[jmclean] FLEX-33807 fixed parsing of dates with no seperators

--
[...truncated 86463 lines...]
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 [java]  moreParameters before:
 [java]  cmdArr after:
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 [java] getting directory from the swf file
 [java] derived directory: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs
 [java] Launching:
 [java]  
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 Launching: 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.swf
 [java] USING directory: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs
 [java] time: 23:41:23.875
 [java] FAIL: 
gumbo/components/FTETextField/Properties/FTETextField_Properties_tester 
autoSize_left5
 [java] FAIL: 
gumbo/components/FTETextField/Properties/FTETextField_Properties_tester 
autoSize_left7
 [java] SCRIPTDONE! 23:41:29.125
 [java] GET /ScriptComplete?0 HTTP/1.1
 [java] Before Wait loop 23:41:29.125 waiting = 0
 [java] After Wait loop 23:41:29.125 waiting = 0
 [java] clobberProcess false
 [java] waited 5000
 [java] ClobberProcess, destroying process
 [java] Grab log, do parse = false
 [java] Grabbing the log from: 
C:\Users\ApacheFlex\AppData/Roaming\Macromedia/Flash Player/Logs/flashlog.txt 
to: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\FTETextField\SWFs\FTETextField_main.log
 [java] new test file: 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java]  cmdArr before:
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java]  moreParameters before:
 [java]  cmdArr after:
 [java] 
C:\ApacheFlex\dependencies\FlashPlayer_Debug\flashplayer11_7r700_232_win_sa_debug.exe
 [java] 
C:\jenkins_slave\workspace\flex-sdk_mustella\mustella\tests\gumbo\components\Image\swfs\ImageMain.swf
 [java] getting directory from the swf file

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33307: adding these arguments makes most of the warnings and some of the errors go away. Baby steps ; -)

2013-09-23 Thread Alex Harui

Nevermind,  I guess you need to do that for the AIR-related SWCs?

-Alex

On 9/23/13 9:51 AM, Alex Harui aha...@adobe.com wrote:

I believe that we normally compile the framework against flex-config.xml
not air-config.xml.  Is there a reason you chose air-config?

-Alex

On 9/23/13 7:31 AM, erikdebr...@apache.org erikdebr...@apache.org
wrote:

Updated Branches:
  refs/heads/develop 5abe3d03d - 05cfdcb68


FLEX-33307: adding these arguments makes most of the warnings and some of
the errors go away. Baby steps ;-)

Signed-off-by: Erik de Bruin e...@ixsoftware.nl


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/05cfdcb6
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/05cfdcb6
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/05cfdcb6

Branch: refs/heads/develop
Commit: 05cfdcb683c2eb2be45b2339626721eb138f1b07
Parents: 5abe3d0
Author: Erik de Bruin e...@ixsoftware.nl
Authored: Mon Sep 23 16:29:28 2013 +0200
Committer: Erik de Bruin e...@ixsoftware.nl
Committed: Mon Sep 23 16:29:28 2013 +0200

--
 compiler.tests/functional-tests/f/SDKSWCTests.java | 6 ++
 1 file changed, 6 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/05cfdcb6/compiler
.
tests/functional-tests/f/SDKSWCTests.java
--
diff --git a/compiler.tests/functional-tests/f/SDKSWCTests.java
b/compiler.tests/functional-tests/f/SDKSWCTests.java
index b936f99..f38e3ea 100644
--- a/compiler.tests/functional-tests/f/SDKSWCTests.java
+++ b/compiler.tests/functional-tests/f/SDKSWCTests.java
@@ -333,6 +333,12 @@ public class SDKSWCTests
 @Test
 public void sparkSWC() // FAILS - FLEX-33307
 {
+extraArgs = new String[]
+{
+
-ignore-problems=org.apache.flex.compiler.problems.DuplicateSkinStatePro
b
lem,
+-load-config+= + env.SDK + /frameworks/air-config.xml
+};
+
 compileSWC(spark);
 }

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33307: adding these arguments makes most of the warnings and some of the errors go away. Baby steps ; -)

2013-09-23 Thread Alex Harui

I believe that we normally compile the framework against flex-config.xml
not air-config.xml.  Is there a reason you chose air-config?

-Alex

On 9/23/13 7:31 AM, erikdebr...@apache.org erikdebr...@apache.org
wrote:

Updated Branches:
  refs/heads/develop 5abe3d03d - 05cfdcb68


FLEX-33307: adding these arguments makes most of the warnings and some of
the errors go away. Baby steps ;-)

Signed-off-by: Erik de Bruin e...@ixsoftware.nl


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/05cfdcb6
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/05cfdcb6
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/05cfdcb6

Branch: refs/heads/develop
Commit: 05cfdcb683c2eb2be45b2339626721eb138f1b07
Parents: 5abe3d0
Author: Erik de Bruin e...@ixsoftware.nl
Authored: Mon Sep 23 16:29:28 2013 +0200
Committer: Erik de Bruin e...@ixsoftware.nl
Committed: Mon Sep 23 16:29:28 2013 +0200

--
 compiler.tests/functional-tests/f/SDKSWCTests.java | 6 ++
 1 file changed, 6 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/05cfdcb6/compiler.
tests/functional-tests/f/SDKSWCTests.java
--
diff --git a/compiler.tests/functional-tests/f/SDKSWCTests.java
b/compiler.tests/functional-tests/f/SDKSWCTests.java
index b936f99..f38e3ea 100644
--- a/compiler.tests/functional-tests/f/SDKSWCTests.java
+++ b/compiler.tests/functional-tests/f/SDKSWCTests.java
@@ -333,6 +333,12 @@ public class SDKSWCTests
 @Test
 public void sparkSWC() // FAILS - FLEX-33307
 {
+extraArgs = new String[]
+{
+
-ignore-problems=org.apache.flex.compiler.problems.DuplicateSkinStateProb
lem,
+-load-config+= + env.SDK + /frameworks/air-config.xml
+};
+
 compileSWC(spark);
 }

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33713: An NPE is thrown by this code when compiling 'spark.swc' from the SDK. The null check bypasses the issue, it doesn't do anything to fix

2013-09-23 Thread Alex Harui

Hmm.  Seems like methodBodyVisitor is needed to complete the codegen for
the static initializer.  Instead of a null check, a call to
getMethodBodyVisitor() might be the right answer, but a simple test case
that verifies correct codegen would be helpful.  There might be something
unique to TextFlowUtil's static APIs that is tripping up Falcon.

-Alex

On 9/23/13 6:23 AM, erikdebr...@apache.org erikdebr...@apache.org
wrote:

Updated Branches:
  refs/heads/develop f7956f9a4 - 78cbff9f0


FLEX-33713: An NPE is thrown by this code when compiling 'spark.swc' from
the SDK. The null check bypasses the issue, it doesn't do anything to fix
the root cause...

Signed-off-by: Erik de Bruin e...@ixsoftware.nl


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/78cbff9f
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/78cbff9f
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/78cbff9f

Branch: refs/heads/develop
Commit: 78cbff9f0342e2de9f28abb88dab6c656e061e95
Parents: f7956f9
Author: Erik de Bruin e...@ixsoftware.nl
Authored: Mon Sep 23 15:22:03 2013 +0200
Committer: Erik de Bruin e...@ixsoftware.nl
Committed: Mon Sep 23 15:22:03 2013 +0200

--
 .../as/codegen/ClassDirectiveProcessor.java | 16 +---
 1 file changed, 13 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/78cbff9f/compiler/
src/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.j
ava
--
diff --git 
a/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirective
Processor.java 
b/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirective
Processor.java
index dae7ebc..29d2a7b 100644
--- 
a/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirective
Processor.java
+++ 
b/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirective
Processor.java
@@ -533,9 +533,19 @@ class ClassDirectiveProcessor extends
DirectiveProcessor
 
 cinit_insns.addInstruction(OP_returnvoid);
 
-
this.classStaticScope.methodBodyVisitor.visitInstructionList(cinit_insns);
-this.classStaticScope.methodBodyVisitor.visitEnd();
-this.classStaticScope.methodVisitor.visitEnd();
+/*
+ * FIXME: NPE while compiling 'spark.swc'
+ * 
+ * erikdebruin: I'm just bypassing that with this null
check. Someone 
+ *  who knows what's going on here should
probably take a
+ *  look WHY this was failing...
+ */
+if (this.classStaticScope.methodBodyVisitor != null)
+{
+
this.classStaticScope.methodBodyVisitor.visitInstructionList(cinit_insns);
+this.classStaticScope.methodBodyVisitor.visitEnd();
+this.classStaticScope.methodVisitor.visitEnd();
+}
 }
 else
 {

Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-33740 made removedFromStageHandler protected so it could be overridden

2013-09-18 Thread Alex Harui

I think it is nighttime for Justin.  Should we wait for him to revert?
I'd do the revert myself, but I have other pushable commits pending and
nervous about following the steps to try to push just a revert.

-Alex

On 9/18/13 8:49 AM, Erik de Bruin e...@ixsoftware.nl wrote:

Wow, that broke so hard, Google decided the notification were spam.
They got filtered out, so I didn't notice anything until Alex emailed.
Sorry about that.

I have paused the builds until the commit is reverted.

EdB



On Wed, Sep 18, 2013 at 4:07 PM, Alex Harui aha...@adobe.com wrote:
 Justin, please revert. I think it broke the build.




 Sent via the PANTECH Discover, an ATT 4G LTE smartphone.

 jmcl...@apache.org wrote:


 Updated Branches:
   refs/heads/develop d2768bef3 - 18ce3aa9f


 FLEX-33740 made removedFromStageHandler protected so it could be
overridden


 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
 Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5d86438e
 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5d86438e
 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5d86438e

 Branch: refs/heads/develop
 Commit: 5d86438e5d5a879b0cc6eabe89bd071e0ca515f6
 Parents: d2768be
 Author: Justin Mclean jmcl...@apache.org
 Authored: Wed Sep 18 18:28:57 2013 +1000
 Committer: Justin Mclean jmcl...@apache.org
 Committed: Wed Sep 18 18:28:57 2013 +1000

 --
  .../projects/framework/src/mx/core/UIComponent.as   | 12
++--
  1 file changed, 10 insertions(+), 2 deletions(-)
 --


 
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5d86438e/frameworks/
projects/framework/src/mx/core/UIComponent.as
 --
 diff --git a/frameworks/projects/framework/src/mx/core/UIComponent.as
b/frameworks/projects/framework/src/mx/core/UIComponent.as
 index 822b49c..4634e80 100644
 --- a/frameworks/projects/framework/src/mx/core/UIComponent.as
 +++ b/frameworks/projects/framework/src/mx/core/UIComponent.as
 @@ -12665,9 +12665,17 @@ public class UIComponent extends FlexSprite
  }

  /**
 - *  @private
 + *
 +* Called when a component is removed from the stage.
 +*
 + *  @param event The event object.
 + *
 + *  @langversion 3.0
 + *  @playerversion Flash 9
 + *  @playerversion AIR 1.1
 + *  @productversion Flex 4.11
   */
 -private function removedFromStageHandler(event:Event):void
 +protected function removedFromStageHandler(event:Event):void
  {
  _systemManagerDirty = true;
  }




-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33702: Added column sort type access to the datagrid columns.

2013-09-09 Thread Alex Harui

Looks fine.  One concern is that you changed an interface.  We got burned
by changing other interfaces in the past.  Remember the IList snafu?  But
I don't know if there are any custom ISortField implementations in the
wild so it may be ok.

-Alex

On 9/9/13 5:00 PM, mkess...@apache.org mkess...@apache.org wrote:

Updated Branches:
  refs/heads/develop 0a8f84da5 - 3188f0141


FLEX-33702: Added column sort type access to the datagrid columns.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3188f014
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3188f014
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3188f014

Branch: refs/heads/develop
Commit: 3188f01419a8c9bdf4d4e6859894ca05cbef3d8d
Parents: 0a8f84d
Author: Mark Kessler kesslerconsult...@gmail.com
Authored: Mon Sep 9 19:45:53 2013 -0400
Committer: Mark Kessler kesslerconsult...@gmail.com
Committed: Mon Sep 9 20:00:30 2013 -0400

--
 .../framework/src/mx/collections/ISortField.as  |  30 +
 .../framework/src/mx/collections/SortField.as   | 117 +-
 .../src/mx/collections/SortFieldCompareTypes.as | 118 ++
 .../projects/mx/src/mx/controls/DataGrid.as |   3 +
 .../controls/dataGridClasses/DataGridColumn.as  |  37 ++
 .../spark/src/spark/collections/SortField.as| 119 ++-
 .../spark/collections/SortFieldCompareTypes.as  | 119 +++
 .../spark/components/gridClasses/GridColumn.as  |  43 ++-
 8 files changed, 582 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3188f014/frameworks/p
rojects/framework/src/mx/collections/ISortField.as
--
diff --git
a/frameworks/projects/framework/src/mx/collections/ISortField.as
b/frameworks/projects/framework/src/mx/collections/ISortField.as
index f0d5ec0..be4bdc8 100644
--- a/frameworks/projects/framework/src/mx/collections/ISortField.as
+++ b/frameworks/projects/framework/src/mx/collections/ISortField.as
@@ -139,6 +139,22 @@ public interface ISortField
 function get numeric():Object;
 function set numeric(value:Object):void;

+
+/**
+ *  Specifies what compare type will be used for the sortField. This
overrides the default
+ *  behavior.
+ *
+ *  @default null
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.11
+ */
+function get sortCompareType():String;
+function set sortCompareType(value:String):void;
+
+
 /**
  *  True if this codeISortField/code uses a custom comparator
function.
  *
@@ -192,5 +208,19 @@ public interface ISortField
  *  @productversion Flex 4.5
  */
 function reverse():void;
+
+
+/**
+ *  This changes the internal compare function used by the
codeSortField/code based
+ *  on the value of codesortCompareType/code.
+ *
+ *  @return true for successfully matched or false for failure to
match the codesortCompareType/code.
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.11
+ */
+function updateSortCompareType():Boolean;
 }
 }

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3188f014/frameworks/p
rojects/framework/src/mx/collections/SortField.as
--
diff --git
a/frameworks/projects/framework/src/mx/collections/SortField.as
b/frameworks/projects/framework/src/mx/collections/SortField.as
index 47eed0a..3a5a388 100644
--- a/frameworks/projects/framework/src/mx/collections/SortField.as
+++ b/frameworks/projects/framework/src/mx/collections/SortField.as
@@ -28,6 +28,7 @@ import mx.managers.SystemManager;
 import mx.resources.IResourceManager;
 import mx.resources.ResourceManager;
 import mx.utils.ObjectUtil;
+import mx.collections.SortFieldCompareTypes;

 [ResourceBundle(collections)]
 [Alternative(replacement=spark.collections.SortField, since=4.5)]
@@ -136,7 +137,11 @@ public class SortField extends EventDispatcher
implements ISortField
 _caseInsensitive = caseInsensitive;
 _descending = descending;
 _numeric = numeric;
-_compareFunction = stringCompare;
+
+if (updateSortCompareType() == false)
+{
+_compareFunction = stringCompare;
+}
 }


//
--
@@ -404,6 +409,46 @@ public class SortField extends EventDispatcher
implements ISortField
 }
 }

+
+//-
+//  sortCompareType
+//-
+
+/**
+ *  @private
+ */
+private var

Re: git commit: [flex-sdk] [refs/heads/develop] - Fixed build version number not being injected into configuration file

2013-08-08 Thread Alex Harui

Minor, but I think tstamp is called more than once now and could end up on
both sides of midnight if you start a build too late at night.

On 8/8/13 10:20 PM, jmcl...@apache.org jmcl...@apache.org wrote:

Updated Branches:
  refs/heads/develop 57fffd956 - 9f3efa466


Fixed build version number not  being injected into configuration file


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9f3efa46
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9f3efa46
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9f3efa46

Branch: refs/heads/develop
Commit: 9f3efa46684bf26381b3e9cb355bff61a013c8e6
Parents: 57fffd9
Author: Justin Mclean jmcl...@apache.org
Authored: Fri Aug 9 15:19:41 2013 +1000
Committer: Justin Mclean jmcl...@apache.org
Committed: Fri Aug 9 15:19:41 2013 +1000

--
 build.xml | 16 
 1 file changed, 12 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9f3efa46/build.xml
--
diff --git a/build.xml b/build.xml
index 6d53e54..99160d8 100644
--- a/build.xml
+++ b/build.xml
@@ -697,9 +697,16 @@
 !-- frameworks/tests --
 antcall target=stage-frameworks-tests/
 
-!-- now that air-config.xml and flex-config.xml are in temp,
fix them up for release. --
-fix-config-file
file=${basedir}/temp/frameworks/air-config.xml /
-fix-config-file
file=${basedir}/temp/frameworks/flex-config.xml /
+tstamp
+  format property=build.number.date pattern=MMdd /
+/tstamp
+property name=build.version
value=${release.version}.${build.number.date} /
+
+!-- now that config xml files are in temp, fix them up for
release. --
+echo message=Updating config file air-config.xml with version
${build.version}/
+fix-config-file
file=${basedir}/temp/frameworks/air-config.xml
version=${build.version} /
+echo message=Updating config file flex-config.xml with version
${build.version}/
+fix-config-file
file=${basedir}/temp/frameworks/flex-config.xml
version=${build.version} /
 
 !-- Update all Version.as files in the kit frameworks directory
with build.number --
 antcall target=version-update/
@@ -1034,6 +1041,7 @@
 
 macrodef name=fix-config-file
 attribute name=file/
+attribute name=version/
 sequential
 replace file=@{file}
 replacefilter
@@ -1041,7 +1049,7 @@
  
value=lt;warn-no-explicit-super-call-in-constructorgt;false/
 replacefilter
 token=$${build.number}
-value=${release.version}.${build.number.date}/
+value=@{version}/
 /replace
 /sequential
 /macrodef

Re: Build failed in Jenkins: flex-sdk_mustella-mobile #20

2013-07-02 Thread Alex Harui

Erik,

I don't know how to use any of the editors on the VM that support unix
line endings, but the jenkins.sh for mobile has an error where it isn't
setting target_os_name in local.properties, but rather arget_os_name.

I still got about 20 failures that I'm looking at, but fixing jenkins.sh
should fix most of these errors.

-Alex

On 7/1/13 3:13 PM, flex.muste...@gmail.com flex.muste...@gmail.com
wrote:

See http://localhost:8080/job/flex-sdk_mustella-mobile/20/

--
[...truncated 24173 lines...]
 [java] mobile/components/TextArea/Styles/TextArea_styles_tester
TextArea_letterSpacing_test1 Failed CompareBitmap(body:step 3)  compare
returned-3
 [java] mobile/components/TextArea/Styles/TextArea_styles_tester
TextArea_letterSpacing_test2 Failed CompareBitmap(body:step 3)  compare
returned-3
 [java] mobile/components/TextArea/Styles/TextArea_styles_tester
TextArea_letterSpacing_test3 Failed CompareBitmap(body:step 4)  compare
returned-3
 [java] mobile/components/TextArea/Styles/TextArea_styles_tester
TextArea_fontFamily_test1 Failed CompareBitmap(body:step 3)  compare
returned-3
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectAll_test1 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectRange_test1 Failed CompareBitmap(body:step 2)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectRange_test3 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectRange_test4 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectRange_test5 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectRange_test6 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_selectRange_test7 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test1 Failed CompareBitmap(body:step 5)  compare
returned-4
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test2 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit ..., expected
Lorem ipsum d...
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test3 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit ..., expected
Lorem ipsum d...
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test4 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit ..., expected
Lorem ipsum d...
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test5 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit a , expected
Lorem ipsum do
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test6 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor s§¥©, expected
Lorem ipsu§¥©
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test7 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit a, expected
Lorem ipsum dol
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test8 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit a, expected
Lorem ipsum dol
 [java] mobile/components/TextInput/Methods/TextInput_Methods_tester
TextInput_truncateToFit_test9 Failed AssertMethodValue (method cannot be
shown)(body:step 4)  method returned Lorem ipsum dolor sit a, expected
Lorem ipsum dol
 [java]
mobile/components/TextInput/Properties/TextInput_properties_tester
TextInput_basic_prompt Failed CompareBitmap(body:step 3)  compare
returned-3
 [java]
mobile/components/TextInput/Properties/TextInput_properties_tester
TextInput_prompt_disappears Failed CompareBitmap(body:step 7)  compare
returned-3
 [java]
mobile/components/TextInput/Properties/TextInput_properties_tester
TextInput_prompt_returns_on_text_removal Failed CompareBitmap(body:step
10)  compare returned-3
 [java]
mobile/components/TextInput/Properties/TextInput_properties_tester
TextInput_displayAsPassword_test2 Failed CompareBitmap(body:step 2)
compare returned-3
 [java]
mobile/components/TextInput/Properties/TextInput_properties_tester

Mustella Tests are failing.

2013-06-30 Thread Alex Harui

Hi,

While we're still ironing out the mustella test server, some tests are now
breaking for me.  I think sometime in the last couple of days some checkin
broke tests in:

Managers/StyleManager/AdvancedCSS
Components/DateField
Gumbo/components/FTETextField.

If you've made changes recently could you review your changes?

-Alex

Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - Fix for older version of AIR (including Linux)

2013-05-30 Thread Alex Harui

Minor nit: I think at one point we were told to use in instead of
hasOwnProperty for non-dynamic instances, e.g. if (renderMode in init)

On 5/30/13 6:18 PM, jmcl...@apache.org jmcl...@apache.org wrote:

Fix for older version of AIR (including Linux)


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f0e7a947
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f0e7a947
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f0e7a947

Branch: refs/heads/develop
Commit: f0e7a947e2e9d36e08b276d7712b75e975713655
Parents: dd14ffc
Author: Justin Mclean jmcl...@apache.org
Authored: Fri May 31 11:17:55 2013 +1000
Committer: Justin Mclean jmcl...@apache.org
Committed: Fri May 31 11:17:55 2013 +1000

--
 .../airspark/src/spark/components/Window.as|3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f0e7a947/frameworks/p
rojects/airspark/src/spark/components/Window.as
--
diff --git a/frameworks/projects/airspark/src/spark/components/Window.as
b/frameworks/projects/airspark/src/spark/components/Window.as
index cc7db12..725c3cf 100644
--- a/frameworks/projects/airspark/src/spark/components/Window.as
+++ b/frameworks/projects/airspark/src/spark/components/Window.as
@@ -1774,7 +1774,8 @@ public class Window extends SkinnableContainer
implements IWindow
 init.type = _type;
 init.systemChrome = _systemChrome;
 init.transparent = _transparent;
-init.renderMode = _renderMode;
+  if (init.hasOwnProperty(renderMode))
+  init[renderMode] = _renderMode;
 return init;
 }

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-16857 Fixed RTE when adding items after setting sort to null

2013-05-14 Thread Alex Harui

Justin,

Thanks for dealing with the DateValidator failure.  I have another one for
you.  

This change is causing a failure in the mustella test:
tests/gumbo/components/DataGrid/Properties/DataGrid_Properties_sortable
column_withEditor_test002.  Did this test pass for you?

I looked at FLEX-16857, and IMO, it is not a bug.  The code is not calling
refresh after setting sort = null and before adding items.  I haven't tried
it, but I suspect that would avoid the error.  The documentation is pretty
clear that calling refresh() is required, although I suppose we could update
the doc to further specify that this is true even when setting sort = null.

On the other hand, the Spark DG is doing something questionable.  When the
GridItemEditor goes to save the new data, the editor saves any current sort,
sets sort = null, then saves the new, then restores the sort and does not
call refresh().  As far as I can tell, this is an attempt to retain the
position of the edited item in the Grid.  I guess they didn't want the Grid
to jump to a new position or have the edited item disappear off-screen if
the new data caused the sort to move the item in the collection.  Because
this change sets localIndex = null right when sort = null, the localIndex is
tossed and the new order is unsorted order and the test fails.

So, I think there are two options:
1) verify that refresh() avoids the RTE in FLEX-16857, revert this change
and maybe update the doc
2) change the behavior of Spark DG when you edit an item in the sort column.

Thoughts?  I'm pretty sure MX DG jumps around when you edit an item in the
sort column, but this would be a change in behavior for Spark DG users.

I'd probably choose #1 as maybe there are other folks relying on localIndex
staying around until you call refresh(), but if you feel strongly that
ListCollectionView should be more tolerant of setting sort=null and not
calling refresh() and it is ok to change behavior on Spark DG users, I'd be
ok with that (and of course, would pass an complaints on to you :-)).

-Alex

On 5/10/13 5:36 PM, jmcl...@apache.org jmcl...@apache.org wrote:

 Updated Branches:
   refs/heads/develop 9f21583b8 - 3b98c1d09
 
 
 FLEX-16857 Fixed RTE when adding items after setting sort to null
 
 
 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
 Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3b98c1d0
 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3b98c1d0
 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3b98c1d0
 
 Branch: refs/heads/develop
 Commit: 3b98c1d096742c4f35b51f28ead2e6827677960a
 Parents: 9f21583
 Author: Justin Mclean jmcl...@apache.org
 Authored: Sat May 11 10:34:47 2013 +1000
 Committer: Justin Mclean jmcl...@apache.org
 Committed: Sat May 11 10:34:47 2013 +1000
 
 --
  .../src/mx/collections/ListCollectionView.as   |4 
  1 files changed, 4 insertions(+), 0 deletions(-)
 --
 
 
 http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3b98c1d0/frameworks/proje
 cts/framework/src/mx/collections/ListCollectionView.as
 --
 diff --git 
 a/frameworks/projects/framework/src/mx/collections/ListCollectionView.as
 b/frameworks/projects/framework/src/mx/collections/ListCollectionView.as
 index afce033..dcffed1 100644
 --- a/frameworks/projects/framework/src/mx/collections/ListCollectionView.as
 +++ b/frameworks/projects/framework/src/mx/collections/ListCollectionView.as
 @@ -378,6 +378,10 @@ public class ListCollectionView extends Proxy
  public function set sort(s:ISort):void
  {
  _sort = s;
 +  
 +  if (s == null)
 +   localIndex = null;
 +  
  dispatchEvent(new Event(sortChanged));
  }
  
 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

2013-05-13 Thread Alex Harui

Justin,

This change is causing Mustella tests to fail for me in
tests/RuntimeLocalization/RTL_SparkSkins/Modules.

Did these tests pass for you?

The tests only compile in fr_FR, then set en_US in the locale chain before
loading a resource module containing US resources.

I tried setting the locale chain after the US resources get loaded, but the
last test is trying to prove that you can load a resource module without
automatically forcing the resources to update and setting the locale chain
after loading causes that update.  Also, there could be apps out there
counting on this behavior.

Thoughts?  Maybe the bug associated with this fix [1] just needs some sort
of check if the resource contains formatting characters?

[1] https://issues.apache.org/jira/browse/FLEX-17210

-Alex


On 4/30/13 5:26 PM, jmcl...@apache.org jmcl...@apache.org wrote:

 Updated Branches:
   refs/heads/develop 4738923f3 - ae28ab34c
 
 
 FLEX-17210 Added check to see if locale exists when changing localeChain
 
 
 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
 Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ae28ab34
 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ae28ab34
 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ae28ab34
 
 Branch: refs/heads/develop
 Commit: ae28ab34c558957927471d54ce2a0ca6aace6207
 Parents: 4738923
 Author: Justin Mclean jmcl...@apache.org
 Authored: Wed May 1 10:26:02 2013 +1000
 Committer: Justin Mclean jmcl...@apache.org
 Committed: Wed May 1 10:26:02 2013 +1000
 
 --
  .../src/mx/resources/ResourceManagerImpl.as|9 +
  1 files changed, 9 insertions(+), 0 deletions(-)
 --
 
 
 http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ae28ab34/frameworks/proje
 cts/framework/src/mx/resources/ResourceManagerImpl.as
 --
 diff --git 
 a/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as
 b/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as
 index c138a9b..ef01ea6 100644
 --- a/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as
 +++ b/frameworks/projects/framework/src/mx/resources/ResourceManagerImpl.as
 @@ -225,6 +225,15 @@ public class ResourceManagerImpl extends EventDispatcher
 implements IResourceMan
  public function set localeChain(value:Array /* of String */):void
  {
  _localeChain = value;
 +  
 +  for each (var locale:String in value)
 +  {
 +   if (!localeMap.hasOwnProperty(locale))
 +   {
 +throw new Error(
 + Could not find compiled locale ' + locale + '.); 
 +   }
 +  }
  
  update();
  }
 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread Alex Harui




On 5/13/13 6:47 PM, jmcl...@apache.org jmcl...@apache.org wrote:

 AdvancedDataGridBase implements IIME
  
  /**
   *  @private
 +  * 
 +  * Note columns may not of been committed at this point.
Shouldn't this be ...may not have been...?

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise

2013-05-10 Thread Alex Harui

Just happened to notice and wonder:  If you are changing from getting the
uid from the data to getting the uid from the item, shoud the
ListSelectionData on the next line be associated with the item instead of
data?


On 5/9/13 6:27 PM, jmcl...@apache.org jmcl...@apache.org wrote:

 Updated Branches:
   refs/heads/develop 670532045 - 6838f9595
 
 
 FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise
 
 
 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
 Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6838f959
 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6838f959
 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6838f959
 
 Branch: refs/heads/develop
 Commit: 6838f95954afc32ba7a9404a454ce8aac5846de5
 Parents: 6705320
 Author: Justin Mclean jmcl...@apache.org
 Authored: Fri May 10 11:26:47 2013 +1000
 Committer: Justin Mclean jmcl...@apache.org
 Committed: Fri May 10 11:26:47 2013 +1000
 
 --
  .../mx/src/mx/controls/listClasses/ListBase.as |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 --
 
 
 http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6838f959/frameworks/proje
 cts/mx/src/mx/controls/listClasses/ListBase.as
 --
 diff --git a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
 b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
 index 238d8e8..4e5c49d 100644
 --- a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
 +++ b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
 @@ -7395,7 +7395,7 @@ public class ListBase extends ScrollControlBase
  item = items[i];
  if (compareFunction(data, item))
  {
 -uid = itemToUID(data);
 +uid = itemToUID(item);
  
  selectionDataArray[proposedSelectedItemIndexes[uid]]
 = new ListBaseSelectionData(data, index, false);
  
 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: git commit: [flex-asjs] [refs/heads/develop] - RadioButtons for jQuery. RadioButtons cannot be programmatically added due to a known jQuery bug (documented in the RadioButton.js file).

2013-05-09 Thread Alex Harui

() {
 +return this.labelFor.innerHTML;
  };


 @@ -90,9 +193,8 @@
 org.apache.flex.jquery.staticControls.RadioButton.prototype.get_text =
   * @this {org.apache.flex.jquery.staticControls.RadioButton}
   * @param {string} value The text setter.
   */
 -org.apache.flex.jquery.staticControls.RadioButton.prototype.set_text =
 -function(value) {
 -  this.element.childNodes.item(1).nodeValue = value;
 +org.apache.flex.jquery.staticControls.RadioButton.prototype.set_text =
 function(value) {
 +   this.labelFor.innerHTML = value;
  };


 @@ -101,9 +203,8 @@
 org.apache.flex.jquery.staticControls.RadioButton.prototype.set_text =
   * @this {org.apache.flex.jquery.staticControls.RadioButton}
   * @return {bool} The selected getter.
   */
 -org.apache.flex.jquery.staticControls.RadioButton.prototype.get_selected =
 -function() {
 -  return this.element.childNodes.item(0).checked;
 +org.apache.flex.jquery.staticControls.RadioButton.prototype.get_selected =
 function() {
 +return this.element.checked;
  };


 @@ -112,7 +213,6 @@
 org.apache.flex.jquery.staticControls.RadioButton.prototype.get_selected =
   * @this {org.apache.flex.jquery.staticControls.RadioButton}
   * @param {bool} value The selected setter.
   */
 -org.apache.flex.jquery.staticControls.RadioButton.prototype.set_selected =
 -function(value) {
 -  this.element.childNodes.item(0).checked = value;
 +org.apache.flex.jquery.staticControls.RadioButton.prototype.set_selected =
 function(value) {
 +this.element.checked = value;
  };


--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-26048 check if date range actually contains dates

2013-05-06 Thread Alex Harui

FWIW, at Adobe, the philosophy was to not do much input checking.
Garbage-in, Garbage Out.  If you pass in garbage, it is ok to get an
exception thrown back at you.  Theoretically, folks debug their code to the
point where it won't need these checks in production.  Sure, any individual
check is small and probably leads to better developer productivity, but they
all add up to a bigger and slower runtime when they shouldn't be needed.

In fact, one of my hopes for FlexJS and its beads is to make it possible
for folks to swap in debug-mode beads that do have helpful input checking
and then swap in production-mode beads later.


On 5/5/13 11:32 PM, jmcl...@apache.org jmcl...@apache.org wrote:

 Updated Branches:
   refs/heads/develop 659a9234f - 63bd807f8
 
 
 FLEX-26048 check if date range actually contains dates
 
 
 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
 Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/63bd807f
 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/63bd807f
 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/63bd807f
 
 Branch: refs/heads/develop
 Commit: 63bd807f8e087e164d5b6fce846bc4a917f3f140
 Parents: 659a923
 Author: Justin Mclean jmcl...@apache.org
 Authored: Mon May 6 16:21:31 2013 +1000
 Committer: Justin Mclean jmcl...@apache.org
 Committed: Mon May 6 16:21:31 2013 +1000
 
 --
  .../projects/mx/src/mx/controls/DateChooser.as |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 --
 
 
 http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/63bd807f/frameworks/proje
 cts/mx/src/mx/controls/DateChooser.as
 --
 diff --git a/frameworks/projects/mx/src/mx/controls/DateChooser.as
 b/frameworks/projects/mx/src/mx/controls/DateChooser.as
 index 27fe888..ed05856 100644
 --- a/frameworks/projects/mx/src/mx/controls/DateChooser.as
 +++ b/frameworks/projects/mx/src/mx/controls/DateChooser.as
 @@ -3120,14 +3120,14 @@ public class DateChooser extends UIComponent
 implements IFocusManagerComponent,
  else if (value is Object)
  {
  var range:Object = {};
 -if (value.rangeStart)
 +if (value.hasOwnProperty(rangeStart)  value.rangeStart is
 Date)
  {
  range.rangeStart = new Date(value.rangeStart.getFullYear(),
  value.rangeStart.getMonth(),
  value.rangeStart.getDate());
  }
  
 -if (value.rangeEnd)
 +if (value.hasOwnProperty(rangeEnd)  value.rangeEnd is Date)
  {
  range.rangeEnd = new Date(value.rangeEnd.getFullYear(),
value.rangeEnd.getMonth(),
 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33524: Added convenience feature to enable/disable buttons in a ButtonBar/TabBar.

2013-05-02 Thread Alex Harui

/code.
 +*
 +*  pThe function takes a single argument which is the ButtonBarButtons
 label./p
 +*  premyButtonBar.enableButton(My Button Label)/pre
 +*
 +*  @param labelValue Is the ButtonBarButton label
 +*  @param fieldName Field used for comparing the label
 +*
 +*  @langversion 3.0
 +*  @playerversion Flash 11.1
 +*  @playerversion AIR 3.4
 +*  @productversion Flex 4.10
 +*/
 +public function enableButton(labelValue:String, fieldName:String =
 ):void
 +{
 +var btnCurrent:ButtonBarButton = null;
 +var buttonIndex:int = -1;
 +
 +
 +if (!dataGroup || labelValue ==  || labelValue == null)
 +{
 +return;
 +}
 +
 +if (fieldName ==  || fieldName == null)
 +{
 +buttonIndex = findRowIndex(labelField, labelValue);
 +}
 +else
 +{
 +buttonIndex = findRowIndex(fieldName, labelValue);
 +}
 +
 +if (buttonIndex == -1)
 +{
 +return;
 +}
 +
 +
 +btnCurrent = dataGroup.getElementAt(buttonIndex) as ButtonBarButton;
 +btnCurrent.enabled = true;
 +}
 +
 +
 +/**
 +*  Disables several of a ButtonBar's Buttons, referencing them by the
 ButtonBarbutton's codelabel/code.
 +*
 +*  pThe function takes a single argument which is the ButtonBarButtons
 label./p
 +*  premyButtonBar.enableButtons([My Button Label1, My
 Label2])/pre
 +*
 +*  @param labelValues Is an array of ButtonBarButton labels.
 +*  @param fieldName Field used for comparing the label
 +*
 +*  @langversion 3.0
 +*  @playerversion Flash 11.1
 +*  @playerversion AIR 3.4
 +*  @productversion Flex 4.10
 +*/
 +public function enableButtons(labelValues:Array, fieldName:String =
 ):void
 +{
 +var btnCurrent:ButtonBarButton = null;
 +var buttonIndices:Array;
 +var indicesTotal:uint = 0;
 +var loopingIndex:uint = 0;
 +
 +
 +if (!dataGroup || labelValues.length  1 || labelValues == null)
 +{
 +return;
 +}
 +
 +if (fieldName ==  || fieldName == null)
 +{
 +buttonIndices = findRowIndices(labelField, labelValues);
 +}
 +else
 +{
 +buttonIndices = findRowIndices(fieldName, labelValues);
 +}
 +
 +
 +indicesTotal = buttonIndices.length
 +
 +if (indicesTotal == 0)
 +{
 +return;
 +}
 +
 +
 +for (loopingIndex; loopingIndex  indicesTotal; loopingIndex++)
 +{
 +btnCurrent = dataGroup.getElementAt(buttonIndices[loopingIndex])
 as ButtonBarButton;
 +btnCurrent.enabled = true;
 +}
 +}
 +
 +
  /**
   *  @private
   */
 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Re: [ApacheFlexTest/whiteboard] a208d5: Testing email notification to Github whiteboard

2013-04-30 Thread Alex Harui

Nice!

Can you detail the steps required for each committer to get set up?
Are there naming conventions we are going to use?
Are all committer whiteboards under some folder in GitHub or anywhere?

-Alex

On 4/30/13 11:11 AM, OmPrakash Muppirala bigosma...@gmail.com wrote:

 Alright, looks like the commit notifications from GitHub are working now.
  Notice that the email is sent from my apache.org alias.  This keeps it
 consistent with the email notifications that Apache's Git sends out.
 
 What next?
 
 Thanks,
 Om
 
 On Tue, Apr 30, 2013 at 11:08 AM, bigosmallm bigosma...@apache.org wrote:
 
   Branch: refs/heads/master
   Home:   https://github.com/ApacheFlexTest/whiteboard
   Commit: a208d5036126f4b33935d35b7d614b128ea0e86c
 
 https://github.com/ApacheFlexTest/whiteboard/commit/a208d5036126f4b33935d35b7
 d614b128ea0e86c
   Author: bigosmallm bigosma...@apache.org
   Date:   2013-04-30 (Tue, 30 Apr 2013)
 
   Changed paths:
 M README.md
 
   Log Message:
   ---
   Testing email notification to Github whiteboard
 
 
 
 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

RE: Build failed in Jenkins: flex-sdk_mustella #460

RE: Build failed in Jenkins: flex-sdk_mustella #460

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33307: adding these arguments makes most of the warnings and some of the errors go away. Baby steps ; -)

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33307: adding these arguments makes most of the warnings and some of the errors go away. Baby steps ; -)

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33713: An NPE is thrown by this code when compiling 'spark.swc' from the SDK. The null check bypasses the issue, it doesn't do anything to fix

Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-33740 made removedFromStageHandler protected so it could be overridden

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33702: Added column sort type access to the datagrid columns.

Re: git commit: [flex-sdk] [refs/heads/develop] - Fixed build version number not being injected into configuration file

Re: Build failed in Jenkins: flex-sdk_mustella-mobile #20

Mustella Tests are failing.

Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - Fix for older version of AIR (including Linux)

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-16857 Fixed RTE when adding items after setting sort to null

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise

Re: git commit: [flex-asjs] [refs/heads/develop] - RadioButtons for jQuery. RadioButtons cannot be programmatically added due to a known jQuery bug (documented in the RadioButton.js file).

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-26048 check if date range actually contains dates

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33524: Added convenience feature to enable/disable buttons in a ButtonBar/TabBar.

Re: [ApacheFlexTest/whiteboard] a208d5: Testing email notification to Github whiteboard

< 1 2

101 - 119 of 119 matches

Site Navigation

Mail list logo

Footer information