[2/2] git commit: [flex-utilities] [refs/heads/develop] - Native application updater is now donated
Native application updater is now donated Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/e6302faa Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/e6302faa Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/e6302faa Branch: refs/heads/develop Commit: e6302faa6066362f54f9aaa16f38648f27284064 Parents: ca69d65 Author: Justin Mclean Authored: Sat Apr 21 10:24:17 2018 +1000 Committer: Justin Mclean Committed: Sat Apr 21 10:24:17 2018 +1000 -- flex-installer/LICENSE | 6 -- 1 file changed, 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/e6302faa/flex-installer/LICENSE -- diff --git a/flex-installer/LICENSE b/flex-installer/LICENSE index 9590971..88074ed 100644 --- a/flex-installer/LICENSE +++ b/flex-installer/LICENSE @@ -211,9 +211,3 @@ conditions of the following licenses. The Open-Sans font is available under Apache License 2.0. For details see common/src/assets/fonts/open-sans/ - -The NativeApplicationUpdater is available under Apache License 2.0. -For details see installer/src/com/riaspace/ - - -
[1/2] git commit: [flex-utilities] [refs/heads/develop] - Revert "Add 3rd party headers to comply with ASF legal policy"
Repository: flex-utilities Updated Branches: refs/heads/develop d430ae4f9 -> e6302faa6 Revert "Add 3rd party headers to comply with ASF legal policy" This reverts commit df0db8756bcca2941aa155231c9e8f640010a813. Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/ca69d65a Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/ca69d65a Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/ca69d65a Branch: refs/heads/develop Commit: ca69d65aa861811ec94e73e7edc2b77a0e67c3e4 Parents: d430ae4 Author: Justin Mclean Authored: Sat Apr 21 10:21:52 2018 +1000 Committer: Justin Mclean Committed: Sat Apr 21 10:21:52 2018 +1000 -- .../NativeApplicationUpdater.as | 25 ++-- .../UpdaterErrorCodes.as| 25 ++-- .../utils/HdiutilHelper.as | 25 ++-- 3 files changed, 36 insertions(+), 39 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/ca69d65a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as -- diff --git a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as index b04d21a..b405aa7 100644 --- a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as +++ b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as @@ -1,23 +1,22 @@ // -// Copyright 2011 Piotr Walczyszyn or Adobe +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at // -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at +// http://www.apache.org/licenses/LICENSE-2.0 // -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. // -// orginal code can be found at https://code.google.com/archive/p/nativeapplicationupdater/ - package com.riaspace.nativeApplicationUpdater { import air.update.events.DownloadErrorEvent; http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/ca69d65a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as -- diff --git a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as index 6725305..5dd0cc6 100644 --- a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as +++ b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as @@ -1,23 +1,22 @@ // -// Copyright 2011 Piotr Walczyszyn or Adobe +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at // -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use t
[1/2] git commit: [flex-utilities] [refs/heads/develop] - Add 3rd party headers to comply with ASF legal policy
Repository: flex-utilities Updated Branches: refs/heads/develop 55c4f6698 -> d430ae4f9 Add 3rd party headers to comply with ASF legal policy Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/df0db875 Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/df0db875 Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/df0db875 Branch: refs/heads/develop Commit: df0db8756bcca2941aa155231c9e8f640010a813 Parents: 2d8b8f5 Author: Justin Mclean Authored: Fri Apr 20 16:42:42 2018 +1000 Committer: Justin Mclean Committed: Fri Apr 20 16:42:42 2018 +1000 -- .../NativeApplicationUpdater.as | 25 ++-- .../UpdaterErrorCodes.as| 25 ++-- .../utils/HdiutilHelper.as | 25 ++-- 3 files changed, 39 insertions(+), 36 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/df0db875/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as -- diff --git a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as index b405aa7..b04d21a 100644 --- a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as +++ b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/NativeApplicationUpdater.as @@ -1,22 +1,23 @@ // -// Licensed to the Apache Software Foundation (ASF) under one or more -// contributor license agreements. See the NOTICE file distributed with -// this work for additional information regarding copyright ownership. -// The ASF licenses this file to You under the Apache License, Version 2.0 -// (the "License"); you may not use this file except in compliance with -// the License. You may obtain a copy of the License at +// Copyright 2011 Piotr Walczyszyn or Adobe // -// http://www.apache.org/licenses/LICENSE-2.0 +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at // -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. // +// orginal code can be found at https://code.google.com/archive/p/nativeapplicationupdater/ + package com.riaspace.nativeApplicationUpdater { import air.update.events.DownloadErrorEvent; http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/df0db875/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as -- diff --git a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as index 5dd0cc6..6725305 100644 --- a/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as +++ b/flex-installer/installer/src/com/riaspace/nativeApplicationUpdater/UpdaterErrorCodes.as @@ -1,22 +1,23 @@ // -// Licensed to the Apache Software Foundation (ASF) under one or more -// contributor license agreements. See the NOTICE file distributed with -// this work for additional information regarding copyright ownership. -// The ASF licenses this file to You under the Apache License, Version 2.0 -// (the "License"); you may not use this file except in compliance with -// the License. You may obtain a copy of the License at +// Copyright 2011 Piotr Walczyszyn or Adobe // -// http://www.apache.org/licenses/LICENSE-2.0 +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in c
[2/2] git commit: [flex-utilities] [refs/heads/develop] - Merge remote-tracking branch 'origin/develop' into develop
Merge remote-tracking branch 'origin/develop' into develop Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/d430ae4f Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/d430ae4f Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/d430ae4f Branch: refs/heads/develop Commit: d430ae4f9bbe3d55dc2954c93a75b55c14c21ea3 Parents: df0db87 55c4f66 Author: Justin Mclean Authored: Fri Apr 20 18:52:07 2018 +1000 Committer: Justin Mclean Committed: Fri Apr 20 18:52:07 2018 +1000 -- flex-installer/RELEASE_NOTES | 271 +++--- 1 file changed, 138 insertions(+), 133 deletions(-) --
git commit: [flex-utilities] [refs/heads/develop] - Use correct header
Repository: flex-utilities Updated Branches: refs/heads/develop 50e3f79b4 -> 2d8b8f531 Use correct header Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/2d8b8f53 Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/2d8b8f53 Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/2d8b8f53 Branch: refs/heads/develop Commit: 2d8b8f53129e53a0024fb00dc835680da08cb7ee Parents: 50e3f79 Author: Justin Mclean Authored: Thu Apr 19 15:30:54 2018 +1000 Committer: Justin Mclean Committed: Thu Apr 19 15:30:54 2018 +1000 -- flex-installer/installer/sign_and_hash.sh | 29 ++ 1 file changed, 16 insertions(+), 13 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/2d8b8f53/flex-installer/installer/sign_and_hash.sh -- diff --git a/flex-installer/installer/sign_and_hash.sh b/flex-installer/installer/sign_and_hash.sh index 0e2d3c2..c5719f3 100644 --- a/flex-installer/installer/sign_and_hash.sh +++ b/flex-installer/installer/sign_and_hash.sh @@ -1,18 +1,21 @@ #!/bin/sh #-- -# Copyright 2004 The Apache Software Foundation -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. #-- # $Id$ #
git commit: [flex-utilities] [refs/heads/develop] - Update year to current one
Repository: flex-utilities Updated Branches: refs/heads/develop 18442a245 -> 50e3f79b4 Update year to current one Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/50e3f79b Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/50e3f79b Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/50e3f79b Branch: refs/heads/develop Commit: 50e3f79b4a9c2dd2dfdae2e4f32e9c82d1a085a8 Parents: 18442a2 Author: Justin Mclean Authored: Thu Apr 19 14:04:34 2018 +1000 Committer: Justin Mclean Committed: Thu Apr 19 14:04:34 2018 +1000 -- flex-installer/installer/src/InstallApacheFlex-app.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/50e3f79b/flex-installer/installer/src/InstallApacheFlex-app.xml -- diff --git a/flex-installer/installer/src/InstallApacheFlex-app.xml b/flex-installer/installer/src/InstallApacheFlex-app.xml index aaad742..19a6c84 100644 --- a/flex-installer/installer/src/InstallApacheFlex-app.xml +++ b/flex-installer/installer/src/InstallApacheFlex-app.xml @@ -55,7 +55,7 @@ - Copyright 2014 The Apache Software Foundation. + Copyright 2018 The Apache Software Foundation.
git commit: [flex-utilities] [refs/heads/develop] - Update year
Repository: flex-utilities Updated Branches: refs/heads/develop 7c19a4d41 -> 18442a245 Update year Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/18442a24 Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/18442a24 Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/18442a24 Branch: refs/heads/develop Commit: 18442a245e47ea65795fbe78f9d9225b47aa8dc1 Parents: 7c19a4d Author: Justin Mclean Authored: Thu Apr 19 09:28:38 2018 +1000 Committer: Justin Mclean Committed: Thu Apr 19 09:28:38 2018 +1000 -- flex-installer/NOTICE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/18442a24/flex-installer/NOTICE -- diff --git a/flex-installer/NOTICE b/flex-installer/NOTICE index 7f153f8..a73c3f6 100644 --- a/flex-installer/NOTICE +++ b/flex-installer/NOTICE @@ -1,5 +1,5 @@ Apache Flex -Copyright [2012-2017] The Apache Software Foundation +Copyright [2012-2018] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/).
git commit: [flex-sdk] [refs/heads/develop] - Ignore failure on copying flash flex kit as it doesn't exist on linux. May be a better way of doing this as it could hide other failures.
Repository: flex-sdk Updated Branches: refs/heads/develop d63dadf1d -> 9e3619cd9 Ignore failure on copying flash flex kit as it doesn't exist on linux. May be a better way of doing this as it could hide other failures. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9e3619cd Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9e3619cd Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9e3619cd Branch: refs/heads/develop Commit: 9e3619cd9edb4b120bb4d1ea4e5636b4e84208e4 Parents: d63dadf Author: Justin Mclean Authored: Sun Dec 31 11:29:36 2017 +1100 Committer: Justin Mclean Committed: Sun Dec 31 11:29:36 2017 +1100 -- build.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9e3619cd/build.xml -- diff --git a/build.xml b/build.xml index 517bcc2..a9edc9a 100644 --- a/build.xml +++ b/build.xml @@ -920,7 +920,7 @@ There are no known issues. - + @@ -947,7 +947,7 @@ There are no known issues. - +
[04/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35260 GridHeaderViewLayout.getHeaderIndexAt() (which calls GridDimensions.getColumnIndexAt()) used to return a valid headerIndex (when it was
FLEX-35260 GridHeaderViewLayout.getHeaderIndexAt() (which calls GridDimensions.getColumnIndexAt()) used to return a valid headerIndex (when it was expected to return -1) for an y < 0. Fixed. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f985937c Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f985937c Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f985937c Branch: refs/heads/master Commit: f985937c08a261e8da91c0fc8a905ca0ddbbc842 Parents: 2adccce Author: Mihai Chira Authored: Fri Mar 10 18:21:44 2017 +0100 Committer: Mihai Chira Committed: Fri Mar 10 18:21:44 2017 +0100 -- .../gridClasses/GridDimensionsView.as | 4 ++-- .../gridClasses/GridHeaderViewLayout.as | 25 +++- 2 files changed, 16 insertions(+), 13 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f985937c/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensionsView.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensionsView.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensionsView.as index fe7b55a..e5444a6 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensionsView.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensionsView.as @@ -225,9 +225,9 @@ public class GridDimensionsView return rowIndex >= 0 ? rowIndex : -1; } -public function getColumnIndexAt(viewX:Number, viewY:Number):int +public function getColumnIndexAt(localX:Number, localY:Number):int { -const columnIndex:int = gridDimensions.getColumnIndexAt(viewX + viewOriginX, viewY + viewOriginY) - viewColumnIndex; +const columnIndex:int = gridDimensions.getColumnIndexAt(localX + viewOriginX, localY + viewOriginY) - viewColumnIndex; return columnIndex >= 0 ? columnIndex : -1; } http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f985937c/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as index 4dd36b8..ef79a02 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as @@ -503,21 +503,24 @@ public class GridHeaderViewLayout extends LayoutBase var headerIndex:int = -1; var globalPoint:Point = gridColumnHeaderGroup.localToGlobal(new Point(x, y)); -if(!gridColumnHeaderGroup.areCoordinatesOverLeftPadding(globalPoint)) +if(gridColumnHeaderGroup.containsGlobalCoordinates(globalPoint)) { -var paddingLeftStyle:Number = gridColumnHeaderGroup.getStyle("paddingLeft"); -var paddingLeft:Number = isNaN(paddingLeftStyle) ? 0 : paddingLeftStyle; - -headerIndex = gridView.gridViewLayout.gridDimensionsView.getColumnIndexAt(x - paddingLeft + horizontalScrollPosition, y); - -if(headerIndex == -1 && gridColumnHeaderGroup.containsGlobalCoordinates(globalPoint)) + if(!gridColumnHeaderGroup.areCoordinatesOverLeftPadding(globalPoint)) { -//then the point is either over the right padding, over the width of the vertical -//scroll bar, or over the space between the last separator and the width of the grid -headerIndex = grid.getPreviousVisibleColumnIndex(columnsView.length); +var paddingLeftStyle:Number = gridColumnHeaderGroup.getStyle("paddingLeft"); +var paddingLeft:Number = isNaN(paddingLeftStyle) ? 0 : paddingLeftStyle; + +headerIndex = gridView.gridViewLayout.gridDimensionsView.getColumnIndexAt(x - paddingLeft + horizontalScrollPosition, y); + +if(headerIndex == -1) +{ +//then the point is either over the right padding, over the width of the vertical +//scroll bar, or over the space between the last separator and the width of the grid +headerIndex = grid.getPreviousVisibleColumnIndex(columnsView.length); +} } } - + return headerIndex; }
[28/50] git commit: [flex-sdk] [refs/heads/master] - Merge remote-tracking branch 'origin/develop' into develop
Merge remote-tracking branch 'origin/develop' into develop Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/fea9be98 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/fea9be98 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/fea9be98 Branch: refs/heads/master Commit: fea9be98df7c60b75b1d1141e568012c5622e2c5 Parents: 0226437 bb7447f Author: Mihai Chira Authored: Tue Jun 27 09:21:18 2017 +0200 Committer: Mihai Chira Committed: Tue Jun 27 09:21:18 2017 +0200 -- RELEASE_NOTES | 42 .../macromedia/asc/embedding/LintEvaluator.java | 8 +++- 2 files changed, 49 insertions(+), 1 deletion(-) --
[02/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35267 FLEX-35260 FLEX-35029 1. GridHeaderViewLayout.getHeaderIndexAt() now verifies if the coordinates are over the GridColumnHeaderView's lef
FLEX-35267 FLEX-35260 FLEX-35029 1. GridHeaderViewLayout.getHeaderIndexAt() now verifies if the coordinates are over the GridColumnHeaderView's left or right padding. 2. Renamed GridColumnHeaderGroup.mouseEventHeaderView() to getHeaderViewUnderGlobalCoordinates(), while also changing the parameter to be a Point instead of a MouseEvent. This is so that areCoordinatesOverAHeaderView(), areCoordinatesOverLeftPadding() and areCoordinatesOverRightPadding() can use it too. 3. Expanded some variable names in GridColumnHeaderGroup. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ad482517 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ad482517 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ad482517 Branch: refs/heads/master Commit: ad48251737546e5ae17081044f3051bfbb1997e8 Parents: a603b07 Author: Mihai Chira Authored: Fri Mar 10 17:44:32 2017 +0100 Committer: Mihai Chira Committed: Fri Mar 10 17:44:32 2017 +0100 -- .../spark/components/GridColumnHeaderGroup.as | 66 +++- .../gridClasses/GridColumnHeaderView.as | 9 ++- .../gridClasses/GridHeaderViewLayout.as | 40 +--- 3 files changed, 72 insertions(+), 43 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ad482517/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as -- diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as index 9d5b81d..a9209a1 100644 --- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as +++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as @@ -782,7 +782,40 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement { return (_visibleSortIndicatorIndices.indexOf(columnIndex) != -1); } + +public function containsGlobalCoordinates(coordinates:Point):Boolean +{ +return areCoordinatesOverAHeaderView(coordinates) || areCoordinatesOverPadding(coordinates); +} + +public function areCoordinatesOverAHeaderView(coordinates:Point):Boolean +{ +return getHeaderViewUnderGlobalCoordinates(coordinates) != null; +} + +public function areCoordinatesOverPadding(coordinates:Point):Boolean +{ +return areCoordinatesOverLeftPadding(coordinates) || areCoordinatesOverRightPadding(coordinates); +} + +public function areCoordinatesOverLeftPadding(coordinates:Point):Boolean +{ +var paddingLeftStyle:Number = getStyle("paddingLeft"); +var paddingLeft:Number = isNaN(paddingLeftStyle) ? 0 : paddingLeftStyle; + +return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && +getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x + paddingLeft, coordinates.y)) != null; +} +public function areCoordinatesOverRightPadding(coordinates:Point):Boolean +{ +var paddingRightStyle:Number = getStyle("paddingRight"); +var paddingRight:Number = isNaN(paddingRightStyle) ? 0 : paddingRightStyle; + +return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && +getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y - paddingRight)) != null; +} + //-- // // Methods @@ -804,28 +837,28 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement */ public function configureGridColumnHeaderViews():void { -const ghl:GridHeaderLayout = layout as GridHeaderLayout; -if (!ghl) +const headerLayout:GridHeaderLayout = layout as GridHeaderLayout; +if (!headerLayout) return; - if (ghl.centerGridColumnHeaderView == null) - ghl.centerGridColumnHeaderView = createGridColumnHeaderView(); + if (headerLayout.centerGridColumnHeaderView == null) + headerLayout.centerGridColumnHeaderView = createGridColumnHeaderView(); if (dataGrid.lockedColumnCount > 0) { - ghl.leftGridColumnHeaderView = createGridColumnHeaderView(); + headerLayout.leftGridColumnHeaderView = createGridColumnHeaderView(); } - else if (ghl.leftGridColumnHeaderView) + else if (headerLayout.leftGridColumnHeaderView) { - removeElement(ghl.leftGridColumnHeaderView); -
[10/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35260 Now we are taking into account paddingTop and paddingBottom in getHeaderIndexAt(). Unit test updated as well (and passes, including a se
FLEX-35260 Now we are taking into account paddingTop and paddingBottom in getHeaderIndexAt(). Unit test updated as well (and passes, including a second data grid configuration). Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5787e9ba Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5787e9ba Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5787e9ba Branch: refs/heads/master Commit: 5787e9baf653d3c4f0a7664cb5baaf2103f8387d Parents: 6bc7ad5 Author: Mihai Chira Authored: Thu Mar 16 15:18:10 2017 +0100 Committer: Mihai Chira Committed: Thu Mar 16 15:18:10 2017 +0100 -- .../gridClasses/GridHeaderViewLayout.as | 2 +- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 111 ++- 2 files changed, 61 insertions(+), 52 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5787e9ba/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as index ef79a02..4eac8c7 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as @@ -505,7 +505,7 @@ public class GridHeaderViewLayout extends LayoutBase if(gridColumnHeaderGroup.containsGlobalCoordinates(globalPoint)) { - if(!gridColumnHeaderGroup.areCoordinatesOverLeftPadding(globalPoint)) +if (!gridColumnHeaderGroup.areCoordinatesOverPadding(globalPoint)) { var paddingLeftStyle:Number = gridColumnHeaderGroup.getStyle("paddingLeft"); var paddingLeft:Number = isNaN(paddingLeftStyle) ? 0 : paddingLeftStyle; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5787e9ba/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as index dad721d..9c7bd51 100644 --- a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as +++ b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as @@ -17,34 +17,35 @@ package spark.components.gridClasses { /* Example for two-column table (with no horizontal scroll): + [pt]: GridColumnHeaderGroup padding top [pl]: GridColumnHeaderGroup padding left [lch]: still part of last column header, but beyond last column width - c0: first column header starts here - c1: first column header ends here, second column header (if it exists) starts, and column separator is here - c2: second column header ends here; second column separator is here - ... - cx: last column header ends here; last column separator is here - d0: first column ends at this x-axis coordinate (but the first header doesn't, due to [pl]) - d1: second column ends at this x-axis coordinate + b0: top-left corner of the data grid. Also, first column starts at this x-coordinate + b1: first column ends at this x-coordinate (but the first header usually doesn't, due to [pl]) + b2: second column ends at this x-coordinate (but the second header usually doesn't, due to [pl]) ... - dx: last column ends at this x-axis coordinate - - e: table ends at this x-axis coordinate + bx: last column ends at this x-coordinate - f0: header ends and grid starts at this y-coordinate - f1: first column ends here and second column (if it exists) begins here - f2: second column ends here and third column (if it exists) begins here + c0: first column header starts at this x-coordinate + c1: first column header ends at this x-coordinate, separator starts at this x-coordinate, and + second column header (if it exists) starts at this x-coordinate + separator.width + c1: second column header ends at this x-coordinate, next separator (if it exists) starts at + this x-coordinate, and third column header (if it exists) starts at this x-coordinate + separator.width ... - fx: last column ends here + cx: last column header ends at this x-coordinate; last column separator starts at this x-coordinate + + d: table ends at this x-axis coordinate + e: top-left corner of header. If [pt] and [pl]
[48/50] git commit: [flex-sdk] [refs/heads/master] - Add information to use Extension Manager CS6 which fix problem with hang of Extension Manager CS5 on Windows 10
Add information to use Extension Manager CS6 which fix problem with hang of Extension Manager CS5 on Windows 10 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f1fac8fc Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f1fac8fc Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f1fac8fc Branch: refs/heads/master Commit: f1fac8fcb5d94465f84650b8c3e1de76691a2531 Parents: d242fd9 Author: Piotr Zarzycki Authored: Thu Nov 9 00:21:56 2017 +0100 Committer: Piotr Zarzycki Committed: Thu Nov 9 00:21:56 2017 +0100 -- README | 4 1 file changed, 4 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f1fac8fc/README -- diff --git a/README b/README index 0bd..7aee7d1 100644 --- a/README +++ b/README @@ -215,6 +215,10 @@ flash-integration. On Windows, download the Adobe Extension Manager from: http://download.macromedia.com/pub/dw_exchange/extension_manager/win/AdobeExtensionManager5All.zip + +On Windows 10, download the Adobe Extension Manager CS6 from: + + http://download.macromedia.com/pub/dw_exchange/extension_manager/win/AdobeExtensionManager6_0_8All.zip and set ADOBE_EXTENSION_MANAGER to the absolute path of 'Adobe Extension Manager CS5.exe'
[07/50] git commit: [flex-sdk] [refs/heads/master] - Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/1040357f Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/1040357f Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/1040357f Branch: refs/heads/master Commit: 1040357f69cea18c8a60d4bab32d1066e3847fae Parents: a616e55 f985937 Author: Justin Mclean Authored: Wed Mar 15 15:04:04 2017 +1100 Committer: Justin Mclean Committed: Wed Mar 15 15:04:04 2017 +1100 -- GIT-TEST.txt| 2 +- .../spark/components/GridColumnHeaderGroup.as | 66 +++- .../gridClasses/GridColumnHeaderView.as | 9 +- .../components/gridClasses/GridDimensions.as| 11 +- .../gridClasses/GridDimensionsView.as | 4 +- .../gridClasses/GridHeaderViewLayout.as | 45 +-- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 387 +++ 7 files changed, 473 insertions(+), 51 deletions(-) --
[14/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35280 FLEX-35260 Recent changes to FLEX-35267 made it so that the y value in GridHeaderViewLayout.getHeaderIndexAt() started to be considered,
FLEX-35280 FLEX-35260 Recent changes to FLEX-35267 made it so that the y value in GridHeaderViewLayout.getHeaderIndexAt() started to be considered, when before it was simply ignored. But one caller of this function, GridColumnHeaderGroup.eventToHeaderLocations(), simply used '0' for that argument, instead of the real value, knowing that (before these changes) it wasn't being considered. Now the real value is used. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/60ccf24c Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/60ccf24c Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/60ccf24c Branch: refs/heads/master Commit: 60ccf24cbd641fcac30e27215156e65d4cb0e923 Parents: 7d3073b Author: Mihai Chira Authored: Wed Apr 12 13:34:54 2017 +0200 Committer: Mihai Chira Committed: Wed Apr 12 13:34:54 2017 +0200 -- .../projects/spark/src/spark/components/GridColumnHeaderGroup.as | 2 +- .../spark/src/spark/components/gridClasses/GridColumnHeaderView.as | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/60ccf24c/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as -- diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as index 02f3aac..3d51fd8 100644 --- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as +++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as @@ -1050,7 +1050,7 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement const separatorIndex:int = viewLayout.getSeparatorIndexAt(viewXY.x, 0); headerCP.rowIndex = (separatorIndex != -1) ? separatorIndex + gdv.viewColumnIndex : -1; -headerCP.columnIndex = (separatorIndex == -1) ? viewLayout.getHeaderIndexAt(viewXY.x, 0) + gdv.viewColumnIndex : -1; +headerCP.columnIndex = (separatorIndex == -1) ? viewLayout.getHeaderIndexAt(viewXY.x, viewXY.y) + gdv.viewColumnIndex : -1; headerXY.x = viewXY.x + gdv.viewOriginX; headerXY.y = viewXY.y; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/60ccf24c/frameworks/projects/spark/src/spark/components/gridClasses/GridColumnHeaderView.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridColumnHeaderView.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridColumnHeaderView.as index a836462..aecb7c2 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridColumnHeaderView.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridColumnHeaderView.as @@ -120,7 +120,6 @@ public class GridColumnHeaderView extends Group origin.x -= width; origin.y += verticalScrollPosition; - var headerViewContainsGlobalCoordinates:Boolean = (stageX >= origin.x) && (stageY >= origin.y) && (stageX < (origin.x + width)) && (stageY < (origin.y + height));
[33/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-18746 Adding another unit test which goes to the heart of the bug - the length calculation in HierarchicalCollectionView. (Currently the test
FLEX-18746 Adding another unit test which goes to the heart of the bug - the length calculation in HierarchicalCollectionView. (Currently the test function test_opening_closing_with_Jill_having_no_children_to_begin_with() fails, as expected.) Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5fb2fb63 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5fb2fb63 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5fb2fb63 Branch: refs/heads/master Commit: 5fb2fb634ea856cc0cd4034dc9bc99e4a58219d5 Parents: 7a519a3 Author: Mihai Chira Authored: Tue Aug 15 17:20:48 2017 +0200 Committer: Mihai Chira Committed: Tue Aug 15 17:20:48 2017 +0200 -- .../Tree_FLEX_18746_Collection_Length_Tests.as | 201 +++ .../tests/mx/controls/Tree_FLEX_18746_Tests.as | 6 - 2 files changed, 201 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5fb2fb63/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as -- diff --git a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as new file mode 100644 index 000..1d7a131 --- /dev/null +++ b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as @@ -0,0 +1,201 @@ +package mx.controls { +import flash.events.Event; +import flash.events.EventDispatcher; + +import mx.collections.ArrayCollection; +import mx.core.mx_internal; + +import org.flexunit.asserts.assertEquals; +import org.flexunit.async.Async; +import org.fluint.uiImpersonation.UIImpersonator; + +use namespace mx_internal; + +public class Tree_FLEX_18746_Collection_Length_Tests +{ +private static var noEnterFramesToWait:int = NaN; +private static const _finishNotifier:EventDispatcher = new EventDispatcher(); + +private static var _sut:Tree_; +private static var Sam:TreeItem; +private static var Ana:TreeItem; +private static var Jenny:TreeItem; +private static var Marc:TreeItem; +private static var parentJill:TreeItem; +private static var parentJohn:TreeItem; + + +[Before] +public function setUp():void +{ +Sam = new TreeItem("Sam"); +Ana = new TreeItem("Ana"); +Jenny = new TreeItem("Jenny"); +Marc = new TreeItem("Marc"); + +_sut = new Tree_(); +_sut.width = 200; +_sut.height = 200; + +UIImpersonator.addChild(_sut); +} + +[After] +public function tearDown():void +{ +UIImpersonator.removeAllChildren(); +_sut = null; +} + + +[Test(async, timeout=300)] +public function test_opening_closing_with_both_parents_having_at_least_one_child():void +{ +//given +parentJill = new TreeItem("Jill", new ArrayCollection([Marc])); +parentJohn = new TreeItem("John", new ArrayCollection([Sam])); + +const dataProvider:ArrayCollection = new ArrayCollection(); +dataProvider.addItem(parentJill); +dataProvider.addItem(parentJohn); + +//when +_sut.dataProvider = dataProvider; + +//then wait a few frames +noEnterFramesToWait = 2; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_and_contract, 250); +} + +[Test(async, timeout=300)] +public function test_opening_closing_with_Jill_having_no_children_to_begin_with():void +{ +//given +parentJill = new TreeItem("Jill", new ArrayCollection()); +parentJohn = new TreeItem("John", new ArrayCollection([Sam])); + +const dataProvider:ArrayCollection = new ArrayCollection(); +dataProvider.addItem(parentJill); +dataProvider.addItem(parentJohn); + +//when +_sut.dataProvider = dataProvider; + +//then wait a few frames +noEnterFramesToWait = 2; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_and_contract, 250); +} + +private static function then_expand_and_contract(event:Event, passThroughData:Object):void +{ +//given +var currentLength:int = _sut.collectionLength_; //current length is correct + +//then +
[03/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35260 GridHeaderViewLayout.getHeaderIndexAt() (which calls GridDimensions.getColumnIndexAt()) used to return a valid headerIndex (when it was
FLEX-35260 GridHeaderViewLayout.getHeaderIndexAt() (which calls GridDimensions.getColumnIndexAt()) used to return a valid headerIndex (when it was expected to return -1) for an x < 0. Fixed. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/2adccce7 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2adccce7 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2adccce7 Branch: refs/heads/master Commit: 2adccce7c285cbbdbd4ceda3e5267d0434fbd477 Parents: ad48251 Author: Mihai Chira Authored: Fri Mar 10 17:53:45 2017 +0100 Committer: Mihai Chira Committed: Fri Mar 10 17:53:45 2017 +0100 -- .../src/spark/components/gridClasses/GridDimensions.as | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/2adccce7/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as index ec0a003..0c679db 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as @@ -1183,9 +1183,12 @@ public class GridDimensions */ public function getColumnIndexAt(x:Number, y:Number):int { -var cur:Number = x; +var current:Number = x; var i:int; - + +if(current < 0) +return -1; + for (i = 0; i < _columnCount; i++) { var temp:Number = _columnWidths[i]; @@ -1202,9 +1205,9 @@ public class GridDimensions if (isNaN(temp)) temp = defaultColumnWidth; -cur -= temp + columnGap; +current -= temp + columnGap; -if (cur < 0) +if (current < 0) return i; }
[24/50] git commit: [flex-sdk] [refs/heads/master] - Add my public key
Add my public key Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/42c7c383 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/42c7c383 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/42c7c383 Branch: refs/heads/master Commit: 42c7c383562f717b142d41cbe3f393e656862c3a Parents: 5ea79a2 Author: piotrz Authored: Sun Jun 18 11:25:04 2017 +0200 Committer: piotrz Committed: Sun Jun 18 11:25:04 2017 +0200 -- KEYS | 58 ++ 1 file changed, 58 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/42c7c383/KEYS -- diff --git a/KEYS b/KEYS index 6651922..276c4db 100644 --- a/KEYS +++ b/KEYS @@ -356,3 +356,61 @@ Kf5nY0+eTBMDKw6a4ntfEow7jkzzikhWKYDya/NuT/QDF51bC8FnbEdU2D3jDCWN f/WyocyIyPkr7HH0xI7PLn0= =nsEL -END PGP PUBLIC KEY BLOCK- + +pub 4096R/05061FC8 2017-06-17 +Key fingerprint = 4499 8F3E 2427 27E9 4C4B ADEB 6B0A 7EC9 0506 1FC8 +uid Piotr Zarzycki (CODE SIGNING KEY) +sub 4096R/E7EF0C6D 2017-06-17 + +-BEGIN PGP PUBLIC KEY BLOCK- +Version: GnuPG 2.0.30 + +mQINBFlE+SwBEADWuDcV3Sce05GopgWoggxbqo6e6JYzy+2kxjasB9I5QSFtLFtI +EVTNVa/iKWGzo0gnRbFQiEcERRog8lcgJ+MPLQxK+Db7zP+kfXE14+qaW/Yr8aDY +LVfb8NfOD6SkBPC0snuluMuesTF0e2E0C1zdDKhIwVE5qUzi1TV+IYHlzgV7r2X9 +dBc0TxYHbb0iOjh8fc2DtvN0X8ieN1MBJxdWt0Ce/mloUueUWxcFJhvsXDOOK9Sc +cBHgcV1X707DTK5I2i3ESBnOzTr3zrns4evkyugXVM60ULgddayhg4wvTlyra7X0 +/t8LkimRHl+hZuSMdr03ZuAEyrOLCA2jkQKVPKoGdbpqeKp+cwmrcI4Jqw/JEKB1 +cbzqEFoELGCwfQE8nMYMqQ43ZLV+jUJ6HC1atEdcW5UjHiUVhhur5pMtb5zsf7Bx +CerOOBoUW8Xw9eM0iM6qGycowc2fsrogYNa8QCHgIq1PDFrC3YNmkkOtPyBoCIhw +xC2bwfvH5AxC1SdKJE5UUY+7Vg7ieB4Ku5Kb/7Fw0DzMbG3mT2Aq0qaHI/KyMUgn +TRQFSFe+Dx5j4QRNXwefqNvQHIFETDCcViVSfXAj9HjwdC+LdG97HJFvrtk48PsD +GvPPVxYyA6M07TE28kuLuFLO5YhCnlrWPc9g6+74RQZRE4ZmDpYzn1gi7wARAQAB +tDVQaW90ciBaYXJ6eWNraSAoQ09ERSBTSUdOSU5HIEtFWSkgPHBpb3RyekBhcGFj +aGUub3JnPokCOQQTAQgAIwUCWUT5LAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4B +AheAAAoJEGsKfskFBh/IQekQALDKXARMBTUBScDuuJNMi5qxgHrIjEzXwcWNMEsw +QCn/8AAh0xpWtZ4Lgiuig+vjpkEQuPogS2nov/4mgxQGABEmOnNBedh4ahltgqN4 +sW93IYK1KEU25El75AOQwfkA+M7YCtriR65IAg0waR/CsDgmzIXKnTOhC+ry6pWV +m5YtbHlLz/l2wq4LdCgQzr/LEOhYJWVeYPZUV4X0VDRvugsDq6XzY7xJQONgiGBB +LQk2HrlmNXa5svFYwTe6ILwNFbN2n3p7rJsXANvP7bDXXQ3NhyzV4sPtrv2OEBrV +8LFRjv5qCifLR3lsB4JY/GnLim5HW9HNvv7wsAA7N72+ZM9EMX89v0YqeIyo1qCO +Fxe2myuZudi8ZxRh8z1Hw6rhRSrDR3IBLLdHU/xp2viGkuK5X3fu/Y0E7Bs8kCCQ +6ebORS4gVygVRA0PkSJI0kTLhWf7gEMhMqb7RqTXAQx84xe+Pwz5ck6mZ1NYKr3Y +7CukINfZ17q9kZCmbwqlJF3S3gNJDBKWunmVKM5O8Dz/LKNxcns5DWmNn6kQGE38 +j0TmmCQPYR5SZa+I+J17ml9Qokc7zTJriJg7KqbdHvOrPArx30eH0n1TxDfNfAwZ +1fh1zLZLGzYgP/xapA+wQp32Onr1+Zo+Dsk7t2beIrdC8rRkohmLml0fXXz88v+A +HztcuQINBFlE+SwBEADsG1n16SgS8NssKFK+VnuOXgJ0QQ4H2nVz0uQHD8Gpqzq8 +wVAAQUHcnCbSdIYF81mPjfq1UK3yGFzQFFY8PrWnipbZzOhH4EORgqGyXFL4h1gt +cyV8axcfyxSThw5zTFffma3IwefbxYZ4c3To60k5z9kp6M7ns7L7dE80BCMlQft1 +vzd6YVkZB3IXeoC+70g3XxK3L4CN20S1fQu9mjhawqyXBqF1fIs9TjLw0xIMDYvG +9SgVG4qoKV/WtprEUTia4Ie2jZ3Oal2Uak8xMvpUcp+dF58su5OcSFXOhYtuKh1A +iDLcYXGMrIOTnbYdmvSjnlClUp6MZfTzq41VwiigjmKnFyv3WB+0uJb4MZJ3TDg2 +DEsaxyrqGQiY1DZL/UzflQ3YtBTaMiOZnkhgnJTEP9joe4xMAJpVusri2XdaUtFs +PmLjbHCarx9esfxslu7XBhE4iikkD5/ptgmBcnu/U+OTebumu8adVP7YQ9TUit9C +M3nK8cQPgdIsu3mr7xggS0UeYxNo/pNKsuapV5bxn1swWksePH2543rl9pq1QAsC +n9nXo1jdP75QS9SpBoCAhbDiUjq8RdUi0ypm64lyZaULpY2KtmA8LvU5lv7IO4ls +bzYdkmNwnzJAtg7mhDrDTJQiNjg6kcOyYr4wPOTAzU3hypgWalfhKztLe51hwQAR +AQABiQIfBBgBCAAJBQJZRPksAhsMAAoJEGsKfskFBh/IagQQAJ6akuFqdgZimt5a +c+LilkgVy2vtMpe1+4Xd/w9ko6WRH4lXQW64RdrF5nLji61AIiOc26jgjSyDslrX +jcsgjgxeXj8PnMyA+wKJgJQhEt9fW0uvGVr6PBeRcwPteaO7wyenOzSUbie47jw3 +dVhACHwr4Dl75JeSwKkKnqfzWbLovYYyVzKFa1dwX+GSzf9rJhT6ooM30ktfrOIq +EhjpHVl8+gkc8kYKJ/yxepKmYCdeFVD7Tixf0+DZfvAu9brynsSyLtOjJMBrYy+b +iDCaTIcQAfqtdC2tT+GvUZFYPN7EuT7GugO7dU2p1x2oDuVQENu2jB7GhMcEU/zo ++DMY4Fk94KfWYxpTKvH7Z2Nh33ETMlCk8RFbQoeq3FEByQylP2RifOV7BgyTugOP +HyP9iqVFkYr9fdi0POJsgO+z0lM4ogRzNk4SYucoH8EZR+bGaTWI6Y0PFe2U3GJE +8TThC+i0BYwD8FeTuF7xwaDDTBh9z6OeLIMj2M0YgxCUdLmhwwvrcAR7yFAHB4OF +WQOR8K0DZJK5nBtBwiIsl7Oeh7m2vquU3+hV6Re6VmyGisH0WMrfl5IdJs1oMyyc +AA5kBssMJqOIOVF5KZsafBSW3OG7xbmF/hNA6cJMmvSDXax69k/eYAH4Uk4MX8m6 +ZGs7Ibn/LbgXcM6jdzDFLOHfulZ/ +=GBzo +-END PGP PUBLIC KEY BLOCK-
[38/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35364 - Fix issue where "air-setup-mac" target launched their dependents targets on windows before checking condition (it is default ant behav
FLEX-35364 - Fix issue where "air-setup-mac" target launched their dependents targets on windows before checking condition (it is default ant behavior) - Fix some merge issue Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7cd99a7a Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7cd99a7a Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7cd99a7a Branch: refs/heads/master Commit: 7cd99a7a0b3e69c409ad6b2f837d817412e9a766 Parents: 4c60183 Author: Piotr Zarzycki Authored: Wed Oct 25 14:25:02 2017 +0200 Committer: Piotr Zarzycki Committed: Wed Oct 25 14:25:02 2017 +0200 -- installer.xml | 41 +++-- 1 file changed, 11 insertions(+), 30 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7cd99a7a/installer.xml -- diff --git a/installer.xml b/installer.xml index 38ace4f..c22be85 100644 --- a/installer.xml +++ b/installer.xml @@ -351,7 +351,7 @@ - + @@ -377,7 +377,7 @@ - + ${INFO_FINISHED_UNZIPPING} ${download.dir}/${air.sdk.url.file} @@ -419,13 +419,8 @@ -<<< HEAD - -=== - ->>> release4.16.0 + - @@ -443,27 +438,17 @@ -<<< HEAD - - - - -=== + ->>> release4.16.0 -<<< HEAD - -=== - ->>> release4.16.0 + @@ -474,11 +459,7 @@ -<<< HEAD - -=== - ->>> release4.16.0 + @@ -486,11 +467,11 @@ -<<< HEAD - -=== - ->>> release4.16.0 + + + + +
[22/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 Refined tests, including checking for how many validation steps happen for size, properties and display list. Without the fix all those
FLEX-35321 Refined tests, including checking for how many validation steps happen for size, properties and display list. Without the fix all those expected to fail fail (the last one is not expected to fail without the fix, because it's there just to make sure no regression is introduced by the fix), while with the fix all of them pass. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/442b5f8e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/442b5f8e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/442b5f8e Branch: refs/heads/master Commit: 442b5f8ea4fe08dc8e5f7d48df7dc36b101c99fe Parents: 75b4d39 Author: Mihai Chira Authored: Sat Jun 10 13:28:05 2017 +0200 Committer: Mihai Chira Committed: Sat Jun 10 13:28:05 2017 +0200 -- .../managers/LayoutManager_FLEX_35321_Tests.as | 42 +++- 1 file changed, 32 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/442b5f8e/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as -- diff --git a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as index 1fef434..9b0b38c 100644 --- a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as +++ b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as @@ -6,6 +6,8 @@ package mx.managers { import mx.core.mx_internal; import mx.events.FlexEvent; +import org.flexunit.assertThat; + import org.flexunit.asserts.assertEquals; import org.flexunit.asserts.assertNotNull; import org.flexunit.asserts.assertNull; @@ -28,7 +30,7 @@ package mx.managers { _creationCompleteCalls = 0; _objectWhichIsRemovedAtValidation = new SomeComponent(); _objectWhichIsRemovedAtValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); -UIImpersonator.addChild(_objectWhichIsRemovedAtValidation); +UIImpersonator.addElement(_objectWhichIsRemovedAtValidation); } [After] @@ -45,7 +47,6 @@ package mx.managers { // //-- - [Test] public function test_object_removed_from_stage_via_code_is_not_initialized():void { @@ -54,10 +55,14 @@ package mx.managers { _objectWhichIsRemovedAtValidation.removeFromStageOnValidateProperties = true; //when +_objectWhichIsRemovedAtValidation.invalidateProperties(); +_objectWhichIsRemovedAtValidation.invalidateSize(); +_objectWhichIsRemovedAtValidation.invalidateDisplayList(); _objectWhichIsRemovedAtValidation.validateNow(); //then then_assert_not_initialized(); +assert_validation_count(1, 0, 0); } @@ -68,7 +73,6 @@ package mx.managers { // //-- - [Test(async, timeout=500)] public function test_object_removed_from_stage_via_user_action_is_not_initialized():void { @@ -84,7 +88,7 @@ package mx.managers { //then wait 1 frame noEnterFramesRemaining = 1; UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); -Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_remove_from_stage_via_callLater, 300, then_assert_not_initialized); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_remove_from_stage_via_callLater, 300, {nextStep:then_assert_not_initialized_but_partially_validated, afterNumFrames:3}); } @@ -111,7 +115,7 @@ package mx.managers { //then wait 1 frame noEnterFramesRemaining = 1; UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); -Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_remove_from_stage_via_callLater, 300, then_readd_object); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_remove_from_stage_via_callLater, 300, {nextStep:then_readd_object, afterNumFrames:1}); } private function then_readd_object(event:Event, passThroughData:Object):void @@ -122,8 +126,8 @@ package mx.managers { //when UIImpersonator.addElement(_objectWhichIsRemovedAtValidation); -//then wait 4 frames, to make sure validation is done -noEnterFramesRemaining = 4; +//then wait 3 frames,
[21/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 test_object_removed_from_stage_via_user_action_is_not_initialized() needed one more frame to complete (made sure it fails without the pr
FLEX-35321 test_object_removed_from_stage_via_user_action_is_not_initialized() needed one more frame to complete (made sure it fails without the proposed fix, and passes with it). Also made some variable and function renames, plus now we can also test how many times each validation function has been called. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/75b4d39d Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/75b4d39d Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/75b4d39d Branch: refs/heads/master Commit: 75b4d39d806d6a3bef3cd123493fe4b718f9b2c3 Parents: f475aed Author: Mihai Chira Authored: Sat Jun 10 11:52:14 2017 +0200 Committer: Mihai Chira Committed: Sat Jun 10 11:52:14 2017 +0200 -- .../managers/LayoutManager_FLEX_35321_Tests.as | 135 +-- 1 file changed, 96 insertions(+), 39 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/75b4d39d/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as -- diff --git a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as index a23d002..1fef434 100644 --- a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as +++ b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as @@ -19,101 +19,108 @@ package mx.managers { private static var noEnterFramesRemaining:int = NaN; private static const _finishNotifier:EventDispatcher = new EventDispatcher(); -private var _objectWhichIsRemovedOnSizeValidation:SomeComponent; +private var _objectWhichIsRemovedAtValidation:SomeComponent; private var _creationCompleteCalls:int; [Before] public function setUp():void { _creationCompleteCalls = 0; -_objectWhichIsRemovedOnSizeValidation = new SomeComponent(); - _objectWhichIsRemovedOnSizeValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); -UIImpersonator.addElement(_objectWhichIsRemovedOnSizeValidation); +_objectWhichIsRemovedAtValidation = new SomeComponent(); + _objectWhichIsRemovedAtValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); +UIImpersonator.addChild(_objectWhichIsRemovedAtValidation); } [After] public function tearDown():void { UIImpersonator.removeAllChildren(); -_objectWhichIsRemovedOnSizeValidation = null; +_objectWhichIsRemovedAtValidation = null; } + + //-- +// +// Test method +// + //-- + + [Test] public function test_object_removed_from_stage_via_code_is_not_initialized():void { //given UIComponentGlobals.mx_internal::layoutManager.usePhasedInstantiation = false; - _objectWhichIsRemovedOnSizeValidation.removeFromStageOnValidateProperties = true; + _objectWhichIsRemovedAtValidation.removeFromStageOnValidateProperties = true; //when -_objectWhichIsRemovedOnSizeValidation.validateNow(); +_objectWhichIsRemovedAtValidation.validateNow(); //then -assertNull("The object was actually not removed from stage. Huh?", _objectWhichIsRemovedOnSizeValidation.parent); -assertEquals("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", 0, _creationCompleteCalls); +then_assert_not_initialized(); } + + + //-- +// +// Test method +// + //-- + + [Test(async, timeout=500)] public function test_object_removed_from_stage_via_user_action_is_not_initialized():void { //given UIComponentGlobals.mx_internal::layoutManager.usePhasedInstantiation = true; - _objectWhichIsRemovedOnSizeValidation.removeFromStageOnValidateProperties = false; + _objectWhichIsRemovedAtValidation.removeFromStageOnValidateProperties = false; //when -_objectWhichIsRemovedOnSizeValidation.invalidateDisplayList(); -_objectWhichIsRemovedOnSizeValidation.invalidateProperties(); -_objectWhichIsRe
[44/50] git commit: [flex-sdk] [refs/heads/master] - add AwesomeUtils
add AwesomeUtils Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/35103c64 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/35103c64 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/35103c64 Branch: refs/heads/master Commit: 35103c64c318c60a4abbc988ae94dac01f9623da Parents: 0b9764c Author: Alex Harui Authored: Fri Nov 3 14:29:08 2017 -0700 Committer: Alex Harui Committed: Fri Nov 3 14:29:08 2017 -0700 -- LICENSE | 3 +++ 1 file changed, 3 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/35103c64/LICENSE -- diff --git a/LICENSE b/LICENSE index 3faa057..3de99e1 100644 --- a/LICENSE +++ b/LICENSE @@ -258,6 +258,9 @@ see frameworks/projects/flatspark/src/flatspark/assets/fonts/awesome The Lato font is available under OFL. For details see frameworks/projects/flatspark/src/flatspark/assets/fonts/lato +The AwesomeUtils is available under MIT. For details +see frameworks/projects/flatspark/src/flatspark/utils/AwesomeUtils.as + This product includes a fork of Apache Batik which includes files available under the 2002 W3C Software license. For details, see modules/thirdparty/batik/LICENSE.W3C2002.
[41/50] git commit: [flex-sdk] [refs/heads/master] - Update version to 4.16.1
Update version to 4.16.1 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d474c808 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d474c808 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d474c808 Branch: refs/heads/master Commit: d474c808f6f95dd7caebad21285a35983e7a92cc Parents: 0f96a26 Author: Piotr Zarzycki Authored: Mon Oct 30 21:03:41 2017 +0100 Committer: Piotr Zarzycki Committed: Mon Oct 30 21:03:41 2017 +0100 -- build.properties | 4 ++-- frameworks/projects/advancedgrids/src/mx/core/Version.as | 2 +- frameworks/projects/airframework/src/mx/core/Version.as | 2 +- frameworks/projects/airspark/src/spark/core/Version.as | 2 +- frameworks/projects/apache/src/core/Version.as | 2 +- frameworks/projects/automation/src/mx/core/Version.as| 2 +- frameworks/projects/automation_agent/src/mx/core/Version.as | 2 +- frameworks/projects/automation_air/src/mx/core/Version.as| 2 +- frameworks/projects/automation_dmv/src/mx/core/Version.as| 2 +- .../projects/automation_flashflexkit/src/mx/core/Version.as | 2 +- frameworks/projects/automation_spark/src/mx/core/Version.as | 2 +- frameworks/projects/automation_spark/src/spark/core/Version.as | 2 +- frameworks/projects/charts/src/mx/core/Version.as| 2 +- frameworks/projects/framework/src/mx/core/Version.as | 2 +- frameworks/projects/mx/src/mx/core/Version.as| 2 +- frameworks/projects/rpc/src/mx/core/Version.as | 2 +- frameworks/projects/spark/src/spark/core/Version.as | 2 +- frameworks/projects/spark_dmv/src/spark/core/Version.as | 2 +- frameworks/projects/tool/src/mx/core/Version.as | 2 +- frameworks/projects/tool_air/src/mx/core/Version.as | 2 +- modules/compiler/src/java/flex2/tools/VersionInfo.java | 2 +- 21 files changed, 22 insertions(+), 22 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d474c808/build.properties -- diff --git a/build.properties b/build.properties index 0ba13bb..fb505da 100644 --- a/build.properties +++ b/build.properties @@ -18,8 +18,8 @@ # flex-sdk-description values -release = Apache Flex 4.16.0 -release.version = 4.16.0 +release = Apache Flex 4.16.1 +release.version = 4.16.1 # override on command line with -Dbuild.number=999 or in local.properties build.number = 0 http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d474c808/frameworks/projects/advancedgrids/src/mx/core/Version.as -- diff --git a/frameworks/projects/advancedgrids/src/mx/core/Version.as b/frameworks/projects/advancedgrids/src/mx/core/Version.as index 3077bda..9cc2191 100644 --- a/frameworks/projects/advancedgrids/src/mx/core/Version.as +++ b/frameworks/projects/advancedgrids/src/mx/core/Version.as @@ -23,4 +23,4 @@ import mx.core.mx_internal; * @private * Version string for this class. */ -mx_internal static const VERSION:String = "4.16.0.0"; +mx_internal static const VERSION:String = "4.16.1.0"; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d474c808/frameworks/projects/airframework/src/mx/core/Version.as -- diff --git a/frameworks/projects/airframework/src/mx/core/Version.as b/frameworks/projects/airframework/src/mx/core/Version.as index 3077bda..9cc2191 100644 --- a/frameworks/projects/airframework/src/mx/core/Version.as +++ b/frameworks/projects/airframework/src/mx/core/Version.as @@ -23,4 +23,4 @@ import mx.core.mx_internal; * @private * Version string for this class. */ -mx_internal static const VERSION:String = "4.16.0.0"; +mx_internal static const VERSION:String = "4.16.1.0"; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d474c808/frameworks/projects/airspark/src/spark/core/Version.as -- diff --git a/frameworks/projects/airspark/src/spark/core/Version.as b/frameworks/projects/airspark/src/spark/core/Version.as index 3077bda..9cc2191 100644 --- a/frameworks/projects/airspark/src/spark/core/Version.as +++ b/frameworks/projects/airspark/src/spark/core/Version.as @@ -23,4 +23,4 @@ import mx.core.mx_internal; * @private * Version string for this class. */ -mx_internal static const VERSION:String = "4.16.0.0"; +mx_internal static const VERSION:String = "4.16.1.0"; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d474c808/frameworks/pro
[39/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35364 - Run air-setup-mac on all non windows OS
FLEX-35364 - Run air-setup-mac on all non windows OS Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/752b1d3e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/752b1d3e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/752b1d3e Branch: refs/heads/master Commit: 752b1d3eb905406075f350197b1ce4701d94e3f9 Parents: 7cd99a7 Author: Piotr Zarzycki Authored: Wed Oct 25 14:41:58 2017 +0200 Committer: Piotr Zarzycki Committed: Wed Oct 25 14:41:58 2017 +0200 -- installer.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/752b1d3e/installer.xml -- diff --git a/installer.xml b/installer.xml index c22be85..ef08ef2 100644 --- a/installer.xml +++ b/installer.xml @@ -467,7 +467,7 @@ - +
[47/50] git commit: [flex-sdk] [refs/heads/master] - Update rat version in releasecandidate.xml file
Update rat version in releasecandidate.xml file Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d242fd9d Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d242fd9d Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d242fd9d Branch: refs/heads/master Commit: d242fd9d20415eef26474dbbc5cfc846c8ec9d5d Parents: 7cc34f9 Author: Piotr Zarzycki Authored: Tue Nov 7 22:56:59 2017 +0100 Committer: Piotr Zarzycki Committed: Tue Nov 7 22:56:59 2017 +0100 -- releasecandidate.xml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d242fd9d/releasecandidate.xml -- diff --git a/releasecandidate.xml b/releasecandidate.xml index 7597846..c2d43f8 100644 --- a/releasecandidate.xml +++ b/releasecandidate.xml @@ -49,9 +49,10 @@ - - - http://people.apache.org/~aharui/rat"; /> + + + http://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.11"; /> + http://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat-tasks/0.11"/> @@ -192,7 +193,7 @@ - +
[06/50] git commit: [flex-sdk] [refs/heads/master] - Merge branch 'release4.16.0' into develop
Merge branch 'release4.16.0' into develop Conflicts: installer.xml Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a616e558 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a616e558 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a616e558 Branch: refs/heads/master Commit: a616e55899d8e58db4886c00f681cee2fe8945ed Parents: a5b04e1 14c9664 Author: Justin Mclean Authored: Wed Mar 15 15:03:47 2017 +1100 Committer: Justin Mclean Committed: Wed Mar 15 15:03:47 2017 +1100 -- .gitignore | 1 + ApproveSDK.xml | 21 +- CONTRIBUTORS| 3 + NOTICE | 2 +- README | 9 +- RELEASE_NOTES | 90 - build.xml | 4 +- frameworks/build.xml| 12 + frameworks/downloads.xml| 21 +- .../mx/controls/listClasses/AdvancedListBase.as | 5 +- .../assets/fonts/awesome/FontAwesome.otf| Bin 109688 -> 134808 bytes .../src/flatspark/utils/AwesomeUtils.as | 122 ++- .../framework/src/mx/utils/ObjectUtil.as| 2 +- .../src/mx/validators/EmailValidator.as | 2 +- .../src/spark/skins/ios7/BusyIndicatorSkin.as | 20 +- .../spark/src/spark/components/DropDownList.as | 12 +- .../src/spark/skins/spark/BusyIndicatorSkin.as | 21 +- ide/addAIRtoSDK.sh | 59 +++- ide/checkAllPlayerGlobals.sh| 50 +-- ide/flashbuilder/config/air-config.xml | 21 +- ide/flashbuilder/config/flex-config.xml | 20 +- ide/setFlashPlayerVersion.sh| 79 - installer.xml | 28 +- licenseParts/NOTICE.asc | 2 +- licenseParts/NOTICE.base| 2 +- licenseParts/NOTICE.pb | 2 +- licenseParts/saxon9-NOTICES/APACHE-ANT.txt | 13 + licenseParts/saxon9-NOTICES/APACHE-RESOLVER.txt | 9 + licenseParts/saxon9-NOTICES/APACHE-XERCES.txt | 17 + licenseParts/saxon9-NOTICES/CERN.txt| 7 + licenseParts/saxon9-NOTICES/FRIJTERS.txt| 22 ++ licenseParts/saxon9-NOTICES/GPL+CLASSPATH.txt | 347 +++ licenseParts/saxon9-NOTICES/JAMESCLARK.txt | 25 ++ licenseParts/saxon9-NOTICES/LEGAL.txt | 33 ++ licenseParts/saxon9-NOTICES/LICENSE.txt | 15 + licenseParts/saxon9-NOTICES/THAI.txt| 31 ++ licenseParts/saxon9-NOTICES/UNICODE.txt | 29 ++ .../src/java/macromedia/asc/embedding/Main.java | 2 +- .../java/macromedia/asc/embedding/Shell.java| 2 +- .../java/macromedia/asc/embedding/SwfMaker.java | 16 +- .../flex2/compiler/common/Configuration.java| 32 ++ .../java/flex2/linker/LinkerConfiguration.java | 4 + .../src/java/flex2/linker/SimpleMovie.java | 10 + .../src/java/flex2/tools/ASDoc_da.properties| 2 +- .../src/java/flex2/tools/ASDoc_de.properties| 2 +- .../src/java/flex2/tools/ASDoc_en.properties| 2 +- .../src/java/flex2/tools/ASDoc_es.properties| 2 +- .../src/java/flex2/tools/ASDoc_fi.properties| 2 +- .../src/java/flex2/tools/ASDoc_fr.properties| 2 +- .../src/java/flex2/tools/ASDoc_it.properties| 2 +- .../src/java/flex2/tools/ASDoc_ja.properties| 2 +- .../src/java/flex2/tools/ASDoc_ko.properties| 2 +- .../src/java/flex2/tools/ASDoc_nb.properties| 2 +- .../src/java/flex2/tools/ASDoc_nl.properties| 2 +- .../src/java/flex2/tools/ASDoc_pt.properties| 2 +- .../src/java/flex2/tools/ASDoc_ru.properties| 2 +- .../src/java/flex2/tools/ASDoc_sv.properties| 2 +- .../src/java/flex2/tools/ASDoc_zh_CN.properties | 2 +- .../src/java/flex2/tools/ASDoc_zh_TW.properties | 2 +- .../src/java/flex2/tools/Compc_da.properties| 2 +- .../src/java/flex2/tools/Compc_de.properties| 2 +- .../src/java/flex2/tools/Compc_en.properties| 2 +- .../src/java/flex2/tools/Compc_es.properties| 2 +- .../src/java/flex2/tools/Compc_fi.properties| 2 +- .../src/java/flex2/tools/Compc_fr.properties| 2 +- .../src/java/flex2/tools/Compc_it.properties| 2 +- .../src/java/flex2/tools/Compc_ja.properties| 2 +- .../src/java/flex2/tools/Compc_ko.properties| 2 +- .../src/java/flex2/tools/Compc_nb.properties| 2 +- .../src/java/flex2/tools/Compc_nl.properties| 2 +- .../src/java/flex2/tools/Compc_pt.properties| 2 +- .../src/java/flex2/tools/Compc_ru.properties| 2 +- .../src/java/flex2/tools/Compc_sv.properties| 2 +- .../src/java/flex2/tools/Compc_zh_CN.properties | 2 +- .../src/java
[26/50] git commit: [flex-sdk] [refs/heads/master] - Merge remote-tracking branch 'origin/develop' into develop
Merge remote-tracking branch 'origin/develop' into develop Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/0226437e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/0226437e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/0226437e Branch: refs/heads/master Commit: 0226437edfef900f9135b3fd97b8b82af10b2ae0 Parents: 9c5cbbe e66554e Author: Mihai Chira Authored: Tue Jun 20 11:50:06 2017 +0200 Committer: Mihai Chira Committed: Tue Jun 20 11:50:06 2017 +0200 -- KEYS | 116 ++ 1 file changed, 116 insertions(+) --
[35/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 CAUSE: if the object isn't on stage when we'd normally set its initialized flag to true, we correctly skip this step, but we also need t
FLEX-35321 CAUSE: if the object isn't on stage when we'd normally set its initialized flag to true, we correctly skip this step, but we also need to set its updateCompletePendingFlag back to false, so that in case it's added to stage again it can work correctly, and have its initialized flag set to true as expected. This second step was skipped in the previous commit. This could be noticed, for example, in DataGrid, which would not show the renderers which it initially used in GridViewLayout.updateTypicalCellSizes(). SOLUTION: set the updateCompletePendingFlag to false even if the object isn't on stage anymore. NOTES: also removed unused imports and an unused local variable. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/243507a7 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/243507a7 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/243507a7 Branch: refs/heads/master Commit: 243507a7346b6acbba755833a970dccdb48cf375 Parents: fcc2586 Author: Mihai Chira Authored: Wed Aug 30 10:27:35 2017 +0200 Committer: Mihai Chira Committed: Wed Aug 30 10:27:35 2017 +0200 -- .../projects/framework/src/mx/managers/LayoutManager.as | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/243507a7/frameworks/projects/framework/src/mx/managers/LayoutManager.as -- diff --git a/frameworks/projects/framework/src/mx/managers/LayoutManager.as b/frameworks/projects/framework/src/mx/managers/LayoutManager.as index d070203..131838e 100644 --- a/frameworks/projects/framework/src/mx/managers/LayoutManager.as +++ b/frameworks/projects/framework/src/mx/managers/LayoutManager.as @@ -19,14 +19,10 @@ package mx.managers { -import flash.display.DisplayObject; -import flash.display.Sprite; import flash.display.Stage; import flash.events.Event; import flash.events.EventDispatcher; -import mx.core.ILayoutElement; -import mx.core.UIComponent; import mx.core.UIComponentGlobals; import mx.core.mx_internal; import mx.events.DynamicEvent; @@ -852,8 +848,9 @@ public class LayoutManager extends EventDispatcher implements ILayoutManager obj.initialized = true; if (obj.hasEventListener(FlexEvent.UPDATE_COMPLETE)) obj.dispatchEvent(new FlexEvent(FlexEvent.UPDATE_COMPLETE)); -obj.updateCompletePendingFlag = false; } + +obj.updateCompletePendingFlag = false; obj = ILayoutManagerClient(updateCompleteQueue.removeLargest()); } @@ -930,7 +927,6 @@ public class LayoutManager extends EventDispatcher implements ILayoutManager var lastCurrentObject:ILayoutManagerClient = currentObject; var obj:ILayoutManagerClient; -var i:int = 0; var done:Boolean = false; var oldTargetLevel:int = targetLevel; @@ -1104,8 +1100,9 @@ public class LayoutManager extends EventDispatcher implements ILayoutManager if (obj.hasEventListener(FlexEvent.UPDATE_COMPLETE)) obj.dispatchEvent(new FlexEvent(FlexEvent.UPDATE_COMPLETE)); -obj.updateCompletePendingFlag = false; } + +obj.updateCompletePendingFlag = false; obj = ILayoutManagerClient(updateCompleteQueue.removeLargestChild(target)); } }
[09/50] git commit: [flex-sdk] [refs/heads/master] - Merge remote-tracking branch 'origin/develop' into develop
Merge remote-tracking branch 'origin/develop' into develop Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6bc7ad5e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6bc7ad5e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6bc7ad5e Branch: refs/heads/master Commit: 6bc7ad5e9e85daada0ebd1e7c6946b032409de71 Parents: d7299c3 1040357 Author: Mihai Chira Authored: Thu Mar 16 13:11:55 2017 +0100 Committer: Mihai Chira Committed: Thu Mar 16 13:11:55 2017 +0100 -- .gitignore | 1 + ApproveSDK.xml | 21 +- CONTRIBUTORS| 3 + NOTICE | 2 +- README | 9 +- RELEASE_NOTES | 90 - build.xml | 4 +- frameworks/build.xml| 12 + frameworks/downloads.xml| 21 +- .../assets/fonts/awesome/FontAwesome.otf| Bin 109688 -> 134808 bytes .../src/flatspark/utils/AwesomeUtils.as | 122 ++- .../framework/src/mx/utils/ObjectUtil.as| 2 +- .../src/mx/validators/EmailValidator.as | 2 +- .../src/spark/skins/ios7/BusyIndicatorSkin.as | 20 +- .../spark/src/spark/components/DropDownList.as | 12 +- .../src/spark/skins/spark/BusyIndicatorSkin.as | 21 +- ide/addAIRtoSDK.sh | 59 +++- ide/checkAllPlayerGlobals.sh| 50 +-- ide/flashbuilder/config/air-config.xml | 21 +- ide/flashbuilder/config/flex-config.xml | 20 +- ide/setFlashPlayerVersion.sh| 79 - installer.xml | 28 +- licenseParts/NOTICE.asc | 2 +- licenseParts/NOTICE.base| 2 +- licenseParts/NOTICE.pb | 2 +- licenseParts/saxon9-NOTICES/APACHE-ANT.txt | 13 + licenseParts/saxon9-NOTICES/APACHE-RESOLVER.txt | 9 + licenseParts/saxon9-NOTICES/APACHE-XERCES.txt | 17 + licenseParts/saxon9-NOTICES/CERN.txt| 7 + licenseParts/saxon9-NOTICES/FRIJTERS.txt| 22 ++ licenseParts/saxon9-NOTICES/GPL+CLASSPATH.txt | 347 +++ licenseParts/saxon9-NOTICES/JAMESCLARK.txt | 25 ++ licenseParts/saxon9-NOTICES/LEGAL.txt | 33 ++ licenseParts/saxon9-NOTICES/LICENSE.txt | 15 + licenseParts/saxon9-NOTICES/THAI.txt| 31 ++ licenseParts/saxon9-NOTICES/UNICODE.txt | 29 ++ .../src/java/macromedia/asc/embedding/Main.java | 2 +- .../java/macromedia/asc/embedding/Shell.java| 2 +- .../java/macromedia/asc/embedding/SwfMaker.java | 16 +- .../flex2/compiler/common/Configuration.java| 32 ++ .../java/flex2/linker/LinkerConfiguration.java | 4 + .../src/java/flex2/linker/SimpleMovie.java | 10 + .../src/java/flex2/tools/ASDoc_da.properties| 2 +- .../src/java/flex2/tools/ASDoc_de.properties| 2 +- .../src/java/flex2/tools/ASDoc_en.properties| 2 +- .../src/java/flex2/tools/ASDoc_es.properties| 2 +- .../src/java/flex2/tools/ASDoc_fi.properties| 2 +- .../src/java/flex2/tools/ASDoc_fr.properties| 2 +- .../src/java/flex2/tools/ASDoc_it.properties| 2 +- .../src/java/flex2/tools/ASDoc_ja.properties| 2 +- .../src/java/flex2/tools/ASDoc_ko.properties| 2 +- .../src/java/flex2/tools/ASDoc_nb.properties| 2 +- .../src/java/flex2/tools/ASDoc_nl.properties| 2 +- .../src/java/flex2/tools/ASDoc_pt.properties| 2 +- .../src/java/flex2/tools/ASDoc_ru.properties| 2 +- .../src/java/flex2/tools/ASDoc_sv.properties| 2 +- .../src/java/flex2/tools/ASDoc_zh_CN.properties | 2 +- .../src/java/flex2/tools/ASDoc_zh_TW.properties | 2 +- .../src/java/flex2/tools/Compc_da.properties| 2 +- .../src/java/flex2/tools/Compc_de.properties| 2 +- .../src/java/flex2/tools/Compc_en.properties| 2 +- .../src/java/flex2/tools/Compc_es.properties| 2 +- .../src/java/flex2/tools/Compc_fi.properties| 2 +- .../src/java/flex2/tools/Compc_fr.properties| 2 +- .../src/java/flex2/tools/Compc_it.properties| 2 +- .../src/java/flex2/tools/Compc_ja.properties| 2 +- .../src/java/flex2/tools/Compc_ko.properties| 2 +- .../src/java/flex2/tools/Compc_nb.properties| 2 +- .../src/java/flex2/tools/Compc_nl.properties| 2 +- .../src/java/flex2/tools/Compc_pt.properties| 2 +- .../src/java/flex2/tools/Compc_ru.properties| 2 +- .../src/java/flex2/tools/Compc_sv.properties| 2 +- .../src/java/flex2/tools/Compc_zh_CN.properties | 2 +- .../src/java/flex2/tools/Compc_zh_TW.properties | 2 +- .../java/flex2/tools/DigestTool_d
[29/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-18746 Added unit test (current fails).
FLEX-18746 Added unit test (current fails). Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f804380f Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f804380f Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f804380f Branch: refs/heads/master Commit: f804380f10e725aa90fee6c2ab998b3db30fe705 Parents: fea9be9 Author: Mihai Chira Authored: Mon Aug 14 19:56:14 2017 +0200 Committer: Mihai Chira Committed: Mon Aug 14 19:56:14 2017 +0200 -- .../tests/mx/controls/Tree_FLEX_18746_Tests.as | 112 +++ 1 file changed, 112 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f804380f/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as -- diff --git a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as new file mode 100644 index 000..5d64b06 --- /dev/null +++ b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as @@ -0,0 +1,112 @@ +package mx.controls { +import flash.events.Event; +import flash.events.EventDispatcher; + +import mx.collections.ArrayCollection; +import mx.core.mx_internal; + +import org.flexunit.assertThat; +import org.flexunit.async.Async; +import org.fluint.uiImpersonation.UIImpersonator; + +use namespace mx_internal; + +public class Tree_FLEX_18746_Tests +{ +private static var noEnterFramesToWait:int = NaN; +private static const _finishNotifier:EventDispatcher = new EventDispatcher(); + +private static var _sut:Tree; +private static var child:Object = {label: "Item"}; +private static var parent0:Object = {label: "Folder 0", children: new ArrayCollection()}; +private static var parent1:Object = {label: "Folder 1", children: new ArrayCollection([child])}; + + +[Before] +public function setUp():void +{ +_sut = new Tree(); +_sut.width = 200; +_sut.height = 200; +UIImpersonator.addChild(_sut); +} + +[After] +public function tearDown():void +{ +UIImpersonator.removeAllChildren(); +_sut = null; +} + + + //-- +// +// Test method +// + //-- + +[Test(async, timeout=1000)] +public function test_object_removed_from_stage_via_code_is_not_initialized():void +{ +//given +const dataProvider:ArrayCollection = new ArrayCollection(); +dataProvider.addItem(parent0); +dataProvider.addItem(parent1); + +//when +_sut.dataProvider = dataProvider; + +//then wait a few frames +noEnterFramesToWait = 2; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_second_folder, 200); +} + + +private function then_expand_second_folder(event:Event, passThroughData:Object):void +{ +//when +_sut.expandItem(parent1, true, true, true); + +//then wait a bit +noEnterFramesToWait = 5; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_move_child_to_first_parent_and_expand_it, 500); +} + +private function then_move_child_to_first_parent_and_expand_it(event:Event, passThroughData:Object):void +{ +//then +assertThat(_sut.isItemOpen(parent1)); + +//when +ArrayCollection(parent1.children).removeItemAt(0); +_sut.expandItem(parent0, true, true, true); +ArrayCollection(parent0.children).addItem(child); + +//then wait a bit +noEnterFramesToWait = 1; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_contract_second_folder, 200); +} + +private static function then_contract_second_folder(event:Event, passThroughData:Object):void +{ +//when +_sut.expandItem(parent1, false, true, true); + +//then no error was thrown +assertThat(true); +} + + +private static function onEnterFrame(event:Event):void +{ +if(!--noEnterFramesToWait) +{
[17/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35306 Addd unit test. Fails when reverting the fix, passes with the fix.
FLEX-35306 Addd unit test. Fails when reverting the fix, passes with the fix. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/2750254b Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2750254b Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2750254b Branch: refs/heads/master Commit: 2750254ba51c284f8bb5dfce2b5101179600b21b Parents: 59cefd8 Author: Mihai Chira Authored: Mon May 22 10:52:55 2017 +0200 Committer: Mihai Chira Committed: Mon May 22 10:52:55 2017 +0200 -- .../spark/components/List_FLEX_35306_Tests.as | 274 +++ .../spark/tests/spark/components/_CompanyVO.as | 49 .../tests/spark/components/_HeadquarterVO.as| 23 ++ .../spark/components/_ListWithMXMLBinding.mxml | 22 ++ 4 files changed, 368 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/2750254b/frameworks/projects/spark/tests/spark/components/List_FLEX_35306_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/List_FLEX_35306_Tests.as b/frameworks/projects/spark/tests/spark/components/List_FLEX_35306_Tests.as new file mode 100644 index 000..1780240 --- /dev/null +++ b/frameworks/projects/spark/tests/spark/components/List_FLEX_35306_Tests.as @@ -0,0 +1,274 @@ + +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// + + +package spark.components { +import flash.events.Event; +import flash.events.EventDispatcher; + +import mx.collections.ArrayCollection; +import mx.collections.IList; +import mx.core.mx_internal; + +import org.flexunit.asserts.assertEquals; +import org.flexunit.asserts.assertFalse; +import org.flexunit.asserts.assertNotNull; +import org.flexunit.async.Async; +import org.flexunit.runners.Parameterized; +import org.fluint.uiImpersonation.UIImpersonator; + +import spark.skins.spark.ListSkin; + +use namespace mx_internal; + +[RunWith("org.flexunit.runners.Parameterized")] +public class List_FLEX_35306_Tests +{ +private static var foo:Parameterized; + +private static const NO_ENTER_FRAMES_TO_ALLOW:int = 4; +private static var noEnterFramesRemaining:int = NaN; +private static const _finishNotifier:EventDispatcher = new EventDispatcher(); + +private static var _sut:_ListWithMXMLBinding; + +private static var _hqRedmond:_HeadquarterVO; +private static var _hqSantaClara:_HeadquarterVO; +private static var _hqBerlin:_HeadquarterVO; +private static var _hqMunchen:_HeadquarterVO; +private static var _hqNewYork:_HeadquarterVO; +private static var _hqSantaMaria:_HeadquarterVO; +private static var _hqSantaDolores:_HeadquarterVO; + +[Bindable] +public var selectedCompany:_CompanyVO; +[Bindable] +public var potentialHeadquarters:IList; + +public static var models:Array; +{ +models = [[createListOfCompaniesWithOnePotentialAddressEach()], [createListOfCompaniesWithMultiplePotentialAddresses()]]; +} + +[AfterClass] +public static function tearDownStatic():void +{ +models = null; +} + +[Before] +public function setUp():void +{ +_sut = new _ListWithMXMLBinding(); +_sut.container = this; +_sut.setStyle("skinClass", ListSkin); +_sut.requireSelection = true; +} + +[After] +public function tearDown():void +{ +UIImpersonator.removeAllChildren(); +_sut = null; +} + +[Test(order=2, async, timeout=1000, dataProvider="models", description="this should run after the main test because it rewrites the model")] +public function test_double_bindi
[31/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35351 FLEX-18746 Now unit tests can be run for the mx project, and they're also included in the entire frameworks suite
FLEX-35351 FLEX-18746 Now unit tests can be run for the mx project, and they're also included in the entire frameworks suite Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/b175cd6d Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/b175cd6d Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/b175cd6d Branch: refs/heads/master Commit: b175cd6d2632091f7ef783bbcc068dbfe9735fc1 Parents: cd060ca Author: Mihai Chira Authored: Tue Aug 15 11:10:14 2017 +0200 Committer: Mihai Chira Committed: Tue Aug 15 11:10:14 2017 +0200 -- frameworks/build.xml | 4 frameworks/projects/mx/build.xml | 6 ++ 2 files changed, 10 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b175cd6d/frameworks/build.xml -- diff --git a/frameworks/build.xml b/frameworks/build.xml index 500a186..2e71195 100644 --- a/frameworks/build.xml +++ b/frameworks/build.xml @@ -142,6 +142,7 @@ + @@ -551,6 +552,9 @@ + + + http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b175cd6d/frameworks/projects/mx/build.xml -- diff --git a/frameworks/projects/mx/build.xml b/frameworks/projects/mx/build.xml index f1ad0ad..259c7b6 100644 --- a/frameworks/projects/mx/build.xml +++ b/frameworks/projects/mx/build.xml @@ -229,4 +229,10 @@ + + + + + +
[36/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35362 Added unit test to reproduce the bug. As expected, it currently fails.
FLEX-35362 Added unit test to reproduce the bug. As expected, it currently fails. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/23a306cc Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/23a306cc Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/23a306cc Branch: refs/heads/master Commit: 23a306cc8a08bfb21165aed7647a4f1ba6edbc4b Parents: 243507a Author: Mihai Chira Authored: Wed Oct 18 14:41:02 2017 +0200 Committer: Mihai Chira Committed: Wed Oct 18 14:41:02 2017 +0200 -- .../DropDownListBase_FLEX_35362_Tests.as| 60 1 file changed, 60 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/23a306cc/frameworks/projects/spark/tests/spark/components/DropDownListBase_FLEX_35362_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/DropDownListBase_FLEX_35362_Tests.as b/frameworks/projects/spark/tests/spark/components/DropDownListBase_FLEX_35362_Tests.as new file mode 100644 index 000..1c081df --- /dev/null +++ b/frameworks/projects/spark/tests/spark/components/DropDownListBase_FLEX_35362_Tests.as @@ -0,0 +1,60 @@ +package spark.components { +import flash.events.Event; +import flash.events.EventDispatcher; +import flash.events.KeyboardEvent; +import flash.ui.Keyboard; + +import org.flexunit.asserts.assertTrue; +import org.flexunit.async.Async; +import org.fluint.uiImpersonation.UIImpersonator; + +public class DropDownListBase_FLEX_35362_Tests { +private var _sut:DropDownList; +private static const NO_ENTER_FRAMES_TO_ALLOW:int = 2; +private static var noEnterFramesRemaining:int = NaN; +private static const _finishNotifier:EventDispatcher = new EventDispatcher(); + +[Before] +public function setUp():void +{ +_sut = new DropDownList(); +} + +[After] +public function tearDown():void +{ +_sut = null; +UIImpersonator.removeAllChildren(); +} + +[Test(async, timeout=1000)] +public function test_pressing_END_right_after_opening_doesnt_trigger_fatal():void +{ +//given +UIImpersonator.addChild(_sut); + +noEnterFramesRemaining = NO_ENTER_FRAMES_TO_ALLOW; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_open_drop_down_and_press_key, 300); +} + +private function then_open_drop_down_and_press_key(event:Event, passThroughData:Object):void +{ +//when +_sut.openDropDown(); +_sut.dispatchEvent(new KeyboardEvent(KeyboardEvent.KEY_DOWN, true, false, 0, Keyboard.END, 0, true, false, false, true, false)); + +//then - no fatal thrown +assertTrue(true); +} + +private static function onEnterFrame(event:Event):void +{ +if(!--noEnterFramesRemaining) +{ + UIImpersonator.testDisplay.removeEventListener(Event.ENTER_FRAME, onEnterFrame); +_finishNotifier.dispatchEvent(new Event(Event.COMPLETE)); +} +} +} +}
[34/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-18746 CAUSE: HierarchicalCollectionView.updateLength() was ignoring nodes without children, as it should. However, the function it called for
FLEX-18746 CAUSE: HierarchicalCollectionView.updateLength() was ignoring nodes without children, as it should. However, the function it called for the nodes with children, getChildren() unfortunately had a necessary side-effect (which is a poor design choice, to be sure), which was to add an event listener to the children collection. So the empty collections of nodes were not listened to, which meant that once the node was open any children that were added to that node were not counted towards the length of the collection. And one way this inconsistency surfaced was through the expandItem() fatal. SOLUTION: The best - and most time-consuming - solution to this is to find a way to extract the side-effect of getChildren() into a separate function and call it when needed. However, for the moment I have opted to simply allow getChildren() to be called even for empty nodes, which in turn adds the event listeners. NOTES: all unit tests now pass. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/fcc25865 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/fcc25865 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/fcc25865 Branch: refs/heads/master Commit: fcc25865f43a7f0760da5a5b1849a932349797d8 Parents: 5fb2fb6 Author: Mihai Chira Authored: Wed Aug 16 11:51:05 2017 +0200 Committer: Mihai Chira Committed: Wed Aug 16 11:51:05 2017 +0200 -- frameworks/projects/mx/src/mx/controls/Tree.as| 2 +- .../src/mx/controls/treeClasses/HierarchicalCollectionView.as | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/fcc25865/frameworks/projects/mx/src/mx/controls/Tree.as -- diff --git a/frameworks/projects/mx/src/mx/controls/Tree.as b/frameworks/projects/mx/src/mx/controls/Tree.as index 5f9215a..5bf874f 100644 --- a/frameworks/projects/mx/src/mx/controls/Tree.as +++ b/frameworks/projects/mx/src/mx/controls/Tree.as @@ -1783,7 +1783,7 @@ public class Tree extends List implements IIMESupport // is the item on screen? if (visibleData[uid]) { -//find the rowindex of the row after the open thats opening/closing +//find the row index of the first row after the one that's opening/closing var n:int = listItems.length; for (rowIndex = 0; rowIndex < n; rowIndex++) { http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/fcc25865/frameworks/projects/mx/src/mx/controls/treeClasses/HierarchicalCollectionView.as -- diff --git a/frameworks/projects/mx/src/mx/controls/treeClasses/HierarchicalCollectionView.as b/frameworks/projects/mx/src/mx/controls/treeClasses/HierarchicalCollectionView.as index 5f357b0..59fe7e8 100644 --- a/frameworks/projects/mx/src/mx/controls/treeClasses/HierarchicalCollectionView.as +++ b/frameworks/projects/mx/src/mx/controls/treeClasses/HierarchicalCollectionView.as @@ -267,7 +267,7 @@ public class HierarchicalCollectionView extends EventDispatcher var modelCursor:IViewCursor = treeData.createCursor(); if (modelCursor.beforeFirst) { - // indicates that an IPE occured on the first item + // indicates that an IPE occurred on the first item return treeData.length; } while (!modelCursor.afterLast) @@ -315,8 +315,7 @@ public class HierarchicalCollectionView extends EventDispatcher parentMap[uid] = parent; if (node != null && openNodes[uid] && - dataDescriptor.isBranch(node, treeData) && - dataDescriptor.hasChildren(node, treeData)) + dataDescriptor.isBranch(node, treeData)) { childNodes = getChildren(node); if (childNodes != null) @@ -432,7 +431,7 @@ public class HierarchicalCollectionView extends EventDispatcher /** * @private -* delegate getchildren in order to add event listeners for nested collections +* delegate getChildren in order to add event listeners for nested collections */ private function getChildren(node:Object):ICollectionView {
[11/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35267 Updated unit test - made it easier to read, and now we're also testing GridColumnHeaderGroup.containsGlobalCoordinates(). For the test t
FLEX-35267 Updated unit test - made it easier to read, and now we're also testing GridColumnHeaderGroup.containsGlobalCoordinates(). For the test to pass I've improved the logic in GridHeaderViewLayout.getHeaderIndexAt() which, in turn, made a few functions redundant in GridColumnHeaderGroup. All tests currently pass. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/56abc7db Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/56abc7db Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/56abc7db Branch: refs/heads/master Commit: 56abc7db27bc79bc313db3f6ab4ab2c14f536a4e Parents: 5787e9b Author: Mihai Chira Authored: Wed Mar 29 13:16:54 2017 +0200 Committer: Mihai Chira Committed: Wed Mar 29 13:16:54 2017 +0200 -- .../spark/components/GridColumnHeaderGroup.as | 37 +- .../gridClasses/GridHeaderViewLayout.as | 21 ++- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 132 --- 3 files changed, 99 insertions(+), 91 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/56abc7db/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as -- diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as index 0b202b7..02f3aac 100644 --- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as +++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as @@ -794,7 +794,10 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement public function containsGlobalCoordinates(coordinates:Point):Boolean { -return areCoordinatesOverAHeaderView(coordinates) || areCoordinatesOverPadding(coordinates); +var globalPosition:Point = localToGlobal(new Point(getLayoutBoundsX(), getLayoutBoundsY())); +var bounds:Rectangle = new Rectangle(globalPosition.x, globalPosition.y, getLayoutBoundsWidth(), getLayoutBoundsHeight()); + +return bounds.containsPoint(coordinates); } public function areCoordinatesOverAHeaderView(coordinates:Point):Boolean @@ -802,38 +805,6 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement return getHeaderViewUnderGlobalCoordinates(coordinates) != null; } -public function areCoordinatesOverPadding(coordinates:Point):Boolean -{ -return areCoordinatesOverLeftPadding(coordinates) || areCoordinatesOverTopPadding(coordinates) || areCoordinatesOverBottomPadding(coordinates); -} - -public function areCoordinatesOverLeftPadding(coordinates:Point):Boolean -{ -var paddingLeftStyle:Number = getStyle("paddingLeft"); -var paddingLeft:Number = isNaN(paddingLeftStyle) ? 0 : paddingLeftStyle; - -return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && -getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x + paddingLeft, coordinates.y)) != null; -} - -public function areCoordinatesOverTopPadding(coordinates:Point):Boolean -{ -var paddingTopStyle:Number = getStyle("paddingTop"); -var paddingTop:Number = isNaN(paddingTopStyle) ? 0 : paddingTopStyle; - -return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && -getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y + paddingTop)) != null; -} - -public function areCoordinatesOverBottomPadding(coordinates:Point):Boolean -{ -var paddingBottomStyle:Number = getStyle("paddingBottom"); -var paddingBottom:Number = isNaN(paddingBottomStyle) ? 0 : paddingBottomStyle; - -return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && -getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y - paddingBottom)) != null; -} - //-- // // Methods http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/56abc7db/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as index 4eac8c7..cbdf3eb 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as @@ -503,21 +503,18 @@ public class Gr
[16/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35306 Reverting the fix for FLEX-19651 because it introduced the FLEX-35306 regression.
FLEX-35306 Reverting the fix for FLEX-19651 because it introduced the FLEX-35306 regression. CAUSE: Due to the fix for FLEX-19651, when the data provider is reset on a (DropDown)List right after the selected item (from this new data provider) is set, a validation cycle is forced on the list immediately before the new data provider is assigned to it. As a consequence, ListBase.commitProperties() fails when trying to find the selected item in the data provider (because, for now, it's still the old one, which doesn't have the new item), thus clearing the selection. But if the list had requireSelection set to true, then the first item in the old provider will be selected nonetheless. And if there was a two-way binding between the list and the model, then the model will at this point be rewritten, most probably wrongly. SOLUTION: we're reverting the fix for FLEX-19651, which was a minor bug, and seeing if any mustella or unit tests fail. If so, we'll find other ways to fix FLEX-19651. NOTES: FLEX-19651 doesn't have enough data to reproduce it, so I can't know for sure if it's still there or not. But after playing a bit with multiple selection and data provider changes, as the ticket suggests, there doesn't appear to be any major difference. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/59cefd8e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/59cefd8e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/59cefd8e Branch: refs/heads/master Commit: 59cefd8e3f5aa8c252f8e06bb5a4a27f95509ef4 Parents: d726aee Author: Mihai Chira Authored: Wed May 17 13:31:23 2017 +0200 Committer: Mihai Chira Committed: Wed May 17 13:31:23 2017 +0200 -- .../projects/spark/src/spark/components/List.as | 29 1 file changed, 29 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/59cefd8e/frameworks/projects/spark/src/spark/components/List.as -- diff --git a/frameworks/projects/spark/src/spark/components/List.as b/frameworks/projects/spark/src/spark/components/List.as index c457c5b..d122821 100644 --- a/frameworks/projects/spark/src/spark/components/List.as +++ b/frameworks/projects/spark/src/spark/components/List.as @@ -630,36 +630,7 @@ public class List extends ListBase implements IFocusManagerComponent super.useVirtualLayout = value; } -//-- -// dataProvider -//-- -[Inspectable(category="Data")] - -/** - * @private - * - * @langversion 3.0 - * @playerversion Flash 10 - * @playerversion AIR 1.5 - * @productversion Flex 4 - */ -override public function set dataProvider(value:IList):void -{ -// Uconditionally clear the selection, see SDK-21645. Can't wait -// to commit the selection because it could be set again before -// commitProperties runs and that selection gets lost. -if (!isEmpty(_proposedSelectedIndices) || !isEmpty(selectedIndices)) -{ -_proposedSelectedIndices.length = 0; -multipleSelectionChanged = true; -invalidateProperties(); -UIComponentGlobals.layoutManager.validateClient(this, true); -} -super.dataProvider = value; -} - - //-- // // Properties
[25/50] git commit: [flex-sdk] [refs/heads/master] - sync up our KEYS file with dist
sync up our KEYS file with dist Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/e66554e9 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/e66554e9 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/e66554e9 Branch: refs/heads/master Commit: e66554e9b94d54b2bfc0d6686b4d5a77fed0f325 Parents: 42c7c38 Author: Alex Harui Authored: Sun Jun 18 21:33:43 2017 -0700 Committer: Alex Harui Committed: Sun Jun 18 21:33:43 2017 -0700 -- KEYS | 58 ++ 1 file changed, 58 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/e66554e9/KEYS -- diff --git a/KEYS b/KEYS index 276c4db..b9f884f 100644 --- a/KEYS +++ b/KEYS @@ -356,6 +356,64 @@ Kf5nY0+eTBMDKw6a4ntfEow7jkzzikhWKYDya/NuT/QDF51bC8FnbEdU2D3jDCWN f/WyocyIyPkr7HH0xI7PLn0= =nsEL -END PGP PUBLIC KEY BLOCK- +pub rsa4096/EDF6613E 2016-09-09 +uid [ultimate] Josh Tynjala (CODE SIGNING KEY) +sig 3EDF6613E 2016-09-09 Josh Tynjala (CODE SIGNING KEY) +sub rsa4096/D5780FEF 2016-09-09 +sig EDF6613E 2016-09-09 Josh Tynjala (CODE SIGNING KEY) + +-BEGIN PGP PUBLIC KEY BLOCK- +Version: GnuPG v2 + +mQINBFfS1pABEADHaLgnR7zWW1ROAmHoPwqIHMML/VAVJHULDbQmCifD+7tndr8w +irZaIUUUusATRH8amdhUrTeidVWCD8QJRG71ckBCxiNWXJ08JpeCjuuE3i9DNIpO +nwvhyNA0nOB6uJuC9kncJh8mUTJoEVoqYesc27Qj0PAPUBsv8mGa3KJizhBUFnjc +dHNzpdLkafPYedyuIYbl2HcV3roiyGZ1wPygBAUjX1Hig164i3xUohh2JozIgnRQ +DxW8r30+D/iuTjnKEDoQDOqBLU3cVWV8C+/j/0AJKkLddFOqfW1BkVLHDEecDguh +aGv98Ifccx4ohaX7ll6twp0IgOhqxOYt7BFK3nQz8kCKevcNaYdQRCS1rl0zWrWd +scNXFZ4E0gUZGaKMWZJPsH74kaAfmz8ahRpCtbEtywx6WEnAXR7S4YOqXFQRDNXs +YTcZl98X+2iJhbDkMR22YV1QpyQ3May05fZloeQ84p8mogbOdo5oxr//xIjKKDzI +uJrj3MEUPZXjfK0gnhJk2XwPpavhbUyHUM7PtltPQyHhF+7vPXjT4sJqLCCg8xs0 +7Wb3z/gqF5X0g9CLlRBjHWRx2TymcJMd85Fn+eN94+GADOpJemMC0SABFd0IzJGP +ihc821YG1rcYfirNCtQZHuDXW6f+k765Rl6YIZkO6s6h+A/ZaIpCGpy4vwARAQAB +tDhKb3NoIFR5bmphbGEgKENPREUgU0lHTklORyBLRVkpIDxqb3NodHluamFsYUBh +cGFjaGUub3JnPokCNwQTAQgAIQUCV9LWkAIbAwULCQgHAgYVCAkKCwIEFgIDAQIe +AQIXgAAKCRA3R56q7fZhPlHTD/4jBQyC9lGNlYOPrNsa7pVALdB2asnf5hCo/dxl +EZzgQADZvvBlgGoRFMfEkINHn8BvuCEmLI4AQtTTKCV0vxC3uvyYu+xUGpLOufOK +Q7/38A0HULN5Z6Qp2FPJaX70VD6HvvdFnob9yXhH6FMgXh+DsDCUz2XW/kf86mTW +gWN8t/NyX4EycQ1eGpOJlvCH2mkIOKuhfLaLzPTYVo6WwMoBL5e5Pgprn9GDi8Cx +cWeMw+lAveH9uowAKtz0nvVE5kwC6oZ1pNBQr/BwVdb8YAvgFpt7Z0hxsQaBLiqB +TOi2vMn9TiKOImUw5lNp4tLgWbNHBrSjjkQC+3YL8YYhdSt8Rcc3UJPJch2HkNtq +dKGI6LZIDG7umNMZbA+EPBHcTzf/zjo9z4jc5e07ImpnqCzXG7AhVhxzBNVHPzp5 +mySLwQ+5jH6ftjUHrvU2Kgo7dcpHRIBoy0yqLbCjbrp6d9ajnU2vXUFssteaGzli +6rak2rNXh4d5UlVEUo8GMho6CkapfcGK5qPCKcZGmZidBvV5bvzHLCQlcAOX/yzj +H6tcb5jC4Ue8UhYVoEAvZXzviuEYA6ziLSnqww6itr7lzfX7CWTFCHtfWIUjPChF +aLmiXOz6Tgm/QrPlar8T0kPCxrR3fVExzgxWkSkLN6FcfBQ9O3e2CZEZTFFcuBQ+ +IidE+bkCDQRX0taQARAAsVh1XhC4qYCn7hjyeocLcKsNAJokSpkkx0GWTGBIDfYr +j70t8xOGJuHLi6BljLf10adNb4NE3ZoSfCwaU0z1v5Qba5fQLu26s4t5ltRtwvjX +Pgoj0AliPyKrLYoA7VfQGx9jWFPqIN+KbExrv2VYOKT4Y1X8jBNNS5W3vmlkKksq +wxPkyF1iL8FUoHEuoubKoEok1iK+ts6sGDLreTRFgHYmgMiMQG68oeIoefPYdovW +Ccnauj+TTjP9dcMQUwogWN2aMqYqQE2+Vb2dZAjLqkksyU2PmO6bxNHzS3wAlTWL +sq86Ne8GQP16Jnp8ggUrt0urW8aaAZrvCKkOgDbRGNAG1vIQuhDnlcc0bW/jN+Mt +KupEqWIetgTGbJfl3KyMtPuIBtTBjt+09ZIU8RhAaeDp6qu5cdZ4qd29gALLF9Bg +JCHn780HAX2oBAGBjE5rqQOqx0+vmfqU0yd55+2llXaxT/5TjMvUfyf/+1F7V/Uv +qyAM5P3vohC0e640lNOdPVKcFYeIGqutt/wVqsiVyV1ygbWTFvqcOfXsv8gSsHyL +InWl9/5fjt4lnSNTO7A6/7Y8yQ5M/54J1oKZcG+LyCYerCVzQHgW5u0oJgB7S579 +6y3Ag2AII4LN+eYPEDOzO2GsuU5ChEHOi5njWWDcdihudj5aA7mE6TGYQBOxFqUA +EQEAAYkCHwQYAQgACQUCV9LWkAIbDAAKCRA3R56q7fZhPouXEACnQWZJEhun2Z+T +ZJXOtVsh/FboBPRXbwgWQPV2T2y7BJGA7MPRV5Bt1TeefOq3OVziwt/R78MIzoHx +zbRGi7S6If5RPOIcIqq3YaVhXf4qgAC62pbFjHEQg8dx/J3Z6LvLUae5vQtU9LTp +/N1Dd8GFOO1g9OdBUyu7McDxeBpOiPbduNiJ3V7MyP6CHtdsn7qUgS1DfKGnvE5K +mzfaA3ewPRSYn0Lfhx4Z3YMaeEpHVT4S1+/wGqPtcETxDc8EV9nn46fOhc0OjIDi +5iKk9ByqBCxRG5WdLMVn7rm1EOKRdnegPxpHjr/opsv7YBspjXDg7CaP1O0opk9G +PavEmM6YgsoFLaaXvtGtJEOzjNPvyU1EQGk6g+h3PgM1kMx3F+hmfR3kzzN/qsz/ +VxwruILL6FPuCBxU4szKvHvKuE94SSAQLFMubKK94G1V4h0OtG5RP4wCk/CMRA0/ +7Zc3d8jtuRKssgRdN1oU3Var0t+elo021tP9NvVPB0TldlCeSocJAWjcC0VKyUP/ +jzuepBWPs3515KGS9ReEnMkpLH+34U8SAA8X/Gzo5y1atXvL1bMQOXdtw156aNm2 +cRT7IPR/6Nnb0zto367C+fJcX9y+GojlAv6lX6lDTT+Qxa72SGWF4CYvYCsqXkFK +CR1nUan0cN8sLesf4hK5RUWpX6ww0g== +=mfLU +-END PGP PUBLIC KEY BLOCK- pub 4096R/05061FC8 2017-06-17 Key fingerprint = 4499 8F3E 2427 27E9 4C4B ADEB 6B0A 7EC9 0506 1FC8
[50/50] git commit: [flex-sdk] [refs/heads/master] - Merge commit 'd90867218312b97113ce7c50c5232f6e5ceee9be'
Merge commit 'd90867218312b97113ce7c50c5232f6e5ceee9be' Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ba414443 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ba414443 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ba414443 Branch: refs/heads/master Commit: ba414443032b49c45ff11b61db452c8a8f428bd8 Parents: ea8a5ab d908672 Author: Justin Mclean Authored: Sun Dec 31 11:02:18 2017 +1100 Committer: Justin Mclean Committed: Sun Dec 31 11:02:18 2017 +1100 -- ApproveSDK.xml | 9 +- GIT-TEST.txt| 2 +- KEYS| 116 LICENSE | 3 + README | 4 + RELEASE_NOTES | 42 ++ build.properties| 4 +- frameworks/build.xml| 4 + .../advancedgrids/src/mx/core/Version.as| 2 +- .../airframework/src/mx/core/Version.as | 2 +- .../projects/airspark/src/spark/core/Version.as | 2 +- frameworks/projects/apache/src/core/Version.as | 2 +- .../projects/automation/src/mx/core/Version.as | 2 +- .../automation_agent/src/mx/core/Version.as | 2 +- .../automation_air/src/mx/core/Version.as | 2 +- .../automation_dmv/src/mx/core/Version.as | 2 +- .../src/mx/core/Version.as | 2 +- .../automation_spark/src/mx/core/Version.as | 2 +- .../automation_spark/src/spark/core/Version.as | 2 +- .../projects/charts/src/mx/core/Version.as | 2 +- .../flatspark/src/flatspark/utils/ColorUtils.as | 16 +- .../framework/src/mx/core/FlexVersion.as| 18 +- .../projects/framework/src/mx/core/Version.as | 2 +- .../framework/src/mx/managers/LayoutManager.as | 35 +- .../managers/LayoutManager_FLEX_35321_Tests.as | 295 + frameworks/projects/mx/build.xml| 6 + frameworks/projects/mx/src/mx/controls/Tree.as | 2 +- .../treeClasses/HierarchicalCollectionView.as | 7 +- frameworks/projects/mx/src/mx/core/Version.as | 2 +- .../Tree_FLEX_18746_Collection_Length_Tests.as | 220 +++ .../tests/mx/controls/Tree_FLEX_18746_Tests.as | 146 + frameworks/projects/rpc/src/mx/core/Version.as | 2 +- .../spark/components/GridColumnHeaderGroup.as | 61 +- .../projects/spark/src/spark/components/List.as | 29 - .../spark/src/spark/components/Scroller.as | 4 +- .../gridClasses/GridColumnHeaderView.as | 17 +- .../components/gridClasses/GridDimensions.as| 23 +- .../gridClasses/GridDimensionsView.as | 4 +- .../gridClasses/GridHeaderViewLayout.as | 42 +- .../supportClasses/DropDownListBase.as | 3 +- .../spark/components/supportClasses/ListBase.as | 6 +- .../projects/spark/src/spark/core/Version.as| 2 +- .../DropDownListBase_FLEX_35362_Tests.as| 79 +++ .../spark/components/List_FLEX_35306_Tests.as | 274 .../spark/tests/spark/components/_CompanyVO.as | 68 ++ .../tests/spark/components/_HeadquarterVO.as| 42 ++ .../spark/components/_ListWithMXMLBinding.mxml | 41 ++ .../GridHeaderViewLayout_FLEX_35260_Tests.as| 646 +++ .../spark_dmv/src/spark/core/Version.as | 2 +- frameworks/projects/tool/src/mx/core/Version.as | 2 +- .../projects/tool_air/src/mx/core/Version.as| 2 +- installer.xml | 18 +- .../macromedia/asc/embedding/LintEvaluator.java | 8 +- .../compiler/common/MxmlConfiguration.java | 6 +- .../src/java/flex2/tools/VersionInfo.java | 2 +- releasecandidate.xml| 9 +- 56 files changed, 2175 insertions(+), 174 deletions(-) --
[46/50] git commit: [flex-sdk] [refs/heads/master] - missing headers
missing headers Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7cc34f9c Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7cc34f9c Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7cc34f9c Branch: refs/heads/master Commit: 7cc34f9c85d410aba0442bd6ede9a6590090c392 Parents: 91f196e Author: Alex Harui Authored: Fri Nov 3 14:29:46 2017 -0700 Committer: Alex Harui Committed: Fri Nov 3 14:29:46 2017 -0700 -- .../managers/LayoutManager_FLEX_35321_Tests.as | 19 +++ .../Tree_FLEX_18746_Collection_Length_Tests.as | 19 +++ .../tests/mx/controls/Tree_FLEX_18746_Tests.as | 19 +++ .../DropDownListBase_FLEX_35362_Tests.as | 19 +++ .../spark/tests/spark/components/_CompanyVO.as | 19 +++ .../tests/spark/components/_HeadquarterVO.as | 19 +++ .../spark/components/_ListWithMXMLBinding.mxml | 19 +++ .../GridHeaderViewLayout_FLEX_35260_Tests.as | 19 +++ 8 files changed, 152 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7cc34f9c/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as -- diff --git a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as index 9b0b38c..1c830f4 100644 --- a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as +++ b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as @@ -1,3 +1,22 @@ + +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// + + package mx.managers { import flash.events.Event; import flash.events.EventDispatcher; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7cc34f9c/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as -- diff --git a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as index 1d7a131..4b32a32 100644 --- a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as +++ b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Collection_Length_Tests.as @@ -1,3 +1,22 @@ + +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// + + package mx.controls { import flash.events.Event; import flash.events.EventDispatcher; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7cc34f9c/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as -- diff --git a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Test
[18/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 Adding unit test (currently fails, as expected).
FLEX-35321 Adding unit test (currently fails, as expected). Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/53a77105 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/53a77105 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/53a77105 Branch: refs/heads/master Commit: 53a771056b9f7c8bf7c1127a50f2bd2c7923e0c7 Parents: 2750254 Author: Mihai Chira Authored: Mon Jun 5 14:14:13 2017 +0200 Committer: Mihai Chira Committed: Mon Jun 5 14:14:13 2017 +0200 -- .../managers/LayoutManager_FLEX_35321_Tests.as | 107 +++ 1 file changed, 107 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/53a77105/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as -- diff --git a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as new file mode 100644 index 000..bb969ba --- /dev/null +++ b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as @@ -0,0 +1,107 @@ +package mx.managers { +import mx.core.UIComponentGlobals; +import mx.core.mx_internal; +import mx.events.FlexEvent; + +import org.flexunit.asserts.assertFalse; +import org.flexunit.asserts.assertNull; +import org.fluint.uiImpersonation.UIImpersonator; + +use namespace mx_internal; + +public class LayoutManager_FLEX_35321_Tests +{ +private var _objectWhichIsRemovedOnSizeValidation:SomeComponent; +private var _creationCompleteCalled:Boolean; + +[Before] +public function setUp():void +{ +_creationCompleteCalled = false; +_objectWhichIsRemovedOnSizeValidation = new SomeComponent(); +UIImpersonator.addChild(_objectWhichIsRemovedOnSizeValidation); +} + +[After] +public function tearDown():void +{ +UIImpersonator.removeChild(_objectWhichIsRemovedOnSizeValidation); +_objectWhichIsRemovedOnSizeValidation = null; +} + +[Test] +public function test_object_removed_from_stage_via_code_is_not_initialized():void +{ +//given + UIComponentGlobals.mx_internal::layoutManager.usePhasedInstantiation = false; + _objectWhichIsRemovedOnSizeValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); + +//when +_objectWhichIsRemovedOnSizeValidation.validateNow(); + +//then +assertNull("The object was actually not removed from stage. Huh?", _objectWhichIsRemovedOnSizeValidation.parent); +assertFalse("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", _creationCompleteCalled); +} + +[Test] +public function test_object_removed_from_stage_via_user_action_is_not_initialized():void +{ +//given + UIComponentGlobals.mx_internal::layoutManager.usePhasedInstantiation = true; + _objectWhichIsRemovedOnSizeValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); + +//when +_objectWhichIsRemovedOnSizeValidation.validateNow(); + _objectWhichIsRemovedOnSizeValidation.pretendUserAskedForComponentRemoval(); + +//then +assertNull("The object was actually not removed from stage. Huh?", _objectWhichIsRemovedOnSizeValidation.parent); +assertFalse("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", _creationCompleteCalled); +} + +private function onCreationComplete(event:FlexEvent):void +{ +_creationCompleteCalled = true; +} +} +} + +import flash.events.TimerEvent; +import flash.utils.Timer; + +import mx.core.IVisualElementContainer; +import mx.core.UIComponent; + +class SomeComponent extends UIComponent +{ +private var _timer:Timer = new Timer(1, 1); + +override public function validateSize(recursive:Boolean = false):void +{ +super.validateSize(recursive); +removeFromStage(); +} + +private function removeFromStage():void +{ +if(this.parent) +{ +if(this.parent is IVisualElementContainer) +IVisualElementContainer(this.parent).removeElement(this); +else +this.parent.removeChild(this); +} +} + +public function pretendUserAskedForComponentRemoval():void +{ +_timer.addEventListener(TimerEvent.TIMER_COMPLETE, onTimerComplete); +_timer.start(); +} + +private function onTimerComple
[12/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35267 Updated unit test - made it easier to read, and now we're also testing GridColumnHeaderGroup.containsGlobalCoordinates(). For the test t
FLEX-35267 Updated unit test - made it easier to read, and now we're also testing GridColumnHeaderGroup.containsGlobalCoordinates(). For the test to pass I've improved the logic in GridHeaderViewLayout.getHeaderIndexAt() which, in turn, made a few functions redundant in GridColumnHeaderGroup. All tests currently pass. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a1c61c5c Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a1c61c5c Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a1c61c5c Branch: refs/heads/master Commit: a1c61c5cfd452cb0a150788e498865763890d112 Parents: 56abc7d Author: Mihai Chira Authored: Wed Mar 29 14:26:51 2017 +0200 Committer: Mihai Chira Committed: Wed Mar 29 14:26:51 2017 +0200 -- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 84 ++-- 1 file changed, 61 insertions(+), 23 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a1c61c5c/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as index 1ac5a17..5bc24b4 100644 --- a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as +++ b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as @@ -88,6 +88,7 @@ package spark.components.gridClasses { private static const directions:Array = [ITSELF, N, NE, E, SE, S, SW, W, NW]; private static const COLUMN_HEADER_RECTANGLES:String = "columnHeaderRectangles"; +private static const COLUMN_RECTANGLES:String = "columnRectangles"; private static const ENTIRE_HEADER_RECTANGLE:String = "headerRectangle"; //includes padding private static const MAIN_HEADER_VIEW_RECTANGLE:String = "mainHeaderViewRectangle"; private static const FIXED_HEADER_VIEW_RECTANGLE:String = "fixedHeaderViewRectangle"; @@ -98,11 +99,11 @@ package spark.components.gridClasses { private var _keyPoints:Array; //@TODO add cases with horizontal scroll, and also with fixed columns -//@TODO we probably have to account for paddingTop and paddingBottom as well public static var dimensions:Array = [ /*x, y, width, header padding left, header padding top, header padding bottom, [column widths] */ -[[10, 0, 300, 5, 0, 5, [25, 150]]], -[[0, 0, 300, 5, 0, 0, [25, 150]]] +[[/*x=*/0, /*y=*/ 0, /*width=*/ 300, /*paddingLeft=*/ 5, /*paddingTop=*/ 0, /*paddingBottom=*/ 0, /*columnWidths=*/[25, 150]]], +[[/*x=*/ 10, /*y=*/ 0, /*width=*/ 300, /*paddingLeft=*/ 5, /*paddingTop=*/ 0, /*paddingBottom=*/ 5, /*columnWidths=*/[25, 150]]], +[[/*x=*/ -5, /*y=*/-100, /*width=*/ 200, /*paddingLeft=*/ 25, /*paddingTop=*/ 12, /*paddingBottom=*/ 5, /*columnWidths=*/[100, 150]]] //horizontal scroll ]; @@ -135,22 +136,6 @@ package spark.components.gridClasses { _keyPoints = null; } -/* -[Ignore] -[Test] -public function test_column_index(globalPoint:Array, expectedColumnIndex:int):void -{ -//given -var localPoint:Point = _dataGrid.grid.globalToLocal(new Point(globalPoint[0], globalPoint[1])); - -//when -var columnIndex:int = _dataGrid.grid.getColumnIndexAt(localPoint.x, 0); - -//then -assertEquals(expectedColumnIndex, columnIndex); -} -*/ - [Test(dataProvider="dimensions")] public function test_with_no_scroll(dimensions:Array):void @@ -189,6 +174,7 @@ package spark.components.gridClasses { { assertThatHeaderContainsPointOrNot(point, pointName, currentTransformation); assertThatHeaderIndexIsCorrect(point, pointName, currentTransformation); +assertThatColumnIndexIsCorrect(point, pointName, currentTransformation); assertThatCoordinatesOverHeaderViewOrNot(point, pointName, currentTransformation); } @@ -227,6 +213,17 @@ package spark.components.gridClasses { assertEquals(errorMessageHeaderIndex, expectedHeaderIndex, actualHeaderIndex); } +private function assertThatColumnIndexIsCorrect(point:Point, pointName:String, currentTransformation:Matrix):void +{ +//when +var expectedColumnIndex:int = getColumnIndexAssumption(point); +var actua
[19/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 Made the unit test more realistic (by having the user's action happen in the next frame), and prevented an error when tearDown() tries t
FLEX-35321 Made the unit test more realistic (by having the user's action happen in the next frame), and prevented an error when tearDown() tries to remove a component which is no longer on stage. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5ea79a20 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5ea79a20 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5ea79a20 Branch: refs/heads/master Commit: 5ea79a20f07bba7aab51dd1a45057cf26c48caa0 Parents: 53a7710 Author: Mihai Chira Authored: Wed Jun 7 13:04:32 2017 +0200 Committer: Mihai Chira Committed: Wed Jun 7 13:04:32 2017 +0200 -- .../framework/src/mx/managers/LayoutManager.as | 2 +- .../managers/LayoutManager_FLEX_35321_Tests.as | 36 +++- 2 files changed, 28 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ea79a20/frameworks/projects/framework/src/mx/managers/LayoutManager.as -- diff --git a/frameworks/projects/framework/src/mx/managers/LayoutManager.as b/frameworks/projects/framework/src/mx/managers/LayoutManager.as index 45395ac..feebeff 100644 --- a/frameworks/projects/framework/src/mx/managers/LayoutManager.as +++ b/frameworks/projects/framework/src/mx/managers/LayoutManager.as @@ -780,7 +780,7 @@ public class LayoutManager extends EventDispatcher implements ILayoutManager */ private function doPhasedInstantiation():void { -// trace(">>DoPhasedInstantation"); +// trace(">>DoPhasedInstantiation"); // If phasing, do only one phase: validateProperties(), // validateSize(), or validateDisplayList(). http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5ea79a20/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as -- diff --git a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as index bb969ba..47d5f14 100644 --- a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as +++ b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as @@ -1,16 +1,23 @@ package mx.managers { +import flash.events.Event; +import flash.events.EventDispatcher; + import mx.core.UIComponentGlobals; import mx.core.mx_internal; import mx.events.FlexEvent; import org.flexunit.asserts.assertFalse; import org.flexunit.asserts.assertNull; +import org.flexunit.async.Async; import org.fluint.uiImpersonation.UIImpersonator; use namespace mx_internal; public class LayoutManager_FLEX_35321_Tests { +private static var noEnterFramesRemaining:int = NaN; +private static const _finishNotifier:EventDispatcher = new EventDispatcher(); + private var _objectWhichIsRemovedOnSizeValidation:SomeComponent; private var _creationCompleteCalled:Boolean; @@ -25,7 +32,7 @@ package mx.managers { [After] public function tearDown():void { -UIImpersonator.removeChild(_objectWhichIsRemovedOnSizeValidation); +UIImpersonator.removeAllChildren(); _objectWhichIsRemovedOnSizeValidation = null; } @@ -44,7 +51,7 @@ package mx.managers { assertFalse("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", _creationCompleteCalled); } -[Test] +[Test(async, timeout=500)] public function test_object_removed_from_stage_via_user_action_is_not_initialized():void { //given @@ -55,11 +62,28 @@ package mx.managers { _objectWhichIsRemovedOnSizeValidation.validateNow(); _objectWhichIsRemovedOnSizeValidation.pretendUserAskedForComponentRemoval(); +//then wait 2 frames +noEnterFramesRemaining = 2; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_assert, 300); +} + +private function then_assert(event:Event, passThroughData:Object):void +{ //then assertNull("The object was actually not removed from stage. Huh?", _objectWhichIsRemovedOnSizeValidation.parent); assertFalse("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", _creationCompleteCalled); } +private static function onEnterFrame(event:Event):void +{ +if(!--noEnterFramesRemaining) +{ + UIImpersonator
[01/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35267 FLEX-35260 Added a unit test which can verify the column-index and header-index related functions more thoroughly. Currently it fails, a
Repository: flex-sdk Updated Branches: refs/heads/master ea8a5ab63 -> ba4144430 FLEX-35267 FLEX-35260 Added a unit test which can verify the column-index and header-index related functions more thoroughly. Currently it fails, as expected. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a603b07c Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a603b07c Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a603b07c Branch: refs/heads/master Commit: a603b07c8cc68173be112b3cffe00670f46bf947 Parents: 7185ca6 Author: Mihai Chira Authored: Fri Mar 10 16:56:41 2017 +0100 Committer: Mihai Chira Committed: Fri Mar 10 16:56:41 2017 +0100 -- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 387 +++ 1 file changed, 387 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a603b07c/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as new file mode 100644 index 000..925ea0c --- /dev/null +++ b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as @@ -0,0 +1,387 @@ +package spark.components.gridClasses { +import flash.geom.Matrix; +import flash.geom.Point; +import flash.geom.Rectangle; + +import mx.collections.ArrayCollection; + +import org.flexunit.assertThat; + +import org.flexunit.asserts.assertEquals; +import org.flexunit.runners.Parameterized; +import org.fluint.uiImpersonation.UIImpersonator; + +import spark.components.DataGrid; +import spark.components.GridColumnHeaderGroup; + +/* + Example for two-column table (with no horizontal scroll): + + [pl]: GridColumnHeaderGroup padding left + [lch]: still part of last column header, but beyond last column width + c0: first column header starts here + c1: first column header ends here, second column header (if it exists) starts, and column separator is here + c2: second column header ends here; second column separator is here + ... + cx: last column header ends here; last column separator is here + + d0: first column ends at this x-axis coordinate (but the first header doesn't, due to [pl]) + d1: second column ends at this x-axis coordinate + ... + dx: last column ends at this x-axis coordinate + + e: table ends at this x-axis coordinate + + f0: header ends and grid starts at this y-coordinate + f1: first column ends here and second column (if it exists) begins here + f2: second column ends here and third column (if it exists) begins here + ... + fx: last column ends here + + g0: bottom-left point of first column header + g1: bottom-right point of first column header + g2: bottom-right point of second column header + ... + gx: bottom-right point of (last column header - [lch]) + + h: bottom-right point of last column header and x-coordinate at end of data grid + + And for each point we generate the 8 adjacent points: + (x+1, y), (x+1, y+1), (x+1, y-1), + (x-1, y), (x-1, y+1), (x-1, y-1), + (x, y-1), (x, y-1). For easier comprehension we mark them + using cardinal points: N, NE, E, SE, S, SW, W, NW. + ...and we check various boundaries against all of them + + a (0, 0) + ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ + âââââbââââc0ââââââd0âââc1ââââââââââââââââââââââââââââd1ââc2âââââââââeâââââââ + ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ + ââââââ[pl]ââââINDEXâââââââââââââââââââââNAMEâââââââââââââââââ[lch]ââââââââââ + ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ + âââââf0âââg0ââââââf1âââg1ââââââ
[23/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 CAUSE: If a component is removed from stage during a validation cycle, the LayoutManager nevertheless sets its initialized flag to true,
FLEX-35321 CAUSE: If a component is removed from stage during a validation cycle, the LayoutManager nevertheless sets its initialized flag to true, even if it's not on stage anymore. That's because it doesn't check at the end whether the component is still on stage. SOLUTION: Now the LayoutManager verifies that the component is still on stage before initializing it. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9c5cbbe5 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9c5cbbe5 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9c5cbbe5 Branch: refs/heads/master Commit: 9c5cbbe553c9d8afe7982f3ba4bf178ee563bf35 Parents: 442b5f8 Author: Mihai Chira Authored: Sat Jun 10 13:36:47 2017 +0200 Committer: Mihai Chira Committed: Sat Jun 10 13:36:47 2017 +0200 -- .../framework/src/mx/managers/LayoutManager.as | 28 1 file changed, 17 insertions(+), 11 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9c5cbbe5/frameworks/projects/framework/src/mx/managers/LayoutManager.as -- diff --git a/frameworks/projects/framework/src/mx/managers/LayoutManager.as b/frameworks/projects/framework/src/mx/managers/LayoutManager.as index feebeff..d070203 100644 --- a/frameworks/projects/framework/src/mx/managers/LayoutManager.as +++ b/frameworks/projects/framework/src/mx/managers/LayoutManager.as @@ -846,11 +846,14 @@ public class LayoutManager extends EventDispatcher implements ILayoutManager var obj:ILayoutManagerClient = ILayoutManagerClient(updateCompleteQueue.removeLargest()); while (obj) { -if (!obj.initialized && obj.processedDescriptors) -obj.initialized = true; -if (obj.hasEventListener(FlexEvent.UPDATE_COMPLETE)) -obj.dispatchEvent(new FlexEvent(FlexEvent.UPDATE_COMPLETE)); -obj.updateCompletePendingFlag = false; +if(obj.nestLevel) +{ +if (!obj.initialized && obj.processedDescriptors) +obj.initialized = true; +if (obj.hasEventListener(FlexEvent.UPDATE_COMPLETE)) +obj.dispatchEvent(new FlexEvent(FlexEvent.UPDATE_COMPLETE)); +obj.updateCompletePendingFlag = false; +} obj = ILayoutManagerClient(updateCompleteQueue.removeLargest()); } @@ -1094,12 +1097,15 @@ public class LayoutManager extends EventDispatcher implements ILayoutManager obj = ILayoutManagerClient(updateCompleteQueue.removeLargestChild(target)); while (obj) { -if (!obj.initialized) -obj.initialized = true; - -if (obj.hasEventListener(FlexEvent.UPDATE_COMPLETE)) -obj.dispatchEvent(new FlexEvent(FlexEvent.UPDATE_COMPLETE)); -obj.updateCompletePendingFlag = false; +if(obj.nestLevel) +{ +if (!obj.initialized) +obj.initialized = true; + +if (obj.hasEventListener(FlexEvent.UPDATE_COMPLETE)) +obj.dispatchEvent(new FlexEvent(FlexEvent.UPDATE_COMPLETE)); +obj.updateCompletePendingFlag = false; +} obj = ILayoutManagerClient(updateCompleteQueue.removeLargestChild(target)); } }
[13/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35267 Updated unit test to support horizontal scrolling and two new grid profiles. Currently tests fail, but for perplexing reasons (seems lik
FLEX-35267 Updated unit test to support horizontal scrolling and two new grid profiles. Currently tests fail, but for perplexing reasons (seems like a failure to validate, despite the unit test calling validateNow() way too many times...). Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7d3073bb Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7d3073bb Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7d3073bb Branch: refs/heads/master Commit: 7d3073bb34cf4a5853039bab63e6df8d1f47cd65 Parents: a1c61c5 Author: Mihai Chira Authored: Wed Apr 5 18:33:03 2017 +0200 Committer: Mihai Chira Committed: Wed Apr 5 18:33:03 2017 +0200 -- .../spark/src/spark/components/Scroller.as | 4 +- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 313 --- 2 files changed, 200 insertions(+), 117 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7d3073bb/frameworks/projects/spark/src/spark/components/Scroller.as -- diff --git a/frameworks/projects/spark/src/spark/components/Scroller.as b/frameworks/projects/spark/src/spark/components/Scroller.as index 3ca9155..4db6528 100644 --- a/frameworks/projects/spark/src/spark/components/Scroller.as +++ b/frameworks/projects/spark/src/spark/components/Scroller.as @@ -759,8 +759,8 @@ public class Scroller extends SkinnableComponent /** * @private - * These are the minimum and maximum scroll possitions allowed - * for both axes. They determine the points at which bounce and + * These are the minimum and maximum scroll positions allowed + * for both axes. They determine the points at which bounce and * pull occur. */ private var minVerticalScrollPosition:Number = 0; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7d3073bb/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as index 5bc24b4..3fb4b92 100644 --- a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as +++ b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as @@ -1,4 +1,7 @@ package spark.components.gridClasses { +import flash.events.Event; +import flash.events.EventDispatcher; + import flash.geom.Matrix; import flash.geom.Point; import flash.geom.Rectangle; @@ -8,6 +11,8 @@ package spark.components.gridClasses { import org.flexunit.assertThat; import org.flexunit.asserts.assertEquals; +import org.flexunit.asserts.assertTrue; +import org.flexunit.async.Async; import org.flexunit.runners.Parameterized; import org.fluint.uiImpersonation.UIImpersonator; @@ -87,22 +92,28 @@ package spark.components.gridClasses { private static const ITSELF:Matrix = new Matrix(1, 0, 0, 1, 0, 0); //the point, unmodified private static const directions:Array = [ITSELF, N, NE, E, SE, S, SW, W, NW]; -private static const COLUMN_HEADER_RECTANGLES:String = "columnHeaderRectangles"; -private static const COLUMN_RECTANGLES:String = "columnRectangles"; -private static const ENTIRE_HEADER_RECTANGLE:String = "headerRectangle"; //includes padding -private static const MAIN_HEADER_VIEW_RECTANGLE:String = "mainHeaderViewRectangle"; +private static const ENTIRE_HEADER_RECTANGLE:String = "visibleHeaderRectangle"; //includes padding private static const FIXED_HEADER_VIEW_RECTANGLE:String = "fixedHeaderViewRectangle"; +private static const NO_ENTER_FRAMES_TO_ALLOW:int = 2; + private static var _dataGrid:DataGrid; +private static const _finishNotifier:EventDispatcher = new EventDispatcher(); private var _keyRectangles:Array; private var _keyPoints:Array; +private var _dimensions:Array; +private var _noEnterFramesRemaining:int = NaN; -//@TODO add cases with horizontal scroll, and also with fixed columns -public static var dimensions:Array = [ +//@TODO add cases with fixed columns +//@TODO can the grid itself have padding? +//@TODO test with a columnGap as well +public static var allDimensions:Array = [ /*x, y, width, header padding left, header padding top, header padding bottom, [column widths] */ [[/*x=*/0, /*y=*/ 0, /*width=*/ 300, /*paddingLeft=*/ 5,
[15/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35260 When calling localToGlobal() on gridColumnHeaderGroup, the result does not reflect its horizontal scroll position, which means that we n
FLEX-35260 When calling localToGlobal() on gridColumnHeaderGroup, the result does not reflect its horizontal scroll position, which means that we need to include it manually (in GridHeaderViewLayout.getHeaderIndexAt()). However, the 'x' function argument is assumed to include it, so we're not adding it anymore when calling GridDimensionsView.getColumnIndexAt(). Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d726aee2 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d726aee2 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d726aee2 Branch: refs/heads/master Commit: d726aee2da04bd796ab91fa1960d7e55d47cde44 Parents: 60ccf24 Author: Mihai Chira Authored: Wed Apr 12 15:16:39 2017 +0200 Committer: Mihai Chira Committed: Wed Apr 12 15:16:39 2017 +0200 -- .../projects/spark/src/spark/components/GridColumnHeaderGroup.as | 4 ++-- .../src/spark/components/gridClasses/GridHeaderViewLayout.as | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d726aee2/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as -- diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as index 3d51fd8..63a0eb3 100644 --- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as +++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as @@ -1039,11 +1039,11 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement // TODO: apologize for stashing the separatorIndex in headerCP.rowIndex private function eventToHeaderLocations(event:MouseEvent, headerCP:CellPosition, headerXY:Point):Boolean { -const view:Group = getHeaderViewUnderGlobalCoordinates(new Point(event.stageX, event.stageY)); +const stageXY:Point = new Point(event.stageX, event.stageY); +const view:Group = getHeaderViewUnderGlobalCoordinates(stageXY); if (!view) return false; - const stageXY:Point = new Point(event.stageX, event.stageY); const viewXY:Point = view.globalToLocal(stageXY); const viewLayout:GridHeaderViewLayout = view.layout as GridHeaderViewLayout; const gdv:GridDimensionsView = viewLayout.gridView.gridViewLayout.gridDimensionsView; http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d726aee2/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as -- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as index cbdf3eb..9432c0a 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridHeaderViewLayout.as @@ -501,14 +501,14 @@ public class GridHeaderViewLayout extends LayoutBase public function getHeaderIndexAt(x:Number, y:Number):int { var headerIndex:int = -1; -var globalPoint:Point = gridColumnHeaderGroup.localToGlobal(new Point(x, y)); +var globalPoint:Point = gridColumnHeaderGroup.localToGlobal(new Point(x - horizontalScrollPosition, y)); if(gridColumnHeaderGroup.areCoordinatesOverAHeaderView(globalPoint)) { var paddingLeftStyle:Number = gridColumnHeaderGroup.getStyle("paddingLeft"); var paddingLeft:Number = isNaN(paddingLeftStyle) ? 0 : paddingLeftStyle; -headerIndex = gridView.gridViewLayout.gridDimensionsView.getColumnIndexAt(x - paddingLeft + horizontalScrollPosition, y); +headerIndex = gridView.gridViewLayout.gridDimensionsView.getColumnIndexAt(x - paddingLeft, y); if(headerIndex == -1) {
[42/50] git commit: [flex-sdk] [refs/heads/master] - More version updates
More version updates Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/0e0220da Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/0e0220da Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/0e0220da Branch: refs/heads/master Commit: 0e0220da3495be9b859dc25e19d84ee7b18e8881 Parents: d474c80 Author: Piotr Zarzycki Authored: Mon Oct 30 22:00:31 2017 +0100 Committer: Piotr Zarzycki Committed: Mon Oct 30 22:00:31 2017 +0100 -- .../projects/framework/src/mx/core/FlexVersion.as | 16 +++- .../flex2/compiler/common/MxmlConfiguration.java| 6 -- 2 files changed, 19 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/0e0220da/frameworks/projects/framework/src/mx/core/FlexVersion.as -- diff --git a/frameworks/projects/framework/src/mx/core/FlexVersion.as b/frameworks/projects/framework/src/mx/core/FlexVersion.as index 08650af..6eca239 100644 --- a/frameworks/projects/framework/src/mx/core/FlexVersion.as +++ b/frameworks/projects/framework/src/mx/core/FlexVersion.as @@ -58,7 +58,21 @@ public class FlexVersion */ public static const CURRENT_VERSION:uint = 0x0410; - /** + /** +* The compatibilityVersion value of Flex 4.16.1, +* encoded numerically as a uint. +* Code can compare this constant against +* the compatibilityVersion +* to implement version-specific behavior. +* +* @langversion 3.0 +* @playerversion Flash 11 +* @playerversion AIR 3 +* @productversion Apache Flex 4.16.1 +*/ + public static const VERSION_4_16_1:uint = 0x0411; + + /** * The compatibilityVersion value of Flex 4.16, * encoded numerically as a uint. * Code can compare this constant against http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/0e0220da/modules/compiler/src/java/flex2/compiler/common/MxmlConfiguration.java -- diff --git a/modules/compiler/src/java/flex2/compiler/common/MxmlConfiguration.java b/modules/compiler/src/java/flex2/compiler/common/MxmlConfiguration.java index 08a9c0c..1614611 100644 --- a/modules/compiler/src/java/flex2/compiler/common/MxmlConfiguration.java +++ b/modules/compiler/src/java/flex2/compiler/common/MxmlConfiguration.java @@ -46,6 +46,8 @@ public class MxmlConfiguration // // 'compiler.mxml.compatibility-version' option // + public static final int VERSION_4_16_1 = 0x0411; + public static final int VERSION_4_16 = 0x0410; public static final int VERSION_4_15 = 0x040f; public static final int VERSION_4_14_1 = 0x040e0001; public static final int VERSION_4_14 = 0x040e; @@ -63,10 +65,10 @@ public class MxmlConfiguration public static final int VERSION_3_0 = 0x0300; public static final int VERSION_2_0_1 = 0x0201; public static final int VERSION_2_0 = 0x0200; -public static final int CURRENT_VERSION = VERSION_4_15; +public static final int CURRENT_VERSION = VERSION_4_16_1; public static final int EARLIEST_MAJOR_VERSION = 3; public static final int LATEST_MAJOR_VERSION = 4; -public static final int LATEST_MINOR_VERSION = 15; +public static final int LATEST_MINOR_VERSION = 16; private int major = LATEST_MAJOR_VERSION; private int minor = LATEST_MINOR_VERSION;
[08/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35260 Now the unit test passes, having been updated to check the column header view boundaries. Other changes: -Now we're ignoring the grid he
FLEX-35260 Now the unit test passes, having been updated to check the column header view boundaries. Other changes: -Now we're ignoring the grid header's right padding, because it doesn't make a visual difference (except in the edge case where, together with the left and right padding, the column widths are wider than the grid's width, in which case the grid header expands beyond the grid limits), but we are starting to take into account bottom and top padding. -Renamed some variables and functions for clarity in GridColumnHeaderView and GridDimensions. -Improved error messages in the unit test Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d7299c33 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d7299c33 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d7299c33 Branch: refs/heads/master Commit: d7299c330fe7bbfd348a8db03258cb3ab777e32b Parents: 9e2620e Author: Mihai Chira Authored: Thu Mar 16 12:45:29 2017 +0100 Committer: Mihai Chira Committed: Thu Mar 16 12:45:29 2017 +0100 -- .../spark/components/GridColumnHeaderGroup.as | 32 ++-- .../gridClasses/GridColumnHeaderView.as | 15 ++-- .../components/gridClasses/GridDimensions.as| 14 ++-- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 81 +++- 4 files changed, 104 insertions(+), 38 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d7299c33/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as -- diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as index a9209a1..0b202b7 100644 --- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as +++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as @@ -783,6 +783,15 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement return (_visibleSortIndicatorIndices.indexOf(columnIndex) != -1); } +/** + * True if either of this GridColumnHeaderGroup's views contains the global + * coordinates in the event, or if they fall over this component's padding. + */ +public function containsMouseEvent(event:MouseEvent):Boolean +{ +return containsGlobalCoordinates(new Point(event.stageX, event.stageY)); +} + public function containsGlobalCoordinates(coordinates:Point):Boolean { return areCoordinatesOverAHeaderView(coordinates) || areCoordinatesOverPadding(coordinates); @@ -795,7 +804,7 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement public function areCoordinatesOverPadding(coordinates:Point):Boolean { -return areCoordinatesOverLeftPadding(coordinates) || areCoordinatesOverRightPadding(coordinates); +return areCoordinatesOverLeftPadding(coordinates) || areCoordinatesOverTopPadding(coordinates) || areCoordinatesOverBottomPadding(coordinates); } public function areCoordinatesOverLeftPadding(coordinates:Point):Boolean @@ -807,13 +816,22 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x + paddingLeft, coordinates.y)) != null; } -public function areCoordinatesOverRightPadding(coordinates:Point):Boolean +public function areCoordinatesOverTopPadding(coordinates:Point):Boolean +{ +var paddingTopStyle:Number = getStyle("paddingTop"); +var paddingTop:Number = isNaN(paddingTopStyle) ? 0 : paddingTopStyle; + +return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && +getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y + paddingTop)) != null; +} + +public function areCoordinatesOverBottomPadding(coordinates:Point):Boolean { -var paddingRightStyle:Number = getStyle("paddingRight"); -var paddingRight:Number = isNaN(paddingRightStyle) ? 0 : paddingRightStyle; +var paddingBottomStyle:Number = getStyle("paddingBottom"); +var paddingBottom:Number = isNaN(paddingBottomStyle) ? 0 : paddingBottomStyle; return getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y)) == null && -getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y - paddingRight)) != null; +getHeaderViewUnderGlobalCoordinates(new Point(coordinates.x, coordinates.y - paddingBottom)) != null; } //-- @@ -1037,11 +1055,11 @@ public class GridColumnHeaderGroup extends
[30/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-18746 Renamed the main test function and increased the timeout a bit.
FLEX-18746 Renamed the main test function and increased the timeout a bit. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/cd060ca2 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/cd060ca2 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/cd060ca2 Branch: refs/heads/master Commit: cd060ca27b7f9c1cad1e3c9045cfbc64614d01e3 Parents: f804380 Author: Mihai Chira Authored: Tue Aug 15 11:02:24 2017 +0200 Committer: Mihai Chira Committed: Tue Aug 15 11:02:24 2017 +0200 -- .../projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/cd060ca2/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as -- diff --git a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as index 5d64b06..26568d6 100644 --- a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as +++ b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as @@ -46,7 +46,7 @@ package mx.controls { //-- [Test(async, timeout=1000)] -public function test_object_removed_from_stage_via_code_is_not_initialized():void +public function test_closing_previously_opened_folder_with_0_children_does_not_throw_fatal():void { //given const dataProvider:ArrayCollection = new ArrayCollection(); @@ -59,7 +59,7 @@ package mx.controls { //then wait a few frames noEnterFramesToWait = 2; UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); -Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_second_folder, 200); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_second_folder, 300); }
[27/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35329: fixed issue where initializing member variable/constant that is [Deprecated] incorrectly throws extra warning
FLEX-35329: fixed issue where initializing member variable/constant that is [Deprecated] incorrectly throws extra warning Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/bb7447f5 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/bb7447f5 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/bb7447f5 Branch: refs/heads/master Commit: bb7447f5ebe32ce58f85a9e9b2d2ffc48994cf42 Parents: e66554e Author: Josh Tynjala Authored: Thu Jun 22 10:53:50 2017 -0700 Committer: Josh Tynjala Committed: Thu Jun 22 10:53:50 2017 -0700 -- RELEASE_NOTES | 42 .../macromedia/asc/embedding/LintEvaluator.java | 8 +++- 2 files changed, 49 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/bb7447f5/RELEASE_NOTES -- diff --git a/RELEASE_NOTES b/RELEASE_NOTES index 5aaadc3..b82ea1f 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -1,3 +1,45 @@ +Apache Flex 4.17.0 +== + + +New Features + + + +AIR and Flash Player Support + + + +Bug Fixes +- +FLEX-35329 Initializing member variable/constant that is [Deprecated] +incorrectly throws extra warning + +Known Issues + + +Adobe Flash Builder Integration + +Adobe Flash Builder 4.7 and Adobe Flash Builder 4.6 both contain a bug where, +when generating the .mxml file for a new project that uses Apache Flex SDK +4.10.0 or later Spark Application, Flash Builder will incorrectly insert the +attribute: + +layout="absolute" + +This results in a compile error in the new project. The remedy is to simply +remove the errant attribute. + +The following wiki page has been set up to contain the latest news on Adobe's +attempt to correct this problem: + + https://cwiki.apache.org/confluence/display/FLEX/Adobe+Flash+Builder+'New+Project'+Bug + +Adobe has provided a patch for Flash Builder 4.7 that resolves this issue: + +http://helpx.adobe.com/flash-builder/kb/flex-new-project-issue--.html + + Apache Flex 4.16.0 == http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/bb7447f5/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java -- diff --git a/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java b/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java index de2ea96..359af64 100644 --- a/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java +++ b/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java @@ -749,8 +749,14 @@ public final class LintEvaluator extends Emitter implements Evaluator, ErrorCons boolean is_unbound_ref = is_unbound_dotref || is_unbound_lexref || is_unbound_globalref; - if (slot != null ) + if (slot != null && !(node.expr instanceof QualifiedIdentifierNode)) + { + //if it's a qualified identifier node, then it's a member/static + //variable on a class that is being initialized, like this: + //public var memberVar:String = "hi"; + //this case should not have a warning! checkDeprecatedSlot(cx, node.expr, node.ref, slot); + } // special case to avoid warning on access to a Class's prototype property. This // property can't be expressed in global.as because you can't both declare a class
[43/50] git commit: [flex-sdk] [refs/heads/master] - Change CURRENT_VERSION to 4.16.1
Change CURRENT_VERSION to 4.16.1 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/0b9764c0 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/0b9764c0 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/0b9764c0 Branch: refs/heads/master Commit: 0b9764c0133e68b6b689ab8ab89ff99fda821d82 Parents: 0e0220d Author: Piotr Zarzycki Authored: Mon Oct 30 23:20:17 2017 +0100 Committer: Piotr Zarzycki Committed: Mon Oct 30 23:20:17 2017 +0100 -- frameworks/projects/framework/src/mx/core/FlexVersion.as | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/0b9764c0/frameworks/projects/framework/src/mx/core/FlexVersion.as -- diff --git a/frameworks/projects/framework/src/mx/core/FlexVersion.as b/frameworks/projects/framework/src/mx/core/FlexVersion.as index 6eca239..21a99b3 100644 --- a/frameworks/projects/framework/src/mx/core/FlexVersion.as +++ b/frameworks/projects/framework/src/mx/core/FlexVersion.as @@ -56,7 +56,7 @@ public class FlexVersion * @playerversion AIR 1.1 * @productversion Flex 3 */ -public static const CURRENT_VERSION:uint = 0x0410; +public static const CURRENT_VERSION:uint = 0x0411; /** * The compatibilityVersion value of Flex 4.16.1,
[37/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35362 CAUSE: the DropDownController signals that the DropDownListBase is open immediately, even before the latter has actually made that chang
FLEX-35362 CAUSE: the DropDownController signals that the DropDownListBase is open immediately, even before the latter has actually made that change on stage. Since the opening takes one or two frames, it leaves a few milliseconds in which code which relies on that open/closed state erroneously assumes that it can use elements that should be on stage or initialized. In this case it's the layout property, which, due to the skin of the DropDownList, is only initialized once the drop down is actually open. SOLUTION: we check whether the layout is not-null, and if it is, we select items in the list as if it were closed. NOTES: -also edited some comments, simplified Array instantiation, and removed an empty constructor. -now the unit test will pass. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/4c601832 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/4c601832 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/4c601832 Branch: refs/heads/master Commit: 4c60183258caf23020d7398f6d2ffdab747d0e56 Parents: 23a306c Author: Mihai Chira Authored: Wed Oct 18 14:56:22 2017 +0200 Committer: Mihai Chira Committed: Wed Oct 18 14:56:22 2017 +0200 -- .../flatspark/src/flatspark/utils/ColorUtils.as | 16 .../components/supportClasses/DropDownListBase.as | 3 +-- .../src/spark/components/supportClasses/ListBase.as | 6 +++--- 3 files changed, 8 insertions(+), 17 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4c601832/frameworks/projects/flatspark/src/flatspark/utils/ColorUtils.as -- diff --git a/frameworks/projects/flatspark/src/flatspark/utils/ColorUtils.as b/frameworks/projects/flatspark/src/flatspark/utils/ColorUtils.as index 09f9cb2..e9007c3 100644 --- a/frameworks/projects/flatspark/src/flatspark/utils/ColorUtils.as +++ b/frameworks/projects/flatspark/src/flatspark/utils/ColorUtils.as @@ -45,15 +45,10 @@ package flatspark.utils public static const Concrete:uint = 0x95A5A6; public static const Asbestos:uint = 0x7F8C8D; - public function ColorUtils() - { - - } - public static function ButtonColor(brand:int, estado:State):uint { // All the possible colors - var cores:Array = new Array( + var cores:Array = [ ButtonColorEnum.PrimaryUp, ButtonColorEnum.PrimaryHover, ButtonColorEnum.PrimaryDown, ButtonColorEnum.PrimaryDisabled, ButtonColorEnum.SuccessUp, ButtonColorEnum.SuccessHover, ButtonColorEnum.SuccessDown, ButtonColorEnum.SuccessDisabled, ButtonColorEnum.WarningUp, ButtonColorEnum.WarningHover, ButtonColorEnum.WarningDown, ButtonColorEnum.WarningDisabled, @@ -61,7 +56,7 @@ package flatspark.utils ButtonColorEnum.DefaultUp, ButtonColorEnum.DefaultHover, ButtonColorEnum.DefaultDown, ButtonColorEnum.DefaultDisabled, ButtonColorEnum.InfoUp, ButtonColorEnum.InfoHover, ButtonColorEnum.InfoDown, ButtonColorEnum.InfoDisabled, ButtonColorEnum.DangerUp, ButtonColorEnum.DangerHover, ButtonColorEnum.DangerDown, ButtonColorEnum.DangerDisabled - ); + ]; // Map all the allowed states var numeroEstado:int = 1; @@ -80,11 +75,8 @@ package flatspark.utils numeroEstado = 3; break; } - - var posicao:int = 1; - posicao = 4 * (brand - 1) + (numeroEstado - 1); - - return cores[posicao]; + + return cores[4 * (brand - 1) + (numeroEstado - 1)]; } } } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4c601832/frameworks/projects/spark/src/spark/components/supportClasses/DropDownListBase.as -- diff --git a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownListBase.as b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownListBase.as index aaba442..c80c2b4 100644 --- a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownListBase.as +++ b/frameworks/projects/spark/src/spark/components/supportClasses/DropDown
[20/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35321 LayoutManager.validateNow() doesn't use phased instantiation, so it wasn't the best idea to test it with that, at least the test where w
FLEX-35321 LayoutManager.validateNow() doesn't use phased instantiation, so it wasn't the best idea to test it with that, at least the test where we fake a user request for the removal of the component in the next frame. Also added a test that tries to make sure that objects removed from stage and then readded are indeed validated and initialized. Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f475aed9 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f475aed9 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f475aed9 Branch: refs/heads/master Commit: f475aed995adc5206a27ad6fc8cf80224ed425fb Parents: 5ea79a2 Author: Mihai Chira Authored: Sat Jun 10 10:33:28 2017 +0200 Committer: Mihai Chira Committed: Sat Jun 10 10:33:28 2017 +0200 -- .../managers/LayoutManager_FLEX_35321_Tests.as | 104 --- 1 file changed, 88 insertions(+), 16 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f475aed9/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as -- diff --git a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as index 47d5f14..a23d002 100644 --- a/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as +++ b/frameworks/projects/framework/tests/mx/managers/LayoutManager_FLEX_35321_Tests.as @@ -6,7 +6,8 @@ package mx.managers { import mx.core.mx_internal; import mx.events.FlexEvent; -import org.flexunit.asserts.assertFalse; +import org.flexunit.asserts.assertEquals; +import org.flexunit.asserts.assertNotNull; import org.flexunit.asserts.assertNull; import org.flexunit.async.Async; import org.fluint.uiImpersonation.UIImpersonator; @@ -19,14 +20,15 @@ package mx.managers { private static const _finishNotifier:EventDispatcher = new EventDispatcher(); private var _objectWhichIsRemovedOnSizeValidation:SomeComponent; -private var _creationCompleteCalled:Boolean; +private var _creationCompleteCalls:int; [Before] public function setUp():void { -_creationCompleteCalled = false; +_creationCompleteCalls = 0; _objectWhichIsRemovedOnSizeValidation = new SomeComponent(); -UIImpersonator.addChild(_objectWhichIsRemovedOnSizeValidation); + _objectWhichIsRemovedOnSizeValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); +UIImpersonator.addElement(_objectWhichIsRemovedOnSizeValidation); } [After] @@ -41,14 +43,14 @@ package mx.managers { { //given UIComponentGlobals.mx_internal::layoutManager.usePhasedInstantiation = false; - _objectWhichIsRemovedOnSizeValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); + _objectWhichIsRemovedOnSizeValidation.removeFromStageOnValidateProperties = true; //when _objectWhichIsRemovedOnSizeValidation.validateNow(); //then assertNull("The object was actually not removed from stage. Huh?", _objectWhichIsRemovedOnSizeValidation.parent); -assertFalse("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", _creationCompleteCalled); +assertEquals("Yep, this is the bug. Why call initialized=true on an object that's not on stage?", 0, _creationCompleteCalls); } [Test(async, timeout=500)] @@ -56,25 +58,79 @@ package mx.managers { { //given UIComponentGlobals.mx_internal::layoutManager.usePhasedInstantiation = true; - _objectWhichIsRemovedOnSizeValidation.addEventListener(FlexEvent.CREATION_COMPLETE, onCreationComplete); + _objectWhichIsRemovedOnSizeValidation.removeFromStageOnValidateProperties = false; //when -_objectWhichIsRemovedOnSizeValidation.validateNow(); - _objectWhichIsRemovedOnSizeValidation.pretendUserAskedForComponentRemoval(); +_objectWhichIsRemovedOnSizeValidation.invalidateDisplayList(); +_objectWhichIsRemovedOnSizeValidation.invalidateProperties(); +_objectWhichIsRemovedOnSizeValidation.invalidateSize(); + +//then wait 1 frame +noEnterFramesRemaining = 1; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_remove_from_stage_in_next_frame, 300); +} + +private func
[49/50] git commit: [flex-sdk] [refs/heads/master] - Update apache rat in ApproveSDK script
Update apache rat in ApproveSDK script Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d9086721 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d9086721 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d9086721 Branch: refs/heads/master Commit: d90867218312b97113ce7c50c5232f6e5ceee9be Parents: f1fac8f Author: Piotr Zarzycki Authored: Sun Nov 12 22:40:53 2017 +0100 Committer: Piotr Zarzycki Committed: Sun Nov 12 22:40:53 2017 +0100 -- ApproveSDK.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d9086721/ApproveSDK.xml -- diff --git a/ApproveSDK.xml b/ApproveSDK.xml index bce723e..903655d 100644 --- a/ApproveSDK.xml +++ b/ApproveSDK.xml @@ -54,10 +54,10 @@ - - -http://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.11"; /> -http://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat-tasks/0.11"; /> + + +http://central.maven.org/maven2/org/apache/rat/apache-rat/0.12"; /> +http://central.maven.org/maven2/org/apache/rat/apache-rat-tasks/0.12"; />
[05/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-35260 Now in the unit test we're also verifying areCoordinatesOverAHeaderView(). Currently fails (for point "b").
FLEX-35260 Now in the unit test we're also verifying areCoordinatesOverAHeaderView(). Currently fails (for point "b"). Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9e2620e5 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9e2620e5 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9e2620e5 Branch: refs/heads/master Commit: 9e2620e5bc2b08567fc33f16116f30d4b0e054f0 Parents: f985937 Author: Mihai Chira Authored: Tue Mar 14 13:46:27 2017 +0100 Committer: Mihai Chira Committed: Tue Mar 14 13:46:27 2017 +0100 -- .../GridHeaderViewLayout_FLEX_35260_Tests.as| 63 ++-- 1 file changed, 44 insertions(+), 19 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9e2620e5/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as -- diff --git a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as index 925ea0c..55421f4 100644 --- a/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as +++ b/frameworks/projects/spark/tests/spark/components/gridClasses/GridHeaderViewLayout_FLEX_35260_Tests.as @@ -89,6 +89,7 @@ package spark.components.gridClasses { private var _keyRectangles:Array; private var _keyPoints:Array; +//@TODO add cases with horizontal scroll, and also with fixed columns public static var dimensions:Array = [/*x, y, width, header padding left, header padding top, [column widths] */ [[10, 0, 300, 5, 0, [25, 150]]], [[0, 0, 300, 5, 0, [25, 150]]] @@ -124,20 +125,7 @@ package spark.components.gridClasses { _keyPoints = null; } -/*[Ignore] -[Test] -public function test_global_coordinates_over_header_view(globalPoint:Array, expectedHeaderIndex:int):void -{ -//given -var pointOverAHeaderView:Boolean = expectedHeaderIndex != -1; - -//when -var doesHeaderContainThisPoint:Boolean = _sut.areCoordinatesOverAHeaderView(new Point(globalPoint[0], globalPoint[1])); - -//then -assertEquals(pointOverAHeaderView, doesHeaderContainThisPoint); -} - +/* [Ignore] [Test] public function test_column_index(globalPoint:Array, expectedColumnIndex:int):void @@ -196,14 +184,21 @@ package spark.components.gridClasses { { for (var i:int = 0; i < directions.length; i++) { +//given +var pointToTest:Point = getAdjacentPoint(_keyPoints[pointName], directions[i]); + //when -var adjacentPoint:Point = getAdjacentPoint(_keyPoints[pointName], directions[i]); -var expectedHeaderIndex:int = getHeaderIndexAssumption(adjacentPoint); -var actualHeaderIndex:int = getHeaderIndexAtGlobalPoint(adjacentPoint); +var expectedHeaderIndex:int = getHeaderIndexAssumption(pointToTest); +var actualHeaderIndex:int = getHeaderIndexAtGlobalPoint(pointToTest); +const errorMessageHeaderIndex:String = getHeaderIndexErrorMessage(pointName, directions[i], pointToTest, expectedHeaderIndex, actualHeaderIndex); + +var shouldBeContainedInHeader:Boolean = getHeaderContainsPointAssumption(pointToTest); +var actuallyContainedInHeader:Boolean = _sut.areCoordinatesOverAHeaderView(pointToTest); +const errorMessageHeaderContainsPoint:String = getHeaderContainsPointErrorMessage(pointName, directions[i], pointToTest, shouldBeContainedInHeader, actuallyContainedInHeader); //then -const errorMessage:String = getHeaderIndexErrorMessage(pointName, directions[i], adjacentPoint, expectedHeaderIndex, actualHeaderIndex); -assertEquals(errorMessage, expectedHeaderIndex, actualHeaderIndex); +assertEquals(errorMessageHeaderIndex, expectedHeaderIndex, actualHeaderIndex); +assertEquals(errorMessageHeaderContainsPoint, shouldBeContainedInHeader, actuallyContainedInHeader); } } } @@ -217,12 +212,26 @@ package spark.components.gridClasses { + "\n DEBUG INFO: headerRectangles=" + headerRectangles); } +private function getHeaderContainsPointErrorMessage(pointName:String, direction:Matrix, transformedPoint:Poi
[45/50] git commit: [flex-sdk] [refs/heads/master] - ignore saxon parts
ignore saxon parts Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/91f196e4 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/91f196e4 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/91f196e4 Branch: refs/heads/master Commit: 91f196e4d1e4e5c2e5398e9c1e002f5a31fb8824 Parents: 35103c6 Author: Alex Harui Authored: Fri Nov 3 14:29:32 2017 -0700 Committer: Alex Harui Committed: Fri Nov 3 14:29:32 2017 -0700 -- ApproveSDK.xml | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/91f196e4/ApproveSDK.xml -- diff --git a/ApproveSDK.xml b/ApproveSDK.xml index 08134b7..bce723e 100644 --- a/ApproveSDK.xml +++ b/ApproveSDK.xml @@ -325,6 +325,7 @@ +
[40/50] git commit: [flex-sdk] [refs/heads/master] - Update release notes to 4.16.1
Update release notes to 4.16.1 Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/0f96a265 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/0f96a265 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/0f96a265 Branch: refs/heads/master Commit: 0f96a26509e0b10fd2b85530378fce42f8b6079d Parents: 752b1d3 Author: Piotr Zarzycki Authored: Mon Oct 30 20:09:33 2017 +0100 Committer: Piotr Zarzycki Committed: Mon Oct 30 20:09:33 2017 +0100 -- RELEASE_NOTES | 16 1 file changed, 8 insertions(+), 8 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/0f96a265/RELEASE_NOTES -- diff --git a/RELEASE_NOTES b/RELEASE_NOTES index b82ea1f..81d4b72 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -1,19 +1,19 @@ -Apache Flex 4.17.0 +Apache Flex 4.16.1 == - -New Features - - - AIR and Flash Player Support - +- Support Flash Player 21.0, 22.0, 23.0, 24.0, 25.0, 26.0 and 27.0 +- Support for AIR 21.0, 22.0, 23.0, 24.0, 25.0, 26.0 and 27.0 Bug Fixes - -FLEX-35329 Initializing member variable/constant that is [Deprecated] +FLEX-35364 Flex installer.xml is failing occasionally +FLEX-35329 Initializing member variable/constant that is [Deprecated] incorrectly throws extra warning +FLEX-35321 LayoutManager initializes components which are no longer on stage +FLEX-35267 Spark DataGrid's GridHeaderViewLayout.getHeaderIndexAt() returns wrong header index when leftPadding is comparable to a column's width +FLEX-27509 AdvancedListBase itemMaskFreeList is null Known Issues
[32/50] git commit: [flex-sdk] [refs/heads/master] - FLEX-18746 Added the same test, but without using opening animation. (This way the bug cannot be reproduced, which is a good clue.)
FLEX-18746 Added the same test, but without using opening animation. (This way the bug cannot be reproduced, which is a good clue.) Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7a519a33 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7a519a33 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7a519a33 Branch: refs/heads/master Commit: 7a519a33e4e93d9657531b15e24d5684a0f80abc Parents: b175cd6 Author: Mihai Chira Authored: Tue Aug 15 12:19:14 2017 +0200 Committer: Mihai Chira Committed: Tue Aug 15 12:19:14 2017 +0200 -- .../tests/mx/controls/Tree_FLEX_18746_Tests.as | 39 +++- 1 file changed, 30 insertions(+), 9 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7a519a33/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as -- diff --git a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as index 26568d6..16a3cbc 100644 --- a/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as +++ b/frameworks/projects/mx/tests/mx/controls/Tree_FLEX_18746_Tests.as @@ -18,8 +18,8 @@ package mx.controls { private static var _sut:Tree; private static var child:Object = {label: "Item"}; -private static var parent0:Object = {label: "Folder 0", children: new ArrayCollection()}; -private static var parent1:Object = {label: "Folder 1", children: new ArrayCollection([child])}; +private static var parent0:Object; +private static var parent1:Object; [Before] @@ -28,6 +28,10 @@ package mx.controls { _sut = new Tree(); _sut.width = 200; _sut.height = 200; + +parent0 = {label: "Folder 0", children: new ArrayCollection()}; +parent1 = {label: "Folder 1", children: new ArrayCollection([child])}; + UIImpersonator.addChild(_sut); } @@ -46,7 +50,24 @@ package mx.controls { //-- [Test(async, timeout=1000)] -public function test_closing_previously_opened_folder_with_0_children_does_not_throw_fatal():void +public function test_closing_previously_opened_folder_with_0_children_without_animation_does_not_throw_fatal():void +{ +//given +const dataProvider:ArrayCollection = new ArrayCollection(); +dataProvider.addItem(parent0); +dataProvider.addItem(parent1); + +//when +_sut.dataProvider = dataProvider; + +//then wait a few frames +noEnterFramesToWait = 2; +UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_second_folder, 300, {useAnimation:false}); +} + +[Test(async, timeout=1000)] +public function test_closing_previously_opened_folder_with_0_children_using_animation_does_not_throw_fatal():void { //given const dataProvider:ArrayCollection = new ArrayCollection(); @@ -59,19 +80,19 @@ package mx.controls { //then wait a few frames noEnterFramesToWait = 2; UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); -Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_second_folder, 300); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_expand_second_folder, 300, {useAnimation:true}); } private function then_expand_second_folder(event:Event, passThroughData:Object):void { //when -_sut.expandItem(parent1, true, true, true); +_sut.expandItem(parent1, true, passThroughData.useAnimation, true); //then wait a bit noEnterFramesToWait = 5; UIImpersonator.testDisplay.addEventListener(Event.ENTER_FRAME, onEnterFrame); -Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_move_child_to_first_parent_and_expand_it, 500); +Async.handleEvent(this, _finishNotifier, Event.COMPLETE, then_move_child_to_first_parent_and_expand_it, 500, passThroughData); } private function then_move_child_to_first_parent_and_expand_it(event:Event, passThroughData:Object):void @@ -81,19 +102,19 @@ package mx.controls { //when ArrayCollection(parent1.children).removeItemAt(0); -_sut.expandItem(parent0, true, true, true); +_sut.expandItem(parent0, true, passThroughData.useAni
git commit: [flex-sdk] [refs/heads/develop] - mobile theme docs are not compiling on Linux (probably old AIR version?)
Repository: flex-sdk Updated Branches: refs/heads/develop 75ace9f5c -> d63dadf1d mobile theme docs are not compiling on Linux (probably old AIR version?) Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d63dadf1 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d63dadf1 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d63dadf1 Branch: refs/heads/develop Commit: d63dadf1d7c247c1b06b5304d2b59fb37c079548 Parents: 75ace9f Author: Justin Mclean Authored: Sun Dec 31 10:51:50 2017 +1100 Committer: Justin Mclean Committed: Sun Dec 31 10:51:50 2017 +1100 -- frameworks/build.xml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d63dadf1/frameworks/build.xml -- diff --git a/frameworks/build.xml b/frameworks/build.xml index 165d630..0d75403 100644 --- a/frameworks/build.xml +++ b/frameworks/build.xml @@ -300,7 +300,7 @@ - + @@ -313,7 +313,6 @@ - @@ -330,6 +329,10 @@ + + + +
git commit: [flex-sdk] [refs/heads/develop] - no support for automation flash flex kit on linux
Repository: flex-sdk Updated Branches: refs/heads/develop bacc8cc5a -> 75ace9f5c no support for automation flash flex kit on linux Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/75ace9f5 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/75ace9f5 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/75ace9f5 Branch: refs/heads/develop Commit: 75ace9f5c031a849b2df091ea093577378b88cbf Parents: bacc8cc Author: Justin Mclean Authored: Sun Dec 31 10:20:34 2017 +1100 Committer: Justin Mclean Committed: Sun Dec 31 10:20:34 2017 +1100 -- frameworks/build.xml | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/75ace9f5/frameworks/build.xml -- diff --git a/frameworks/build.xml b/frameworks/build.xml index 5ac6438..165d630 100644 --- a/frameworks/build.xml +++ b/frameworks/build.xml @@ -258,17 +258,22 @@ - + + + - + + + +
git commit: [flex-sdk] [refs/heads/develop] - source clean was removing player libs on jenkins job
Repository: flex-sdk Updated Branches: refs/heads/develop b0ef9c4ee -> bacc8cc5a source clean was removing player libs on jenkins job Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/bacc8cc5 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/bacc8cc5 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/bacc8cc5 Branch: refs/heads/develop Commit: bacc8cc5a7b1324070300d31c1ea78a3302581b9 Parents: b0ef9c4 Author: Justin Mclean Authored: Sun Dec 31 09:21:28 2017 +1100 Committer: Justin Mclean Committed: Sun Dec 31 09:21:28 2017 +1100 -- build.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/bacc8cc5/build.xml -- diff --git a/build.xml b/build.xml index 3002366..517bcc2 100644 --- a/build.xml +++ b/build.xml @@ -118,7 +118,7 @@ description="Creates source and binary kits for Apache Flex."/>
git commit: [flex-sdk] [refs/heads/develop] - order matters when you compile the flash integration
Repository: flex-sdk Updated Branches: refs/heads/develop e92853781 -> b0ef9c4ee order matters when you compile the flash integration Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/b0ef9c4e Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/b0ef9c4e Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/b0ef9c4e Branch: refs/heads/develop Commit: b0ef9c4ee9fd8d8f199259eaee3924593330622c Parents: e928537 Author: Justin Mclean Authored: Sun Dec 31 08:25:59 2017 +1100 Committer: Justin Mclean Committed: Sun Dec 31 08:25:59 2017 +1100 -- frameworks/build.xml | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b0ef9c4e/frameworks/build.xml -- diff --git a/frameworks/build.xml b/frameworks/build.xml index 7a31bdc..5ac6438 100644 --- a/frameworks/build.xml +++ b/frameworks/build.xml @@ -108,7 +108,9 @@ Should consider updating the OSMF and TLF versions in use. --> - + + + @@ -119,9 +121,9 @@ - - - + + + @@ -130,13 +132,16 @@ - + + + +
git commit: [flex-sdk] [refs/heads/develop] - setup does a clean which is removing the flash player downloads in the jenkins job
Repository: flex-sdk Updated Branches: refs/heads/develop cfc19471e -> e92853781 setup does a clean which is removing the flash player downloads in the jenkins job Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/e9285378 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/e9285378 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/e9285378 Branch: refs/heads/develop Commit: e92853781a67619a1273390e0c1e266aef2ecb3b Parents: cfc1947 Author: Justin Mclean Authored: Sat Dec 30 19:25:10 2017 +1100 Committer: Justin Mclean Committed: Sat Dec 30 19:25:10 2017 +1100 -- build.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/e9285378/build.xml -- diff --git a/build.xml b/build.xml index d3f4781..3002366 100644 --- a/build.xml +++ b/build.xml @@ -117,7 +117,8 @@ depends="check-compile-env,check-runtime-env,check-adobe-extension-manager-env,source-release,binary-release,rat-check" description="Creates source and binary kits for Apache Flex."/> -
git commit: [flex-sdk] [refs/heads/develop] - flash integration not supported on linux
Repository: flex-sdk Updated Branches: refs/heads/develop 35214ffd3 -> cfc19471e flash integration not supported on linux Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/cfc19471 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/cfc19471 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/cfc19471 Branch: refs/heads/develop Commit: cfc19471e508207c45c83092964810b8e4454c6c Parents: 35214ff Author: Justin Mclean Authored: Sat Dec 30 18:04:56 2017 +1100 Committer: Justin Mclean Committed: Sat Dec 30 18:04:56 2017 +1100 -- frameworks/build.xml | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/cfc19471/frameworks/build.xml -- diff --git a/frameworks/build.xml b/frameworks/build.xml index 2e71195..7a31bdc 100644 --- a/frameworks/build.xml +++ b/frameworks/build.xml @@ -108,7 +108,7 @@ Should consider updating the OSMF and TLF versions in use. --> - + @@ -123,7 +123,6 @@ - @@ -134,6 +133,10 @@ + + + + @@ -262,7 +265,7 @@ - + @@ -274,7 +277,6 @@ - @@ -283,8 +285,12 @@ + + + + - + @@ -301,7 +307,6 @@ - + + + +
git commit: [flex-sdk] [refs/heads/develop] - testing if we can make a release build target without running the tests
Repository: flex-sdk Updated Branches: refs/heads/develop eeb68fcc4 -> 35214ffd3 testing if we can make a release build target without running the tests Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/35214ffd Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/35214ffd Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/35214ffd Branch: refs/heads/develop Commit: 35214ffd3d88ea4eaa255befc693be2b25bca51d Parents: eeb68fc Author: Justin Mclean Authored: Sat Dec 30 17:25:46 2017 +1100 Committer: Justin Mclean Committed: Sat Dec 30 17:25:46 2017 +1100 -- build.xml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/35214ffd/build.xml -- diff --git a/build.xml b/build.xml index 66842ec..d3f4781 100644 --- a/build.xml +++ b/build.xml @@ -116,6 +116,9 @@ + + - +
[1/2] git commit: [flex-asjs] [refs/heads/develop] - no need for bracket notation and moving AS mouse disable to constructor
Repository: flex-asjs Updated Branches: refs/heads/develop a25a2cb1a -> dd4672bf1 no need for bracket notation and moving AS mouse disable to constructor Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/135f1ebd Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/135f1ebd Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/135f1ebd Branch: refs/heads/develop Commit: 135f1ebd725d8386d6f4ab49015154ed463daee1 Parents: a25a2cb Author: Justin Mclean Authored: Sat Jul 15 11:30:20 2017 +1000 Committer: Justin Mclean Committed: Sat Jul 15 11:30:20 2017 +1000 -- .../src/main/flex/org/apache/flex/html/ToolTip.as | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/135f1ebd/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as index 97b2d27..1d39b4d 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as @@ -58,16 +58,10 @@ package org.apache.flex.html { super(); className = "ToolTip"; - } - - /** -* @private -*/ - COMPILE::SWF - override public function addedToParent():void - { - super.addedToParent(); - (element as InteractiveObject).mouseEnabled = false; + COMPILE::SWF + { + mouseEnabled = false; + } } /** @@ -78,7 +72,7 @@ package org.apache.flex.html { var element:WrappedHTMLElement = super.createElement(); positioner.style.position = 'absolute'; - positioner.style["pointer-events"] = "none"; + positioner.style.pointerEvents = "none"; typeNames = "ToolTip"; return element; }
[2/2] git commit: [flex-asjs] [refs/heads/develop] - change value to large numbers as suggested
change value to large numbers as suggested Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/dd4672bf Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/dd4672bf Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/dd4672bf Branch: refs/heads/develop Commit: dd4672bf147af7e08874acef26383aa20bcb35db Parents: 135f1eb Author: Justin Mclean Authored: Sat Jul 15 11:30:47 2017 +1000 Committer: Justin Mclean Committed: Sat Jul 15 11:30:47 2017 +1000 -- .../flex/org/apache/flex/html/accessories/ToolTipBead.as | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/dd4672bf/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index a22283d..3ccf708 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -53,11 +53,11 @@ package org.apache.flex.html.accessories { } - public static const TOP:int = 0; - public static const BOTTOM:int = 1; - public static const LEFT:int = 2; - public static const RIGHT:int = 3; - public static const MIDDLE:int = 4; + public static const TOP:int = 1; + public static const BOTTOM:int = 10001; + public static const LEFT:int = 10002; + public static const RIGHT:int = 10003; + public static const MIDDLE:int = 10004; private var _toolTip:String; private var tt:ToolTip; @@ -159,6 +159,7 @@ package org.apache.flex.html.accessories var xFactor:Number = 1; var yFactor:Number = 1; var pt:Point; + var relative:Boolean = _xPos > TOP && _yPos > TOP; if (_xPos == LEFT) { xFactor = Number.POSITIVE_INFINITY;
git commit: [flex-asjs] [refs/heads/develop] - added simple positioning to tool tip / make tool tip not react to mouse events
Repository: flex-asjs Updated Branches: refs/heads/develop 2dd4d5d2e -> b88f92e7b added simple positioning to tool tip / make tool tip not react to mouse events Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/b88f92e7 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/b88f92e7 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/b88f92e7 Branch: refs/heads/develop Commit: b88f92e7b304759752b6adb4e0f1007ace191c09 Parents: 2dd4d5d Author: Justin Mclean Authored: Thu Jul 13 17:16:13 2017 +1000 Committer: Justin Mclean Committed: Thu Jul 13 17:16:13 2017 +1000 -- .../main/flex/org/apache/flex/html/ToolTip.as | 26 +-- .../apache/flex/html/accessories/ToolTipBead.as | 79 2 files changed, 84 insertions(+), 21 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b88f92e7/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as index 2f29d1b..97b2d27 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as @@ -18,11 +18,10 @@ package org.apache.flex.html { - import org.apache.flex.core.ITextModel; - import org.apache.flex.core.UIBase; - import org.apache.flex.core.ValuesManager; - import org.apache.flex.events.Event; - import org.apache.flex.events.IEventDispatcher; + COMPILE::SWF + { + import flash.display.InteractiveObject; + } COMPILE::JS { import org.apache.flex.core.WrappedHTMLElement; @@ -60,17 +59,28 @@ package org.apache.flex.html super(); className = "ToolTip"; } - + + /** +* @private +*/ + COMPILE::SWF + override public function addedToParent():void + { + super.addedToParent(); + (element as InteractiveObject).mouseEnabled = false; + } + /** * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement */ COMPILE::JS override protected function createElement():WrappedHTMLElement { - var e:WrappedHTMLElement = super.createElement(); + var element:WrappedHTMLElement = super.createElement(); positioner.style.position = 'absolute'; + positioner.style["pointer-events"] = "none"; typeNames = "ToolTip"; - return e; + return element; } } } http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b88f92e7/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index 8e64f3a..a22283d 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -18,7 +18,6 @@ package org.apache.flex.html.accessories { - import org.apache.flex.core.IBead; import org.apache.flex.core.IPopUpHost; import org.apache.flex.core.IStrand; @@ -54,7 +53,17 @@ package org.apache.flex.html.accessories { } + public static const TOP:int = 0; + public static const BOTTOM:int = 1; + public static const LEFT:int = 2; + public static const RIGHT:int = 3; + public static const MIDDLE:int = 4; + private var _toolTip:String; + private var tt:ToolTip; + private var host:IPopUpHost; + private var _xPos:int = RIGHT; + private var _yPos:int = BOTTOM; /** * The string to use as the toolTip. @@ -73,9 +82,37 @@ package org.apache.flex.html.accessories _toolTip = value; } - private var _strand:IStrand; +
[3/3] git commit: [flex-asjs] [refs/heads/develop] - Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/2dd4d5d2 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/2dd4d5d2 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/2dd4d5d2 Branch: refs/heads/develop Commit: 2dd4d5d2eba56a1445fde2ee2f85cdf244b1f6c8 Parents: c5b71c4 4010a04 Author: Justin Mclean Authored: Thu Jul 13 14:23:04 2017 +1000 Committer: Justin Mclean Committed: Thu Jul 13 14:23:04 2017 +1000 -- .../org/apache/flex/core/ApplicationBase.as | 1 + .../org/apache/flex/html/beads/DisableBead.as | 6 +- .../apache/flex/html/beads/DisabledAlphaBead.as | 130 +++ .../html/beads/layouts/HorizontalFlexLayout.as | 2 +- .../html/beads/layouts/VerticalFlexLayout.as| 2 +- .../supportClasses/AccordionItemRenderer.as | 1 - .../Basic/src/main/resources/basic-manifest.xml | 1 + .../Basic/src/main/resources/defaults.css | 1 + .../flex/org/apache/flex/utils/BinaryData.as| 9 ++ .../html/beads/SingleSelectionDragSourceBead.as | 4 + .../beads/controllers/DragMouseController.as| 13 +- .../main/flex/org/apache/flex/file/FileProxy.as | 9 ++ .../org/apache/flex/file/beads/FileBrowser.as | 26 ++-- .../flex/file/beads/FileBrowserWithFilter.as| 63 + .../org/apache/flex/file/beads/FileLoader.as| 2 +- .../org/apache/flex/file/beads/FileModel.as | 2 +- .../src/main/resources/basic-manifest.xml | 1 + 17 files changed, 247 insertions(+), 26 deletions(-) --
[1/3] git commit: [flex-asjs] [refs/heads/develop] - fix typesNames
Repository: flex-asjs Updated Branches: refs/heads/develop 4010a04c2 -> 2dd4d5d2e fix typesNames Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/39a47652 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/39a47652 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/39a47652 Branch: refs/heads/develop Commit: 39a4765243c866d995abfbe378a8ecf6817bdc66 Parents: 3b5053f Author: Justin Mclean Authored: Tue Jul 11 18:44:01 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 18:44:01 2017 +1000 -- .../projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/39a47652/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as index b2da0f0..2f29d1b 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/ToolTip.as @@ -69,7 +69,7 @@ package org.apache.flex.html { var e:WrappedHTMLElement = super.createElement(); positioner.style.position = 'absolute'; - typeNames = "ToolTIp"; + typeNames = "ToolTip"; return e; } }
[2/3] git commit: [flex-asjs] [refs/heads/develop] - Revert "FLEX-35337 place tool tip anchor point in the centre rather than the bottom right"
Revert "FLEX-35337 place tool tip anchor point in the centre rather than the bottom right" This reverts commit 3891820488387121767c92e1cf9c132f6e858496. Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c5b71c41 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c5b71c41 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c5b71c41 Branch: refs/heads/develop Commit: c5b71c418676bce2088b94bde5b315819decc059 Parents: 39a4765 Author: Justin Mclean Authored: Thu Jul 13 14:22:20 2017 +1000 Committer: Justin Mclean Committed: Thu Jul 13 14:22:20 2017 +1000 -- .../src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5b71c41/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index 5f93579..8e64f3a 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -124,7 +124,7 @@ package org.apache.flex.html.accessories protected function determinePosition(event:MouseEvent, base:Object):Point { var comp:IUIBase = _strand as IUIBase; - var pt:Point = new Point(comp.width/2, comp.height/2); + var pt:Point = new Point(comp.width, comp.height); pt = PointUtils.localToGlobal(pt, comp); return pt; }
git commit: [flex-asjs] [refs/heads/develop] - take into account x and y and check for leaving left and top sides
Repository: flex-asjs Updated Branches: refs/heads/develop 1d73de00b -> a87ffefd3 take into account x and y and check for leaving left and top sides Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/a87ffefd Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/a87ffefd Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/a87ffefd Branch: refs/heads/develop Commit: a87ffefd32a1eaed0a389022cd00b67886e1dbad Parents: 1d73de0 Author: Justin Mclean Authored: Tue Jul 11 16:11:48 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 16:11:48 2017 +1000 -- .../src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a87ffefd/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index b1f0620..5f93579 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -135,7 +135,8 @@ package org.apache.flex.html.accessories private function rollOutHandler(event:MouseEvent):void { var comp:IUIBase = _strand as IUIBase; - var outside:Boolean = event.clientX > comp.width || event.clientY > comp.height; + var outside:Boolean = event.clientX > (comp.x + comp.width) || event.clientY > (comp.y + comp.height) + || event.clientX < comp.x || event.clientY < comp.y; // check for outside otherwise tool tip itself with flash when you roll over it if (tt && outside) { host.removeElement(tt);
[4/5] git commit: [flex-asjs] [refs/heads/develop] - Add alt bead for images alt tag on JS / tooltip on AS
Add alt bead for images alt tag on JS / tooltip on AS Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/eafb8111 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/eafb8111 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/eafb8111 Branch: refs/heads/develop Commit: eafb8b556e413d314d4826ef3f16eac63df8 Parents: c0d218f Author: Justin Mclean Authored: Tue Jul 11 15:40:05 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 15:40:05 2017 +1000 -- .../flex/html/beads/AccessibilityAltBead.as | 114 +++ .../Basic/src/main/resources/basic-manifest.xml | 1 + 2 files changed, 115 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/eafb8111/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/AccessibilityAltBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/AccessibilityAltBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/AccessibilityAltBead.as new file mode 100644 index 000..3bb3580 --- /dev/null +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/AccessibilityAltBead.as @@ -0,0 +1,114 @@ + +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// + +package org.apache.flex.html.beads +{ + + import org.apache.flex.core.IBead; + import org.apache.flex.core.IStrand; + import org.apache.flex.events.IEventDispatcher; + import org.apache.flex.events.ValueEvent; + + COMPILE::SWF { + import org.apache.flex.html.accessories.ToolTipBead; + } + +/** +* The AccessibilityAltBead class is a bead that can be used with +* any Image control. The bead places add an alt text attribute +* on a image. +* +* @langversion 3.0 +* @playerversion Flash 10.2 +* @playerversion AIR 2.6 +* @productversion FlexJS 0.9 +*/ + public class AccessibilityAltBead implements IBead + { + /** +* constructor. +* +* @langversion 3.0 +* @playerversion Flash 10.2 +* @playerversion AIR 2.6 +* @productversion FlexJS 0.9 +*/ + public function AccessibilityAltBead() + { + } + + private var _strand:IStrand; + private var _alt:String; + + /** +* @copy org.apache.flex.core.IBead#strand +* +* @langversion 3.0 +* @playerversion Flash 10.2 +* @playerversion AIR 2.6 +* @productversion FlexJS 0.9 +* @flexjsignorecoercion HTMLInputElement +* @flexjsignorecoercion org.apache.flex.core.UIBase; +*/ + public function set strand(value:IStrand):void + { + _strand = value; + updateHost(); + } + + public function get alt():String + { + return _alt; + } + + /** +* @private +*/ + public function set alt(value:String):void + { + if (value != _alt) + { + _alt = value; + updateHost(); + } + } + + private function updateHost():void + { + if(!_strand) + return; + + COMPILE::SWF { +
[1/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35337 place tool tip anchor point in the centre rather than the bottom right
Repository: flex-asjs Updated Branches: refs/heads/develop e93c11d7c -> 1d73de00b FLEX-35337 place tool tip anchor point in the centre rather than the bottom right Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/38918204 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/38918204 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/38918204 Branch: refs/heads/develop Commit: 3891820488387121767c92e1cf9c132f6e858496 Parents: 54d00a0 Author: Justin Mclean Authored: Tue Jul 11 14:43:29 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 14:43:29 2017 +1000 -- .../src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/38918204/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index 64d04bf..03ce21e 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -122,7 +122,7 @@ package org.apache.flex.html.accessories protected function determinePosition(event:MouseEvent, base:Object):Point { var comp:IUIBase = _strand as IUIBase; - var pt:Point = new Point(comp.width, comp.height); + var pt:Point = new Point(comp.width/2, comp.height/2); pt = PointUtils.localToGlobal(pt, comp); return pt; }
[5/5] git commit: [flex-asjs] [refs/heads/develop] - Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/1d73de00 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/1d73de00 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/1d73de00 Branch: refs/heads/develop Commit: 1d73de00b5235161eccc24870169b484ed32 Parents: eafb811 e93c11d Author: Justin Mclean Authored: Tue Jul 11 15:40:17 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 15:40:17 2017 +1000 -- .../flex/file/beads/FileLoaderAndUploader.as| 23 1 file changed, 14 insertions(+), 9 deletions(-) --
[2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking
FLEX-35338 stop cursor from spinning / CPU from spiking Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/549a10d8 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/549a10d8 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/549a10d8 Branch: refs/heads/develop Commit: 549a10d82da5835c61a2b1247b65f7bfbc2f9a36 Parents: 3891820 Author: Justin Mclean Authored: Tue Jul 11 14:57:04 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 14:57:04 2017 +1000 -- .../main/flex/org/apache/flex/html/accessories/ToolTipBead.as | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/549a10d8/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index 03ce21e..bdf0b68 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -100,7 +100,10 @@ package org.apache.flex.html.accessories * @private */ protected function rollOverHandler( event:MouseEvent ):void - { + { + if (!toolTip) + return; + IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OUT, rollOutHandler, false); var comp:IUIBase = _strand as IUIBase
[3/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35339 stop tool tip flashing on and off like mad when you mouse over it
FLEX-35339 stop tool tip flashing on and off like mad when you mouse over it Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c0d218f5 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c0d218f5 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c0d218f5 Branch: refs/heads/develop Commit: c0d218f5bf0e83d2f82fa1979aad0ff09b6317f2 Parents: 549a10d Author: Justin Mclean Authored: Tue Jul 11 15:36:05 2017 +1000 Committer: Justin Mclean Committed: Tue Jul 11 15:36:05 2017 +1000 -- .../apache/flex/html/accessories/ToolTipBead.as | 47 +++- 1 file changed, 25 insertions(+), 22 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c0d218f5/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as index bdf0b68..b1f0620 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/ToolTipBead.as @@ -18,26 +18,23 @@ package org.apache.flex.html.accessories { - + import org.apache.flex.core.IBead; import org.apache.flex.core.IPopUpHost; import org.apache.flex.core.IStrand; import org.apache.flex.core.IUIBase; - import org.apache.flex.core.UIBase; - import org.apache.flex.events.Event; import org.apache.flex.events.IEventDispatcher; import org.apache.flex.events.MouseEvent; - import org.apache.flex.events.utils.MouseUtils; import org.apache.flex.geom.Point; import org.apache.flex.html.ToolTip; import org.apache.flex.utils.PointUtils; import org.apache.flex.utils.UIUtils; - + /** * The ToolTipBead class is a specialty bead that can be used with * any control. The bead floats a string over a control if * the user hovers over the control with a mouse. -* +* * @langversion 3.0 * @playerversion Flash 10.2 * @playerversion AIR 2.6 @@ -56,9 +53,9 @@ package org.apache.flex.html.accessories public function ToolTipBead() { } - + private var _toolTip:String; - + /** * The string to use as the toolTip. * @@ -75,12 +72,12 @@ package org.apache.flex.html.accessories { _toolTip = value; } - + private var _strand:IStrand; - + /** * @copy org.apache.flex.core.IBead#strand -* +* * @langversion 3.0 * @playerversion Flash 10.2 * @playerversion AIR 2.6 @@ -92,32 +89,34 @@ package org.apache.flex.html.accessories IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OVER, rollOverHandler, false); } - + private var tt:ToolTip; private var host:IPopUpHost; - + /** * @private */ protected function rollOverHandler( event:MouseEvent ):void { - if (!toolTip) + if (!toolTip || tt) return; IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OUT, rollOutHandler, false); - + var comp:IUIBase = _strand as IUIBase host = UIUtils.findPopUpHost(comp); if (tt) host.removeElement(tt); - + tt = new ToolTip(); tt.text = toolTip; var pt:Point = determinePosition(event, event.target); tt.x = pt.x; tt.y = pt.y; host.addElement(tt, false); // don't trigger a layout + + tt.addEventListener(MouseEvent.MOUSE_OUT, rollOutHandler, false); } - + /** * @private * Determines the position of the toolTip. @@ -129,16 +128,20 @@ package org.apache.flex.html.accessories pt = PointUtils.localToGlobal(pt, comp); return pt; } - + /** * @private */ -pr
git commit: [flex-asjs] [refs/heads/develop] - Revert "Fix merge error removing support for numeric font size."
Repository: flex-asjs Updated Branches: refs/heads/develop 01a2a2823 -> a81e88163 Revert "Fix merge error removing support for numeric font size." This reverts commit 68f118b1a56a49484c4e898826af4834c0cc2fa2. Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/a81e8816 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/a81e8816 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/a81e8816 Branch: refs/heads/develop Commit: a81e88163e403ccdbc028b8ec191af6453fc8696 Parents: 01a2a28 Author: Justin Mclean Authored: Sat Jul 8 16:43:27 2017 +1000 Committer: Justin Mclean Committed: Sat Jul 8 16:43:27 2017 +1000 -- .../flex/org/apache/flex/core/SimpleCSSValuesImpl.as | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a81e8816/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as -- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as index 740e6ab..36198f6 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as @@ -764,13 +764,7 @@ package org.apache.flex.core 'constructor': 1 }; -/** - * The styles that can use raw numbers - */ -COMPILE::JS -public static const numericStyles:Object = { -'fontWeight': 1 -}; + /** * @param thisObject The object to apply styles to; @@ -783,7 +777,6 @@ package org.apache.flex.core var styleList:Object = SimpleCSSValuesImpl.perInstanceStyles; var colorStyles:Object = SimpleCSSValuesImpl.colorStyles; var skipStyles:Object = SimpleCSSValuesImpl.skipStyles; -var numericStyles:Object = SimpleCSSValuesImpl.numericStyles; var listObj:Object = styles; if (styles.styleList) listObj = styles.styleList; @@ -798,8 +791,6 @@ package org.apache.flex.core if (typeof(value) == 'number') { if (colorStyles[p]) value = CSSUtils.attributeFromColor(value); -else if (numericStyles[p]) -value = value.toString(); else value = value.toString() + 'px'; }
git commit: [flex-asjs] [refs/heads/develop] - simplify switch statement
Repository: flex-asjs Updated Branches: refs/heads/develop 48f1fd801 -> d9724b829 simplify switch statement Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/d9724b82 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/d9724b82 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/d9724b82 Branch: refs/heads/develop Commit: d9724b829ec36291b777617a1e37571bbfae5524 Parents: 48f1fd8 Author: Justin Mclean Authored: Thu Jul 6 17:17:38 2017 +1000 Committer: Justin Mclean Committed: Thu Jul 6 17:17:38 2017 +1000 -- .../flex/textLayout/elements/TableElement.as | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/d9724b82/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/elements/TableElement.as -- diff --git a/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/elements/TableElement.as b/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/elements/TableElement.as index d759bbe..d9a1fa8 100644 --- a/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/elements/TableElement.as +++ b/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/elements/TableElement.as @@ -1133,19 +1133,11 @@ package org.apache.flex.textLayout.elements { addColumn(); } - var w:Number; - switch(typeof(computedFormat.tableWidth)){ - case "number": - w = suggestedWidth; - break; - case "string": - if(computedFormat.tableWidth.indexOf("%") > 0){ - w = suggestedWidth / (parseFloat(computedFormat.tableWidth)/100); - break; - } - default: - w = suggestedWidth; - break; + var w:Number = suggestedWidth; + if (typeof(computedFormat.tableWidth) == "string"){ + if(computedFormat.tableWidth.indexOf("%") > 0){ + w = suggestedWidth / (parseFloat(computedFormat.tableWidth)/100); + } } if(isNaN(w)) w = 600;
git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.
Repository: flex-asjs Updated Branches: refs/heads/develop 18992c5fd -> 68f118b1a Fix merge error removing support for numeric font size. Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/68f118b1 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/68f118b1 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/68f118b1 Branch: refs/heads/develop Commit: 68f118b1a56a49484c4e898826af4834c0cc2fa2 Parents: 18992c5 Author: Justin Mclean Authored: Thu Jun 29 16:20:17 2017 +1000 Committer: Justin Mclean Committed: Thu Jun 29 16:20:17 2017 +1000 -- .../flex/org/apache/flex/core/SimpleCSSValuesImpl.as | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/68f118b1/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as -- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as index f5d71ca..16b42c6 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as @@ -764,7 +764,13 @@ package org.apache.flex.core 'constructor': 1 }; - +/** + * The styles that can use raw numbers + */ +COMPILE::JS +public static const numericStyles:Object = { +'fontWeight': 1 +}; /** * @param thisObject The object to apply styles to; @@ -777,6 +783,7 @@ package org.apache.flex.core var styleList:Object = SimpleCSSValuesImpl.perInstanceStyles; var colorStyles:Object = SimpleCSSValuesImpl.colorStyles; var skipStyles:Object = SimpleCSSValuesImpl.skipStyles; +var numericStyles:Object = SimpleCSSValuesImpl.numericStyles; var listObj:Object = styles; if (styles.styleList) listObj = styles.styleList; @@ -791,6 +798,8 @@ package org.apache.flex.core if (typeof(value) === 'number') { if (colorStyles[p]) value = CSSUtils.attributeFromColor(value); +else if (numericStyles[p]) +value = value.toString(); else value = value.toString() + 'px'; }
[1/2] git commit: [flex-falcon] [refs/heads/initializers] - make default initialisers configurable
Repository: flex-falcon Updated Branches: refs/heads/initializers c17bdc9a5 -> b805d6d99 make default initialisers configurable Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/62d53ed4 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/62d53ed4 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/62d53ed4 Branch: refs/heads/initializers Commit: 62d53ed404bfa1cd2c3f75ce2463c0f01e3c7afe Parents: c17bdc9 Author: Justin Mclean Authored: Fri Jun 16 12:49:57 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 16 12:49:57 2017 +1000 -- .../codegen/js/jx/VarDeclarationEmitter.java| 57 ++-- .../flex/compiler/config/Configuration.java | 23 .../apache/flex/compiler/messages_en.properties | 1 + .../org/apache/flex/compiler/ant/COMPCTask.java | 1 + .../org/apache/flex/compiler/ant/MXMLCTask.java | 1 + 5 files changed, 54 insertions(+), 29 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/62d53ed4/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java -- diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java index 67ae28f..a4c8e22 100644 --- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java +++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java @@ -19,6 +19,7 @@ package org.apache.flex.compiler.internal.codegen.js.jx; +import org.apache.flex.compiler.clients.JSConfiguration; import org.apache.flex.compiler.codegen.ISubEmitter; import org.apache.flex.compiler.codegen.js.IJSEmitter; import org.apache.flex.compiler.constants.IASLanguageConstants; @@ -28,6 +29,7 @@ import org.apache.flex.compiler.definitions.metadata.IMetaTagAttribute; import org.apache.flex.compiler.internal.codegen.as.ASEmitterTokens; import org.apache.flex.compiler.internal.codegen.js.JSSubEmitter; import org.apache.flex.compiler.internal.codegen.js.flexjs.JSFlexJSEmitter; +import org.apache.flex.compiler.internal.projects.FlexJSProject; import org.apache.flex.compiler.internal.tree.as.ChainedVariableNode; import org.apache.flex.compiler.internal.tree.as.DynamicAccessNode; import org.apache.flex.compiler.internal.tree.as.FunctionCallNode; @@ -42,10 +44,14 @@ import org.apache.flex.compiler.tree.as.IVariableNode; public class VarDeclarationEmitter extends JSSubEmitter implements ISubEmitter { +boolean ignoreInitilization; public VarDeclarationEmitter(IJSEmitter emitter) { super(emitter); + +JSConfiguration configuration = ((FlexJSProject) getProject()).config; +ignoreInitilization = configuration.getIgnoreDefaultInitilization(); } @Override @@ -180,40 +186,33 @@ public class VarDeclarationEmitter extends JSSubEmitter implements IExpressionNode enode = node.getVariableTypeNode();//getAssignedValueNode(); if (enode != null) typedef = enode.resolveType(getWalker().getProject()); -if (typedef != null) -{ - String defName = typedef.getQualifiedName(); - if (defName.equals("int") || defName.equals("uint")) - { - if (node.getParent() != null && - node.getParent().getParent() != null && - node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) - { - write(ASEmitterTokens.SPACE); - writeToken(ASEmitterTokens.EQUAL); - write("0"); - } - } -else if (defName.equals("Boolean")) -{ +if (typedef != null) { +String defName = typedef.getQualifiedName(); +if (defName.equals("int") || defName.equals("uint")) { if (node.getParent() != null && node.getParent().getParent() != null && -node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) -{ +node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) { write(ASEmitterTokens.SPACE); writeToken(ASEmitterTokens.EQUAL); -write(ASEmitterT
[2/2] git commit: [flex-falcon] [refs/heads/initializers] - add config option to ignore initialisers
add config option to ignore initialisers Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/b805d6d9 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/b805d6d9 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/b805d6d9 Branch: refs/heads/initializers Commit: b805d6d995b33a96f074d06ec020938ad1956eb2 Parents: 62d53ed Author: Justin Mclean Authored: Fri Jun 23 09:36:20 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 23 09:36:20 2017 +1000 -- .../codegen/js/jx/VarDeclarationEmitter.java | 17 - .../apache/flex/compiler/config/Configuration.java | 5 ++--- 2 files changed, 10 insertions(+), 12 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/b805d6d9/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java -- diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java index a4c8e22..3b883c8 100644 --- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java +++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java @@ -42,16 +42,15 @@ import org.apache.flex.compiler.tree.as.IExpressionNode; import org.apache.flex.compiler.tree.as.IVariableNode; public class VarDeclarationEmitter extends JSSubEmitter implements -ISubEmitter -{ -boolean ignoreInitilization; +ISubEmitter { -public VarDeclarationEmitter(IJSEmitter emitter) -{ +public VarDeclarationEmitter(IJSEmitter emitter) { super(emitter); +} +protected boolean defaultInitialisation() { JSConfiguration configuration = ((FlexJSProject) getProject()).config; -ignoreInitilization = configuration.getIgnoreDefaultInitilization(); +return configuration == null || !configuration.getIgnoreDefaultInitilization(); } @Override @@ -196,8 +195,8 @@ public class VarDeclarationEmitter extends JSSubEmitter implements writeToken(ASEmitterTokens.EQUAL); write("0"); } -} else if (!ignoreInitilization) { -if (ignoreInitilization && defName.equals("Boolean")) { +} else if (defaultInitialisation()) { +if (defName.equals("Boolean")) { if (node.getParent() != null && node.getParent().getParent() != null && node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) { @@ -205,7 +204,7 @@ public class VarDeclarationEmitter extends JSSubEmitter implements writeToken(ASEmitterTokens.EQUAL); write(ASEmitterTokens.FALSE); } -} else if (ignoreInitilization && defName.equals("Number")) { +} else if (defName.equals("Number")) { if (node.getParent() != null && node.getParent().getParent() != null && node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) { http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/b805d6d9/compiler/src/main/java/org/apache/flex/compiler/config/Configuration.java -- diff --git a/compiler/src/main/java/org/apache/flex/compiler/config/Configuration.java b/compiler/src/main/java/org/apache/flex/compiler/config/Configuration.java index e21ef65..64ff7c9 100644 --- a/compiler/src/main/java/org/apache/flex/compiler/config/Configuration.java +++ b/compiler/src/main/java/org/apache/flex/compiler/config/Configuration.java @@ -3966,9 +3966,9 @@ public class Configuration /** * Allow the user to set Boolean and Number type to be undefined and ignore them being initialised - * to false and NaN respectively. Note that use this option breaks compatability with ActionScript. + * to false and NaN respectively. Note that using this option breaks compatability with ActionScript. */ -private boolean ignoreDefaultInitilization = true; +private boolean ignoreDefaultInitilization = false; public boolean getIgnoreDefaultInitilization() { @@ -3977,7 +3977,6 @@ public class Configuration @Config(advanced = true) @Mapping({ "compiler", "ignore-default-initilization" }) -@FlexOnly public void setIgnoreDefaultInitilization(ConfigurationValue cv, boole
flex-typedefs git commit: stop caching of JS file as it breaks the build sometimes
Repository: flex-typedefs Updated Branches: refs/heads/release0.8.0 2bd4044d1 -> b72f9b8b2 stop caching of JS file as it breaks the build sometimes Project: http://git-wip-us.apache.org/repos/asf/flex-typedefs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-typedefs/commit/b72f9b8b Tree: http://git-wip-us.apache.org/repos/asf/flex-typedefs/tree/b72f9b8b Diff: http://git-wip-us.apache.org/repos/asf/flex-typedefs/diff/b72f9b8b Branch: refs/heads/release0.8.0 Commit: b72f9b8b2fb387e40988ee5e7bff1b456afa80fd Parents: 2bd4044 Author: Justin Mclean Authored: Fri Jun 16 11:58:17 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 16 11:58:57 2017 +1000 -- js/pom.xml | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/flex-typedefs/blob/b72f9b8b/js/pom.xml -- diff --git a/js/pom.xml b/js/pom.xml index d10843b..1e4bb7d 100644 --- a/js/pom.xml +++ b/js/pom.xml @@ -51,6 +51,7 @@ https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js svg.js ${project.build.directory}/downloads + true
flex-typedefs git commit: stop caching of JS file as it breaks the build sometimes
Repository: flex-typedefs Updated Branches: refs/heads/develop 736388add -> 257efb237 stop caching of JS file as it breaks the build sometimes Project: http://git-wip-us.apache.org/repos/asf/flex-typedefs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-typedefs/commit/257efb23 Tree: http://git-wip-us.apache.org/repos/asf/flex-typedefs/tree/257efb23 Diff: http://git-wip-us.apache.org/repos/asf/flex-typedefs/diff/257efb23 Branch: refs/heads/develop Commit: 257efb237919577123f8a038bd2113bad6abdd88 Parents: 736388a Author: Justin Mclean Authored: Fri Jun 16 11:58:17 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 16 11:58:17 2017 +1000 -- js/pom.xml | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/flex-typedefs/blob/257efb23/js/pom.xml -- diff --git a/js/pom.xml b/js/pom.xml index 3c0a26c..ddea7a7 100644 --- a/js/pom.xml +++ b/js/pom.xml @@ -51,6 +51,7 @@ https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js svg.js ${project.build.directory}/downloads + true
git commit: [flex-falcon] [refs/heads/initializers] - initialise Boolean to false and Numbers to NaN
Repository: flex-falcon Updated Branches: refs/heads/initializers [created] c17bdc9a5 initialise Boolean to false and Numbers to NaN Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/c17bdc9a Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/c17bdc9a Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/c17bdc9a Branch: refs/heads/initializers Commit: c17bdc9a5ac163b0b265343f518364ebb3631556 Parents: 7121b45 Author: Justin Mclean Authored: Sun Jun 11 12:31:38 2017 +1000 Committer: Justin Mclean Committed: Sun Jun 11 12:31:38 2017 +1000 -- .../codegen/js/jx/VarDeclarationEmitter.java| 22 1 file changed, 22 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c17bdc9a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java -- diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java index 4e35e39..67ae28f 100644 --- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java +++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/VarDeclarationEmitter.java @@ -194,6 +194,28 @@ public class VarDeclarationEmitter extends JSSubEmitter implements write("0"); } } +else if (defName.equals("Boolean")) +{ +if (node.getParent() != null && +node.getParent().getParent() != null && +node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) +{ +write(ASEmitterTokens.SPACE); +writeToken(ASEmitterTokens.EQUAL); +write(ASEmitterTokens.FALSE); +} +} +else if (defName.equals("Number")) +{ +if (node.getParent() != null && +node.getParent().getParent() != null && +node.getParent().getParent().getNodeID() != ASTNodeID.Op_InID) +{ +write(ASEmitterTokens.SPACE); +writeToken(ASEmitterTokens.EQUAL); +write("NaN"); +} +} } }
git commit: [flex-falcon] [refs/heads/develop] - make it clear you are not dividing by zero
Repository: flex-falcon Updated Branches: refs/heads/develop 16297c334 -> 7121b45a9 make it clear you are not dividing by zero Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/7121b45a Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/7121b45a Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/7121b45a Branch: refs/heads/develop Commit: 7121b45a93588041bf6e099f33be448a4e3a5770 Parents: 16297c3 Author: Justin Mclean Authored: Sun Jun 11 12:29:48 2017 +1000 Committer: Justin Mclean Committed: Sun Jun 11 12:29:48 2017 +1000 -- .../flex/compiler/internal/as/codegen/ABCGeneratingReducer.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7121b45a/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ABCGeneratingReducer.java -- diff --git a/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ABCGeneratingReducer.java b/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ABCGeneratingReducer.java index 776993f..c712f56 100644 --- a/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ABCGeneratingReducer.java +++ b/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ABCGeneratingReducer.java @@ -749,7 +749,7 @@ public class ABCGeneratingReducer // java treats -0 and 0 as equal, but divide by -0 results in NEG INFINITY, whereas pos // 0 results in POS INFINITY // positive 0 can be encoded with a pushbyte, but neg zero requires a pushdouble -if( dval == 0 && 1/dval == Double.NEGATIVE_INFINITY ) +if( dval == 0.0 && 1.0/dval == Double.NEGATIVE_INFINITY ) result_list.addInstruction(OP_pushdouble, dval); else // Integer
git commit: [flex-asjs] [refs/heads/develop] - opps extra ; crept in
Repository: flex-asjs Updated Branches: refs/heads/develop 0d6965416 -> d78243ed0 opps extra ; crept in Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/d78243ed Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/d78243ed Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/d78243ed Branch: refs/heads/develop Commit: d78243ed0ddf0ba8dec59d3e6d65304f31811a0f Parents: 0d69654 Author: Justin Mclean Authored: Mon Jun 5 13:49:44 2017 +1000 Committer: Justin Mclean Committed: Mon Jun 5 13:49:44 2017 +1000 -- .../flex/org/apache/flex/html/accessories/PasswordInputBead.as | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/d78243ed/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as index 4312100..8e47222 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as @@ -78,7 +78,7 @@ package org.apache.flex.html.accessories var host:UIBase; var e:HTMLInputElement; - if (value !== null) {; + if (value !== null) { host = value as UIBase; e = host.element as HTMLInputElement; e.type = 'password';
[2/3] git commit: [flex-asjs] [refs/heads/develop] - set strand to null when removing bead - do this so beads can cleanly remove themselves
set strand to null when removing bead - do this so beads can cleanly remove themselves Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/385655aa Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/385655aa Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/385655aa Branch: refs/heads/develop Commit: 385655aa137456614c7b70d295f84f50046af64b Parents: 66773df Author: Justin Mclean Authored: Mon Jun 5 13:16:36 2017 +1000 Committer: Justin Mclean Committed: Mon Jun 5 13:16:36 2017 +1000 -- .../Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/385655aa/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as index d67686e..30a67bb 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as @@ -208,7 +208,7 @@ package org.apache.flex.core if (bead === value) { _beads.splice(i, 1); - +bead.strand = null; return bead; } }
[3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed
set input type back to text when bead is removed Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0d696541 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0d696541 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0d696541 Branch: refs/heads/develop Commit: 0d69654163d8fe0ae7d027f027fa06bb7d71f4bd Parents: 385655a Author: Justin Mclean Authored: Mon Jun 5 13:17:04 2017 +1000 Committer: Justin Mclean Committed: Mon Jun 5 13:17:04 2017 +1000 -- .../flex/html/accessories/PasswordInputBead.as | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/0d696541/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as index e73822b..4312100 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories/PasswordInputBead.as @@ -68,17 +68,27 @@ package org.apache.flex.html.accessories */ public function set strand(value:IStrand):void { - _strand = value; - COMPILE::SWF { + _strand = value; IEventDispatcher(value).addEventListener("viewChanged",viewChangeHandler); } COMPILE::JS { - var host:UIBase = value as UIBase; - var e:HTMLInputElement = host.element as HTMLInputElement; - e.type = 'password'; + var host:UIBase; + var e:HTMLInputElement; + + if (value !== null) {; + host = value as UIBase; + e = host.element as HTMLInputElement; + e.type = 'password'; +} + else { + host = _strand as UIBase; + e = host.element as HTMLInputElement; +e.type = 'text'; +} + _strand = value; } }
[1/3] git commit: [flex-asjs] [refs/heads/develop] - positioner can be null or undefined
Repository: flex-asjs Updated Branches: refs/heads/develop 407cacd15 -> 0d6965416 positioner can be null or undefined Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/66773dfe Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/66773dfe Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/66773dfe Branch: refs/heads/develop Commit: 66773dfeb7bf9bf228720d521f5e5682a12ee8c6 Parents: 407cacd Author: Justin Mclean Authored: Mon Jun 5 13:14:47 2017 +1000 Committer: Justin Mclean Committed: Mon Jun 5 13:14:47 2017 +1000 -- .../projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/66773dfe/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as index bf23ddf..efde41b 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as @@ -1474,7 +1474,8 @@ package org.apache.flex.core { if (element === null) element = document.createElement('div') as WrappedHTMLElement; -if (positioner === null) +// initially undefined could be set to null +if (positioner == null) positioner = element; positioner.style.display = 'block'; //positioner.style.position = 'relative';
[2/7] git commit: [flex-asjs] [refs/heads/develop] - no need to check c twice
no need to check c twice Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/282125cc Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/282125cc Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/282125cc Branch: refs/heads/develop Commit: 282125cc3d9159b115b06e1e885c76cea4d0bd70 Parents: ae3fbe3 Author: Justin Mclean Authored: Fri Jun 2 14:25:51 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 2 14:25:51 2017 +1000 -- .../Basic/src/main/flex/org/apache/flex/core/UIBase.as| 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/282125cc/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as index 94cfef5..04615c3 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as @@ -870,11 +870,8 @@ package org.apache.flex.core var c:Class = ValuesManager.valuesImpl.getValue(this, "iBeadView") as Class; if (c) { -if (c) -{ -_view = (new c()) as IBeadView; -addBead(_view); -} +_view = (new c()) as IBeadView; +addBead(_view); } } return _view;
[6/7] git commit: [flex-asjs] [refs/heads/develop] - temporary fix for null/unresolved issues between AS/JS
temporary fix for null/unresolved issues between AS/JS Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/2af9ded8 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/2af9ded8 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/2af9ded8 Branch: refs/heads/develop Commit: 2af9ded85cb047c3b74407bd381fd8187eba7ed8 Parents: 256dcd7 Author: Justin Mclean Authored: Sat Jun 3 11:42:30 2017 +1000 Committer: Justin Mclean Committed: Sat Jun 3 11:42:30 2017 +1000 -- .../main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/2af9ded8/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as -- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as index a4e4e1d..5e3a6c4 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as @@ -336,7 +336,8 @@ package org.apache.flex.core if (thisObject is IStyleableObject) { var styleable:IStyleableObject = IStyleableObject(thisObject); -if (styleable.style !== undefined) +// undefined in JS null in AS +if (styleable.style != null) { value = styleable.style[valueName]; if (value === INHERIT) @@ -344,7 +345,8 @@ package org.apache.flex.core if (value !== undefined) return value; } -if (styleable.id !== undefined) +// undefined in JS null in AS +if (styleable.id != null) { o = values["#" + styleable.id]; if (o !== undefined) @@ -357,7 +359,8 @@ package org.apache.flex.core } } var classNames:String = styleable.className; -if (classNames !== undefined) +// undefined in JS null in AS +if (classNames != null) { var classNameList:Array = classNames.split(" "); for each (className in classNameList)
[4/7] git commit: [flex-asjs] [refs/heads/develop] - Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-asjs into develop Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6fef8802 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6fef8802 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6fef8802 Branch: refs/heads/develop Commit: 6fef8802fddde60abd7e848d3c26d3829adf16de Parents: 4eb2f8b f730c0c Author: Justin Mclean Authored: Sat Jun 3 08:52:48 2017 +1000 Committer: Justin Mclean Committed: Sat Jun 3 08:52:48 2017 +1000 -- examples/flexjs/DataBindingExampleWithFlexLayout/pom.xml | 1 + 1 file changed, 1 insertion(+) --
[1/7] git commit: [flex-asjs] [refs/heads/develop] - remove blank statement
Repository: flex-asjs Updated Branches: refs/heads/develop f730c0cfd -> 407cacd15 remove blank statement Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/ae3fbe3e Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/ae3fbe3e Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/ae3fbe3e Branch: refs/heads/develop Commit: ae3fbe3e60a1cadc82820cc10ac13c30e6ed6c08 Parents: 6f03502 Author: Justin Mclean Authored: Fri Jun 2 14:23:15 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 2 14:23:15 2017 +1000 -- .../projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/ae3fbe3e/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as index d917b8d..94cfef5 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as @@ -1509,7 +1509,7 @@ package org.apache.flex.core var newStyle:Object = {}; newStyle[value.propertyName] = value.newValue; ValuesManager.valuesImpl.applyStyles(this, newStyle); -}; +} /** * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
[5/7] git commit: [flex-asjs] [refs/heads/develop] - as returns null rather than undefined
as returns null rather than undefined Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/256dcd71 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/256dcd71 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/256dcd71 Branch: refs/heads/develop Commit: 256dcd71c4fce9168c5c07e88d3e72a11239d2ce Parents: 6fef880 Author: Justin Mclean Authored: Sat Jun 3 10:41:36 2017 +1000 Committer: Justin Mclean Committed: Sat Jun 3 10:41:36 2017 +1000 -- .../Basic/src/main/flex/org/apache/flex/core/UIBase.as | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/256dcd71/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as index e242fd6..e524bc3 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as @@ -868,7 +868,7 @@ package org.apache.flex.core if (_view === null) { var c:Class = ValuesManager.valuesImpl.getValue(this, "iBeadView") as Class; -if (c !== undefined) +if (c !== null) { _view = (new c()) as IBeadView; addBead(_view); @@ -1344,7 +1344,7 @@ package org.apache.flex.core if (getBeadByType(IBeadModel) === null) { c = ValuesManager.valuesImpl.getValue(this, "iBeadModel") as Class; -if (c !== undefined) +if (c !== null) { var model:IBeadModel = new c as IBeadModel; if (model) @@ -1354,7 +1354,7 @@ package org.apache.flex.core if (_view === null && getBeadByType(IBeadView) === null) { c = ValuesManager.valuesImpl.getValue(this, "iBeadView") as Class; -if (c !== undefined) +if (c !== null) { var view:IBeadView = new c as IBeadView; if (view) @@ -1364,7 +1364,7 @@ package org.apache.flex.core if (getBeadByType(IBeadController) === null) { c = ValuesManager.valuesImpl.getValue(this, "iBeadController") as Class; -if (c !== undefined) +if (c !== null) { var controller:IBeadController = new c as IBeadController; if (controller)
[3/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== where needed
use === and !== where needed Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/4eb2f8b1 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/4eb2f8b1 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/4eb2f8b1 Branch: refs/heads/develop Commit: 4eb2f8b168e4857b33163a36d8e98b56550fc39c Parents: 282125c Author: Justin Mclean Authored: Fri Jun 2 19:48:19 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 2 19:48:19 2017 +1000 -- .../main/flex/org/apache/flex/core/UIBase.as| 80 ++-- 1 file changed, 40 insertions(+), 40 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4eb2f8b1/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as index 04615c3..e242fd6 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as @@ -202,7 +202,7 @@ package org.apache.flex.core */ public function set explicitWidth(value:Number):void { - if (_explicitWidth == value) + if (_explicitWidth === value) return; // width can be pixel or percent not both @@ -235,7 +235,7 @@ package org.apache.flex.core */ public function set explicitHeight(value:Number):void { - if (_explicitHeight == value) + if (_explicitHeight === value) return; // height can be pixel or percent not both @@ -272,7 +272,7 @@ package org.apache.flex.core public function set percentWidth(value:Number):void { COMPILE::SWF { - if (_percentWidth == value) + if (_percentWidth === value) return; if (!isNaN(value)) @@ -315,7 +315,7 @@ package org.apache.flex.core public function set percentHeight(value:Number):void { COMPILE::SWF { - if (_percentHeight == value) + if (_percentHeight === value) return; if (!isNaN(value)) @@ -369,7 +369,7 @@ package org.apache.flex.core { var pixels:Number; var strpixels:String = positioner.style.width as String; -if (strpixels !== null && strpixels.indexOf('%') != -1) +if (strpixels !== null && strpixels.indexOf('%') !== -1) pixels = NaN; else pixels = parseFloat(strpixels); @@ -389,7 +389,7 @@ package org.apache.flex.core COMPILE::SWF override public function set width(value:Number):void { - if (explicitWidth != value) + if (explicitWidth !== value) { explicitWidth = value; } @@ -403,7 +403,7 @@ package org.apache.flex.core COMPILE::JS public function set width(value:Number):void { -if (explicitWidth != value) +if (explicitWidth !== value) { explicitWidth = value; } @@ -461,7 +461,7 @@ package org.apache.flex.core { var pixels:Number; var strpixels:String = positioner.style.height as String; -if (strpixels !== null && strpixels.indexOf('%') != -1) +if (strpixels !== null && strpixels.indexOf('%') !== -1) pixels = NaN; else pixels = parseFloat(strpixels); @@ -481,7 +481,7 @@ package org.apache.flex.core COMPILE::SWF override public function set height(value:Number):void { - if (explicitHeight != value) + if (explicitHeight !== value) { explicitHeight = value; } @@ -495,7 +495,7 @@ package org.apache.flex.core COMPILE::JS public function set height(value:Number):void { -if (explicitHeight != value) +
[7/7] git commit: [flex-asjs] [refs/heads/develop] - temporary fix for null/undefined issues between AS/JS
temporary fix for null/undefined issues between AS/JS Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/407cacd1 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/407cacd1 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/407cacd1 Branch: refs/heads/develop Commit: 407cacd158576b58e1d6e7f04a52ae915e2a95f2 Parents: 2af9ded Author: Justin Mclean Authored: Sat Jun 3 11:43:06 2017 +1000 Committer: Justin Mclean Committed: Sat Jun 3 11:43:06 2017 +1000 -- .../src/main/flex/org/apache/flex/core/UIBase.as | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/407cacd1/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as index e524bc3..bf23ddf 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as @@ -865,10 +865,12 @@ package org.apache.flex.core */ public function get view():IBeadView { -if (_view === null) +// JS undefined AS null +if (_view == null) { var c:Class = ValuesManager.valuesImpl.getValue(this, "iBeadView") as Class; -if (c !== null) +// JS undefined AS null +if (c != null) { _view = (new c()) as IBeadView; addBead(_view); @@ -1344,17 +1346,20 @@ package org.apache.flex.core if (getBeadByType(IBeadModel) === null) { c = ValuesManager.valuesImpl.getValue(this, "iBeadModel") as Class; -if (c !== null) +// JS undefined AS null +if (c != null) { var model:IBeadModel = new c as IBeadModel; if (model) addBead(model); } } -if (_view === null && getBeadByType(IBeadView) === null) +// view JS undefined AS null +if (_view == null && getBeadByType(IBeadView) === null) { c = ValuesManager.valuesImpl.getValue(this, "iBeadView") as Class; -if (c !== null) +// JS undefined AS null +if (c != null) { var view:IBeadView = new c as IBeadView; if (view) @@ -1364,7 +1369,8 @@ package org.apache.flex.core if (getBeadByType(IBeadController) === null) { c = ValuesManager.valuesImpl.getValue(this, "iBeadController") as Class; -if (c !== null) +// JS undefined AS null +if (c != null) { var controller:IBeadController = new c as IBeadController; if (controller)
git commit: [flex-asjs] [refs/heads/develop] - improve comparisons and move end condition calculation out of loop
Repository: flex-asjs Updated Branches: refs/heads/develop 5e0d33052 -> 6f03502df improve comparisons and move end condition calculation out of loop Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6f03502d Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6f03502d Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6f03502d Branch: refs/heads/develop Commit: 6f03502df36ca0cd01a269db255b2a5c2cbea6f3 Parents: 5e0d330 Author: Justin Mclean Authored: Fri Jun 2 12:03:57 2017 +1000 Committer: Justin Mclean Committed: Fri Jun 2 12:03:57 2017 +1000 -- .../org/apache/flex/collections/ArrayList.as| 26 +++- .../apache/flex/collections/FlattenedList.as| 15 ++- 2 files changed, 24 insertions(+), 17 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6f03502d/frameworks/projects/Collections/src/main/flex/org/apache/flex/collections/ArrayList.as -- diff --git a/frameworks/projects/Collections/src/main/flex/org/apache/flex/collections/ArrayList.as b/frameworks/projects/Collections/src/main/flex/org/apache/flex/collections/ArrayList.as index fe74932..2598dd5 100644 --- a/frameworks/projects/Collections/src/main/flex/org/apache/flex/collections/ArrayList.as +++ b/frameworks/projects/Collections/src/main/flex/org/apache/flex/collections/ArrayList.as @@ -93,8 +93,10 @@ package org.apache.flex.collections public function ArrayList(initialSource:Array=null) { super(); - if (initialSource) _source = initialSource; - else _source = []; + if (initialSource !== null) + _source = initialSource; + else + _source = []; } private var _id:String; @@ -117,7 +119,7 @@ package org.apache.flex.collections */ public function set id(value:String):void { - if (_id != value) + if (_id !== value) { _id = value; dispatchEvent(new Event("idChanged")); @@ -157,8 +159,8 @@ package org.apache.flex.collections public function set source(value:Array):void { - if (_source != value) { - if (value == null) + if (_source !== value) { + if (value === null) { _source = []; } @@ -207,8 +209,10 @@ package org.apache.flex.collections */ public function getItemIndex(item:Object):int { - for (var index:int=0; index < _source.length; index++) { - if (item == _source[index]) { + var length:int = _source.length; + + for (var index:int=0; index < length; index++) { + if (item === _source[index]) { return index; } } @@ -244,11 +248,11 @@ package org.apache.flex.collections { source.splice(index, 0, item); } - else if (index == spliceUpperBound) + else if (index === spliceUpperBound) { source.push(item); } - else if (index == 0) + else if (index === 0) { source.unshift(item); } @@ -328,11 +332,11 @@ package org.apache.flex.collections { removed = source.splice(index, 1)[0]; } - else if (index == spliceUpperBound) + else if (index === spliceUpperBound) { removed = source.pop(); } - else if (index == 0) + else if (index === 0) { removed = source.shift(); } http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6f03502d/frameworks/projects/Collections/src/main/flex/org/apache/flex/collections/FlattenedList.as
[1/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !=== where safe
Repository: flex-asjs Updated Branches: refs/heads/develop 516e04f89 -> 5e0d33052 use === and !=== where safe Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/02a1232c Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/02a1232c Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/02a1232c Branch: refs/heads/develop Commit: 02a1232c7806c6e78f3ee7843eee5a7aafbc7c76 Parents: 516e04f Author: Justin Mclean Authored: Thu Jun 1 12:21:51 2017 +1000 Committer: Justin Mclean Committed: Thu Jun 1 12:21:51 2017 +1000 -- .../src/main/flex/org/apache/flex/utils/CSSUtils.as | 16 1 file changed, 8 insertions(+), 8 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/02a1232c/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as -- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as index dc264f8..36705ba 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as @@ -70,11 +70,11 @@ package org.apache.flex.utils public static function toNumber(str:String, reference:Number = 0):Number { var c:int = str.indexOf("px"); -if (c != -1) +if (c !== -1) return Number(str.substr(0, c)); c = str.indexOf("%"); -if (c != -1) +if (c !== -1) return Number(str.substr(0, c)) * reference / 100; return Number(str); @@ -123,17 +123,17 @@ package org.apache.flex.utils { return uint.MAX_VALUE; } -if (stringValue.charAt(0) == '#') +if (stringValue.charAt(0) === '#') { -if (stringValue.length == 4) +if (stringValue.length === 4) return uint("0x" + stringValue.charAt(1) + stringValue.charAt(1) + stringValue.charAt(2) + stringValue.charAt(2) + stringValue.charAt(3) + stringValue.charAt(3)); -if (stringValue.length == 7) +if (stringValue.length === 7) return uint("0xFF" + stringValue.substr(1)); return uint("0x" + stringValue.substr(1)); } -else if ((c = stringValue.indexOf("rgb(")) != -1) +else if ((c = stringValue.indexOf("rgb(")) !== -1) { c2 = stringValue.indexOf(")"); stringValue = stringValue.substring(c + 4, c2); @@ -143,7 +143,7 @@ package org.apache.flex.utils (uint(parts3[1]) << 8) + uint(parts3[2])); } -else if ((c = stringValue.indexOf("rgba(")) != -1) +else if ((c = stringValue.indexOf("rgba(")) !== -1) { c2 = stringValue.indexOf(")"); stringValue = stringValue.substring(c + 5, c2); @@ -295,7 +295,7 @@ package org.apache.flex.utils switch (side) { case 2: -side = n == 2 ? 0 : 2; +side = n === 2 ? 0 : 2; break; case 3: side = n < 3 ? 1 : 3;
[3/7] git commit: [flex-asjs] [refs/heads/develop] - make colour map const
make colour map const Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/ee3a98ec Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/ee3a98ec Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/ee3a98ec Branch: refs/heads/develop Commit: ee3a98ecf4711a8ac0bb17b5173ec5106da0615a Parents: 53eeff4 Author: Justin Mclean Authored: Thu Jun 1 13:14:41 2017 +1000 Committer: Justin Mclean Committed: Thu Jun 1 13:14:41 2017 +1000 -- .../Core/src/main/flex/org/apache/flex/utils/CSSUtils.as | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/ee3a98ec/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as -- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as index 0dcad67..39dc818 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as @@ -119,7 +119,7 @@ package org.apache.flex.utils var c2:int; var stringValue:String = value as String; - if (stringValue == "transparent") + if (stringValue === "transparent") { return uint.MAX_VALUE; } @@ -316,7 +316,7 @@ package org.apache.flex.utils * @playerversion AIR 2.6 * @productversion FlexJS 0.0 */ -public static var colorMap:Object = { +public static const colorMap:Object = { transparent: 0, white: 0x, silver: 0xFFC0C0C0,