git commit: [flex-sdk] [refs/heads/develop] - FLEX-35082: Changed the way regex was being used to compare the given pattern for dataProvider objects in the findRowIndex / findRowIndices methods.

2016-04-28 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop ce0ec309d -> f2c02cbf0


FLEX-35082: Changed the way regex was being used to compare the given pattern 
for dataProvider objects in the findRowIndex / findRowIndices methods.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f2c02cbf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f2c02cbf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f2c02cbf

Branch: refs/heads/develop
Commit: f2c02cbf0c8a3c8e228fc2596933a411b2cbb781
Parents: ce0ec30
Author: Mark Kessler 
Authored: Thu Apr 28 19:30:05 2016 -0400
Committer: Mark Kessler 
Committed: Thu Apr 28 19:30:05 2016 -0400

--
 frameworks/projects/spark/src/spark/components/Grid.as   | 4 ++--
 .../spark/src/spark/components/supportClasses/ListBase.as| 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f2c02cbf/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index 23a6d5f..5f9f0cd 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -4805,7 +4805,7 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
 {
 currentObject = dataProvider.getItemAt(loopingIndex);
 
-if (currentObject.hasOwnProperty(field) == true && 
currentObject[field].search(pattern) != -1)
+if (currentObject.hasOwnProperty(field) == true && 
pattern.test(currentObject[field]) == true)
 {
 return loopingIndex;
 }
@@ -4862,7 +4862,7 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
 //Loop through regex patterns from the values array.
 for (loopingValuesIndex = 0; loopingValuesIndex < valuesTotal; 
loopingValuesIndex++)
 {
-if 
(currentObject[field].search(regexList[loopingValuesIndex]) != -1)
+if 
(regexList[loopingValuesIndex].test(currentObject[field]) == true)
 {
 matchedIndices.push(loopingDataProviderIndex);
 

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f2c02cbf/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index c72d4d5..e700d0d 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1311,7 +1311,7 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 {
 currentObject = dataProvider.getItemAt(loopingIndex);
 
-if (currentObject.hasOwnProperty(field) == true && 
currentObject[field].search(pattern) != -1)
+if (currentObject.hasOwnProperty(field) == true && 
pattern.test(currentObject[field]) == true)
 {
 return loopingIndex;
 }
@@ -1368,7 +1368,7 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 //Loop through regex patterns from the values array.
 for (loopingValuesIndex = 0; loopingValuesIndex < valuesTotal; 
loopingValuesIndex++)
 {
-if 
(currentObject[field].search(regexList[loopingValuesIndex]) != -1)
+if 
(regexList[loopingValuesIndex].test(currentObject[field]) == true)
 {
 matchedIndices.push(loopingDataProviderIndex);
 



git commit: [flex-sdk] [refs/heads/develop] - FLEX-34982: The styles will now fallback to assigning directly to the chart directly if the style declaration was not found. This corrects RTE's that occu

2015-12-12 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop d22d68726 -> 10a910ea2


FLEX-34982: The styles will now fallback to assigning directly to the chart 
directly if the style declaration was not found.  This corrects RTE's that 
occur later when the styles are referenced and do not perform null checks.

-Removed initStyles() method return values since they were not being checked 
and it's only response was true.  It's a private method, will not have to worry 
about being overridden.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/10a910ea
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/10a910ea
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/10a910ea

Branch: refs/heads/develop
Commit: 10a910ea280b7abec5c8afff4883a94360f701b0
Parents: d22d687
Author: Mark Kessler 
Authored: Fri Dec 11 12:34:20 2015 -0500
Committer: Mark Kessler 
Committed: Fri Dec 11 12:34:20 2015 -0500

--
 .../charts/src/mx/charts/series/AreaSeries.as   | 20 
 .../charts/src/mx/charts/series/BarSeries.as| 17 ++
 .../charts/src/mx/charts/series/BubbleSeries.as | 19 
 .../src/mx/charts/series/CandlestickSeries.as   | 18 +++
 .../charts/src/mx/charts/series/ColumnSeries.as | 16 ++---
 .../charts/src/mx/charts/series/HLOCSeries.as   | 17 ++
 .../charts/src/mx/charts/series/LineSeries.as   | 20 
 .../charts/src/mx/charts/series/PieSeries.as| 24 ++--
 .../charts/src/mx/charts/series/PlotSeries.as   | 14 +---
 9 files changed, 125 insertions(+), 40 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/10a910ea/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
--
diff --git a/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as 
b/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
index 1b26975..f36d4ed 100644
--- a/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
+++ b/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
@@ -869,11 +869,13 @@ public class AreaSeries extends Series implements 
IStackable2
/**
 *  @private
 */
-   private function initStyles():Boolean
+   private function initStyles():void
{
HaloDefaults.init(styleManager);
-   
+
var areaSeriesStyle:CSSStyleDeclaration = 
HaloDefaults.findStyleDeclaration(styleManager, "mx.charts.series.AreaSeries");
+
+
if (areaSeriesStyle)
{
areaSeriesStyle.setStyle("areaRenderer", new 
ClassFactory(mx.charts.renderers.AreaRenderer));
@@ -882,10 +884,18 @@ public class AreaSeries extends Series implements 
IStackable2
areaSeriesStyle.setStyle("fills", []);
areaSeriesStyle.setStyle("stroke", 
HaloDefaults.pointStroke);
}
-   
-   return true;
+else
+{
+//Fallback to set the style to this chart directly.
+   setStyle("areaRenderer", new 
ClassFactory(mx.charts.renderers.AreaRenderer));
+   setStyle("legendMarkerRenderer", new 
ClassFactory(AreaSeriesLegendMarker));
+   setStyle("areaFill", new SolidColor(0x00));
+   setStyle("fills", []);
+   setStyle("stroke", HaloDefaults.pointStroke);
+}
}
-   
+
+
/**
 *  @inheritDoc
 *  

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/10a910ea/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
--
diff --git a/frameworks/projects/charts/src/mx/charts/series/BarSeries.as 
b/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
index 7fb224a..42b5d76 100644
--- a/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
+++ b/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
@@ -1051,11 +1051,13 @@ public class BarSeries extends Series implements 
IStackable2, IBar
/**
  *  @private
  */
-private function initStyles():Boolean
+private function initStyles():void
 {
 HaloDefaults.init(styleManager);

var barSeriesStyle:CSSStyleDeclaration = 
HaloDefaults.findStyleDeclaration(styleManager, "mx.charts.series.BarSeries");
+
+
if (barSeriesStyle)
{
barSeriesStyle.setStyle("itemRenderer", new 
ClassFactory(mx.charts.renderers.BoxItemRenderer));
@@ -1063,10 +1065,17 @@ public class BarSeries extends Series implements 
IStackable2, IBar

git commit: [flex-sdk] [refs/heads/develop] - Moved the initStyles from the moduleFactory setter to the class constructor. This resolved a bug with the styles only being attempted once.

2015-12-20 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop dc86ad392 -> 7738c750e


Moved the initStyles from the moduleFactory setter to the class constructor. 
This resolved a bug with the styles only being attempted once.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7738c750
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7738c750
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7738c750

Branch: refs/heads/develop
Commit: 7738c750e36be693076c191fc61cc8fa5c7ab132
Parents: dc86ad3
Author: Mark Kessler 
Authored: Sun Dec 20 21:35:34 2015 -0500
Committer: Mark Kessler 
Committed: Sun Dec 20 21:35:34 2015 -0500

--
 .../projects/charts/src/mx/charts/series/AreaSeries.as   | 6 +++---
 frameworks/projects/charts/src/mx/charts/series/BarSeries.as | 6 +++---
 .../projects/charts/src/mx/charts/series/BubbleSeries.as | 6 +++---
 .../charts/src/mx/charts/series/CandlestickSeries.as | 6 +++---
 .../projects/charts/src/mx/charts/series/ColumnSeries.as | 6 +++---
 .../projects/charts/src/mx/charts/series/HLOCSeries.as   | 6 +++---
 .../projects/charts/src/mx/charts/series/LineSeries.as   | 6 +++---
 frameworks/projects/charts/src/mx/charts/series/PieSeries.as | 8 
 .../projects/charts/src/mx/charts/series/PlotSeries.as   | 6 +++---
 9 files changed, 28 insertions(+), 28 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7738c750/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
--
diff --git a/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as 
b/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
index f36d4ed..5d89c71 100644
--- a/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
+++ b/frameworks/projects/charts/src/mx/charts/series/AreaSeries.as
@@ -283,6 +283,9 @@ public class AreaSeries extends Series implements 
IStackable2
 _instanceCache.creationCallback = applyItemRendererProperties;
 
 dataTransform = new CartesianTransform();
+
+   // our style settings
+   initStyles();
 }
 
 
//--
@@ -912,9 +915,6 @@ public class AreaSeries extends Series implements 
IStackable2
return;

_moduleFactoryInitialized[factory] = true;
-   
-   // our style settings
-   initStyles();
}

 /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7738c750/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
--
diff --git a/frameworks/projects/charts/src/mx/charts/series/BarSeries.as 
b/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
index f717f51..9ca363a 100644
--- a/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
+++ b/frameworks/projects/charts/src/mx/charts/series/BarSeries.as
@@ -273,6 +273,9 @@ public class BarSeries extends Series implements 
IStackable2, IBar
 };
 
 dataTransform = new CartesianTransform();
+
+// our style settings
+initStyles();
 }
 
 private function getLabelClass():Class
@@ -1099,9 +1102,6 @@ public class BarSeries extends Series implements 
IStackable2, IBar
 return;
 
 _moduleFactoryInitialized[factory] = true;
-
-// our style settings
-initStyles();
 }
 
 /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7738c750/frameworks/projects/charts/src/mx/charts/series/BubbleSeries.as
--
diff --git a/frameworks/projects/charts/src/mx/charts/series/BubbleSeries.as 
b/frameworks/projects/charts/src/mx/charts/series/BubbleSeries.as
index c061671..428e83a 100644
--- a/frameworks/projects/charts/src/mx/charts/series/BubbleSeries.as
+++ b/frameworks/projects/charts/src/mx/charts/series/BubbleSeries.as
@@ -200,6 +200,9 @@ public class BubbleSeries extends Series
 _instanceCache.creationCallback = applyItemRendererProperties;
 
 dataTransform = new CartesianTransform();
+
+   // our style settings
+   initStyles();
 }
 
 
//--
@@ -740,9 +743,6 @@ public class BubbleSeries extends Series
return;

_moduleFactoryInitialized[factory] = true;
-   
-   // our style settings
-   initStyles();
}

 /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7738

git commit: [flex-utilities] [refs/heads/develop] - FLEX-34474: Removed styles that were not needed and were causing white labels on gray buttons.

2014-08-20 Thread mkessler
Repository: flex-utilities
Updated Branches:
  refs/heads/develop 354013ee8 -> 44748b11f


FLEX-34474: Removed styles that were not needed and were causing white labels 
on gray buttons.

Added a destination value for the scale example besides the number 1.  It was 
scaling from 1 to 1...


Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/44748b11
Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/44748b11
Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/44748b11

Branch: refs/heads/develop
Commit: 44748b11f99c0e8165bfd07af551e62f60b6ceef
Parents: 354013e
Author: Mark Kessler 
Authored: Wed Aug 20 16:49:59 2014 -0400
Committer: Mark Kessler 
Committed: Wed Aug 20 16:49:59 2014 -0400

--
 .../src/spark/effects/Rotate3DExample.mxml  | 33 +
 .../src/spark/effects/Scale3DExample.mxml   | 37 ++--
 2 files changed, 4 insertions(+), 66 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/44748b11/TourDeFlex/TourDeFlex3/src/spark/effects/Rotate3DExample.mxml
--
diff --git a/TourDeFlex/TourDeFlex3/src/spark/effects/Rotate3DExample.mxml 
b/TourDeFlex/TourDeFlex3/src/spark/effects/Rotate3DExample.mxml
index 5134671..3fc6364 100644
--- a/TourDeFlex/TourDeFlex3/src/spark/effects/Rotate3DExample.mxml
+++ b/TourDeFlex/TourDeFlex3/src/spark/effects/Rotate3DExample.mxml
@@ -21,38 +21,7 @@
xmlns:fx="http://ns.adobe.com/mxml/2009";
xmlns:mx="library://ns.adobe.com/flex/mx"
xmlns:s="library://ns.adobe.com/flex/spark">
-   
-   
-   @namespace "library://ns.adobe.com/flex/spark";
-   Label { 
-   baseColor: #00; 
-   fontFamily: "Arial";
-   fontWeight: "bold";
-   fontSize: "11";
-   advancedAntiAliasing: true;
-   }
-   Button:up{ 
-   baseColor: #00; 
-   color: #FF; 
-   fontWeight: "bold";
-   }
-   Button:over{ 
-   baseColor: #878787; 
-   color: #FF; 
-   fontWeight: "bold";
-   }
-   Button:down{ 
-   baseColor: #878787; 
-   color: #00; 
-   fontWeight: "bold";
-   }
-   Button:disabled { 
-   baseColor: #FF; 
-   color: #878787; 
-   fontWeight: "bold";
-   }
-   
-   
+

http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/44748b11/TourDeFlex/TourDeFlex3/src/spark/effects/Scale3DExample.mxml
--
diff --git a/TourDeFlex/TourDeFlex3/src/spark/effects/Scale3DExample.mxml 
b/TourDeFlex/TourDeFlex3/src/spark/effects/Scale3DExample.mxml
index c6fd840..5d8e7c7 100644
--- a/TourDeFlex/TourDeFlex3/src/spark/effects/Scale3DExample.mxml
+++ b/TourDeFlex/TourDeFlex3/src/spark/effects/Scale3DExample.mxml
@@ -21,38 +21,7 @@
xmlns:fx="http://ns.adobe.com/mxml/2009";
xmlns:mx="library://ns.adobe.com/flex/mx"
xmlns:s="library://ns.adobe.com/flex/spark">
-   
-   
-   @namespace "library://ns.adobe.com/flex/spark";
-   Label { 
-   baseColor: #00; 
-   fontFamily: "Arial";
-   fontWeight: "bold";
-   fontSize: "11";
-   advancedAntiAliasing: true;
-   }
-   Button:up{ 
-   baseColor: #00; 
-   color: #FF; 
-   fontWeight: "bold";
-   }
-   Button:over{ 
-   baseColor: #878787; 
-   color: #FF; 
-   fontWeight: "bold";
-   }
-   Button:down{ 
-   baseColor: #878787; 
-   color: #00; 
-   fontWeight: "bold";
-   }
-   Button:disabled { 
-   baseColor: #FF; 
-   color: #878787; 
-   fontWeight: "bold";
-   }
-   
-   
+




-   
+   



-  

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33710: Added index bounds checks.

2013-09-04 Thread mkessler
Updated Branches:
  refs/heads/develop 4862c56fd -> b1d0359b6


FLEX-33710: Added index bounds checks.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/b1d0359b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/b1d0359b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/b1d0359b

Branch: refs/heads/develop
Commit: b1d0359b6368670e82a843cec9992260a968ca9a
Parents: 4862c56
Author: Mark Kessler 
Authored: Wed Sep 4 20:46:14 2013 -0400
Committer: Mark Kessler 
Committed: Wed Sep 4 20:46:14 2013 -0400

--
 .../spark/src/spark/components/DataGrid.as  | 26 +---
 1 file changed, 23 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b1d0359b/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 54f005c..9fa5449 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -4769,6 +4769,20 @@ public class DataGrid extends SkinnableContainerBase
 */ 
protected function isCellEditable(rowIndex:int, columnIndex:int):Boolean
{
+//
+//  Index out of bounds tests.
+//
+if (columnIndex < 0 || rowIndex < 0)
+{
+return false;
+}
+
+if (columnIndex >= columnsLength || rowIndex >= dataProvider.length)
+{
+return false;
+}
+
+
var dataItem:Object = dataProvider.getItemAt(rowIndex);
var column:GridColumn = 
GridColumn(columns.getItemAt(columnIndex));
var dataField:String = column.dataField;
@@ -5021,18 +5035,24 @@ public class DataGrid extends SkinnableContainerBase
 for each (var columnIndex:int in columnIndices)
 {
 var col:GridColumn = this.getColumnAt(columnIndex);
+
 if (!col || (!col.dataField && (col.labelFunction == null) && 
(col.sortCompareFunction == null)))
 return null;
-
+
 var dataField:String = col.dataField;
 var isComplexDataField:Boolean = (dataField && 
(dataField.indexOf(".") != -1));
 var sortField:ISortField = findSortField(dataField, 
previousFields, isComplexDataField);
 
 if (!sortField)
-sortField = col.sortField;  // constructs a new sortField
+{
+//Constructs a new sortField from the columns own sortField 
property.
+sortField = col.sortField;
+}
 else
+{
 sortField.descending = col.sortDescending;
-
+}
+
 fields.push(sortField);
 }
 



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33710: Changed the Range out of bounds check to a try/catch for a range error.

2013-09-04 Thread mkessler
Updated Branches:
  refs/heads/develop b1d0359b6 -> 1bef09730


FLEX-33710: Changed the Range out of bounds check to a try/catch for a range 
error.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/1bef0973
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/1bef0973
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/1bef0973

Branch: refs/heads/develop
Commit: 1bef09730660a8bf33d51083f9e1420fef72ef16
Parents: b1d0359
Author: Mark Kessler 
Authored: Wed Sep 4 21:23:37 2013 -0400
Committer: Mark Kessler 
Committed: Wed Sep 4 21:23:37 2013 -0400

--
 .../projects/spark/src/spark/components/DataGrid.as | 16 +---
 1 file changed, 5 insertions(+), 11 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/1bef0973/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 9fa5449..3ee69f0 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -4769,24 +4769,18 @@ public class DataGrid extends SkinnableContainerBase
 */ 
protected function isCellEditable(rowIndex:int, columnIndex:int):Boolean
{
-//
-//  Index out of bounds tests.
-//
-if (columnIndex < 0 || rowIndex < 0)
+try
 {
-return false;
+var dataItem:Object = dataProvider.getItemAt(rowIndex);
+var column:GridColumn = GridColumn(columns.getItemAt(columnIndex));
+var dataField:String = column.dataField;
 }
-
-if (columnIndex >= columnsLength || rowIndex >= dataProvider.length)
+catch (e:RangeError)
 {
 return false;
 }
 
 
-   var dataItem:Object = dataProvider.getItemAt(rowIndex);
-   var column:GridColumn = 
GridColumn(columns.getItemAt(columnIndex));
-   var dataField:String = column.dataField;
-   
return isDataEditable(dataItem, dataField);
}




git commit: [flex-sdk] [refs/heads/develop] - FLEX-33717: Created a new baseline image.

2013-09-06 Thread mkessler
Updated Branches:
  refs/heads/develop 614c19612 -> a53dd0d3f


FLEX-33717: Created a new baseline image.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a53dd0d3
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a53dd0d3
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a53dd0d3

Branch: refs/heads/develop
Commit: a53dd0d3f56db191cacd88d2fc40cb4805babb82
Parents: 614c196
Author: Mark Kessler 
Authored: Fri Sep 6 16:07:52 2013 -0400
Committer: Mark Kessler 
Committed: Fri Sep 6 16:08:38 2013 -0400

--
 .../Baselines/Editable_variableRowHeight_small.png | Bin 719 -> 708 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a53dd0d3/mustella/tests/gumbo/components/DataGrid/Properties/Baselines/Editable_variableRowHeight_small.png
--
diff --git 
a/mustella/tests/gumbo/components/DataGrid/Properties/Baselines/Editable_variableRowHeight_small.png
 
b/mustella/tests/gumbo/components/DataGrid/Properties/Baselines/Editable_variableRowHeight_small.png
index c8124fd..dfb856f 100644
Binary files 
a/mustella/tests/gumbo/components/DataGrid/Properties/Baselines/Editable_variableRowHeight_small.png
 and 
b/mustella/tests/gumbo/components/DataGrid/Properties/Baselines/Editable_variableRowHeight_small.png
 differ



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33702: Added column sort type access to the datagrid columns.

2013-09-09 Thread mkessler
Updated Branches:
  refs/heads/develop 0a8f84da5 -> 3188f0141


FLEX-33702: Added column sort type access to the datagrid columns.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3188f014
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3188f014
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3188f014

Branch: refs/heads/develop
Commit: 3188f01419a8c9bdf4d4e6859894ca05cbef3d8d
Parents: 0a8f84d
Author: Mark Kessler 
Authored: Mon Sep 9 19:45:53 2013 -0400
Committer: Mark Kessler 
Committed: Mon Sep 9 20:00:30 2013 -0400

--
 .../framework/src/mx/collections/ISortField.as  |  30 +
 .../framework/src/mx/collections/SortField.as   | 117 +-
 .../src/mx/collections/SortFieldCompareTypes.as | 118 ++
 .../projects/mx/src/mx/controls/DataGrid.as |   3 +
 .../controls/dataGridClasses/DataGridColumn.as  |  37 ++
 .../spark/src/spark/collections/SortField.as| 119 ++-
 .../spark/collections/SortFieldCompareTypes.as  | 119 +++
 .../spark/components/gridClasses/GridColumn.as  |  43 ++-
 8 files changed, 582 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3188f014/frameworks/projects/framework/src/mx/collections/ISortField.as
--
diff --git a/frameworks/projects/framework/src/mx/collections/ISortField.as 
b/frameworks/projects/framework/src/mx/collections/ISortField.as
index f0d5ec0..be4bdc8 100644
--- a/frameworks/projects/framework/src/mx/collections/ISortField.as
+++ b/frameworks/projects/framework/src/mx/collections/ISortField.as
@@ -139,6 +139,22 @@ public interface ISortField
 function get numeric():Object;
 function set numeric(value:Object):void;
 
+
+/**
+ *  Specifies what compare type will be used for the sortField. This 
overrides the default
+ *  behavior.
+ * 
+ *  @default null
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.11
+ */
+function get sortCompareType():String;
+function set sortCompareType(value:String):void;
+
+
 /**
  *  True if this ISortField uses a custom comparator function.
  *
@@ -192,5 +208,19 @@ public interface ISortField
  *  @productversion Flex 4.5
  */
 function reverse():void;
+
+
+/**
+ *  This changes the internal compare function used by the 
SortField based
+ *  on the value of sortCompareType.
+ * 
+ *  @return true for successfully matched or false for failure to match 
the sortCompareType.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.11
+ */
+function updateSortCompareType():Boolean;
 }
 }

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3188f014/frameworks/projects/framework/src/mx/collections/SortField.as
--
diff --git a/frameworks/projects/framework/src/mx/collections/SortField.as 
b/frameworks/projects/framework/src/mx/collections/SortField.as
index 47eed0a..3a5a388 100644
--- a/frameworks/projects/framework/src/mx/collections/SortField.as
+++ b/frameworks/projects/framework/src/mx/collections/SortField.as
@@ -28,6 +28,7 @@ import mx.managers.SystemManager;
 import mx.resources.IResourceManager;
 import mx.resources.ResourceManager;
 import mx.utils.ObjectUtil;
+import mx.collections.SortFieldCompareTypes;
 
 [ResourceBundle("collections")]
 [Alternative(replacement="spark.collections.SortField", since="4.5")]
@@ -136,7 +137,11 @@ public class SortField extends EventDispatcher implements 
ISortField
 _caseInsensitive = caseInsensitive;
 _descending = descending;
 _numeric = numeric;
-_compareFunction = stringCompare;
+
+if (updateSortCompareType() == false)
+{
+_compareFunction = stringCompare;
+}
 }
 
 
//--
@@ -404,6 +409,46 @@ public class SortField extends EventDispatcher implements 
ISortField
 }
 }
 
+
+//-
+//  sortCompareType
+//-
+
+/**
+ *  @private
+ */
+private var _sortCompareType:String = null;
+
+/**
+ *  @inheritDoc
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.11
+ */
+[Bindable("sortCompareTypeChanged")]
+public function get sortCompareType():String
+{
+return _sortCompareType;
+}
+
+/**
+ *  @private
+ */
+public f

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33702: Added sortCompareType to AdvancedDataGrid and corrected some spelling.

2013-09-13 Thread mkessler
Updated Branches:
  refs/heads/develop c85073c1e -> 64c0f1afb


FLEX-33702: Added sortCompareType to AdvancedDataGrid and corrected some 
spelling.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/64c0f1af
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/64c0f1af
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/64c0f1af

Branch: refs/heads/develop
Commit: 64c0f1afb9fddcca8c60144d271913ab22bb1ea0
Parents: c85073c
Author: Mark Kessler 
Authored: Fri Sep 13 20:30:22 2013 -0400
Committer: Mark Kessler 
Committed: Fri Sep 13 21:02:24 2013 -0400

--
 .../src/mx/controls/AdvancedDataGridBaseEx.as   |  1 +
 .../AdvancedDataGridColumn.as   | 37 
 .../framework/src/mx/collections/SortField.as   |  2 +-
 .../spark/src/spark/collections/SortField.as|  2 +-
 4 files changed, 40 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/64c0f1af/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
--
diff --git 
a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as 
b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
index e1f4766..0dc81d8 100644
--- 
a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
+++ 
b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
@@ -6130,6 +6130,7 @@ public class AdvancedDataGridBaseEx extends 
AdvancedDataGridBase implements IIME
 
 column.sortDescending = desc;
 var field:ISortField = new SortField(columnName); // name
+field.sortCompareType = column.sortCompareType;
 field.descending = desc;
 
 //field.name = column.dataField;

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/64c0f1af/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridColumn.as
--
diff --git 
a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridColumn.as
 
b/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridColumn.as
index d015779..034bb51 100644
--- 
a/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridColumn.as
+++ 
b/frameworks/projects/advancedgrids/src/mx/controls/advancedDataGridClasses/AdvancedDataGridColumn.as
@@ -1284,6 +1284,43 @@ public class AdvancedDataGridColumn extends 
CSSStyleDeclaration implements IIMES
 dispatchEvent(new Event("sortCompareFunctionChanged"));
 }
 
+
+//--
+//  sortCompareType
+//--
+
+/**
+ *  @private
+ */
+private var _sortCompareType:String;
+
+/**
+ *  @inheritDoc
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.11
+ */
+[Bindable("sortCompareTypeChanged")]
+public function get sortCompareType():String
+{
+return _sortCompareType;
+}
+
+/**
+ *  @private
+ */
+public function set sortCompareType(value:String):void
+{
+if (_sortCompareType != value)
+{
+_sortCompareType = value;
+dispatchEvent(new Event("sortCompareTypeChanged"));
+}
+}
+
+
 //--
 //  visible
 //--

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/64c0f1af/frameworks/projects/framework/src/mx/collections/SortField.as
--
diff --git a/frameworks/projects/framework/src/mx/collections/SortField.as 
b/frameworks/projects/framework/src/mx/collections/SortField.as
index 3a5a388..53b2dab 100644
--- a/frameworks/projects/framework/src/mx/collections/SortField.as
+++ b/frameworks/projects/framework/src/mx/collections/SortField.as
@@ -607,7 +607,7 @@ public class SortField extends EventDispatcher implements 
ISortField
 }
 
 
-//Loopup the sortCompareType by its SortFieldCompareTypes and set the 
assocuated compare function.
+//Lookup the sortCompareType by its SortFieldCompareTypes value and 
set the associated compare method.
 switch(_sortCompareType)
 {
 case SortFieldCompareTypes.DATE:

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/64c0f1af/frameworks/projects/spark/src/spark/collections/SortField.as
--
diff --git a/frameworks/projects/spark/src/spark/collections/SortField.as 
b/frameworks/projects/spark/s

git commit: [flex-sdk] [refs/heads/develop] - Updated to added another issue comment.

2013-09-13 Thread mkessler
Updated Branches:
  refs/heads/develop 64c0f1afb -> 108f1efbe


Updated to added another issue comment.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/108f1efb
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/108f1efb
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/108f1efb

Branch: refs/heads/develop
Commit: 108f1efbeac6bd9d0e217a5c2718c576aeb5b615
Parents: 64c0f1a
Author: Mark Kessler 
Authored: Fri Sep 13 21:08:45 2013 -0400
Committer: Mark Kessler 
Committed: Fri Sep 13 21:08:45 2013 -0400

--
 RELEASE_NOTES | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/108f1efb/RELEASE_NOTES
--
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index c590205..ed0f7c5 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -38,7 +38,7 @@ SDK Changes
 -
 - 120 and 640 dpi mobile resolution/skin support, fixes to 480dpi skins.
 - mx:AdvancedDataGrid and mx:DataGrid speed improvements.
-- Added column sort type access to the datagrid columns in mx:Datagrid and 
s:Datagrid. 
+- Added column sort type access to the datagrid columns in mx:Datagrid, 
s:Datagrid, and mx:AdvancedDataGrid. 
 - Able to easily change mx:AdvancedDataGrid row and column item renderer 
spanning.
 - s:DataGridEditor will now be visible in ASDocs and be visible in the Tag 
inspector.
 - Minor changes to make SDK compile with Falcon compiler.
@@ -60,6 +60,7 @@ FLEX-33714  Falcon compiler is stricter with ++ and -- 
operator on constants.
 FLEX-33712  DataGrid with itemRenderer Drag and Drop error
 FLEX-33710  spark DataGrid isCellEditable is missing index bounds check
 FLEX-33705  DataGridDragProxy created item renderer without a reference to the 
column
+FLEX-33702  DataGrid columns unable to specify sorting internal compare 
functions used.
 FLEX-33698  Shift Return creates new ParagraphElement
 FLEX-33692  Spark button border issue
 FLEX-33689  Flex Library project unit tests creates invalid 
FlexUnitApplication.mxml



git commit: [flex-sdk] [refs/heads/develop] - Updated to add more issues to the summary

2013-09-13 Thread mkessler
Updated Branches:
  refs/heads/develop 108f1efbe -> 91d35


Updated to add more issues to the summary


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/91d3
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/91d3
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/91d3

Branch: refs/heads/develop
Commit: 91d350ec6979123db6a4426dba06bdb1bd2a
Parents: 108f1ef
Author: Mark Kessler 
Authored: Fri Sep 13 22:15:35 2013 -0400
Committer: Mark Kessler 
Committed: Fri Sep 13 22:15:35 2013 -0400

--
 RELEASE_NOTES | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/91d3/RELEASE_NOTES
--
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index ed0f7c5..7afa548 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -78,9 +78,11 @@ FLEX-33636  Error when creating new project in FB 4.7 using 
SDK 4.10.0 (11.8/3.8
 FLEX-33409  TLF crashes when hypens are shown in a multi span textFlow
 FLEX-33131  rendererDescriptionMap is private, should be made protected to 
allow customizing the grid for condition
 FLEX-28012  FormItemSkin and StackedFormItemSkib indicatorDisplay's toolTip is 
not localized
+FLEX-27658  DataGrid component does not allow a default sorting order
 FLEX-27648  ViewStack.getItemIndex() throws error instead of returning -1 when 
item is not a child of the ViewStack
+FLEX-26779  DataGrid Problem
 FLEX-25906  ComboBox textInput not cleared when dataprovider changes
-
+FLEX-22182  AdvancedDatagrid get resorted once a refresh on the group 
Collection of a sorted ArrayCollection
 
 Apache Flex 4.10
 =



git commit: [flex-sdk] [refs/heads/develop] - Correcting ASDOC comments.

2013-10-01 Thread mkessler
Updated Branches:
  refs/heads/develop 760c581c5 -> c3d5e628a


Correcting ASDOC comments.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/c3d5e628
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/c3d5e628
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/c3d5e628

Branch: refs/heads/develop
Commit: c3d5e628ab1da9b91cdbcfe2ffd88f467879e53f
Parents: 760c581
Author: Mark Kessler 
Authored: Tue Oct 1 20:04:29 2013 -0400
Committer: Mark Kessler 
Committed: Tue Oct 1 20:04:29 2013 -0400

--
 frameworks/projects/spark/src/spark/components/Grid.as | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/c3d5e628/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index 1ce7d91..c31e781 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -1267,9 +1267,9 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
 
 /**
  *  The doubleClick mode of the control.  Possible values are:
- *  GridSelectionMode.CELL, 
- *  GridSelectionMode.GRID, 
- *  GridSelectionMode.ROW, 
+ *  GridDoubleClickMode.CELL, 
+ *  GridDoubleClickMode.GRID, 
+ *  GridDoubleClickMode.ROW, 
  * 
  *  Changing the doubleClickMode changes the double click
  *  criteria for firing the doubleClick event



git commit: [flex-sdk] [refs/heads/develop] - Correcting setButtonEnabled ASDOC comments. Better descriptions, corrected params, etc

2013-10-15 Thread mkessler
Updated Branches:
  refs/heads/develop ba846c447 -> 90d76c623


Correcting setButtonEnabled ASDOC comments.  Better descriptions, corrected 
params, etc


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/90d76c62
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/90d76c62
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/90d76c62

Branch: refs/heads/develop
Commit: 90d76c6232269a712ae8e7d436f79c7df3961324
Parents: ba846c4
Author: Mark Kessler 
Authored: Tue Oct 15 20:12:07 2013 -0400
Committer: Mark Kessler 
Committed: Tue Oct 15 20:12:07 2013 -0400

--
 .../components/supportClasses/ButtonBarBase.as  | 24 
 1 file changed, 15 insertions(+), 9 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/90d76c62/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
index ab5a28e..cdd4841 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
@@ -550,13 +550,16 @@ public class ButtonBarBase extends ListBase
 
 
 /**
-*  Changes the enabled property of a ButtonBar's Button 
referencing it by the ButtonBarbutton's label. 
+*  Allows changing the enabled property of a the child 
ButtonBarbutton's.
+*  It identifies the button given its label field (default) or an 
different optional field name may be passed. 
 *
-*  The method takes a single ButtonBarButton label, a new 
enabled property value, and an optional field name to search 
for.
-*  myButtonBar.setButtonEnabled("My Button Label", false)
+*  The method takes a single ButtonBarButton label, a new 
enabled property value, and an optional field name to use as the 
comparison field.
+*  
+*  myButtonBar.setButtonEnabled("My Button Label", false)
 *
-*  @param labelValue Is the ButtonBarButton label
-*  @param fieldName Field used for comparing the label
+*  @param labelValue Is the ButtonBarButton label.
+*  @param enabledValue The buttons new enabled value.
+*  @param fieldName Field used to compare the label value against.
 *
 *  @langversion 3.0
 *  @playerversion Flash 11.1
@@ -570,13 +573,16 @@ public class ButtonBarBase extends ListBase
 
 
 /**
-*  Disables several of a ButtonBar's Buttons, referencing them by the 
ButtonBarbutton's label. 
+*  Allows changing the enabled property of several child 
ButtonBarbutton's.
+*  It identifies the buttons given their label fields (default) or an 
different optional field name may be passed. 
 *
-*  The method takes an array of ButtonBarButton labels, a new 
enabled property value, and an optional field name to search 
for.
-*  myButtonBar.setButtonsEnabled(["My Button Label1", "My Label2"], 
false)
+*  The method takes an array of ButtonBarButton labels, a new 
enabled property value, and an optional field name to use as the 
comparison field.
+*  
+*  myButtonBar.setButtonsEnabled(["My Button Label1", "My Label2"], 
false)
 *
 *  @param labelValues Is an array of ButtonBarButton labels.
-*  @param fieldName Field used for comparing the label
+*  @param enabledValue The buttons new enabled value.
+*  @param fieldName Field used to compare the label value against.
 *
 *  @langversion 3.0
 *  @playerversion Flash 11.1



git commit: [flex-sdk] [refs/heads/release4.11.0] - Correcting setButtonEnabled ASDOC comments. Better descriptions, corrected params, etc

2013-10-15 Thread mkessler
Updated Branches:
  refs/heads/release4.11.0 c47ef1790 -> b612cd772


Correcting setButtonEnabled ASDOC comments.  Better descriptions, corrected 
params, etc


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/b612cd77
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/b612cd77
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/b612cd77

Branch: refs/heads/release4.11.0
Commit: b612cd772f66ea243238e211e9570c3404a57bb6
Parents: c47ef17
Author: Mark Kessler 
Authored: Tue Oct 15 20:12:07 2013 -0400
Committer: Mark Kessler 
Committed: Tue Oct 15 20:14:50 2013 -0400

--
 .../components/supportClasses/ButtonBarBase.as  | 24 
 1 file changed, 15 insertions(+), 9 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b612cd77/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
index ab5a28e..cdd4841 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
@@ -550,13 +550,16 @@ public class ButtonBarBase extends ListBase
 
 
 /**
-*  Changes the enabled property of a ButtonBar's Button 
referencing it by the ButtonBarbutton's label. 
+*  Allows changing the enabled property of a the child 
ButtonBarbutton's.
+*  It identifies the button given its label field (default) or an 
different optional field name may be passed. 
 *
-*  The method takes a single ButtonBarButton label, a new 
enabled property value, and an optional field name to search 
for.
-*  myButtonBar.setButtonEnabled("My Button Label", false)
+*  The method takes a single ButtonBarButton label, a new 
enabled property value, and an optional field name to use as the 
comparison field.
+*  
+*  myButtonBar.setButtonEnabled("My Button Label", false)
 *
-*  @param labelValue Is the ButtonBarButton label
-*  @param fieldName Field used for comparing the label
+*  @param labelValue Is the ButtonBarButton label.
+*  @param enabledValue The buttons new enabled value.
+*  @param fieldName Field used to compare the label value against.
 *
 *  @langversion 3.0
 *  @playerversion Flash 11.1
@@ -570,13 +573,16 @@ public class ButtonBarBase extends ListBase
 
 
 /**
-*  Disables several of a ButtonBar's Buttons, referencing them by the 
ButtonBarbutton's label. 
+*  Allows changing the enabled property of several child 
ButtonBarbutton's.
+*  It identifies the buttons given their label fields (default) or an 
different optional field name may be passed. 
 *
-*  The method takes an array of ButtonBarButton labels, a new 
enabled property value, and an optional field name to search 
for.
-*  myButtonBar.setButtonsEnabled(["My Button Label1", "My Label2"], 
false)
+*  The method takes an array of ButtonBarButton labels, a new 
enabled property value, and an optional field name to use as the 
comparison field.
+*  
+*  myButtonBar.setButtonsEnabled(["My Button Label1", "My Label2"], 
false)
 *
 *  @param labelValues Is an array of ButtonBarButton labels.
-*  @param fieldName Field used for comparing the label
+*  @param enabledValue The buttons new enabled value.
+*  @param fieldName Field used to compare the label value against.
 *
 *  @langversion 3.0
 *  @playerversion Flash 11.1



git commit: [flex-sdk] [refs/heads/develop] - Updated ASDOC comments for the GridColumn.sortCompareType to be more descriptive.

2013-11-16 Thread mkessler
Updated Branches:
  refs/heads/develop 78eab008d -> 9f3a8015b


Updated ASDOC comments for the GridColumn.sortCompareType to be more 
descriptive.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9f3a8015
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9f3a8015
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9f3a8015

Branch: refs/heads/develop
Commit: 9f3a8015b588064716814fb679035fe3191f0776
Parents: 78eab00
Author: Mark Kessler 
Authored: Sat Nov 16 18:58:19 2013 -0500
Committer: Mark Kessler 
Committed: Sat Nov 16 18:58:19 2013 -0500

--
 .../src/spark/components/gridClasses/GridColumn.as   | 15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9f3a8015/frameworks/projects/spark/src/spark/components/gridClasses/GridColumn.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/gridClasses/GridColumn.as 
b/frameworks/projects/spark/src/spark/components/gridClasses/GridColumn.as
index 642b8b8..ff7b298 100644
--- a/frameworks/projects/spark/src/spark/components/gridClasses/GridColumn.as
+++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridColumn.as
@@ -1451,7 +1451,20 @@ public class GridColumn extends EventDispatcher
 private var _sortCompareType:String;
 
 /**
- *  @inheritDoc
+*  The sortCompareType defines the valid constant values for the 
+*  sortCompareType property of the SortField 
and GridColumn.
+*  
+*  Use the constants in ActionsScript, as the following example 
shows:
+*  
+*column.sortCompareType = SortFieldCompareTypes.NUMERIC;
+*  
+*
+*  In MXML, use the String value of the constants, as the following 
example shows:
+*  
+* 
+*  
+* 
+ *  @see spark.collections.SortFieldCompareTypes
  *
  *  @langversion 3.0
  *  @playerversion Flash 11.8



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33919: Corrected the range check to included everything below zero.

2013-11-19 Thread mkessler
Updated Branches:
  refs/heads/develop dc4ebc0b0 -> 323882d8a


FLEX-33919: Corrected the range check to included everything below zero.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/323882d8
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/323882d8
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/323882d8

Branch: refs/heads/develop
Commit: 323882d8a2619046e3833ae5e7033e7d9a70b4a1
Parents: dc4ebc0
Author: Mark Kessler 
Authored: Tue Nov 19 21:09:25 2013 -0500
Committer: Mark Kessler 
Committed: Tue Nov 19 21:13:50 2013 -0500

--
 .../projects/spark/src/spark/components/supportClasses/ListBase.as | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/323882d8/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index e639b5c..13a3785 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -923,7 +923,7 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 if (allowCustomSelectedItem && selectedIndex == CUSTOM_SELECTED_ITEM)
 return _selectedItem;
 
-if (selectedIndex == NO_SELECTION || dataProvider == null)
+if (selectedIndex < 0 || dataProvider == null)
return undefined;

 return dataProvider.length > selectedIndex ? 
dataProvider.getItemAt(selectedIndex) : undefined;



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33920: It now checks the upper bounds before calling dataProvider.getItemAt()

2013-11-20 Thread mkessler
Updated Branches:
  refs/heads/develop 323882d8a -> c1b8214bc


FLEX-33920: It now checks the upper bounds before calling 
dataProvider.getItemAt()


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/c1b8214b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/c1b8214b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/c1b8214b

Branch: refs/heads/develop
Commit: c1b8214bcdfad6f20af43dd1a8d1a6b2345a1dd1
Parents: 323882d
Author: Mark Kessler 
Authored: Wed Nov 20 19:37:37 2013 -0500
Committer: Mark Kessler 
Committed: Wed Nov 20 19:37:37 2013 -0500

--
 frameworks/projects/spark/src/spark/components/ComboBox.as | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/c1b8214b/frameworks/projects/spark/src/spark/components/ComboBox.as
--
diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as 
b/frameworks/projects/spark/src/spark/components/ComboBox.as
index e2ae977..2b67302 100644
--- a/frameworks/projects/spark/src/spark/components/ComboBox.as
+++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
@@ -883,7 +883,7 @@ public class ComboBox extends DropDownListBase implements 
IIMESupport
 {
 super.changeHighlightedSelection(newIndex, scrollToTop);
 
-if (newIndex >= 0)
+if (newIndex >= 0 && newIndex < dataProvider.length)
 {
 var item:Object = dataProvider ? dataProvider.getItemAt(newIndex) 
: undefined;
 if (item && textInput)



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33984: Added support for labelPlacement on s:CheckBox.

2013-12-08 Thread mkessler
Updated Branches:
  refs/heads/develop 5093c0fc5 -> 7c3d70818


FLEX-33984: Added support for labelPlacement on s:CheckBox.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7c3d7081
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7c3d7081
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7c3d7081

Branch: refs/heads/develop
Commit: 7c3d7081815ecacaad19d5c38c71c2ae6b7ef9bf
Parents: 5093c0f
Author: Mark Kessler 
Authored: Sun Dec 8 14:40:26 2013 -0500
Committer: Mark Kessler 
Committed: Sun Dec 8 14:40:26 2013 -0500

--
 frameworks/projects/spark/defaults.css  |   2 +
 .../spark/src/spark/components/CheckBox.as  | 291 ++-
 .../components/supportClasses/LabelPlacement.as |  95 ++
 .../src/spark/skins/spark/CheckBoxSkin.mxml |   4 +-
 4 files changed, 390 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7c3d7081/frameworks/projects/spark/defaults.css
--
diff --git a/frameworks/projects/spark/defaults.css 
b/frameworks/projects/spark/defaults.css
index cb7b46f..79eecc1 100644
--- a/frameworks/projects/spark/defaults.css
+++ b/frameworks/projects/spark/defaults.css
@@ -66,6 +66,8 @@ CalloutButton {
 
 CheckBox
 {
+gap: 5;
+labelPlacement: "right";
 skinClass: ClassReference("spark.skins.spark.CheckBoxSkin");
 }
 

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7c3d7081/frameworks/projects/spark/src/spark/components/CheckBox.as
--
diff --git a/frameworks/projects/spark/src/spark/components/CheckBox.as 
b/frameworks/projects/spark/src/spark/components/CheckBox.as
index 4ca1279..77dd23d 100644
--- a/frameworks/projects/spark/src/spark/components/CheckBox.as
+++ b/frameworks/projects/spark/src/spark/components/CheckBox.as
@@ -24,7 +24,9 @@ import flash.events.Event;
 import flash.events.MouseEvent;
 
 import mx.core.mx_internal;
+import mx.core.UIComponent;
 
+import spark.components.supportClasses.LabelPlacement;
 import spark.components.supportClasses.ToggleButtonBase;
 
 use namespace mx_internal;
@@ -34,6 +36,19 @@ use namespace mx_internal;
 //--
 
 /**
+ *  The space between layout elements, in pixels.
+ * 
+ *  @default 5
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.12
+ */
+[Style(name="gap", type="int", inherit="no")]
+
+
+/**
  *  Orientation of the icon in relation to the label.
  *  Valid MXML values are right, left,
  *  bottom, and top.
@@ -54,6 +69,29 @@ use namespace mx_internal;
  */
 [Style(name="iconPlacement", type="String", 
enumeration="top,bottom,right,left", inherit="no", theme="mobile")]
 
+
+/**
+ *  Orientation of the Label in relation to the CheckBox.
+ *  Valid MXML values are "left", "right",
+ *  "top", and "bottom".
+ *
+ *  In ActionScript, you can use the following constants
+ *  to set this property:
+ *  LabelPlacement.LEFT,
+ *  LabelPlacement.RIGHT,
+ *  LabelPlacement.TOP, and
+ *  LabelPlacement.BOTTOM.
+ *
+ *  @see spark.components.supportClasses.LabelPlacement
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 1.5
+ *  @productversion Flex 4
+ */
+[Style(name="labelPlacement", type="String", 
enumeration="top,bottom,left,right", inherit="no", defaultValue="right")]
+
+
 /**
  *  @copy spark.components.supportClasses.GroupBase#style:symbolColor
  *
@@ -172,7 +210,94 @@ public class CheckBox extends ToggleButtonBase
 {
 super();
 }
-
+
+
+
//--
+//
+//  Variables
+//
+
//--
+
+//--
+//  checkDisplay
+//--
+
+/**
+ *  The skin part that defines the CheckBox grouping.
+ *
+ *  @see spark.skins.spark.CheckBoxSkin#checkDisplay
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+ *  @playerversion AIR 3.8
+ *  @productversion Flex 4.12
+ */
+[SkinPart(required="false")]
+public var checkDisplay:UIComponent;
+
+
+
//--
+//
+//  Properties
+//
+
//--
+
+//--
+//  gap
+//--
+
+/**
+ *  The space between layout elements, in pixels.  This is mearly a 
wrapper for the
+ *  gap style.
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33984: Moved the placement logic from the hostComponent to the skin. Removed some code no longer needed.

2013-12-08 Thread mkessler
Updated Branches:
  refs/heads/develop 7c3d70818 -> cdcb49242


FLEX-33984: Moved the placement logic from the hostComponent to the skin. 
Removed some code no longer needed.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/cdcb4924
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/cdcb4924
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/cdcb4924

Branch: refs/heads/develop
Commit: cdcb49242ae0d06645d3ebaf4f7e3c102b8f6506
Parents: 7c3d708
Author: Mark Kessler 
Authored: Sun Dec 8 15:59:25 2013 -0500
Committer: Mark Kessler 
Committed: Sun Dec 8 15:59:25 2013 -0500

--
 .../spark/src/spark/components/CheckBox.as  | 188 ---
 .../src/spark/skins/spark/CheckBoxSkin.mxml | 138 ++
 2 files changed, 138 insertions(+), 188 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/cdcb4924/frameworks/projects/spark/src/spark/components/CheckBox.as
--
diff --git a/frameworks/projects/spark/src/spark/components/CheckBox.as 
b/frameworks/projects/spark/src/spark/components/CheckBox.as
index 77dd23d..c72f6c8 100644
--- a/frameworks/projects/spark/src/spark/components/CheckBox.as
+++ b/frameworks/projects/spark/src/spark/components/CheckBox.as
@@ -24,9 +24,7 @@ import flash.events.Event;
 import flash.events.MouseEvent;
 
 import mx.core.mx_internal;
-import mx.core.UIComponent;
 
-import spark.components.supportClasses.LabelPlacement;
 import spark.components.supportClasses.ToggleButtonBase;
 
 use namespace mx_internal;
@@ -214,30 +212,6 @@ public class CheckBox extends ToggleButtonBase
 
 
//--
 //
-//  Variables
-//
-
//--
-
-//--
-//  checkDisplay
-//--
-
-/**
- *  The skin part that defines the CheckBox grouping.
- *
- *  @see spark.skins.spark.CheckBoxSkin#checkDisplay
- *
- *  @langversion 3.0
- *  @playerversion Flash 11.8
- *  @playerversion AIR 3.8
- *  @productversion Flex 4.12
- */
-[SkinPart(required="false")]
-public var checkDisplay:UIComponent;
-
-
-
//--
-//
 //  Properties
 //
 
//--
@@ -323,120 +297,6 @@ public class CheckBox extends ToggleButtonBase
 
 
//--
 //
-//  Methods
-//
-
//--
-
-/**
- *  Sets the label placement in relation to the checkbox.
- *  Requires the SkinParts checkDisplay and 
labelDisplay.  
- *
- *  @langversion 3.0
- *  @playerversion Flash 11.8
- *  @playerversion AIR 3.8
- *  @productversion Flex 4.12
- */
-public function updateLabelPlacement():void
-{
-var labelDisplayAsUIComponent:UIComponent;
-
-
-if (!checkDisplay || !labelDisplay)
-{
-return;
-}
-
-labelDisplayAsUIComponent = labelDisplay as UIComponent;
-
-
-switch (String(getStyle("labelPlacement")).toLowerCase())
-{
-case LabelPlacement.BOTTOM:
-{
-//Adjust the labels position to the bottom.
-labelDisplayAsUIComponent.horizontalCenter = 0;
-labelDisplayAsUIComponent.verticalCenter = undefined;
-labelDisplayAsUIComponent.top = checkDisplay.height + 
int(getStyle("gap"));
-labelDisplayAsUIComponent.bottom = undefined;
-labelDisplayAsUIComponent.left = undefined;
-labelDisplayAsUIComponent.right = undefined;
-
-//Adjust the checkboxes position to the top.
-checkDisplay.horizontalCenter = 0;
-checkDisplay.verticalCenter = undefined;
-checkDisplay.top = 0;
-checkDisplay.bottom = undefined;
-
-break;
-}
-
-case LabelPlacement.LEFT:
-{
-//Adjust the labels position to left side.
-labelDisplayAsUIComponent.horizontalCenter = undefined;
-labelDisplayAsUIComponent.verticalCenter = 2;
-labelDisplayAsUIComponent.top = undefined;
-labelDisplayAsUIComponent.bottom = undefined;
-labelDisplayAsUIComponent.left = undefined;
-labelDisplayAsUIComponent.right = checkDisplay.width + 
int(getStyle("gap"));
-

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33984: Corrected an ASDOC comment.

2013-12-08 Thread mkessler
Updated Branches:
  refs/heads/develop cdcb49242 -> cfc9b1d1a


FLEX-33984: Corrected an ASDOC comment.

FLEX-33984: Corrected ASDOC tag.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/cfc9b1d1
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/cfc9b1d1
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/cfc9b1d1

Branch: refs/heads/develop
Commit: cfc9b1d1ab880fd9edb192a186fc89637a7e1431
Parents: cdcb492
Author: Mark Kessler 
Authored: Sun Dec 8 17:35:35 2013 -0500
Committer: Mark Kessler 
Committed: Sun Dec 8 17:35:35 2013 -0500

--
 .../projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml  | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/cfc9b1d1/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
--
diff --git a/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml 
b/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
index e6bf5b3..f4ad944 100644
--- a/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
+++ b/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
@@ -117,8 +117,7 @@
 
//--
 
 /**
- *  Sets the label placement in relation to the checkbox.
- *  Requires the SkinParts checkDisplay and 
labelDisplay.  
+ *  Sets the label placement in relation to the checkbox. 
  *
  *  @langversion 3.0
  *  @playerversion Flash 11.8
@@ -232,7 +231,7 @@
 
 
 
-
+   
 
 
 



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33984: Added a default labelPlacement when no style is present.

2013-12-09 Thread mkessler
Updated Branches:
  refs/heads/develop 27be89a05 -> dfa2f1c6c


FLEX-33984: Added a default labelPlacement when no style is present.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dfa2f1c6
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dfa2f1c6
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dfa2f1c6

Branch: refs/heads/develop
Commit: dfa2f1c6c379caf13e52f382d274de7ff0c63102
Parents: 27be89a
Author: Mark Kessler 
Authored: Mon Dec 9 19:13:19 2013 -0500
Committer: Mark Kessler 
Committed: Mon Dec 9 19:13:19 2013 -0500

--
 .../src/spark/skins/spark/CheckBoxSkin.mxml | 60 
 1 file changed, 36 insertions(+), 24 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/dfa2f1c6/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
--
diff --git a/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml 
b/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
index f4ad944..83d176c 100644
--- a/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
+++ b/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
@@ -117,7 +117,8 @@
 
//--
 
 /**
- *  Sets the label placement in relation to the checkbox. 
+ *  Sets the label placement in relation to the checkbox.
+ *  Requires the SkinParts checkDisplay and 
labelDisplay.  
  *
  *  @langversion 3.0
  *  @playerversion Flash 11.8
@@ -126,11 +127,25 @@
  */
 public function updateLabelPlacement():void
 {
+var spacing:int;
+
+
 if (!checkDisplay || !labelDisplay)
 {
 return;
 }
 
+if (getStyle("gap") == undefined)
+{
+//Add a default gap if the gap style is undefined.
+spacing = 5;
+}
+else
+{
+spacing = int(getStyle("gap"));
+}
+
+
 switch (String(getStyle("labelPlacement")).toLowerCase())
 {
 case LabelPlacement.BOTTOM:
@@ -138,7 +153,7 @@
 //Adjust the labels position to the bottom.
 labelDisplay.horizontalCenter = 0;
 labelDisplay.verticalCenter = undefined;
-labelDisplay.top = checkDisplay.height + 
int(getStyle("gap"));
+labelDisplay.top = checkDisplay.height + spacing;
 labelDisplay.bottom = undefined;
 labelDisplay.left = undefined;
 labelDisplay.right = undefined;
@@ -160,7 +175,7 @@
 labelDisplay.top = undefined;
 labelDisplay.bottom = undefined;
 labelDisplay.left = undefined;
-labelDisplay.right = checkDisplay.width + 
int(getStyle("gap"));
+labelDisplay.right = checkDisplay.width + spacing;
 
 //Adjust the checkboxes position to right side.
 checkDisplay.horizontalCenter = undefined;
@@ -171,32 +186,13 @@
 break;
 }
 
-case LabelPlacement.RIGHT:
-{
-//Adjust the labels position to right side.
-labelDisplay.horizontalCenter = undefined;
-labelDisplay.verticalCenter = 2;
-labelDisplay.top = undefined;
-labelDisplay.bottom = undefined;
-labelDisplay.left = checkDisplay.width + 
int(getStyle("gap"));
-labelDisplay.right = undefined;
-
-//Adjust the checkboxes position to left side.
-checkDisplay.horizontalCenter = undefined;
-checkDisplay.verticalCenter = 0;
-checkDisplay.left = 0;
-checkDisplay.right = undefined;
-
-break;
-}
-
 case LabelPlacement.TOP:
 {
 //Adjust the labels position to the top.
 labelDisplay.horizontalCenter = 0;
 labelDisplay.verticalCenter = undefined;
 labelDisplay.top = undefined;
-labelDisplay.bottom = checkDisplay.height + 
int(getStyle

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33984: Corrected the vertical centering for label

2013-12-10 Thread mkessler
Updated Branches:
  refs/heads/develop 651b1790a -> 2bd02be67


FLEX-33984: Corrected the vertical centering for label


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/2bd02be6
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2bd02be6
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2bd02be6

Branch: refs/heads/develop
Commit: 2bd02be67d50f9736c1a1f0ddf6c62d763cb3259
Parents: 651b179
Author: Mark Kessler 
Authored: Tue Dec 10 22:13:06 2013 -0500
Committer: Mark Kessler 
Committed: Tue Dec 10 22:13:06 2013 -0500

--
 .../src/spark/skins/spark/CheckBoxSkin.mxml | 24 ++--
 1 file changed, 12 insertions(+), 12 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/2bd02be6/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
--
diff --git a/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml 
b/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
index 83d176c..b491d38 100644
--- a/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
+++ b/frameworks/projects/spark/src/spark/skins/spark/CheckBoxSkin.mxml
@@ -154,9 +154,9 @@
 labelDisplay.horizontalCenter = 0;
 labelDisplay.verticalCenter = undefined;
 labelDisplay.top = checkDisplay.height + spacing;
-labelDisplay.bottom = undefined;
-labelDisplay.left = undefined;
-labelDisplay.right = undefined;
+labelDisplay.bottom = 0;
+labelDisplay.left = 0;
+labelDisplay.right = 0;
 
 //Adjust the checkboxes position to the top.
 checkDisplay.horizontalCenter = 0;
@@ -172,9 +172,9 @@
 //Adjust the labels position to left side.
 labelDisplay.horizontalCenter = undefined;
 labelDisplay.verticalCenter = 2;
-labelDisplay.top = undefined;
-labelDisplay.bottom = undefined;
-labelDisplay.left = undefined;
+labelDisplay.top = 3;
+labelDisplay.bottom = 3;
+labelDisplay.left = 0;
 labelDisplay.right = checkDisplay.width + spacing;
 
 //Adjust the checkboxes position to right side.
@@ -191,10 +191,10 @@
 //Adjust the labels position to the top.
 labelDisplay.horizontalCenter = 0;
 labelDisplay.verticalCenter = undefined;
-labelDisplay.top = undefined;
+labelDisplay.top = 0;
 labelDisplay.bottom = checkDisplay.height + spacing;
-labelDisplay.left = undefined;
-labelDisplay.right = undefined;
+labelDisplay.left = 0;
+labelDisplay.right = 0;
 
 //Adjust the checkboxes position to the bottom.
 checkDisplay.horizontalCenter = 0;
@@ -212,10 +212,10 @@
 //Adjust the labels position to right side.
 labelDisplay.horizontalCenter = undefined;
 labelDisplay.verticalCenter = 2;
-labelDisplay.top = undefined;
-labelDisplay.bottom = undefined;
+labelDisplay.top = 3;
+labelDisplay.bottom = 3;
 labelDisplay.left = checkDisplay.width + spacing;
-labelDisplay.right = undefined;
+labelDisplay.right = 0;
 
 //Adjust the checkboxes position to left side.
 checkDisplay.horizontalCenter = undefined;



git commit: [flex-sdk] [refs/heads/develop] - Change part of the playerglobal example to 12.0

2014-02-26 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 5648d8887 -> dcdf0e80f


Change part of the playerglobal example to 12.0


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dcdf0e80
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dcdf0e80
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dcdf0e80

Branch: refs/heads/develop
Commit: dcdf0e80fe3115516e8a2f3e3229628ab1f9e8f7
Parents: 5648d88
Author: Mark Kessler 
Authored: Wed Feb 26 17:26:54 2014 -0500
Committer: Mark Kessler 
Committed: Wed Feb 26 17:26:54 2014 -0500

--
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/dcdf0e80/README
--
diff --git a/README b/README
index 50bcb46..104158b 100644
--- a/README
+++ b/README
@@ -307,9 +307,9 @@ Adobe Flash Player Version Support
 Change the playerglobal.version in the build.properties file to have a 
value other
 than "11.1". For this change to take effect the SDK needs to be recompiled.
 For example to compile against the latest version of the Adobe Flash 
Player set
-the value of playerglobal.version to be "11.8" like so:
+the value of playerglobal.version to be "12.0" like so:
 
-playerglobal.version = 11.8
+playerglobal.version = 12.0
 
 OR
 



git commit: [flex-utilities] [refs/heads/develop] - Updated 3rd install step.

2015-06-23 Thread mkessler
Repository: flex-utilities
Updated Branches:
  refs/heads/develop 779907321 -> c21b31d00


Updated 3rd install step.


Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/c21b31d0
Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/c21b31d0
Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/c21b31d0

Branch: refs/heads/develop
Commit: c21b31d00e112fd7f31c1377af994f820cec1d3a
Parents: 7799073
Author: Mark Kessler 
Authored: Tue Jun 23 19:10:22 2015 -0400
Committer: Mark Kessler 
Committed: Tue Jun 23 19:10:22 2015 -0400

--
 flex-installer/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/c21b31d0/flex-installer/README
--
diff --git a/flex-installer/README b/flex-installer/README
index fdba7a0..e3f0b56 100644
--- a/flex-installer/README
+++ b/flex-installer/README
@@ -119,7 +119,7 @@ How to build the installer using ANT (no Flash Builder or 
any other IDE required
 it is used.  Otherwise, the AIR_HOME_MAC or AIR_HOME_WIN property in 
 installer/build.properties is used.

-3.  In the installer directory, run:
+3.  In the root directory, run:
 ant build [-DFLEX_HOME=/path/to/apache/flex/sdk] 
[-DAIR_HOME=/path/to/air/sdk]
 
 4.  The installer executable file created in the installer/release directory.  
If you are 



git commit: [flex-utilities] [refs/heads/Branch_apache-flex-sdk-installer-3.2-rc2] - Updated 3rd install step.

2015-06-23 Thread mkessler
Repository: flex-utilities
Updated Branches:
  refs/heads/Branch_apache-flex-sdk-installer-3.2-rc2 [created] df170bc10


Updated 3rd install step.


Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/df170bc1
Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/df170bc1
Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/df170bc1

Branch: refs/heads/Branch_apache-flex-sdk-installer-3.2-rc2
Commit: df170bc10770cd60377a0a0b559c7d42c7917537
Parents: 7799073
Author: Mark Kessler 
Authored: Tue Jun 23 19:10:22 2015 -0400
Committer: Mark Kessler 
Committed: Tue Jun 23 19:16:56 2015 -0400

--
 flex-installer/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/df170bc1/flex-installer/README
--
diff --git a/flex-installer/README b/flex-installer/README
index fdba7a0..e3f0b56 100644
--- a/flex-installer/README
+++ b/flex-installer/README
@@ -119,7 +119,7 @@ How to build the installer using ANT (no Flash Builder or 
any other IDE required
 it is used.  Otherwise, the AIR_HOME_MAC or AIR_HOME_WIN property in 
 installer/build.properties is used.

-3.  In the installer directory, run:
+3.  In the root directory, run:
 ant build [-DFLEX_HOME=/path/to/apache/flex/sdk] 
[-DAIR_HOME=/path/to/air/sdk]
 
 4.  The installer executable file created in the installer/release directory.  
If you are 



git commit: [flex-utilities] [refs/heads/develop] - FLEX-34529: Removed a redundant label that was also causing a warning for binding.

2014-09-07 Thread mkessler
Repository: flex-utilities
Updated Branches:
  refs/heads/develop 5f0719e21 -> 279b88b84


FLEX-34529: Removed a redundant label that was also causing a warning for 
binding.


Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/279b88b8
Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/279b88b8
Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/279b88b8

Branch: refs/heads/develop
Commit: 279b88b84050ea08c12e37bc78fe1dd3a0a32739
Parents: 5f0719e
Author: Mark Kessler 
Authored: Sun Sep 7 15:35:51 2014 -0400
Committer: Mark Kessler 
Committed: Sun Sep 7 15:35:51 2014 -0400

--
 .../src/spark/other/BidirectionalBinding1Example.mxml | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/279b88b8/TourDeFlex/TourDeFlex3/src/spark/other/BidirectionalBinding1Example.mxml
--
diff --git 
a/TourDeFlex/TourDeFlex3/src/spark/other/BidirectionalBinding1Example.mxml 
b/TourDeFlex/TourDeFlex3/src/spark/other/BidirectionalBinding1Example.mxml
index ebe35cf..a30b544 100644
--- a/TourDeFlex/TourDeFlex3/src/spark/other/BidirectionalBinding1Example.mxml
+++ b/TourDeFlex/TourDeFlex3/src/spark/other/BidirectionalBinding1Example.mxml
@@ -23,7 +23,7 @@
xmlns:mx="library://ns.adobe.com/flex/mx">






-   
-  
+   
 





git commit: [flex-utilities] [refs/heads/develop] - Modified the binding example labels to distinguish between examples 1 and 2.

2014-09-07 Thread mkessler
Repository: flex-utilities
Updated Branches:
  refs/heads/develop 279b88b84 -> 45488c150


Modified the binding example labels to distinguish between examples 1 and 2.


Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/45488c15
Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/45488c15
Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/45488c15

Branch: refs/heads/develop
Commit: 45488c150e0507bb4bf87551b5cc3f1728682235
Parents: 279b88b
Author: Mark Kessler 
Authored: Sun Sep 7 15:47:44 2014 -0400
Committer: Mark Kessler 
Committed: Sun Sep 7 15:47:44 2014 -0400

--
 TourDeFlex/TourDeFlex3/src/explorer.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/45488c15/TourDeFlex/TourDeFlex3/src/explorer.xml
--
diff --git a/TourDeFlex/TourDeFlex3/src/explorer.xml 
b/TourDeFlex/TourDeFlex3/src/explorer.xml
index 77c9ffd..8c50a5e 100755
--- a/TourDeFlex/TourDeFlex3/src/explorer.xml
+++ b/TourDeFlex/TourDeFlex3/src/explorer.xml
@@ -212,8 +212,8 @@



-   
-   
+   
+   






git commit: [flex-utilities] [refs/heads/develop] - FLEX-34530: Forced the vertical scroll to be active. Removed 2 bindings that were causing warnings and were not needed.

2014-09-07 Thread mkessler
Repository: flex-utilities
Updated Branches:
  refs/heads/develop 45488c150 -> df9ae1bd0


FLEX-34530: Forced the vertical scroll to be active.  Removed 2 bindings that 
were causing warnings and were not needed.


Project: http://git-wip-us.apache.org/repos/asf/flex-utilities/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-utilities/commit/df9ae1bd
Tree: http://git-wip-us.apache.org/repos/asf/flex-utilities/tree/df9ae1bd
Diff: http://git-wip-us.apache.org/repos/asf/flex-utilities/diff/df9ae1bd

Branch: refs/heads/develop
Commit: df9ae1bd0a7f05f79ba5c59722ae6034216c535f
Parents: 45488c1
Author: Mark Kessler 
Authored: Sun Sep 7 16:15:21 2014 -0400
Committer: Mark Kessler 
Committed: Sun Sep 7 16:15:21 2014 -0400

--
 .../TourDeFlex3/src/spark/controls/ScrollBarExample.mxml  | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/df9ae1bd/TourDeFlex/TourDeFlex3/src/spark/controls/ScrollBarExample.mxml
--
diff --git a/TourDeFlex/TourDeFlex3/src/spark/controls/ScrollBarExample.mxml 
b/TourDeFlex/TourDeFlex3/src/spark/controls/ScrollBarExample.mxml
index 8de456e..bed0582 100644
--- a/TourDeFlex/TourDeFlex3/src/spark/controls/ScrollBarExample.mxml
+++ b/TourDeFlex/TourDeFlex3/src/spark/controls/ScrollBarExample.mxml
@@ -36,7 +36,7 @@
 
clipAndEnableScrolling="true"
 
itemRenderer="spark.skins.spark.DefaultItemRenderer">
 
-
+
 
 
 
@@ -72,10 +72,7 @@
 


-   
+   




git commit: [flex-sdk] [refs/heads/develop] - FLEX-34531: Removed the exclude statement for hlocColor style.

2014-09-08 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 714210cbe -> ec8b9bcce


FLEX-34531: Removed the exclude statement for hlocColor style.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ec8b9bcc
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ec8b9bcc
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ec8b9bcc

Branch: refs/heads/develop
Commit: ec8b9bcce28b3a26aa20337396e52a7cc6f3b4e1
Parents: 714210c
Author: Mark Kessler 
Authored: Mon Sep 8 21:38:58 2014 -0400
Committer: Mark Kessler 
Committed: Mon Sep 8 21:38:58 2014 -0400

--
 frameworks/projects/charts/src/mx/charts/series/HLOCSeries.as | 1 -
 1 file changed, 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ec8b9bcc/frameworks/projects/charts/src/mx/charts/series/HLOCSeries.as
--
diff --git a/frameworks/projects/charts/src/mx/charts/series/HLOCSeries.as 
b/frameworks/projects/charts/src/mx/charts/series/HLOCSeries.as
index 93a5739..dfcc8af 100644
--- a/frameworks/projects/charts/src/mx/charts/series/HLOCSeries.as
+++ b/frameworks/projects/charts/src/mx/charts/series/HLOCSeries.as
@@ -103,7 +103,6 @@ use namespace mx_internal;
  */
 [Style(name="stroke", type="mx.graphics.IStroke", inherit="no")]
 
-[Exclude(name="hlocColor", kind="style")]  //this is private style and 
excluded from tag inspector
 
 /**
  *  Represents financial data as a series of elements



git commit: [flex-sdk] [refs/heads/develop] - Revert "FLEX-33537: Changed the internal setfocus to the textDisplay call to be callLater. This allows for the skin/child components to be setup before re

2015-11-18 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop a936d2efa -> 094b9a52b


Revert "FLEX-33537:  Changed the internal setfocus to the textDisplay call to 
be callLater.  This allows for the skin/child components to be setup before 
receiving focus."

This reverts commit d5c329722cd60568c53210973024b591b912b486.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/094b9a52
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/094b9a52
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/094b9a52

Branch: refs/heads/develop
Commit: 094b9a52bd1f1d31651aa5097f24247588050ca0
Parents: a936d2e
Author: Mark Kessler 
Authored: Wed Nov 18 19:20:50 2015 -0500
Committer: Mark Kessler 
Committed: Wed Nov 18 19:30:06 2015 -0500

--
 .../src/spark/components/supportClasses/SkinnableTextBase.as  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/094b9a52/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
index b08c7a3..388135d 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
@@ -1875,8 +1875,7 @@ public class SkinnableTextBase extends SkinnableComponent
 }
 else
 {
-//Calling later so the skin/state can finish setting up before 
accepting focus on textDisplay.
-callLater(textDisplay.setFocus);
+textDisplay.setFocus();
 }
 }
 }



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33537: Updated to force properties to be validated before setting the focus to the textDisplay. This seems to stop it tripping over itself with the v

2015-11-18 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 094b9a52b -> b29975cc0


FLEX-33537: Updated to force properties to be validated before setting the 
focus to the textDisplay.  This seems to stop it tripping over itself with the 
visible skin states.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/b29975cc
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/b29975cc
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/b29975cc

Branch: refs/heads/develop
Commit: b29975cc08515531f9e51f6681baf23f94f3ef50
Parents: 094b9a5
Author: Mark Kessler 
Authored: Wed Nov 18 20:38:51 2015 -0500
Committer: Mark Kessler 
Committed: Wed Nov 18 20:38:51 2015 -0500

--
 .../supportClasses/SkinnableTextBase.as | 24 +---
 1 file changed, 16 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/b29975cc/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
index 388135d..abb6dfb 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
@@ -1875,6 +1875,9 @@ public class SkinnableTextBase extends SkinnableComponent
 }
 else
 {
+//Force properties to validate before resetting focus.
+validateProperties();
+
 textDisplay.setFocus();
 }
 }
@@ -2692,18 +2695,23 @@ public class SkinnableTextBase extends 
SkinnableComponent
  */
 private function textDisplay_changeHandler(event:Event):void
 {
-//trace(id, "textDisplay_changeHandler", textDisplay.text);
-
 // The text component has changed.  Generate an UPDATE_COMPLETE event.
 invalidateDisplayList();
-
+
+
 // We may have gone from empty to non-empty or vice-versa. This should
 // cause the prompt to show or hide.
-if (prompt != null && prompt != "" && skin && skin.currentState &&
-(skin.currentState.indexOf("WithPrompt") != -1 && text.length != 0 
||
-skin.currentState.indexOf("WithPrompt") == -1 && text.length == 0))
-invalidateSkinState();
-
+if (prompt != null && prompt != "" && skin && skin.currentState)
+{
+//Checks when to invalidate skin. However when component is 
focused (and not prompt with focus) it will not have "WithPrompt".  Broken out 
for clarity.
+if (skin.currentState.indexOf("WithPrompt") != -1 && text.length 
!= 0 ||
+skin.currentState.indexOf("WithPrompt") == -1 && text.length 
== 0)
+{
+invalidateSkinState();
+}
+}
+
+
 // Redispatch the event that came from the RichEditableText.
 dispatchEvent(event);
 }



git commit: [flex-sdk] [refs/heads/develop] - FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a value in MXML. This was due to the grid part not being present yet. Modified

2014-12-29 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 789a0ca73 -> c47f9f9ec


FLEX-34710: s:DataGrid doubleClickMode was throwing an error when assigned a 
value in MXML.  This was due to the grid part not being present yet.  Modified 
the setter to use setGridProperty which allows delayed property setting if 
needed.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/c47f9f9e
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/c47f9f9e
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/c47f9f9e

Branch: refs/heads/develop
Commit: c47f9f9ec1bc53ad9e3cb48a51aee5c446229c30
Parents: 789a0ca
Author: Mark Kessler 
Authored: Mon Dec 29 21:08:55 2014 -0500
Committer: Mark Kessler 
Committed: Mon Dec 29 21:08:55 2014 -0500

--
 frameworks/projects/spark/src/spark/components/DataGrid.as | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/c47f9f9e/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 8db0d85..9b17f60 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -1578,7 +1578,6 @@ public class DataGrid extends SkinnableContainerBase
 *  @playerversion AIR 3.4
 *  @productversion Flex 4.10
 */
-
 public function get doubleClickMode():String
 {
 return grid.doubleClickMode;
@@ -1589,13 +1588,10 @@ public class DataGrid extends SkinnableContainerBase
 */
 public function set doubleClickMode(newValue:String):void
 {
-if (grid.doubleClickMode == newValue)
+if (setGridProperty("doubleClickMode", newValue))
 {
-   return;
+dispatchChangeEvent("doubleClickModeChanged");
 }
-
-grid.doubleClickMode = newValue;
-dispatchChangeEvent("doubleClickModeChanged");
 }
 
 



git commit: [flex-sdk] [refs/heads/develop] - Correcting ASDOC comment from "items" to "itemsByIndex" when referring drag n drop for list items.

2015-01-25 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 11288df3b -> 1a62df235


Correcting ASDOC comment from "items" to "itemsByIndex" when referring drag n 
drop for list items.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/1a62df23
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/1a62df23
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/1a62df23

Branch: refs/heads/develop
Commit: 1a62df23572e933e80ecf3081dfb142d45bf706c
Parents: 11288df
Author: Mark Kessler 
Authored: Sun Jan 25 21:03:08 2015 -0500
Committer: Mark Kessler 
Committed: Sun Jan 25 21:03:08 2015 -0500

--
 frameworks/projects/framework/src/mx/core/DragSource.as | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/1a62df23/frameworks/projects/framework/src/mx/core/DragSource.as
--
diff --git a/frameworks/projects/framework/src/mx/core/DragSource.as 
b/frameworks/projects/framework/src/mx/core/DragSource.as
index a749a95..08fc5dc 100644
--- a/frameworks/projects/framework/src/mx/core/DragSource.as
+++ b/frameworks/projects/framework/src/mx/core/DragSource.as
@@ -183,7 +183,7 @@ public class DragSource
 *  for the format parameter. If the control that 
initiated the
 *  drag operation is a Tree, then the format is "treeItems" and the 
items
 *  implement the ITreeDataProvider interface. For all other List-based
-*  controls that have built-in drag and drop support, the format is 
"items" and the items
+*  controls that have built-in drag and drop support, the format is 
"itemsByIndex" and the items
 *  implement the IDataProvider interface.
 *
 *  @return An Object



git commit: [flex-sdk] [refs/heads/develop] - FLEX-34741: Corrected the dropIndicator. It will now use the grid.layout.centergridview.layout instead of the grid.layout directly. Also removed the calcu

2015-08-03 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 07e7bcf74 -> 8767c20ce


FLEX-34741: Corrected the dropIndicator.  It will now use the 
grid.layout.centergridview.layout instead of the grid.layout directly.  Also 
removed the calculateDropLocation from the DataGrid as it is no longer used.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/8767c20c
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/8767c20c
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/8767c20c

Branch: refs/heads/develop
Commit: 8767c20ce73386de8fa68f0f625eef4f30e93984
Parents: 07e7bcf
Author: Mark Kessler 
Authored: Mon Aug 3 22:55:50 2015 -0400
Committer: Mark Kessler 
Committed: Mon Aug 3 22:55:50 2015 -0400

--
 .../spark/src/spark/components/DataGrid.as  | 78 
 1 file changed, 46 insertions(+), 32 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/8767c20c/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 926e0cc..8cbe25d 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -71,6 +71,7 @@ package spark.components
 import spark.components.gridClasses.GridSelection;
 import spark.components.gridClasses.GridSelectionMode;
 import spark.components.gridClasses.GridView;
+import spark.components.gridClasses.GridViewLayout;
 import spark.components.gridClasses.IDataGridElement;
 import spark.components.gridClasses.IGridItemEditor;
 import spark.components.supportClasses.IDataProviderEnhance;
@@ -6272,20 +6273,13 @@ public class DataGrid extends SkinnableContainerBase
 //
 
//--
 
-private function calculateDropLocation(event:DragEvent):DropLocation
-{
-// Verify data format
-if (!enabled || !event.dragSource.hasFormat("itemsByIndex"))
-return null;
-
-// Calculate the drop location
-var location:DropLocation = grid.layout.calculateDropLocation(event);
-   if (location.dropIndex > dataProvider.length) 
-   location.dropIndex = dataProvider.length;
-   
-   return location;
-}
-
+/**
+*  @private
+*  Used in drag n drop methods for drop location / drop indicators.
+*/
+private var _gridViewLayout:GridViewLayout = null;
+
+
 /**
  *  Creates and instance of the dropIndicator class that is used to
  *  display the visuals of the drop location during a drag and drop
@@ -6308,10 +6302,12 @@ public class DataGrid extends SkinnableContainerBase
 public function createDropIndicator():DisplayObject
 {
 // Do we have a drop indicator already?
-if (grid.layout.dropIndicator)
-return grid.layout.dropIndicator;
-
+if (_gridViewLayout.dropIndicator)
+return _gridViewLayout.dropIndicator;
+
+
 var dropIndicatorInstance:DisplayObject;
+
 if (dropIndicator)
 {
 dropIndicatorInstance = 
DisplayObject(createDynamicPartInstance("dropIndicator"));
@@ -6322,11 +6318,13 @@ public class DataGrid extends SkinnableContainerBase
 if (dropIndicatorClass)
 dropIndicatorInstance = new dropIndicatorClass();
 }
+
 if (dropIndicatorInstance is IVisualElement)
 IVisualElement(dropIndicatorInstance).owner = this;
 
 // Set it in the layout
-grid.layout.dropIndicator = dropIndicatorInstance;
+_gridViewLayout.dropIndicator = dropIndicatorInstance;
+
 return dropIndicatorInstance;
 }
 
@@ -6348,15 +6346,17 @@ public class DataGrid extends SkinnableContainerBase
  */
 public function destroyDropIndicator():DisplayObject
 {
-var dropIndicatorInstance:DisplayObject = grid.layout.dropIndicator;
+var dropIndicatorInstance:DisplayObject = 
_gridViewLayout.dropIndicator;
+
 if (!dropIndicatorInstance)
 return null;
 
 // Release the reference from the layout
-grid.layout.dropIndicator = null;
+_gridViewLayout.dropIndicator = null;
 
 // Release it if it's a dynamic skin part
 var count:int = numDynamicParts("dropIndicator");
+
 for (var i:int = 0; i < count; i++)
 {
 if (dropIndicatorInstance == getDynamicPartAt("dropIndicator", i))
@@ -6366,6 +6366,7 @@ public class DataGrid extends SkinnableContainerBase
  

git commit: [flex-sdk] [refs/heads/develop] - FLEX-34028: Changed how the down click drag preparation behavior works. If the CTRL key is down and the current item being clicked on is already selected

2015-08-12 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 8767c20ce -> 1754c10c1


FLEX-34028: Changed how the down click drag preparation behavior works.  If the 
CTRL key is down and the current item being clicked on is already selected 
(meaning would toggle it's selection) it will avoid the drag prep.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/1754c10c
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/1754c10c
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/1754c10c

Branch: refs/heads/develop
Commit: 1754c10c136831f4dfb9cc0ae790060a19a2e8a5
Parents: 8767c20
Author: Mark Kessler 
Authored: Tue Aug 11 20:44:16 2015 -0400
Committer: Mark Kessler 
Committed: Tue Aug 11 20:44:16 2015 -0400

--
 frameworks/projects/spark/src/spark/components/DataGrid.as | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/1754c10c/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 8cbe25d..5bc516f 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -5629,7 +5629,7 @@ public class DataGrid extends SkinnableContainerBase
 if (rowIndex == -1 || isCellSelection && columnIndex == -1)
 return;
 
-if (dragEnabled && isRowSelectionMode() && 
selectionContainsIndex(rowIndex))
+if (event.ctrlKey == false && dragEnabled && isRowSelectionMode() && 
selectionContainsIndex(rowIndex))
 {
 pendingSelectionOnMouseUp = true;
 pendingSelectionShiftKey = event.shiftKey;



git commit: [flex-sdk] [refs/heads/develop] - FLEX-34028: Removed 2 variables that were not being used and changed the event ctrlKey/shiftKey selection check to before the dragEnabled check.

2015-08-12 Thread mkessler
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 1754c10c1 -> 75154b643


FLEX-34028: Removed 2 variables that were not being used and changed the event 
ctrlKey/shiftKey selection check to before the dragEnabled check.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/75154b64
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/75154b64
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/75154b64

Branch: refs/heads/develop
Commit: 75154b643aed70acf100f8098099e0d1491813bb
Parents: 1754c10
Author: Mark Kessler 
Authored: Wed Aug 12 20:36:52 2015 -0400
Committer: Mark Kessler 
Committed: Wed Aug 12 20:36:52 2015 -0400

--
 .../spark/src/spark/components/DataGrid.as  | 45 
 1 file changed, 18 insertions(+), 27 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/75154b64/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 5bc516f..fb0676f 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -862,16 +862,7 @@ public class DataGrid extends SkinnableContainerBase
  *  comitting the selection until mouse up.
  */
 private var pendingSelectionOnMouseUp:Boolean = false;
-
-/**
- *  @private
- */
-private var pendingSelectionShiftKey:Boolean;
-
-/**
- *  @private
- */
-private var pendingSelectionCtrlKey:Boolean;
+
 
 
//--
 //
@@ -5628,29 +5619,23 @@ public class DataGrid extends SkinnableContainerBase
 // position.
 if (rowIndex == -1 || isCellSelection && columnIndex == -1)
 return;
-
-if (event.ctrlKey == false && dragEnabled && isRowSelectionMode() && 
selectionContainsIndex(rowIndex))
+
+
+if (event.ctrlKey)
 {
-pendingSelectionOnMouseUp = true;
-pendingSelectionShiftKey = event.shiftKey;
-pendingSelectionCtrlKey = event.ctrlKey;
+// ctrl-click toggles the selection and updates caret and anchor.
+if (!toggleSelection(rowIndex, columnIndex))
+return;
+
+grid.anchorRowIndex = rowIndex;
+grid.anchorColumnIndex = columnIndex;
 }
 else
 {
-if (event.ctrlKey)
-{
-// ctrl-click toggles the selection and updates caret and 
anchor.
-if (!toggleSelection(rowIndex, columnIndex))
-return;
-
-grid.anchorRowIndex = rowIndex;
-grid.anchorColumnIndex = columnIndex;
-}
-else if (event.shiftKey)
+if (event.shiftKey)
 {
 // shift-click extends the selection and updates the caret.
-if  (grid.selectionMode == GridSelectionMode.MULTIPLE_ROWS || 
-grid.selectionMode == GridSelectionMode.MULTIPLE_CELLS)
+if  (grid.selectionMode == GridSelectionMode.MULTIPLE_ROWS || 
grid.selectionMode == GridSelectionMode.MULTIPLE_CELLS)
 {
 if (!extendSelection(rowIndex, columnIndex))
 return;
@@ -5662,6 +5647,12 @@ public class DataGrid extends SkinnableContainerBase
 setSelectionAnchorCaret(rowIndex, columnIndex);
 }
 }
+
+
+if (dragEnabled && isRowSelectionMode() && 
selectionContainsIndex(rowIndex))
+{
+pendingSelectionOnMouseUp = true;
+}
 
 // If selection is pending on mouse up then we have just moused down on
 // an item, part of an already commited selection.



git commit: testing

2013-03-28 Thread mkessler
Updated Branches:
  refs/heads/develop 39fdf7fa8 -> 7784b6f44


testing


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7784b6f4
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7784b6f4
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7784b6f4

Branch: refs/heads/develop
Commit: 7784b6f448d27d06dc839bc948cdb811c515789c
Parents: 39fdf7f
Author: Mark Kessler 
Authored: Thu Mar 28 17:56:40 2013 -0400
Committer: Mark Kessler 
Committed: Thu Mar 28 17:57:39 2013 -0400

--
 SVN-TEST.txt |5 -
 1 files changed, 4 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7784b6f4/SVN-TEST.txt
--
diff --git a/SVN-TEST.txt b/SVN-TEST.txt
index d7487bd..75560ef 100644
--- a/SVN-TEST.txt
+++ b/SVN-TEST.txt
@@ -1,4 +1,4 @@
-junheider is Top Posting this file�people hate this on mailing lists.
+junheider is Top Posting this file�people hate this on mailing lists.
 
 Flex committers can use this file to check their svn access.
 "I love work; it fascinates me; I can sit and watch it for hours." -- Jerome 
K. Jerome
@@ -62,4 +62,7 @@ Through Eden took thir solitarie way.
 
 Frédéric Thomas (fthomas)
 
+It's a trap!
+
+
 



git commit: Changed setSelectedIndex from mxinternal to public.

2013-04-06 Thread mkessler
Updated Branches:
  refs/heads/develop 579e7c307 -> 192a5b2a7


Changed setSelectedIndex from mxinternal to public.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/192a5b2a
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/192a5b2a
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/192a5b2a

Branch: refs/heads/develop
Commit: 192a5b2a70b4fc7326b7337080a1b12063cdd554
Parents: 579e7c3
Author: Mark Kessler 
Authored: Sat Apr 6 10:03:01 2013 -0400
Committer: Mark Kessler 
Committed: Sat Apr 6 10:08:00 2013 -0400

--
 .../spark/src/spark/components/ComboBox.as |2 +-
 .../spark/components/supportClasses/ListBase.as|   20 +-
 2 files changed, 14 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/192a5b2a/frameworks/projects/spark/src/spark/components/ComboBox.as
--
diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as 
b/frameworks/projects/spark/src/spark/components/ComboBox.as
index 46d4337..95616d0 100644
--- a/frameworks/projects/spark/src/spark/components/ComboBox.as
+++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
@@ -887,7 +887,7 @@ public class ComboBox extends DropDownListBase implements 
IIMESupport
 /**
  * @private
  */
-override mx_internal function setSelectedIndex(value:int, 
dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
+override public function setSelectedIndex(value:int, 
dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
 {
 // It is possible that the label display changed but the selection 
didn't.  If this is
 // the case, the label has to be updated since the setSelectedIndex 
code will short-circuit

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/192a5b2a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index 3c367a3..20b9ad6 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -710,19 +710,25 @@ public class ListBase extends SkinnableDataContainer
 }
 
 /**
- *  @private
- *  Used internally to specify whether the selectedIndex changed 
programmatically or due to 
- *  user interaction. 
+ *  The rowIndex is the index in the data provider
+ *  of the item containing the selected cell.
+ *
+ *  @param rowIndex The 0-based row index of the cell.
  * 
  *  @param dispatchChangeEvent if true, the component will dispatch a 
"change" event if the
- *  value has changed. Otherwise, it will dispatch a "valueCommit" event. 
+ *  rowIndex has changed. Otherwise, it will dispatch a "valueCommit" 
event. 
  * 
  *  @param changeCaret if true, the caret will be set to the selectedIndex 
as a side-effect of calling 
  *  this method.  If false, caretIndex won't change.
+ *
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 1.5
+ *  @productversion Flex 4
  */
-mx_internal function setSelectedIndex(value:int, 
dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
+public function setSelectedIndex(rowIndex:int, dispatchChangeEvent:Boolean 
= false, changeCaret:Boolean = true):void
 {
-if (value == selectedIndex)
+if (rowIndex == selectedIndex)
 {
 // this should short-circuit, but we should check to make sure 
 // that caret doesn't need to be changed either, as that's a side
@@ -736,7 +742,7 @@ public class ListBase extends SkinnableDataContainer
 if (dispatchChangeEvent)
 dispatchChangeAfterSelection = (dispatchChangeAfterSelection || 
dispatchChangeEvent);
 changeCaretOnSelection = changeCaret;
-_proposedSelectedIndex = value;
+_proposedSelectedIndex = rowIndex;
 invalidateProperties();
 }
 



git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase

2013-04-06 Thread mkessler
Updated Branches:
  refs/heads/develop 192a5b2a7 -> 9ec4d1780


FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of 
the ListBase


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9ec4d178
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9ec4d178
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9ec4d178

Branch: refs/heads/develop
Commit: 9ec4d178067315ff2a928a0d6aa6e011cdf88870
Parents: 192a5b2
Author: Mark Kessler 
Authored: Sat Apr 6 14:22:48 2013 -0400
Committer: Mark Kessler 
Committed: Sat Apr 6 14:22:48 2013 -0400

--
 .../spark/src/spark/components/ComboBox.as |7 ++-
 1 files changed, 6 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9ec4d178/frameworks/projects/spark/src/spark/components/ComboBox.as
--
diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as 
b/frameworks/projects/spark/src/spark/components/ComboBox.as
index 95616d0..18bf6f2 100644
--- a/frameworks/projects/spark/src/spark/components/ComboBox.as
+++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
@@ -885,7 +885,12 @@ public class ComboBox extends DropDownListBase implements 
IIMESupport
 }
 
 /**
- * @private
+ *  @copy spark.components.supportClasses.ListBase#setSelectedIndex()
+ *  
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 1.5
+ *  @productversion Flex 4
  */
 override public function setSelectedIndex(value:int, 
dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
 {




[1/3] git commit: FLEX-33477: Corrected the ASDOC tags for the versions implemented and tested the changes with.

2013-04-07 Thread mkessler
Updated Branches:
  refs/heads/develop 2b3c3c090 -> 317e88442


FLEX-33477: Corrected the ASDOC tags for the versions implemented and tested 
the changes with.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/02230059
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/02230059
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/02230059

Branch: refs/heads/develop
Commit: 0223005900897d55ecaf245f3f26d1efc158966b
Parents: 2b3c3c0
Author: Mark Kessler 
Authored: Sun Apr 7 11:48:27 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 7 11:48:27 2013 -0400

--
 .../spark/src/spark/components/ComboBox.as |6 +++---
 .../spark/components/supportClasses/ListBase.as|6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/02230059/frameworks/projects/spark/src/spark/components/ComboBox.as
--
diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as 
b/frameworks/projects/spark/src/spark/components/ComboBox.as
index 18bf6f2..79905b7 100644
--- a/frameworks/projects/spark/src/spark/components/ComboBox.as
+++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
@@ -888,9 +888,9 @@ public class ComboBox extends DropDownListBase implements 
IIMESupport
  *  @copy spark.components.supportClasses.ListBase#setSelectedIndex()
  *  
  *  @langversion 3.0
- *  @playerversion Flash 10
- *  @playerversion AIR 1.5
- *  @productversion Flex 4
+ *  @playerversion Flash 11.1
+ *  @playerversion AIR 3.4
+ *  @productversion Flex 4.10
  */
 override public function setSelectedIndex(value:int, 
dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
 {

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/02230059/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index 20b9ad6..d0da37f 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -722,9 +722,9 @@ public class ListBase extends SkinnableDataContainer
  *  this method.  If false, caretIndex won't change.
  *
  *  @langversion 3.0
- *  @playerversion Flash 10
- *  @playerversion AIR 1.5
- *  @productversion Flex 4
+ *  @playerversion Flash 11.1
+ *  @playerversion AIR 3.4
+ *  @productversion Flex 4.10
  */
 public function setSelectedIndex(rowIndex:int, dispatchChangeEvent:Boolean 
= false, changeCaret:Boolean = true):void
 {



[2/3] git commit: FLEX-33190: Corrected ASDOC comments to use the new release version that it was tested with.

2013-04-07 Thread mkessler
FLEX-33190: Corrected ASDOC comments to use the new release version that it was 
tested with.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/abc381bf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/abc381bf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/abc381bf

Branch: refs/heads/develop
Commit: abc381bfa6ca8ded590a02b6d6be092738b78cee
Parents: 2b3c3c0
Author: Mark Kessler 
Authored: Sun Apr 7 12:09:56 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 7 12:09:56 2013 -0400

--
 .../spark/src/spark/components/DataGrid.as |6 +-
 .../projects/spark/src/spark/components/Grid.as|6 +-
 .../components/gridClasses/GridDoubleClickMode.as  |   33 ---
 3 files changed, 23 insertions(+), 22 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/abc381bf/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 681b7cf..85032f0 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -1572,9 +1572,9 @@ public class DataGrid extends SkinnableContainerBase
 *  @see spark.components.gridClasses.GridDoubleClickMode
 * 
 *  @langversion 3.0
-*  @playerversion Flash 10
-*  @playerversion AIR 2.5
-*  @productversion Flex 4.5
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
 */
 
 public function get doubleClickMode():String

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/abc381bf/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index 3b49cfd..02c71b3 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -1212,9 +1212,9 @@ public class Grid extends Group implements 
IDataGridElement
  *  @see spark.components.gridClasses.GridDoubleClickMode
  * 
  *  @langversion 3.0
- *  @playerversion Flash 10
- *  @playerversion AIR 2.5
- *  @productversion Flex 4.5
+ *  @playerversion Flash 11.1
+ *  @playerversion AIR 3.4
+ *  @productversion Flex 4.10
  */
 public function get doubleClickMode():String
 {

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/abc381bf/frameworks/projects/spark/src/spark/components/gridClasses/GridDoubleClickMode.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/gridClasses/GridDoubleClickMode.as
 
b/frameworks/projects/spark/src/spark/components/gridClasses/GridDoubleClickMode.as
index 47f88d6..f978a6f 100644
--- 
a/frameworks/projects/spark/src/spark/components/gridClasses/GridDoubleClickMode.as
+++ 
b/frameworks/projects/spark/src/spark/components/gridClasses/GridDoubleClickMode.as
@@ -27,13 +27,14 @@ package spark.components.gridClasses
 *  Use the constants in ActionsScript, as the following example shows: 

 *  
 *myDG.doubleClickMode = GridDoubleClickMode.ROW;
+*myDG.doubleClickEnabled = true;
 *  
 *
 *  In MXML, use the String value of the constants, 
 *  as the following example shows:
 *  
 * 
+*doubleClickMode="row" doubleClickEnabled="true"> 
 *...
 * 
 *  
@@ -42,9 +43,9 @@ package spark.components.gridClasses
 *  @see spark.components.Grid#doubleClickMode
 *  
 *  @langversion 3.0
-*  @playerversion Flash 10
-*  @playerversion AIR 2.5
-*  @productversion Flex 4.5
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
 */
 public final class GridDoubleClickMode
 {
@@ -52,9 +53,9 @@ package spark.components.gridClasses
 *  Constructor.
 * 
 *  @langversion 3.0
-*  @playerversion Flash 10
-*  @playerversion AIR 2.5
-*  @productversion Flex 4.5
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
 */
 public function GridDoubleClickMode()
 {
@@ -68,9 +69,9 @@ package spark.components.gridClasses
 *  Specifies that the doubleClick event should be based on a cell.
 * 
 *  @langversion 3.0
-*  @playerversion F

[3/3] git commit: Merge branch 'FLEX-33190' into develop

2013-04-07 Thread mkessler
Merge branch 'FLEX-33190' into develop


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/317e8844
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/317e8844
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/317e8844

Branch: refs/heads/develop
Commit: 317e8844207a20ec9ff5cd9f3319fb1021b02ccb
Parents: 0223005 abc381b
Author: Mark Kessler 
Authored: Sun Apr 7 12:10:55 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 7 12:10:55 2013 -0400

--
 .../spark/src/spark/components/DataGrid.as |6 +-
 .../projects/spark/src/spark/components/Grid.as|6 +-
 .../components/gridClasses/GridDoubleClickMode.as  |   33 ---
 3 files changed, 23 insertions(+), 22 deletions(-)
--




git commit: [flex-sdk] - FLEX-24780: Returned dispatchChangeAfterSelection to false after preventDefault is called commitSelection is called. This should resolve the issue for all children such as lis

2013-04-15 Thread mkessler
Updated Branches:
  refs/heads/develop 3c9d73ba5 -> 00201ff88


FLEX-24780: Returned dispatchChangeAfterSelection to false after preventDefault 
is called commitSelection is called.  This should resolve the issue for all 
children such as list, buttonbar, tabbar and the like.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/00201ff8
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/00201ff8
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/00201ff8

Branch: refs/heads/develop
Commit: 00201ff88e87cd361e1f46d487c9084b99c3266b
Parents: 3c9d73b
Author: Mark Kessler 
Authored: Mon Apr 15 20:20:11 2013 -0400
Committer: Mark Kessler 
Committed: Mon Apr 15 20:22:16 2013 -0400

--
 .../spark/components/supportClasses/ListBase.as|4 
 1 files changed, 4 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/00201ff8/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index d0da37f..a25f9df 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1322,6 +1322,10 @@ public class ListBase extends SkinnableDataContainer
 // The event was cancelled. Cancel the selection change and 
return.
 itemSelected(_proposedSelectedIndex, false);
 _proposedSelectedIndex = NO_PROPOSED_SELECTION;
+
+//Reset back to false to resolve selectedIndex
+dispatchChangeAfterSelection = false;
+
 return false;
 }
 }



git commit: [flex-sdk] - FLEX-28883: Corrected the requireSelection being ignored on dataProvider's being refreshed. It's original default behavior was to remove any selection and leave it that way.

2013-04-17 Thread mkessler
Updated Branches:
  refs/heads/develop 92448d797 -> c858daafb


FLEX-28883:  Corrected the requireSelection being ignored on dataProvider's 
being refreshed.  It's original default behavior was to remove any selection 
and leave it that way.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/c858daaf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/c858daaf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/c858daaf

Branch: refs/heads/develop
Commit: c858daafbe8738ce993a88296c58bafe884376ed
Parents: 92448d7
Author: Mark Kessler 
Authored: Wed Apr 17 21:40:08 2013 -0400
Committer: Mark Kessler 
Committed: Wed Apr 17 21:41:31 2013 -0400

--
 .../spark/components/supportClasses/ListBase.as|   15 +++
 1 files changed, 11 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/c858daaf/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index a25f9df..74d0d73 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1497,10 +1497,17 @@ public class ListBase extends SkinnableDataContainer
  */
 mx_internal function dataProviderRefreshed():void
 {
-selectedItem = undefined;
-setSelectedIndex(NO_SELECTION, false);
-// TODO (rfrishbe): probably don't need the setCurrentCaretIndex below
-setCurrentCaretIndex(NO_CARET);
+if (requireSelection == true)
+{
+setSelectedIndex(0, false);
+}
+else
+{
+selectedItem = undefined;
+setSelectedIndex(NO_SELECTION, false);
+// TODO (rfrishbe): probably don't need the setCurrentCaretIndex 
below
+setCurrentCaretIndex(NO_CARET);
+}
 }
 
 /**



git commit: [flex-sdk] - FLEX-28883: Added dataProvider existance and length check before applying a default selectedIndex.

2013-04-17 Thread mkessler
Updated Branches:
  refs/heads/develop c858daafb -> 56cff181d


FLEX-28883: Added dataProvider existance and length check before applying a 
default selectedIndex.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/56cff181
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/56cff181
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/56cff181

Branch: refs/heads/develop
Commit: 56cff181d719f49ca5359be835e600b3704181bd
Parents: c858daa
Author: Mark Kessler 
Authored: Wed Apr 17 21:50:21 2013 -0400
Committer: Mark Kessler 
Committed: Wed Apr 17 21:55:17 2013 -0400

--
 .../spark/components/supportClasses/ListBase.as|2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/56cff181/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index 74d0d73..ac85f89 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1497,7 +1497,7 @@ public class ListBase extends SkinnableDataContainer
  */
 mx_internal function dataProviderRefreshed():void
 {
-if (requireSelection == true)
+if (dataProvider && dataProvider.length > 0 && requireSelection == 
true)
 {
 setSelectedIndex(0, false);
 }



git commit: [flex-sdk] - FLEX-33498: Adding new feature for dataProvider/selectedIndex supporting components. This covers; Grid, DataGrid, ListBase, ComboBox, DropDownList, List, ButtonBar, TabBar, Bu

2013-04-19 Thread mkessler
Updated Branches:
  refs/heads/develop 531f7f2fe -> 774cdd7b6


FLEX-33498:  Adding new feature for dataProvider/selectedIndex supporting 
components.  This covers; Grid, DataGrid, ListBase, ComboBox, DropDownList, 
List, ButtonBar, TabBar, ButtonBarBase


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/774cdd7b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/774cdd7b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/774cdd7b

Branch: refs/heads/develop
Commit: 774cdd7b68759fcc93b40f8854de86824c6e4a97
Parents: 531f7f2
Author: Mark Kessler 
Authored: Tue Apr 16 21:23:40 2013 -0400
Committer: Mark Kessler 
Committed: Fri Apr 19 21:32:53 2013 -0400

--
 .../spark/src/spark/components/DataGrid.as |  181 +++-
 .../projects/spark/src/spark/components/Grid.as|  233 ++-
 .../supportClasses/IDataProviderEnhance.as |  150 +
 .../spark/components/supportClasses/ListBase.as|  232 ++-
 .../components/supportClasses/RegExPatterns.as |  221 ++
 5 files changed, 993 insertions(+), 24 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/774cdd7b/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 85032f0..9eede5e 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -73,6 +73,8 @@ import spark.components.gridClasses.GridSortField;
 import spark.components.gridClasses.GridView;
 import spark.components.gridClasses.IDataGridElement;
 import spark.components.gridClasses.IGridItemEditor;
+import spark.components.supportClasses.IDataProviderEnhance;
+import spark.components.supportClasses.RegExPatterns;
 import spark.components.supportClasses.SkinnableContainerBase;
 import spark.core.NavigationUnit;
 import spark.events.GridCaretEvent;
@@ -763,7 +765,7 @@ include "../styles/metadata/BasicInheritingTextStyles.as"
  *  @productversion Flex 4.5
  */  
 public class DataGrid extends SkinnableContainerBase 
-implements IFocusManagerComponent, IIMESupport
+implements IDataProviderEnhance, IFocusManagerComponent, IIMESupport
 {
 include "../core/Version.as";
 
@@ -1572,9 +1574,9 @@ public class DataGrid extends SkinnableContainerBase
 *  @see spark.components.gridClasses.GridDoubleClickMode
 * 
 *  @langversion 3.0
-*  @playerversion Flash 11.1
-*  @playerversion AIR 3.4
-*  @productversion Flex 4.10
+*  @playerversion Flash 10
+*  @playerversion AIR 2.5
+*  @productversion Flex 4.5
 */
 
 public function get doubleClickMode():String
@@ -1784,7 +1786,60 @@ public class DataGrid extends SkinnableContainerBase
 {
 return false;
 }
-
+
+
+//--
+//  isFirstRow
+//--
+
+/**
+*  @copy spark.components.Grid#isFirstRow
+*  If a grid is not assigned, will always return false;
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function get isFirstRow():Boolean
+{
+if (grid)
+{
+return grid.isFirstRow;
+}
+else
+{
+return false;
+}
+}
+
+
+//--
+//  isLastRow
+//--
+
+/**
+*  @copy spark.components.Grid#isLastRow
+*  If a grid is not assigned, will always return false;
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function get isLastRow():Boolean
+{
+if (grid)
+{
+return grid.isLastRow;
+}
+else
+{
+return false;
+}
+}
+
+
 //--
 //  multiColumnSortingEnabled
 //--
@@ -3905,7 +3960,28 @@ public class DataGrid extends SkinnableContainerBase
 //  Public Methods
 //
 
//--
-
+
+/**
+*  @copy spark.components.Grid#findRowIndex()
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function findRowIndex(field:String, value:String, startingIndex:int 
= 0, patternType:String = RegExPatterns.EXACT):int
+{
+if (grid)
+{
+retu

git commit: [flex-sdk] - FLEX-33498: Corrected asdoc changes from a merge issue.

2013-04-19 Thread mkessler
Updated Branches:
  refs/heads/develop 638fd912a -> 5e6e5c36c


FLEX-33498: Corrected asdoc changes from a merge issue.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5e6e5c36
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5e6e5c36
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5e6e5c36

Branch: refs/heads/develop
Commit: 5e6e5c36c6e713d55d4e289ec530cdb09d124002
Parents: 638fd91
Author: Mark Kessler 
Authored: Fri Apr 19 22:00:01 2013 -0400
Committer: Mark Kessler 
Committed: Fri Apr 19 22:04:01 2013 -0400

--
 .../spark/src/spark/components/DataGrid.as |6 +++---
 .../projects/spark/src/spark/components/Grid.as|   10 +-
 .../spark/components/supportClasses/ListBase.as|6 +++---
 3 files changed, 11 insertions(+), 11 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5e6e5c36/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 9eede5e..fa567c5 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -1574,9 +1574,9 @@ public class DataGrid extends SkinnableContainerBase
 *  @see spark.components.gridClasses.GridDoubleClickMode
 * 
 *  @langversion 3.0
-*  @playerversion Flash 10
-*  @playerversion AIR 2.5
-*  @productversion Flex 4.5
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
 */
 
 public function get doubleClickMode():String

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5e6e5c36/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index 320a34f..94a16fe 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -194,7 +194,7 @@ use namespace mx_internal;
  *  overhead to a minimum, pooled and recycled.
  *
  *  The Grid control supports a doubleClick event, according the 
doubleClickMode
- *  property.  
+ *  property.
  * 
  *  The Grid control supports selection, according the 
selectionMode
  *  property.  The set of selected row or cell indices can be modified or
@@ -212,7 +212,7 @@ use namespace mx_internal;
  *  The Grid control supports smooth scrolling.  
  *  Their vertical and horizontal scroll positions define the pixel origin 
  *  of the visible part of the grid and the grid's layout only displays 
- *  as many cell item renderers as are needed to fill the available space.  

+ *  as many cell item renderers as are needed to fill the available space.
  *
  *  The Grid control supports variable height rows that automatically 
compute 
  *  their height based on the item renderers' contents.  
@@ -1279,9 +1279,9 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
  *  @see spark.components.gridClasses.GridDoubleClickMode
  * 
  *  @langversion 3.0
- *  @playerversion Flash 10
- *  @playerversion AIR 2.5
- *  @productversion Flex 4.5
+ *  @playerversion Flash 11.1
+ *  @playerversion AIR 3.4
+ *  @productversion Flex 4.10
  */
 public function get doubleClickMode():String
 {

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5e6e5c36/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index fa391ba..50fcdb3 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -789,9 +789,9 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
  *  this method.  If false, caretIndex won't change.
  *
  *  @langversion 3.0
- *  @playerversion Flash 10
- *  @playerversion AIR 1.5
- *  @productversion Flex 4
+ *  @playerversion Flash 11.1
+ *  @playerversion AIR 3.4
+ *  @productversion Flex 4.10
  */
 public function setSelectedIndex(rowIndex:int, dispatchChangeEvent:Boolean 
= false, changeCaret:Boolean = true):void
 {



git commit: [flex-sdk] - Updated Flex-SDK\README to update FlashPlayerDebugger system var information on windows.

2013-04-20 Thread mkessler
Updated Branches:
  refs/heads/develop e9db73c84 -> 81b3ddaea


Updated Flex-SDK\README to update FlashPlayerDebugger system var information on 
windows.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/81b3ddae
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/81b3ddae
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/81b3ddae

Branch: refs/heads/develop
Commit: 81b3ddaea42d0531bd113ef88328ced1a7f92201
Parents: e9db73c
Author: Mark Kessler 
Authored: Sat Apr 20 09:14:31 2013 -0400
Committer: Mark Kessler 
Committed: Sat Apr 20 09:15:27 2013 -0400

--
 README |6 --
 1 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/81b3ddae/README
--
diff --git a/README b/README
index fa68eaa..fb2517f 100644
--- a/README
+++ b/README
@@ -173,8 +173,10 @@ Install Prerequisites
 and 11.5 on Windows and Mac. It has been compiled against other Adobe 
Flash Player
 versions but has not been fully tested.
 
-On Windows, set FLASHPLAYER_DEBUGGER to the absolute path of 
FlashPlayerDebugger.exe
-
+On Windows, set FLASHPLAYER_DEBUGGER to the absolute path including 
the filename of
+the FlashPlayerDebugger.exe.  Note the filename of flash player 
debugger maybe different.
+   e.g. C:\MyPath\FlashPlayerDebugger.exe
+
 On the Mac, set FLASHPLAYER_DEBUGGER to the absolute path of 
 Flash Player Debugger.app/Contents/MacOS/Flash Player Debugger
 



git commit: [flex-sdk] - FLEX-23974: Forced the itemRenderers to update their display before selecting a new index off of them.

2013-04-21 Thread mkessler
Updated Branches:
  refs/heads/develop 8bf8aa7b2 -> ae8d259e9


FLEX-23974: Forced the itemRenderers to update their display before selecting a 
new index off of them.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ae8d259e
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ae8d259e
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ae8d259e

Branch: refs/heads/develop
Commit: ae8d259e9c9e030a20e3565248162c74cbb51ba1
Parents: 8bf8aa7
Author: Mark Kessler 
Authored: Sun Apr 21 12:41:18 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 21 12:42:48 2013 -0400

--
 .../mx/src/mx/controls/listClasses/ListBase.as |4 
 1 files changed, 4 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ae8d259e/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
--
diff --git a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as 
b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
index 7c58a2b..fdac0ee 100644
--- a/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
+++ b/frameworks/projects/mx/src/mx/controls/listClasses/ListBase.as
@@ -7179,7 +7179,11 @@ public class ListBase extends ScrollControlBase
 if (!selectedData[uid])
 {
 if (listContent && UIDToItemRenderer(uid))
+{
+//Calling validateNow to make sure the item renderers have 
had a chance to update before selectItem references one to set as the new 
selectedIndex.
+validateNow();
 selectItem(UIDToItemRenderer(uid), false, false);
+}
 else
 {
 clearSelected();



git commit: [flex-sdk] - FLEX-23303: Added new minor enhancement selectedIndex.

2013-04-21 Thread mkessler
Updated Branches:
  refs/heads/develop e6c5be9c2 -> 97a9298cc


FLEX-23303:  Added new minor enhancement selectedIndex.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/97a9298c
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/97a9298c
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/97a9298c

Branch: refs/heads/develop
Commit: 97a9298cc314f752763b06720f5481b805e41045
Parents: e6c5be9
Author: Mark Kessler 
Authored: Sun Apr 21 22:09:08 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 21 22:10:24 2013 -0400

--
 .../spark/src/spark/components/RadioButtonGroup.as |   54 +++
 1 files changed, 54 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/97a9298c/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
--
diff --git a/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as 
b/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
index e562a8a..2fb1526 100644
--- a/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
+++ b/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
@@ -277,6 +277,58 @@ public class RadioButtonGroup extends EventDispatcher 
implements IMXMLObject
 return radioButtons.length;
 }
 
+
+//--
+//  selectedIndex
+//--
+
+/**
+*  @private
+*/
+private var _selectedIndex:int = -1;
+
+[Bindable("change")]
+[Bindable("valueCommit")]
+[Inspectable(category="General")]
+
+/**
+*  The index of the selected RadioButton component in the group.
+*  If a RadioButton is not selected, this property is -1.
+*
+*  @default -1
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function get selectedIndex():int
+{
+return _selectedIndex;
+}
+
+/**
+*  @private.
+*/
+public function set selectedIndex(newValue:int):void
+{
+if (newValue == _selectedIndex)
+{
+return;
+}
+
+if (newValue == -1)
+{
+setSelection(null, false);
+return;
+}
+
+changeSelection(newValue, false)
+
+dispatchEvent(new FlexEvent(FlexEvent.VALUE_COMMIT));
+}
+
+
 //--
 //  selectedValue
 //--
@@ -569,6 +621,7 @@ public class RadioButtonGroup extends EventDispatcher 
implements IMXMLObject
 {
 _selection.selected = false;
 _selection = null;
+_selectedIndex = -1;
 if (fireChange)
 dispatchEvent(new Event(Event.CHANGE));
 }
@@ -607,6 +660,7 @@ public class RadioButtonGroup extends EventDispatcher 
implements IMXMLObject
 // Fire a click event for the radio group.
 _selection = rb;
 _selection.selected = true;
+_selectedIndex = index;
 if (fireChange)
 dispatchEvent(new Event(Event.CHANGE));
 }



git commit: [flex-sdk] - FLEX-23303: Made sure setting an index value of -1 fires the valueCommit event.

2013-04-22 Thread mkessler
Updated Branches:
  refs/heads/develop ec15ddde1 -> 4f55ae424


FLEX-23303: Made sure setting an index value of -1 fires the valueCommit event.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/4f55ae42
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/4f55ae42
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/4f55ae42

Branch: refs/heads/develop
Commit: 4f55ae42497441c0bc7abba7c29942a8c54dbfac
Parents: ec15ddd
Author: Mark Kessler 
Authored: Mon Apr 22 19:47:53 2013 -0400
Committer: Mark Kessler 
Committed: Mon Apr 22 19:48:36 2013 -0400

--
 .../spark/src/spark/components/RadioButtonGroup.as |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4f55ae42/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
--
diff --git a/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as 
b/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
index 2fb1526..1f1c063 100644
--- a/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
+++ b/frameworks/projects/spark/src/spark/components/RadioButtonGroup.as
@@ -320,6 +320,8 @@ public class RadioButtonGroup extends EventDispatcher 
implements IMXMLObject
 if (newValue == -1)
 {
 setSelection(null, false);
+dispatchEvent(new FlexEvent(FlexEvent.VALUE_COMMIT));
+
 return;
 }
 



git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices method to allow array values.

2013-04-27 Thread mkessler
Updated Branches:
  refs/heads/develop 9084f8164 -> ec1ac280b


FLEX-33526: Added the findRowIndices method to allow array values.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/ec1ac280
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/ec1ac280
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/ec1ac280

Branch: refs/heads/develop
Commit: ec1ac280b7f0124169fd4efe82191bd170c7ae7c
Parents: 9084f81
Author: Mark Kessler 
Authored: Sat Apr 27 21:58:40 2013 -0400
Committer: Mark Kessler 
Committed: Sat Apr 27 21:59:58 2013 -0400

--
 .../spark/src/spark/components/DataGrid.as |   21 +
 .../projects/spark/src/spark/components/Grid.as|   60 +++
 .../supportClasses/IDataProviderEnhance.as |   11 +++
 .../spark/components/supportClasses/ListBase.as|   60 +++
 4 files changed, 152 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ec1ac280/frameworks/projects/spark/src/spark/components/DataGrid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/DataGrid.as 
b/frameworks/projects/spark/src/spark/components/DataGrid.as
index 85e4b43..933935c 100644
--- a/frameworks/projects/spark/src/spark/components/DataGrid.as
+++ b/frameworks/projects/spark/src/spark/components/DataGrid.as
@@ -3983,6 +3983,27 @@ public class DataGrid extends SkinnableContainerBase
 
 
 /**
+*  @copy spark.components.Grid#findRowIndices()
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function findRowIndices(field:String, values:Array, 
patternType:String = RegExPatterns.EXACT):Array
+{
+if (grid)
+{
+return grid.findRowIndices(field, values, patternType);
+}
+else
+{
+return [];
+}
+}
+
+
+/**
  *  @copy spark.components.Grid#invalidateCell()
  *  
  *  @langversion 3.0

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/ec1ac280/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index 94a16fe..be40673 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -4809,6 +4809,66 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
 
 
 /**
+*  This will search through a dataprovider checking the given field and 
for the given values and return an array of indices that matched.
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function findRowIndices(field:String, values:Array, 
patternType:String = RegExPatterns.EXACT):Array
+{
+var currentObject:Object = null;
+var regexList:Array = [];
+var matchedIndices:Array = [];
+var dataProviderTotal:uint = 0;
+var valuesTotal:uint = values.length;
+var loopingDataProviderIndex:uint = 0;
+var loopingValuesIndex:uint = 0;
+
+
+if (dataProvider && dataProvider.length > 0 && valuesTotal > 0)
+{
+dataProviderTotal = dataProvider.length;
+
+
+//Set the regex patterns in an array once.
+for (loopingValuesIndex = 0; loopingValuesIndex < valuesTotal; 
loopingValuesIndex++)
+{
+
regexList.push(RegExPatterns.createRegExp(values[loopingValuesIndex], 
patternType));
+}
+
+
+//Loop through dataprovider
+for (loopingDataProviderIndex; loopingDataProviderIndex < 
dataProviderTotal; loopingDataProviderIndex++)
+{
+currentObject = 
dataProvider.getItemAt(loopingDataProviderIndex);
+
+if (currentObject.hasOwnProperty(field) == false)
+{
+continue;
+}
+
+//Loop through regex patterns from the values array.
+for (loopingValuesIndex = 0; loopingValuesIndex < valuesTotal; 
loopingValuesIndex++)
+{
+if 
(currentObject[field].search(regexList[loopingValuesIndex]) != -1)
+{
+matchedIndices.push(loopingDataProviderIndex);
+
+break;
+}
+}
+}
+
+}
+
+
+return matchedIndices;
+}
+
+
+/**
 *  This will search through a dataprovider checking the given fie

git commit: [flex-sdk] - FLEX-33526: Added null test for values array.

2013-04-28 Thread mkessler
Updated Branches:
  refs/heads/develop 55b14753e -> 376417244


FLEX-33526: Added null test for values array.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/37641724
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/37641724
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/37641724

Branch: refs/heads/develop
Commit: 37641724467bc9df5299b0f0ead8052a4e28997a
Parents: 55b1475
Author: Mark Kessler 
Authored: Sun Apr 28 08:04:15 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 28 08:05:56 2013 -0400

--
 .../projects/spark/src/spark/components/Grid.as|5 +++--
 .../spark/components/supportClasses/ListBase.as|5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/37641724/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index be40673..b19e86f 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -4822,14 +4822,15 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
 var regexList:Array = [];
 var matchedIndices:Array = [];
 var dataProviderTotal:uint = 0;
-var valuesTotal:uint = values.length;
+var valuesTotal:uint = 0;
 var loopingDataProviderIndex:uint = 0;
 var loopingValuesIndex:uint = 0;
 
 
-if (dataProvider && dataProvider.length > 0 && valuesTotal > 0)
+if (dataProvider && dataProvider.length > 0 && values != null && 
values.length > 0)
 {
 dataProviderTotal = dataProvider.length;
+valuesTotal = values.length;
 
 
 //Set the regex patterns in an array once.

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/37641724/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index 5f737f4..120018b 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1284,14 +1284,15 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 var regexList:Array = [];
 var matchedIndices:Array = [];
 var dataProviderTotal:uint = 0;
-var valuesTotal:uint = values.length;
+var valuesTotal:uint = 0;
 var loopingDataProviderIndex:uint = 0;
 var loopingValuesIndex:uint = 0;
 
 
-if (dataProvider && dataProvider.length > 0 && valuesTotal > 0)
+if (dataProvider && dataProvider.length > 0 && values != null && 
values.length > 0)
 {
 dataProviderTotal = dataProvider.length;
+valuesTotal = values.length;
 
 
 //Set the regex patterns in an array once.



git commit: [flex-sdk] - FLEX-33526: Changed null test of dataProvider to be more consistent

2013-04-28 Thread mkessler
Updated Branches:
  refs/heads/develop 376417244 -> a0548274c


FLEX-33526: Changed null test of dataProvider to be more consistent


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a0548274
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a0548274
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a0548274

Branch: refs/heads/develop
Commit: a0548274c4ce2278d28767528cafc1701eb3d09e
Parents: 3764172
Author: Mark Kessler 
Authored: Sun Apr 28 09:32:13 2013 -0400
Committer: Mark Kessler 
Committed: Sun Apr 28 09:35:34 2013 -0400

--
 .../projects/spark/src/spark/components/Grid.as|2 +-
 .../spark/components/supportClasses/ListBase.as|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a0548274/frameworks/projects/spark/src/spark/components/Grid.as
--
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as 
b/frameworks/projects/spark/src/spark/components/Grid.as
index b19e86f..1ce7d91 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -4827,7 +4827,7 @@ public class Grid extends Group implements 
IDataGridElement, IDataProviderEnhanc
 var loopingValuesIndex:uint = 0;
 
 
-if (dataProvider && dataProvider.length > 0 && values != null && 
values.length > 0)
+if (dataProvider != null && dataProvider.length > 0 && values != null 
&& values.length > 0)
 {
 dataProviderTotal = dataProvider.length;
 valuesTotal = values.length;

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a0548274/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index 120018b..903e67f 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1289,7 +1289,7 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 var loopingValuesIndex:uint = 0;
 
 
-if (dataProvider && dataProvider.length > 0 && values != null && 
values.length > 0)
+if (dataProvider != null && dataProvider.length > 0 && values != null 
&& values.length > 0)
 {
 dataProviderTotal = dataProvider.length;
 valuesTotal = values.length;



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33524: Added convenience feature to enable/disable buttons in a ButtonBar/TabBar.

2013-05-02 Thread mkessler
Updated Branches:
  refs/heads/develop 7d20cec89 -> 3053c3295


FLEX-33524: Added convenience feature to enable/disable buttons in a 
ButtonBar/TabBar.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3053c329
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3053c329
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3053c329

Branch: refs/heads/develop
Commit: 3053c3295e6c14b291e2aa5a947b1d88e9650a6f
Parents: 7d20cec
Author: Mark Kessler 
Authored: Thu May 2 19:41:46 2013 -0400
Committer: Mark Kessler 
Committed: Thu May 2 19:44:51 2013 -0400

--
 .../components/supportClasses/ButtonBarBase.as |  198 ++-
 1 files changed, 197 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3053c329/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
index 233a210..b41504e 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
@@ -513,7 +513,203 @@ public class ButtonBarBase extends ListBase
 //  Methods
 //
 
//--
-
+
+/**
+*  Disable a ButtonBar's Button referencing it by the ButtonBarbutton's 
label. 
+*
+*  The function takes a single argument which is the ButtonBarButtons 
label.
+*  myButtonBar.disableButton("My Button Label")
+*
+*  @param labelValue Is the ButtonBarButton label
+*  @param fieldName Field used for comparing the label
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function disableButton(labelValue:String, fieldName:String = 
""):void
+{
+var btnCurrent:ButtonBarButton = null;
+var buttonIndex:int = -1;
+
+
+if (!dataGroup || labelValue == "" || labelValue == null)
+{
+return;
+}
+
+if (fieldName == "" || fieldName == null)
+{
+buttonIndex = findRowIndex(labelField, labelValue);
+}
+else
+{
+buttonIndex = findRowIndex(fieldName, labelValue);
+}
+
+if (buttonIndex == -1)
+{
+return;
+}
+
+
+btnCurrent = dataGroup.getElementAt(buttonIndex) as ButtonBarButton;
+btnCurrent.enabled = false;
+}
+
+
+/**
+*  Disables several of a ButtonBar's Buttons, referencing them by the 
ButtonBarbutton's label. 
+*
+*  The function takes a single argument which is the ButtonBarButtons 
label.
+*  myButtonBar.disableButtons(["My Button Label1", "My Label2"])
+*
+*  @param labelValues Is an array of ButtonBarButton labels.
+*  @param fieldName Field used for comparing the label
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function disableButtons(labelValues:Array, fieldName:String = 
""):void
+{
+var btnCurrent:ButtonBarButton = null;
+var buttonIndices:Array;
+var indicesTotal:uint = 0;
+var loopingIndex:uint = 0;
+
+
+if (!dataGroup || labelValues.length < 1 || labelValues == null)
+{
+return;
+}
+
+if (fieldName == "" || fieldName == null)
+{
+buttonIndices = findRowIndices(labelField, labelValues);
+}
+else
+{
+buttonIndices = findRowIndices(fieldName, labelValues);
+}
+
+
+indicesTotal = buttonIndices.length
+
+if (indicesTotal == 0)
+{
+return;
+}
+
+
+for (loopingIndex; loopingIndex < indicesTotal; loopingIndex++)
+{
+btnCurrent = dataGroup.getElementAt(buttonIndices[loopingIndex]) 
as ButtonBarButton;
+btnCurrent.enabled = false;
+}
+}
+
+
+/**
+*  Enable a ButtonBar's Button referencing it by the ButtonBarbutton's 
label. 
+*
+*  The function takes a single argument which is the ButtonBarButtons 
label.
+*  myButtonBar.enableButton("My Button Label")
+*
+*  @param labelValue Is the ButtonBarButton label
+*  @param fieldName Field used for comparing the label
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function enableButton(la

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33524: Combined a few methods and reduced redundant code.

2013-05-05 Thread mkessler
Updated Branches:
  refs/heads/develop ac89b97c2 -> 068c787f1


FLEX-33524: Combined a few methods and reduced redundant code.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/068c787f
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/068c787f
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/068c787f

Branch: refs/heads/develop
Commit: 068c787f19000b29478be8568582c2f725a2d5b7
Parents: ac89b97
Author: Mark Kessler 
Authored: Sun May 5 07:39:08 2013 -0400
Committer: Mark Kessler 
Committed: Sun May 5 07:41:13 2013 -0400

--
 .../components/supportClasses/ButtonBarBase.as |  142 ++-
 1 files changed, 20 insertions(+), 122 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/068c787f/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
index b41504e..ab5a28e 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/ButtonBarBase.as
@@ -515,108 +515,45 @@ public class ButtonBarBase extends ListBase
 
//--
 
 /**
-*  Disable a ButtonBar's Button referencing it by the ButtonBarbutton's 
label. 
+*  Gets the index for several of a ButtonBar's Buttons, referencing them 
by the ButtonBarbutton's label.  
 *
-*  The function takes a single argument which is the ButtonBarButtons 
label.
-*  myButtonBar.disableButton("My Button Label")
+*  The method takes an array of ButtonBarButtons label and an optional 
field name.
+*  myButtonBar.getButtonIndices(["My Button Label1", "My 
Label2"])
 *
-*  @param labelValue Is the ButtonBarButton label
-*  @param fieldName Field used for comparing the label
+*  @param labelValues Are the ButtonBarButton labels to find.
+*  @param fieldName Field used for comparing the label (optional)
 *
 *  @langversion 3.0
 *  @playerversion Flash 11.1
 *  @playerversion AIR 3.4
 *  @productversion Flex 4.10
 */
-public function disableButton(labelValue:String, fieldName:String = 
""):void
+public function getButtonIndices(labelValues:Array, fieldName:String = 
""):Array
 {
-var btnCurrent:ButtonBarButton = null;
-var buttonIndex:int = -1;
-
-
-if (!dataGroup || labelValue == "" || labelValue == null)
-{
-return;
-}
-
-if (fieldName == "" || fieldName == null)
-{
-buttonIndex = findRowIndex(labelField, labelValue);
-}
-else
-{
-buttonIndex = findRowIndex(fieldName, labelValue);
-}
-
-if (buttonIndex == -1)
-{
-return;
-}
-
-
-btnCurrent = dataGroup.getElementAt(buttonIndex) as ButtonBarButton;
-btnCurrent.enabled = false;
-}
-
-
-/**
-*  Disables several of a ButtonBar's Buttons, referencing them by the 
ButtonBarbutton's label. 
-*
-*  The function takes a single argument which is the ButtonBarButtons 
label.
-*  myButtonBar.disableButtons(["My Button Label1", "My Label2"])
-*
-*  @param labelValues Is an array of ButtonBarButton labels.
-*  @param fieldName Field used for comparing the label
-*
-*  @langversion 3.0
-*  @playerversion Flash 11.1
-*  @playerversion AIR 3.4
-*  @productversion Flex 4.10
-*/
-public function disableButtons(labelValues:Array, fieldName:String = 
""):void
-{
-var btnCurrent:ButtonBarButton = null;
 var buttonIndices:Array;
-var indicesTotal:uint = 0;
-var loopingIndex:uint = 0;
 
 
 if (!dataGroup || labelValues.length < 1 || labelValues == null)
 {
-return;
+return [];
 }
 
 if (fieldName == "" || fieldName == null)
 {
-buttonIndices = findRowIndices(labelField, labelValues);
+return findRowIndices(labelField, labelValues);
 }
 else
 {
-buttonIndices = findRowIndices(fieldName, labelValues);
-}
-
-
-indicesTotal = buttonIndices.length
-
-if (indicesTotal == 0)
-{
-return;
-}
-
-
-for (loopingIndex; loopingIndex < indicesTotal; loopingIndex++)
-{
-btnCurrent = dataGroup.getElementAt(buttonIndices[loopingIndex]) 
as ButtonBarButton;
-btnCurrent.enabled = false;
+return find

git commit: [flex-sdk] [refs/heads/develop] - FLEX-33537: Changed the internal setfocus to the textDisplay call to be callLater. This allows for the skin/child components to be setup before receiving

2013-05-07 Thread mkessler
Updated Branches:
  refs/heads/develop 11734d892 -> d5c329722


FLEX-33537:  Changed the internal setfocus to the textDisplay call to be 
callLater.  This allows for the skin/child components to be setup before 
receiving focus.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d5c32972
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d5c32972
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d5c32972

Branch: refs/heads/develop
Commit: d5c329722cd60568c53210973024b591b912b486
Parents: 11734d8
Author: Mark Kessler 
Authored: Tue May 7 21:11:54 2013 -0400
Committer: Mark Kessler 
Committed: Tue May 7 21:13:42 2013 -0400

--
 .../components/supportClasses/SkinnableTextBase.as |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d5c32972/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
 
b/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
index 440878f..7f4a29d 100644
--- 
a/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
+++ 
b/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTextBase.as
@@ -1879,7 +1879,8 @@ public class SkinnableTextBase extends SkinnableComponent
 }
 else
 {
-textDisplay.setFocus();
+//Calling later so the skin/state can finish setting up before 
accepting focus on textDisplay.
+callLater(textDisplay.setFocus);
 }
 }
 }



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33189: Allow for better PopUpManager centering of RTL layouts.

2013-05-22 Thread mkessler
Updated Branches:
  refs/heads/develop 5c561804c -> 0e48dac30


FLEX-33189: Allow for better PopUpManager centering of RTL layouts.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/0e48dac3
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/0e48dac3
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/0e48dac3

Branch: refs/heads/develop
Commit: 0e48dac303d93ab406fcc1452d0fcbf1227b60ad
Parents: 5c56180
Author: Mark Kessler 
Authored: Tue May 21 17:35:03 2013 -0400
Committer: Mark Kessler 
Committed: Wed May 22 20:28:09 2013 -0400

--
 .../framework/src/mx/managers/PopUpManagerImpl.as  |   23 ++
 1 files changed, 16 insertions(+), 7 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/0e48dac3/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as
--
diff --git a/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as 
b/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as
index 2affd47..3cb569d 100644
--- a/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as
+++ b/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as
@@ -598,13 +598,22 @@ public class PopUpManagerImpl extends EventDispatcher 
implements IPopUpManager
 const popUpLDE:ILayoutDirectionElement = popUp as 
ILayoutDirectionElement;
 const parentLDE:ILayoutDirectionElement = popUpParent as 
ILayoutDirectionElement;
 
-if (popUpLDE &&
-((parentLDE && parentLDE.layoutDirection != 
popUpLDE.layoutDirection) ||
-(!parentLDE && popUpLDE.layoutDirection == 
LayoutDirection.RTL)))
- {
-x = -x /* to flip it on the other side of the x axis*/ 
--popUp.width /* because 0 is the right edge */;

- }
+if (popUpLDE)
+{
+if ((parentLDE && parentLDE.layoutDirection != 
popUpLDE.layoutDirection) ||
+   (!parentLDE && popUpLDE.layoutDirection == 
LayoutDirection.RTL))
+{
+//(x = -x)  to flip it on the other side of the x axis.
+//(-popUp.width)  because 0 is the right edge.
+x = -x -popUp.width;
+}
+
+if (popUpLDE.layoutDirection == LayoutDirection.RTL)
+{
+//Corrects the x offset for RTL.
+clippingOffset.x += popUpParent.width;
+}
+}
 }
 
 pt = new Point(clippingOffset.x, clippingOffset.y);



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33590: Added minor convenience feature to preventSelection of buttons on a buttonbar/tabbar.

2013-06-20 Thread mkessler
Updated Branches:
  refs/heads/develop 34c9dfbdc -> 7d8b4465b


FLEX-33590: Added minor convenience feature to preventSelection of buttons on a 
buttonbar/tabbar.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7d8b4465
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7d8b4465
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7d8b4465

Branch: refs/heads/develop
Commit: 7d8b4465ba8dc7ee1e6186c48fa29264f1bc2aba
Parents: 34c9dfb
Author: Mark Kessler 
Authored: Thu Jun 20 18:32:14 2013 -0400
Committer: Mark Kessler 
Committed: Thu Jun 20 18:35:02 2013 -0400

--
 .../spark/components/supportClasses/ListBase.as | 76 +++-
 1 file changed, 74 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7d8b4465/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as 
b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index 903e67f..e639b5c 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -625,7 +625,57 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 labelFieldOrFunctionChanged = true;
 invalidateProperties(); 
 }
-
+
+
+//--
+//  preventSelection
+//--
+
+/**
+*  @private
+*/
+private var _preventSelection:Boolean = false;
+
+
+/**
+*  If true items will be prevented from being selected.  The 
selectedIndex value should always be -1.
+*  When this is set to true, it will set the 
requireSelection to false.
+*  Click events will continue to be called.
+*
+*  @default false
+*
+*  @langversion 3.0
+*  @playerversion Flash 11.1
+*  @playerversion AIR 3.4
+*  @productversion Flex 4.10
+*/
+public function get preventSelection():Boolean
+{
+return _preventSelection;
+}
+
+public function set preventSelection(newValue:Boolean):void
+{
+if (newValue == _preventSelection)
+{
+return;
+}
+
+
+if (newValue == true)
+{
+//Make sure to disable requireSelection since these two properties 
are polar opposites.
+requireSelection = false;
+
+//Remove any previous selection and allow it to update before 
enabling the prevent selection.
+setSelectedIndex(NO_SELECTION, false);
+validateNow();
+}
+
+_preventSelection = newValue;
+}
+
+
 //--
 //  requireSelection
 //--
@@ -677,6 +727,9 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 // from false to true
 if (value == true)
 {
+//Make sure to disable preventSelection since these two properties 
are polar opposites.
+preventSelection = false;
+
 requireSelectionChanged = true;
 invalidateProperties();
 }
@@ -1570,7 +1623,26 @@ public class ListBase extends SkinnableDataContainer 
implements IDataProviderEnh
 var oldSelectedIndex:int = _selectedIndex;
 var oldCaretIndex:int = _caretIndex;
 var e:IndexChangeEvent;
-
+
+
+//Prevents an in item from being selected.  Stops the change before it 
sends out changing events.
+if (_preventSelection == true)
+{
+if (_selectedIndex != NO_SELECTION)
+{
+itemSelected(NO_SELECTION, false);
+_selectedIndex = NO_SELECTION;
+}
+
+//Cancel the selection change and return false.
+itemSelected(_proposedSelectedIndex, false);
+_proposedSelectedIndex = NO_PROPOSED_SELECTION;
+dispatchChangeAfterSelection = false;
+
+return false;
+}
+
+
 if (!allowCustomSelectedItem || _proposedSelectedIndex != 
CUSTOM_SELECTED_ITEM)
 {
 if (_proposedSelectedIndex < NO_SELECTION)



git commit: [flex-sdk] [refs/heads/develop] - added another issue number to the list.

2013-06-21 Thread mkessler
Updated Branches:
  refs/heads/develop 7d8b4465b -> 2ee032783


added another issue number to the list.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/2ee03278
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2ee03278
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2ee03278

Branch: refs/heads/develop
Commit: 2ee0327836c054e6471effef9d174f86647ed049
Parents: 7d8b446
Author: Mark Kessler 
Authored: Fri Jun 21 21:24:14 2013 -0400
Committer: Mark Kessler 
Committed: Fri Jun 21 21:24:38 2013 -0400

--
 RELEASE_NOTES | 1 +
 1 file changed, 1 insertion(+)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/2ee03278/RELEASE_NOTES
--
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index fbca1c0..e4561c4 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -102,6 +102,7 @@ Bug Fixes
 
 JIRA Issue Number  Summary 
Resolution
 
--
+FLEX-33590 Adding a preventSelection feature to spark components 
inheriting listbase   Implemented
 FLEX-33545 RTE in destroyItemEditor in AdvancedDataGrid
Fixed
 FLEX-33537 Spark TextArea writing in prompt text format
Fixed
 FLEX-33526 findRowIndicies to complement findRowIndex  
Implemented



git commit: [flex-sdk] [refs/heads/develop] - Adding to "SDK Changes" section in Release notes.

2013-06-25 Thread mkessler
Updated Branches:
  refs/heads/develop 541083ce1 -> 571cd9fc5


Adding to "SDK Changes" section in Release notes.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/571cd9fc
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/571cd9fc
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/571cd9fc

Branch: refs/heads/develop
Commit: 571cd9fc50f7be7da6ecbab149a8275e9871f0f1
Parents: 541083c
Author: Mark Kessler 
Authored: Tue Jun 25 19:25:42 2013 -0400
Committer: Mark Kessler 
Committed: Tue Jun 25 19:26:27 2013 -0400

--
 RELEASE_NOTES | 3 +++
 1 file changed, 3 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/571cd9fc/RELEASE_NOTES
--
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index e4561c4..3a49eb7 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -38,6 +38,9 @@ SDK Changes
  - New data grid features to lock rows and columns, sort multiple columns and
move and sorting columns via the keyboard.
  - Row, column, cell and table datagrid double click modes.
+ - Spark RadioButtonGroup now has a selectedIndex property.
+ - Spark ButtonBar and TabBar can now enable/disable buttons.
+ - Spark ButtonBar and TabBar can now prevent the selection / toggling of 
their buttons.
  - Fixed RTEs in Advanced DataGrid when dynamically assigning columns.
  - Improved support of dates including DD/MM/ support, single digit day and
month in date formats and international dates including Japanese, Chinese



git commit: [flex-sdk] [refs/heads/develop] - FLEX-14522: Added enabledField and support during button creation. Minor logic changes.

2013-06-25 Thread mkessler
Updated Branches:
  refs/heads/develop 571cd9fc5 -> 712b1ba76


FLEX-14522:  Added enabledField and support during button creation. Minor logic 
changes.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/712b1ba7
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/712b1ba7
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/712b1ba7

Branch: refs/heads/develop
Commit: 712b1ba7680a969a3c25d4bc76c8ce40e7e3eebe
Parents: 571cd9f
Author: Mark Kessler 
Authored: Tue Jun 25 21:06:16 2013 -0400
Committer: Mark Kessler 
Committed: Tue Jun 25 21:11:51 2013 -0400

--
 .../projects/mx/src/mx/controls/NavBar.as   | 79 
 1 file changed, 63 insertions(+), 16 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/712b1ba7/frameworks/projects/mx/src/mx/controls/NavBar.as
--
diff --git a/frameworks/projects/mx/src/mx/controls/NavBar.as 
b/frameworks/projects/mx/src/mx/controls/NavBar.as
index 37f2e33..60849a3 100644
--- a/frameworks/projects/mx/src/mx/controls/NavBar.as
+++ b/frameworks/projects/mx/src/mx/controls/NavBar.as
@@ -106,6 +106,7 @@ use namespace mx_internal;
  *  

git commit: [flex-sdk] [refs/heads/develop] - Added an addition issue and updated the sdk changes.

2013-06-25 Thread mkessler
Updated Branches:
  refs/heads/develop 712b1ba76 -> a374632f5


Added an addition issue and updated the sdk changes.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a374632f
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a374632f
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a374632f

Branch: refs/heads/develop
Commit: a374632f52d0873c7f0709faab3d81ea5e7acb8e
Parents: 712b1ba
Author: Mark Kessler 
Authored: Tue Jun 25 22:00:51 2013 -0400
Committer: Mark Kessler 
Committed: Tue Jun 25 22:01:17 2013 -0400

--
 RELEASE_NOTES | 2 ++
 1 file changed, 2 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a374632f/RELEASE_NOTES
--
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index 3a49eb7..6a3fb14 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -41,6 +41,7 @@ SDK Changes
  - Spark RadioButtonGroup now has a selectedIndex property.
  - Spark ButtonBar and TabBar can now enable/disable buttons.
  - Spark ButtonBar and TabBar can now prevent the selection / toggling of 
their buttons.
+ - Added enabled property when buttons are created for the MX ButtonBar.
  - Fixed RTEs in Advanced DataGrid when dynamically assigning columns.
  - Improved support of dates including DD/MM/ support, single digit day and
month in date formats and international dates including Japanese, Chinese
@@ -290,6 +291,7 @@ FLEX-14787 Confusing, implicit cast to Number
 FLEX-14773 ListBase::findKey is invoked with event.keyCode instead of 
event.charCode   Fixed
 FLEX-14630 Flex-SDK cannot be built entirely from source   
Fixed
 FLEX-14581 Mx.Controls.DateChooser - Setting .monthNames to Array of 
Length < 12 causes "Null" months  Fixed
+FLEX-14522 enable/disable items within the building phase of the 
ButtonBar component not possible  Implemented
 FLEX-14450 NumberValidator maxValue/minValue don't work with 
non-english settings  Fixed
 FLEX-14316 mx.core.UITextField.truncateToFit() contains dead code  
Fixed
 FLEX-14153 Unrequired cast of calHeader in DateChooser 
Fixed



git commit: [flex-sdk] [refs/heads/develop] - FLEX-14522: Made boolean comparison more consistent.

2013-06-25 Thread mkessler
Updated Branches:
  refs/heads/develop a374632f5 -> 643dc5bad


FLEX-14522: Made boolean comparison more consistent.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/643dc5ba
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/643dc5ba
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/643dc5ba

Branch: refs/heads/develop
Commit: 643dc5bade5292e95321809f6ca1829a15c6db3d
Parents: a374632
Author: Mark Kessler 
Authored: Tue Jun 25 22:10:24 2013 -0400
Committer: Mark Kessler 
Committed: Tue Jun 25 22:11:13 2013 -0400

--
 frameworks/projects/mx/src/mx/controls/NavBar.as | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/643dc5ba/frameworks/projects/mx/src/mx/controls/NavBar.as
--
diff --git a/frameworks/projects/mx/src/mx/controls/NavBar.as 
b/frameworks/projects/mx/src/mx/controls/NavBar.as
index 60849a3..58d6093 100644
--- a/frameworks/projects/mx/src/mx/controls/NavBar.as
+++ b/frameworks/projects/mx/src/mx/controls/NavBar.as
@@ -1038,13 +1038,13 @@ public class NavBar extends Box
 }
 
 //Check for toolTip field and assign it to the individual 
button if it exists.
-if (_toolTipField != "" && item.hasOwnProperty(_toolTipField))
+if (_toolTipField != "" && item.hasOwnProperty(_toolTipField) 
== true)
 {
 navItem.toolTip = String(item[_toolTipField]);
 }
 
 //Check for enabled field and assign it to the individual 
button if it exists.
-if (_enabledField != "" && item.hasOwnProperty(_enabledField))
+if (_enabledField != "" && item.hasOwnProperty(_enabledField) 
== true)
 {
 navItem.enabled = Boolean(item[_enabledField]);
 }



git commit: [flex-sdk] [refs/heads/develop] - Adding in the main build.xml fix for the TLF_Home to the ASDOC build.xml

2013-07-21 Thread mkessler
Updated Branches:
  refs/heads/develop c39c3f4ce -> d1b6cecc1


Adding in the main build.xml fix for the TLF_Home to the ASDOC build.xml


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d1b6cecc
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d1b6cecc
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d1b6cecc

Branch: refs/heads/develop
Commit: d1b6cecc1acabc98d6d1bfb3d90871c9315e11f1
Parents: c39c3f4
Author: Mark Kessler 
Authored: Sun Jul 21 21:41:43 2013 -0400
Committer: Mark Kessler 
Committed: Sun Jul 21 21:42:07 2013 -0400

--
 asdoc/build.xml | 15 +++
 1 file changed, 15 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d1b6cecc/asdoc/build.xml
--
diff --git a/asdoc/build.xml b/asdoc/build.xml
index df941ae..8803daf 100644
--- a/asdoc/build.xml
+++ b/asdoc/build.xml
@@ -26,6 +26,21 @@
 

 
+
+
+
+
+
+

 




git commit: [flex-sdk] [refs/heads/develop] - FLEX-33665: Correcting the item editor positioning for datagrid.

2013-08-15 Thread mkessler
Updated Branches:
  refs/heads/develop 52d831085 -> da4cb4f71


FLEX-33665: Correcting the item editor positioning for datagrid.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/da4cb4f7
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/da4cb4f7
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/da4cb4f7

Branch: refs/heads/develop
Commit: da4cb4f712cffaea5b49ed44e1939af989435681
Parents: 52d8310
Author: Mark Kessler 
Authored: Wed Aug 14 05:00:26 2013 -0400
Committer: Mark Kessler 
Committed: Thu Aug 15 20:47:53 2013 -0400

--
 .../spark/src/spark/components/gridClasses/DataGridEditor.as   | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/da4cb4f7/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
index 06ee8d4..2991309 100644
--- 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
+++ 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
@@ -570,7 +570,7 @@ public class DataGridEditor
 
 _editedItemRenderer = item;
 
-   // Need to turn on focusable children flag so focus manager will
+// Need to turn on focusable children flag so focus manager will
 // allow focus into the data grid's children.
 if (restoreFocusableChildren)
 saveDataGridHasFocusableChildren = dataGrid.hasFocusableChildren; 
@@ -578,6 +578,10 @@ public class DataGridEditor
 
 if (dataGrid.scroller)
 {
+//Correct the item edit positioning based on the scroll position.
+//localCellOrigin.x -= grid.horizontalScrollPosition;
+//localCellOrigin.y -= grid.verticalScrollPosition;
+
 if (restoreFocusableChildren)
 saveScrollerHasFocusableChildren = 
dataGrid.scroller.hasFocusableChildren; 
 dataGrid.scroller.hasFocusableChildren = true;



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33665: Uncommenting correction.

2013-08-21 Thread mkessler
Updated Branches:
  refs/heads/develop 943232244 -> 20c22b2fc


FLEX-33665: Uncommenting correction.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/20c22b2f
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/20c22b2f
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/20c22b2f

Branch: refs/heads/develop
Commit: 20c22b2fc4ae184335e68fb215e7c37770f1171a
Parents: 9432322
Author: Mark Kessler 
Authored: Wed Aug 21 21:40:36 2013 -0400
Committer: Mark Kessler 
Committed: Wed Aug 21 21:40:36 2013 -0400

--
 .../spark/src/spark/components/gridClasses/DataGridEditor.as | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/20c22b2f/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
index 2991309..a3aaf9a 100644
--- 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
+++ 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
@@ -579,8 +579,8 @@ public class DataGridEditor
 if (dataGrid.scroller)
 {
 //Correct the item edit positioning based on the scroll position.
-//localCellOrigin.x -= grid.horizontalScrollPosition;
-//localCellOrigin.y -= grid.verticalScrollPosition;
+localCellOrigin.x -= grid.horizontalScrollPosition;
+localCellOrigin.y -= grid.verticalScrollPosition;
 
 if (restoreFocusableChildren)
 saveScrollerHasFocusableChildren = 
dataGrid.scroller.hasFocusableChildren; 



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33666: Mouse wheel events will now end the item edit. It will default to saving the edited text.

2013-08-27 Thread mkessler
Updated Branches:
  refs/heads/develop ef87141ac -> fd2330f67


FLEX-33666: Mouse wheel events will now end the item edit.  It will default to 
saving the edited text.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/fd2330f6
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/fd2330f6
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/fd2330f6

Branch: refs/heads/develop
Commit: fd2330f6786a0a3ee1dacbae34459bf17d774555
Parents: ef87141
Author: Mark Kessler 
Authored: Tue Aug 27 19:18:18 2013 -0400
Committer: Mark Kessler 
Committed: Tue Aug 27 19:18:18 2013 -0400

--
 .../spark/components/gridClasses/DataGridEditor.as  | 16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/fd2330f6/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
index a3aaf9a..4d5b227 100644
--- 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
+++ 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
@@ -450,7 +450,7 @@ public class DataGridEditor
 {
 // add listeners to enable cell editing
 var grid:Grid = dataGrid.grid;
-
+
 dataGrid.addEventListener(KeyboardEvent.KEY_DOWN, 
dataGrid_keyboardDownHandler);
 
 // Make sure we get first shot at mouse events before selection is 
changed. We use 
@@ -458,6 +458,7 @@ public class DataGridEditor
 grid.addEventListener(GridEvent.GRID_MOUSE_DOWN, 
grid_gridMouseDownHandler, false, 1000);
 grid.addEventListener(GridEvent.GRID_MOUSE_UP, 
grid_gridMouseUpHandler, false, 1000);
 grid.addEventListener(GridEvent.GRID_DOUBLE_CLICK, 
grid_gridDoubleClickHandler);
+grid.addEventListener(MouseEvent.MOUSE_WHEEL, 
grid_gridMouseWheelHandler, false, 0);
 }
 
 /**
@@ -468,11 +469,11 @@ public class DataGridEditor
 public function uninitialize():void
 {
 // remove listeners to disable cell editing   
-
 grid.removeEventListener(KeyboardEvent.KEY_DOWN, 
dataGrid_keyboardDownHandler);
 grid.removeEventListener(GridEvent.GRID_MOUSE_DOWN, 
grid_gridMouseDownHandler);
 grid.removeEventListener(GridEvent.GRID_MOUSE_UP, 
grid_gridMouseUpHandler);
 grid.removeEventListener(GridEvent.GRID_DOUBLE_CLICK, 
grid_gridDoubleClickHandler);
+grid.removeEventListener(MouseEvent.MOUSE_WHEEL, 
grid_gridMouseWheelHandler);
 }
 
 /**
@@ -1465,6 +1466,17 @@ public class DataGridEditor
 lastItemDown = null;
 }
 
+
+/**
+*  @private
+* 
+*/
+protected function grid_gridMouseWheelHandler(event:MouseEvent):void
+{
+endEdit();
+}
+
+
 /**
  *  @private
  * 



git commit: [flex-sdk] [refs/heads/develop] - FLEX-33687: Now will show up in the ASDocs, as well as removed the @private tags on the public functions. Added in minor verbiage to ones that required it

2013-08-28 Thread mkessler
Updated Branches:
  refs/heads/develop 945099e89 -> 9909781d8


FLEX-33687: Now will show up in the ASDocs, as well as removed the @private 
tags on the public functions.  Added in minor verbiage to ones that required it.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9909781d
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9909781d
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9909781d

Branch: refs/heads/develop
Commit: 9909781d82ee75f4b44d202215d3f17cf7f4050a
Parents: 945099e
Author: Mark Kessler 
Authored: Wed Aug 28 20:45:23 2013 -0400
Committer: Mark Kessler 
Committed: Wed Aug 28 20:45:23 2013 -0400

--
 .../components/gridClasses/DataGridEditor.as| 57 ++--
 1 file changed, 42 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9909781d/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
--
diff --git 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
index 4d5b227..33ca0cb 100644
--- 
a/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
+++ 
b/frameworks/projects/spark/src/spark/components/gridClasses/DataGridEditor.as
@@ -56,7 +56,6 @@ import spark.events.GridItemEditorEvent;
 
 use namespace mx_internal;
 
-[ExcludeClass]
 
 /**
  *  The DataGridEditor contains all the logic and event handling needed to 
@@ -180,8 +179,12 @@ public class DataGridEditor
 private var _dataGrid:DataGrid;
 
 /**
- *  @private
- *  The data grid that owns this editor.
+ *  Reference to the DataGrid that created the editor.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 2.5
+ *  @productversion Flex 4.5
  */
 public function get dataGrid():DataGrid
 {
@@ -189,8 +192,12 @@ public class DataGridEditor
 }
 
 /**
- *  @private
- *  Convenience property to get the grid.
+ *  Convenience property to get the Grid associated with the 
parent DataGrid.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 2.5
+ *  @productversion Flex 4.5
  */
 public function get grid():Grid
 {
@@ -236,7 +243,12 @@ public class DataGridEditor
 }
 
 /**
- *  @private
+ *  Sets the edited item position based on the grids rowIndex 
and columnIndex.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 2.5
+ *  @productversion Flex 4.5
  */
 public function set editedItemPosition(value:Object):void
 {
@@ -442,9 +454,13 @@ public class DataGridEditor
 
//--
 
 /**
- *  @private
- *  Called by the data grid after construction to initialize the editor. No
+ *  Called by the DataGrid after construction to initialize 
the editor. No
  *  item editors can be created until after this method is called.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 2.5
+ *  @productversion Flex 4.5
  */  
 public function initialize():void
 {
@@ -462,9 +478,12 @@ public class DataGridEditor
 }
 
 /**
- *  @private
+ *  The method is called to disable item editing on the 
DataGrid.
  * 
- *  The method is called to disable item editing on the data grid.
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 2.5
+ *  @productversion Flex 4.5
  */ 
 public function uninitialize():void
 {
@@ -772,8 +791,6 @@ public class DataGridEditor
 }
 
 /**
- *  @private
- * 
  *  Start editing a cell for a specified row and column index.
  *  
  *  Dispatches a 
GridItemEditorEvent.GRID_ITEM_EDITOR_SESSION_STARTING
@@ -782,6 +799,11 @@ public class DataGridEditor
  *  @param rowIndex The zero-based row index of the cell to edit.
  * 
  *  @param columnIndex The zero-based column index of the cell to edit.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 10
+ *  @playerversion AIR 2.5
+ *  @productversion Flex 4.5
  */
 public function startItemEditorSession(rowIndex:int, 
columnIndex:int):Boolean
 {
@@ -1468,9 +1490,14 @@ public class DataGridEditor
 
 
 /**
-*  @private
-* 
-*/
+ *  Grid MouseWheel event handler.  Used to end the itemeditor when 
scrolling on the grid.
+ *  Default action is to save the edited contents.
+ * 
+ *  @langversion 3.0
+ *  @playerversion Flash 11.8
+  

git commit: [flex-sdk] [refs/heads/develop] - Updated the Release Notes with new issue numbers and an SDK change.

2013-08-28 Thread mkessler
Updated Branches:
  refs/heads/develop 9909781d8 -> 65c219c11


Updated the Release Notes with new issue numbers and an SDK change.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/65c219c1
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/65c219c1
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/65c219c1

Branch: refs/heads/develop
Commit: 65c219c112a61d21927f6ca6216bf4f1831fd0bb
Parents: 9909781
Author: Mark Kessler 
Authored: Wed Aug 28 20:58:09 2013 -0400
Committer: Mark Kessler 
Committed: Wed Aug 28 20:58:09 2013 -0400

--
 RELEASE_NOTES | 4 
 1 file changed, 4 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/65c219c1/RELEASE_NOTES
--
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index e8ed92d..dd5bbbd 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -10,6 +10,7 @@ SDK Changes
 -
 - 120 and 640 dpi mobile resolution/skin support.
 - mx:AdvancedDataGrid and mx:DataGrid speed improvements
+- s:DataGridEditor will now be visible in ASDocs and be visible in the Tag 
inspector.
 
 Bug Fixes
 --
@@ -23,7 +24,10 @@ Bug Fixes
 JIRA Issue Number  Summary 
   
 
---
 FLEX-33688 RTE in advanced list when setting selection to null and column 
is sorted
+FLEX-33687  DataGridEditor is not visible in ASDOCS has been excluded
 FLEX-33667  compiler with apache flex 4.10 occur error : Uncaught exception in 
compiler.
+FLEX-33666  When scrolling a Spark Datagrid with the mousewheel after starting 
an itemEditor session, the itemEditor doesn't follow it's cell
+FLEX-33665  ItemEditors are placed on the wrong position after scrolling an 
editable Spark Datagrid
 FLEX-33655 RTE when closing SkinnablePopUpContainer
 FLEX-33643 Improve experimental CallOut component frame arrow display
 FLEX-28012 FormItemSkin and StackedFormItemSkib indicatorDisplay's toolTip 
is not localized



[flex-sdk] branch develop updated: -Xbootclasspath/p is no longer supported as of JDK9 and JDK12 is the latest version. Changed to /p to /a.

2019-04-29 Thread mkessler
This is an automated email from the ASF dual-hosted git repository.

mkessler pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/flex-sdk.git


The following commit(s) were added to refs/heads/develop by this push:
 new 5d6f446  -Xbootclasspath/p is no longer supported as of JDK9 and JDK12 
is the latest version.  Changed to /p to /a.
5d6f446 is described below

commit 5d6f44683233c942ff747f5e12f8ff33d71e5b1b
Author: Mark Kessler 
AuthorDate: Mon Apr 29 20:21:59 2019 -0400

-Xbootclasspath/p is no longer supported as of JDK9 and JDK12 is the latest 
version.  Changed to /p to /a.
---
 bin/aasdoc.bat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/aasdoc.bat b/bin/aasdoc.bat
index 0daad06..569363c 100755
--- a/bin/aasdoc.bat
+++ b/bin/aasdoc.bat
@@ -30,4 +30,4 @@ rem
 
 if "%FLEX_HOME%"=="" set FLEX_HOME=%~dp0\..
 
-java -Xmx1024m -Dsun.io.useCanonCaches=false 
-Xbootclasspath/p:"%FLEX_HOME%\lib\xalan.jar" -classpath 
"%FLEX_HOME%\lib\asdoc.jar" flex2.tools.ASDoc +configname=air 
+flexlib="%FLEX_HOME%\frameworks" %*
+java -Xmx1024m -Dsun.io.useCanonCaches=false 
-Xbootclasspath/a:"%FLEX_HOME%\lib\xalan.jar" -classpath 
"%FLEX_HOME%\lib\asdoc.jar" flex2.tools.ASDoc +configname=air 
+flexlib="%FLEX_HOME%\frameworks" %*