Re: [1/4] Initial commit of 'correct' whitespace emission.
I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLApplica tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 026a53c72 - dc0c5fe49 http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4bdbf59/compiler. jx.tests/test-files/flexjs/files/MyInitialView_result.js -- diff --git a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js index 2bebadd..5ef10ba 100644 --- a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js +++ b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js @@ -21,157 +21,157 @@ goog.require('org.apache.flex.utils.Timer'); * @extends {org.apache.flex.core.ViewBase} */ MyInitialView = function() { - goog.base(this); - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.lbl; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID0; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID1; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID2; - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.timerLabel; - - /** - * @private - * @type {org.apache.flex.html.staticControls.List} - */ - this.cityList; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID3; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextArea} - */ - this.$ID5; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID4; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextInput} - */ - this.input; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID6; - - /** - * @private - * @type {org.apache.flex.html.staticControls.CheckBox} - */ - this.checkbox; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID7; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID8; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID9; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID10; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID11; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID12; - - /** - * @private - * @type {org.apache.flex.html.staticControls.DropDownList} - */ - this.list; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID13; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID14; - - /** - * @private - * @type {org.apache.flex.html.staticControls.ComboBox} - */ - this.comboBox; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID15; - - /** - * @private - * @type {Array} - */ - this.mxmldd; - - /** - * @private - * @type {Array} - */ - this.mxmldp; + goog.base(this); + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.lbl; + + /** + * @private + * @type {org.apache.flex.binding.SimpleBinding} + */ + this.$ID0; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextButton} + */ + this.$ID1; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextButton} + */ + this.$ID2; + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.timerLabel; + + /** + * @private + * @type {org.apache.flex.html.staticControls.List} + */ + this.cityList; + + /** + * @private + * @type {org.apache.flex.binding.ConstantBinding} + */ + this.$ID3; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextArea} + */ + this.$ID5; + + /** + * @private + * @type {org.apache.flex.binding.SimpleBinding} + */ + this.$ID4; + + /** + *
Re: [1/4] Initial commit of 'correct' whitespace emission.
It's passing for me, both in Eclipse and from the terminal (OSX 10.9). What is the test complaining about? EdB On Tue, Nov 12, 2013 at 8:07 PM, Alex Harui aha...@adobe.com wrote: I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLApplica tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 026a53c72 - dc0c5fe49 http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4bdbf59/compiler. jx.tests/test-files/flexjs/files/MyInitialView_result.js -- diff --git a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js index 2bebadd..5ef10ba 100644 --- a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js +++ b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js @@ -21,157 +21,157 @@ goog.require('org.apache.flex.utils.Timer'); * @extends {org.apache.flex.core.ViewBase} */ MyInitialView = function() { - goog.base(this); - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.lbl; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID0; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID1; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID2; - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.timerLabel; - - /** - * @private - * @type {org.apache.flex.html.staticControls.List} - */ - this.cityList; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID3; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextArea} - */ - this.$ID5; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID4; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextInput} - */ - this.input; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID6; - - /** - * @private - * @type {org.apache.flex.html.staticControls.CheckBox} - */ - this.checkbox; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID7; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID8; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID9; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID10; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID11; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID12; - - /** - * @private - * @type {org.apache.flex.html.staticControls.DropDownList} - */ - this.list; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID13; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID14; - - /** - * @private - * @type {org.apache.flex.html.staticControls.ComboBox} - */ - this.comboBox; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID15; - - /** - * @private - * @type {Array} - */ - this.mxmldd; - - /** - * @private - * @type {Array} - */ - this.mxmldp; + goog.base(this); + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.lbl; + + /** + * @private + * @type {org.apache.flex.binding.SimpleBinding} + */ + this.$ID0; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextButton} + */ + this.$ID1; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextButton} + */ + this.$ID2; + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.timerLabel; + + /** + * @private + * @type {org.apache.flex.html.staticControls.List} + */ + this.cityList; + + /** + * @private + * @type {org.apache.flex.binding.ConstantBinding} + */ + this.$ID3; + + /** + * @private + *
Re: [1/4] Initial commit of 'correct' whitespace emission.
It's not picking up the goog.require(StockDataJSONItemConverter). I'm cleaning and rebuilding. Hopefully it will just go away. -Alex On 11/12/13 11:40 AM, Erik de Bruin e...@ixsoftware.nl wrote: It's passing for me, both in Eclipse and from the terminal (OSX 10.9). What is the test complaining about? EdB On Tue, Nov 12, 2013 at 8:07 PM, Alex Harui aha...@adobe.com wrote: I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLAppli ca tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 026a53c72 - dc0c5fe49 http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4bdbf59/compile r. jx.tests/test-files/flexjs/files/MyInitialView_result.js -- diff --git a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js index 2bebadd..5ef10ba 100644 --- a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js +++ b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js @@ -21,157 +21,157 @@ goog.require('org.apache.flex.utils.Timer'); * @extends {org.apache.flex.core.ViewBase} */ MyInitialView = function() { - goog.base(this); - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.lbl; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID0; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID1; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID2; - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.timerLabel; - - /** - * @private - * @type {org.apache.flex.html.staticControls.List} - */ - this.cityList; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID3; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextArea} - */ - this.$ID5; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID4; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextInput} - */ - this.input; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID6; - - /** - * @private - * @type {org.apache.flex.html.staticControls.CheckBox} - */ - this.checkbox; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID7; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID8; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID9; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID10; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID11; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID12; - - /** - * @private - * @type {org.apache.flex.html.staticControls.DropDownList} - */ - this.list; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID13; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID14; - - /** - * @private - * @type {org.apache.flex.html.staticControls.ComboBox} - */ - this.comboBox; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID15; - - /** - * @private - * @type {Array} - */ - this.mxmldd; - - /** - * @private - * @type {Array} - */ - this.mxmldp; + goog.base(this); + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.lbl; + + /** + * @private + * @type {org.apache.flex.binding.SimpleBinding} + */ + this.$ID0; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextButton} + */ + this.$ID1; + + /** + * @private + * @type {org.apache.flex.html.staticControls.TextButton} + */ + this.$ID2; + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.timerLabel; + + /** + * @private + *
Re: [1/4] Initial commit of 'correct' whitespace emission.
Still failing after clean. Interesting, the test says FAILED, but from the command-line it still thinks the build succeeded. But Eclipse definitely knows it failed. I guess I'll have to dig into it. -Alex On 11/12/13 11:52 AM, Alex Harui aha...@adobe.com wrote: It's not picking up the goog.require(StockDataJSONItemConverter). I'm cleaning and rebuilding. Hopefully it will just go away. -Alex On 11/12/13 11:40 AM, Erik de Bruin e...@ixsoftware.nl wrote: It's passing for me, both in Eclipse and from the terminal (OSX 10.9). What is the test complaining about? EdB On Tue, Nov 12, 2013 at 8:07 PM, Alex Harui aha...@adobe.com wrote: I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLAppl i ca tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 026a53c72 - dc0c5fe49 http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4bdbf59/compil e r. jx.tests/test-files/flexjs/files/MyInitialView_result.js -- diff --git a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js index 2bebadd..5ef10ba 100644 --- a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js +++ b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js @@ -21,157 +21,157 @@ goog.require('org.apache.flex.utils.Timer'); * @extends {org.apache.flex.core.ViewBase} */ MyInitialView = function() { - goog.base(this); - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.lbl; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID0; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID1; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID2; - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.timerLabel; - - /** - * @private - * @type {org.apache.flex.html.staticControls.List} - */ - this.cityList; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID3; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextArea} - */ - this.$ID5; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID4; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextInput} - */ - this.input; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID6; - - /** - * @private - * @type {org.apache.flex.html.staticControls.CheckBox} - */ - this.checkbox; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID7; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID8; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID9; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID10; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID11; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID12; - - /** - * @private - * @type {org.apache.flex.html.staticControls.DropDownList} - */ - this.list; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID13; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID14; - - /** - * @private - * @type {org.apache.flex.html.staticControls.ComboBox} - */ - this.comboBox; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID15; - - /** - * @private - * @type {Array} - */ - this.mxmldd; - - /** - * @private - * @type {Array} - */ - this.mxmldp; + goog.base(this); + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.lbl; + + /** + * @private + * @type {org.apache.flex.binding.SimpleBinding} + */ + this.$ID0; + + /** + * @private + * @type
Re: [1/4] Initial commit of 'correct' whitespace emission.
Yes, that's the one that I wrestled with the past couple of days. The fix was to change a path to the latest flex-asjs... Peter renamed one of the examples and the test uses a hard coded path to it. EdB On Tue, Nov 12, 2013 at 8:52 PM, Alex Harui aha...@adobe.com wrote: It's not picking up the goog.require(StockDataJSONItemConverter). I'm cleaning and rebuilding. Hopefully it will just go away. -Alex On 11/12/13 11:40 AM, Erik de Bruin e...@ixsoftware.nl wrote: It's passing for me, both in Eclipse and from the terminal (OSX 10.9). What is the test complaining about? EdB On Tue, Nov 12, 2013 at 8:07 PM, Alex Harui aha...@adobe.com wrote: I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLAppli ca tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 026a53c72 - dc0c5fe49 http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4bdbf59/compile r. jx.tests/test-files/flexjs/files/MyInitialView_result.js -- diff --git a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js index 2bebadd..5ef10ba 100644 --- a/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js +++ b/compiler.jx.tests/test-files/flexjs/files/MyInitialView_result.js @@ -21,157 +21,157 @@ goog.require('org.apache.flex.utils.Timer'); * @extends {org.apache.flex.core.ViewBase} */ MyInitialView = function() { - goog.base(this); - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.lbl; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID0; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID1; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID2; - - /** - * @private - * @type {org.apache.flex.html.staticControls.Label} - */ - this.timerLabel; - - /** - * @private - * @type {org.apache.flex.html.staticControls.List} - */ - this.cityList; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID3; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextArea} - */ - this.$ID5; - - /** - * @private - * @type {org.apache.flex.binding.SimpleBinding} - */ - this.$ID4; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextInput} - */ - this.input; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID6; - - /** - * @private - * @type {org.apache.flex.html.staticControls.CheckBox} - */ - this.checkbox; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID7; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID8; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID9; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID10; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID11; - - /** - * @private - * @type {org.apache.flex.html.staticControls.RadioButton} - */ - this.$ID12; - - /** - * @private - * @type {org.apache.flex.html.staticControls.DropDownList} - */ - this.list; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID13; - - /** - * @private - * @type {org.apache.flex.html.staticControls.TextButton} - */ - this.$ID14; - - /** - * @private - * @type {org.apache.flex.html.staticControls.ComboBox} - */ - this.comboBox; - - /** - * @private - * @type {org.apache.flex.binding.ConstantBinding} - */ - this.$ID15; - - /** - * @private - * @type {Array} - */ - this.mxmldd; - - /** - * @private - * @type {Array} - */ - this.mxmldp; + goog.base(this); + + /** + * @private + * @type {org.apache.flex.html.staticControls.Label} + */ + this.lbl; + + /** + * @private + * @type {org.apache.flex.binding.SimpleBinding} + */ + this.$ID0; + + /** + * @private + * @type