Re: [3/3] git commit: [flex-falcon] [refs/heads/develop] - Fix tests to use '[qname].base' instead of 'goog.base'.

2014-06-25 Thread Alex Harui 
Thanks for doing this!

Do you have time to upgrade the GCL on the builds machine?  I don't have
my windows machine handy and VMWare is painful slow.  Or maybe you did it
already, I haven't checked.

Thanks,
-Alex

On 6/25/14 8:38 AM, erikdebr...@apache.org erikdebr...@apache.org
wrote:

Fix tests to use '[qname].base' instead of 'goog.base'.

Signed-off-by: Erik de Bruin e...@ixsoftware.nl


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/3438a56e
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/3438a56e
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/3438a56e

Branch: refs/heads/develop
Commit: 3438a56ec28fe7a20a827c24a88867ff56b05671
Parents: 507d5eb
Author: Erik de Bruin e...@ixsoftware.nl
Authored: Wed Jun 25 17:32:49 2014 +0200
Committer: Erik de Bruin e...@ixsoftware.nl
Committed: Wed Jun 25 17:32:49 2014 +0200

--
 .../js/flexjs/TestFlexJSAccessorMembers.java|  4 ++--
 .../codegen/js/flexjs/TestFlexJSClass.java  | 20 ++--
 .../codegen/js/flexjs/TestFlexJSEmiter.java |  2 +-
 .../js/flexjs/TestFlexJSExpressions.java|  4 ++--
 .../js/goog/TestGoogAccessorMembers.java|  4 ++--
 .../internal/codegen/js/goog/TestGoogClass.java | 16 
 .../codegen/js/goog/TestGoogEmiter.java |  2 +-
 .../codegen/js/goog/TestGoogExpressions.java|  4 ++--
 .../flexjs/files/FlexJSTest_again_result.js |  4 ++--
 .../flexjs/files/MyInitialView_result.js|  4 ++--
 .../flexjs/files/models/MyModel_result.js   |  2 +-
 .../flexjs/files/wildcard_import_result.js  |  2 +-
 .../flexjs/projects/interfaces/Test_result.js   |  2 +-
 .../projects/interfaces/classes/A_result.js |  2 +-
 .../flexjs/projects/super/Base_result.js|  8 
 .../test-files/goog/files/call-super_result.js  |  4 ++--
 .../test-files/goog/files/output.js |  2 +-
 .../test-files/goog/files/poc_result.js |  2 +-
 .../goog/files/qualify-new-object_result.js |  2 +-
 19 files changed, 45 insertions(+), 45 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3438a56e/compiler.
jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJ
SAccessorMembers.java
--
diff --git 
a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSAccessorMembers.java
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSAccessorMembers.java
index bddaeab..0d40229 100644
--- 
a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSAccessorMembers.java
+++ 
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSAccessorMembers.java
@@ -64,7 +64,7 @@ public class TestFlexJSAccessorMembers extends
TestGoogAccessorMembers
 {
 IGetterNode node = (IGetterNode) getAccessor(public override
function get foo():int{super.foo(); return -1;});
 asBlockWalker.visitGetter(node);
-assertOut(/**\n * @expose\n * @return {number}\n * @override\n
*/\nFalconTest_A.prototype.get_foo = function() {\n  goog.base(this,
'get_foo');\n  return -1;\n});
+assertOut(/**\n * @expose\n * @return {number}\n * @override\n
*/\nFalconTest_A.prototype.get_foo = function() {\n
FalconTest_A.base(this, 'get_foo');\n  return -1;\n});
 }
 
 @Override
@@ -109,7 +109,7 @@ public class TestFlexJSAccessorMembers extends
TestGoogAccessorMembers
 {
 ISetterNode node = (ISetterNode) getAccessor(public override
function set foo(value:int):void{super.foo();});
 asBlockWalker.visitSetter(node);
-assertOut(/**\n * @expose\n * @param {number} value\n *
@override\n */\nFalconTest_A.prototype.set_foo = function(value) {\n
goog.base(this, 'set_foo');\n});
+assertOut(/**\n * @expose\n * @param {number} value\n *
@override\n */\nFalconTest_A.prototype.set_foo = function(value) {\n
FalconTest_A.base(this, 'set_foo');\n});
 }
 
 @Override

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3438a56e/compiler.
jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJ
SClass.java
--
diff --git 
a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSClass.java
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSClass.java
index 4a45d10..1d2ac89 100644
--- 
a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSClass.java
+++ 
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexj
s/TestFlexJSClass.java
@@ -46,7 +46,7 @@ public class TestFlexJSClass extends

Re: [3/3] git commit: [flex-falcon] [refs/heads/develop] - Fix tests to use '[qname].base' instead of 'goog.base'.

2014-06-25 Thread Alex Harui 
OK. I'll try to find time for that unless you have time.

Let me know,
-Alex

On 6/25/14 10:35 AM, Erik de Bruin e...@ixsoftware.nl wrote:

I say we try to 'auto-update'. One of the reasons for using CI is to be
alerted to new issues as soon as possible. The GC Compiler and Library are
constantly being developed to keep up with the newest standards, browsers
and JS VMs, and our framework should as well.

EdB




On Wed, Jun 25, 2014 at 7:22 PM, Alex Harui aha...@adobe.com wrote:

 Awesome, thanks.

 As you may have noted, the build/install script does not pull down the
 latest GCL.  Do you think we should?  I think we've been burned by this
in
 the past when they make some incompatible change.  Right now, we'll end
up
 bundling some known good version the RM is using.

 Thoughts?
 -Alex

 From: Erik de Bruin e...@ixsoftware.nlmailto:e...@ixsoftware.nl
 Reply-To: d...@flex.apache.orgmailto:d...@flex.apache.org 
 d...@flex.apache.orgmailto:d...@flex.apache.org
 Date: Wednesday, June 25, 2014 10:04 AM
 To: d...@flex.apache.orgmailto:d...@flex.apache.org
d...@flex.apache.org
 mailto:d...@flex.apache.org
 Cc: commits@flex.apache.orgmailto:commits@flex.apache.org 
 commits@flex.apache.orgmailto:commits@flex.apache.org
 Subject: Re: [3/3] git commit: [flex-falcon] [refs/heads/develop] - Fix
 tests to use '[qname].base' instead of 'goog.base'.

 Done.

 EdB




 On Wed, Jun 25, 2014 at 6:53 PM, Erik de Bruin
e...@ixsoftware.nlmailto:
 e...@ixsoftware.nl wrote:
 On it.

 EdB




 On Wed, Jun 25, 2014 at 6:13 PM, Alex Harui aha...@adobe.commailto:
 aha...@adobe.com wrote:
 Thanks for doing this!

 Do you have time to upgrade the GCL on the builds machine?  I don't have
 my windows machine handy and VMWare is painful slow.  Or maybe you did
it
 already, I haven't checked.

 Thanks,
 -Alex

 On 6/25/14 8:38 AM,
erikdebr...@apache.orgmailto:erikdebr...@apache.org
 erikdebr...@apache.orgmailto:erikdebr...@apache.org
 wrote:

 Fix tests to use '[qname].base' instead of 'goog.base'.
 
 Signed-off-by: Erik de Bruin e...@ixsoftware.nlmailto:
 e...@ixsoftware.nl
 
 
 Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
 Commit:
 http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/3438a56e
 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/3438a56e
 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/3438a56e
 
 Branch: refs/heads/develop
 Commit: 3438a56ec28fe7a20a827c24a88867ff56b05671
 Parents: 507d5eb
 Author: Erik de Bruin e...@ixsoftware.nlmailto:e...@ixsoftware.nl
 Authored: Wed Jun 25 17:32:49 2014 +0200
 Committer: Erik de Bruin
e...@ixsoftware.nlmailto:e...@ixsoftware.nl
 Committed: Wed Jun 25 17:32:49 2014 +0200
 
 --
  .../js/flexjs/TestFlexJSAccessorMembers.java|  4 ++--
  .../codegen/js/flexjs/TestFlexJSClass.java  | 20
++--
  .../codegen/js/flexjs/TestFlexJSEmiter.java |  2 +-
  .../js/flexjs/TestFlexJSExpressions.java|  4 ++--
  .../js/goog/TestGoogAccessorMembers.java|  4 ++--
  .../internal/codegen/js/goog/TestGoogClass.java | 16 
  .../codegen/js/goog/TestGoogEmiter.java |  2 +-
  .../codegen/js/goog/TestGoogExpressions.java|  4 ++--
  .../flexjs/files/FlexJSTest_again_result.js |  4 ++--
  .../flexjs/files/MyInitialView_result.js|  4 ++--
  .../flexjs/files/models/MyModel_result.js   |  2 +-
  .../flexjs/files/wildcard_import_result.js  |  2 +-
  .../flexjs/projects/interfaces/Test_result.js   |  2 +-
  .../projects/interfaces/classes/A_result.js |  2 +-
  .../flexjs/projects/super/Base_result.js|  8 
  .../test-files/goog/files/call-super_result.js  |  4 ++--
  .../test-files/goog/files/output.js |  2 +-
  .../test-files/goog/files/poc_result.js |  2 +-
  .../goog/files/qualify-new-object_result.js |  2 +-
  19 files changed, 45 insertions(+), 45 deletions(-)
 --
 
 
 
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3438a56e/compile
r
 .
 
jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFle
xJ
 SAccessorMembers.java
 --
 diff --git
 
a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/fle
xj
 s/TestFlexJSAccessorMembers.java
 
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/fle
xj
 s/TestFlexJSAccessorMembers.java
 index bddaeab..0d40229 100644
 ---
 
a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/fle
xj
 s/TestFlexJSAccessorMembers.java
 +++
 
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/fle
xj
 s/TestFlexJSAccessorMembers.java
 @@ -64,7 +64,7 @@ public class TestFlexJSAccessorMembers extends
 TestGoogAccessorMembers
  {
  IGetterNode node = (IGetterNode) getAccessor(public override
 function get foo():int