Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function
Hi again! Last week I have got the assets documentation from the sales branch. Could you please check it? I have uploaded it lower: https://onedrive.live.com/download?cid=82EF47538A1E39FE=82EF47538A1E39FE%21110=AAuVbDhXC9vn8jo File password: RP5687 Hi Harbs, Thanks for adding it - That may be really helpful. I think you should consider move it to one of the folder to Basic: accessories or supportClasses. If you could also add version when it was introduced etc. What do you think? Thanks, Piotr On Sun, Aug 27, 2017, 06:43 <> wrote: > Repository: flex-asjs > Updated Branches: > refs/heads/develop 5b8f1c589 -> daca90f9e > > > Added helper function > > > Project: git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit: git-wip-us.apache.org/repos/asf/flex-asjs/commit/daca90f9 > Tree: git-wip-us.apache.org/repos/asf/flex-asjs/tree/daca90f9 > Diff: git-wip-us.apache.org/repos/asf/flex-asjs/diff/daca90f9 > > Branch: refs/heads/develop > Commit: daca90f9e688a3ac79edd569f759df2b5ba89b80 > Parents: 5b8f1c5 > Author: Harbs <> > Authored: Sun Aug 27 07:43:25 2017 +0300 > Committer: Harbs <> > Committed: Sun Aug 27 07:43:25 2017 +0300 > > -- > .../Basic/src/main/flex/BasicClasses.as | 4 > .../org/apache/flex/html/addElementToWrapper.as | 20 > 2 files changed, 24 insertions(+) > -- > > > > git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/BasicClasses.as > -- > diff --git a/frameworks/projects/Basic/src/main/flex/BasicClasses.as > b/frameworks/projects/Basic/src/main/flex/BasicClasses.as > index 697efa8..bc62158 100644 > --- a/frameworks/projects/Basic/src/main/flex/BasicClasses.as > +++ b/frameworks/projects/Basic/src/main/flex/BasicClasses.as > @@ -27,6 +27,10 @@ package > */ > internal class BasicClasses > { > + COMPILE::JS > + { > + import org.apache.flex.html.addElementToWrapper; > addElementToWrapper; > + } > import org.apache.flex.html.ToolTip; ToolTip; > import org.apache.flex.html.accessories.NumericOnlyTextInputBead; > NumericOnlyTextInputBead; > import org.apache.flex.html.beads.DispatchInputFinishedBead; > DispatchInputFinishedBead; > > > git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > -- > diff --git > a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > new file mode 100644 > index 000..0c4427c > --- /dev/null > +++ > b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > @@ -0,0 +1,20 @@ > +package org.apache.flex.html > +{ > +COMPILE::JS > +{ > +import org.apache.flex.core.UIBase; > +import org.apache.flex.core.WrappedHTMLElement; > +} > + > +/** > + * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement > + */ > +COMPILE::JS > +public function > addElementToWrapper(wrapper:UIBase,type:String):WrappedHTMLElement > +{ > +var elem:WrappedHTMLElement = document.createElement(type) as > WrappedHTMLElement; > + wrapper.positioner = wrapper.element = elem; > + elem.flexjs_wrapper = wrapper; > +return elem; > +} > +} > \ No newline at end of file > >
Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function
Hi Harbs, Thanks for adding it - That may be really helpful. I think you should consider move it to one of the folder to Basic: accessories or supportClasses. If you could also add version when it was introduced etc. What do you think? Thanks, Piotr On Sun, Aug 27, 2017, 06:43wrote: > Repository: flex-asjs > Updated Branches: > refs/heads/develop 5b8f1c589 -> daca90f9e > > > Added helper function > > > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/daca90f9 > Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/daca90f9 > Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/daca90f9 > > Branch: refs/heads/develop > Commit: daca90f9e688a3ac79edd569f759df2b5ba89b80 > Parents: 5b8f1c5 > Author: Harbs > Authored: Sun Aug 27 07:43:25 2017 +0300 > Committer: Harbs > Committed: Sun Aug 27 07:43:25 2017 +0300 > > -- > .../Basic/src/main/flex/BasicClasses.as | 4 > .../org/apache/flex/html/addElementToWrapper.as | 20 > 2 files changed, 24 insertions(+) > -- > > > > http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/BasicClasses.as > -- > diff --git a/frameworks/projects/Basic/src/main/flex/BasicClasses.as > b/frameworks/projects/Basic/src/main/flex/BasicClasses.as > index 697efa8..bc62158 100644 > --- a/frameworks/projects/Basic/src/main/flex/BasicClasses.as > +++ b/frameworks/projects/Basic/src/main/flex/BasicClasses.as > @@ -27,6 +27,10 @@ package > */ > internal class BasicClasses > { > + COMPILE::JS > + { > + import org.apache.flex.html.addElementToWrapper; > addElementToWrapper; > + } > import org.apache.flex.html.ToolTip; ToolTip; > import org.apache.flex.html.accessories.NumericOnlyTextInputBead; > NumericOnlyTextInputBead; > import org.apache.flex.html.beads.DispatchInputFinishedBead; > DispatchInputFinishedBead; > > > http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > -- > diff --git > a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > new file mode 100644 > index 000..0c4427c > --- /dev/null > +++ > b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as > @@ -0,0 +1,20 @@ > +package org.apache.flex.html > +{ > +COMPILE::JS > +{ > +import org.apache.flex.core.UIBase; > +import org.apache.flex.core.WrappedHTMLElement; > +} > + > +/** > + * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement > + */ > +COMPILE::JS > +public function > addElementToWrapper(wrapper:UIBase,type:String):WrappedHTMLElement > +{ > +var elem:WrappedHTMLElement = document.createElement(type) as > WrappedHTMLElement; > + wrapper.positioner = wrapper.element = elem; > + elem.flexjs_wrapper = wrapper; > +return elem; > +} > +} > \ No newline at end of file > >
git commit: [flex-asjs] [refs/heads/develop] - Added helper function
Repository: flex-asjs Updated Branches: refs/heads/develop 5b8f1c589 -> daca90f9e Added helper function Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/daca90f9 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/daca90f9 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/daca90f9 Branch: refs/heads/develop Commit: daca90f9e688a3ac79edd569f759df2b5ba89b80 Parents: 5b8f1c5 Author: HarbsAuthored: Sun Aug 27 07:43:25 2017 +0300 Committer: Harbs Committed: Sun Aug 27 07:43:25 2017 +0300 -- .../Basic/src/main/flex/BasicClasses.as | 4 .../org/apache/flex/html/addElementToWrapper.as | 20 2 files changed, 24 insertions(+) -- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/BasicClasses.as -- diff --git a/frameworks/projects/Basic/src/main/flex/BasicClasses.as b/frameworks/projects/Basic/src/main/flex/BasicClasses.as index 697efa8..bc62158 100644 --- a/frameworks/projects/Basic/src/main/flex/BasicClasses.as +++ b/frameworks/projects/Basic/src/main/flex/BasicClasses.as @@ -27,6 +27,10 @@ package */ internal class BasicClasses { + COMPILE::JS + { + import org.apache.flex.html.addElementToWrapper; addElementToWrapper; + } import org.apache.flex.html.ToolTip; ToolTip; import org.apache.flex.html.accessories.NumericOnlyTextInputBead; NumericOnlyTextInputBead; import org.apache.flex.html.beads.DispatchInputFinishedBead; DispatchInputFinishedBead; http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as -- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as new file mode 100644 index 000..0c4427c --- /dev/null +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as @@ -0,0 +1,20 @@ +package org.apache.flex.html +{ +COMPILE::JS +{ +import org.apache.flex.core.UIBase; +import org.apache.flex.core.WrappedHTMLElement; +} + +/** + * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement + */ +COMPILE::JS +public function addElementToWrapper(wrapper:UIBase,type:String):WrappedHTMLElement +{ +var elem:WrappedHTMLElement = document.createElement(type) as WrappedHTMLElement; + wrapper.positioner = wrapper.element = elem; + elem.flexjs_wrapper = wrapper; +return elem; +} +} \ No newline at end of file