Re: [PR] feat: add a script to automatically generate doc [incubator-fury]

2024-05-25 Thread via GitHub


LiangliangSui commented on PR #1648:
URL: https://github.com/apache/incubator-fury/pull/1648#issuecomment-2131370945

   Do you have any other suggestions for generating Tables based on Fields and 
writing them to `java_serialization_guide.md`? @chaokunyang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org



Re: [PR] feat: add a script to automatically generate doc [incubator-fury]

2024-05-25 Thread via GitHub


LiangliangSui commented on PR #1648:
URL: https://github.com/apache/incubator-fury/pull/1648#issuecomment-2131370462

   > Could we use parse javadoc html instead?
   
   Good suggestion!
   
   It can be implemented by parsing javadoc html. Even if it is implemented by 
parsing html, we need to clearly point out which config fields are in the 
comments. 
   
   In addition, we need to clearly point out the defaultValue in the comments 
of each filed, because it will not be included in javadoc. The true default 
value of the field (for example, `false` in `boolean enable = false` will not 
appear in the javadoc html)
   
   Our config field comments can be designed in the following format?
   
   ```
   /**
* x
*
* @defaultValue: 
*/
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org



Re: [PR] feat: add a script to automatically generate doc [incubator-fury]

2024-05-25 Thread via GitHub


chaokunyang commented on PR #1648:
URL: https://github.com/apache/incubator-fury/pull/1648#issuecomment-2131330247

   Could we use parse javadoc html instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org



Re: [PR] feat(java): support nonexistent class deserialization in meta share mode [incubator-fury]

2024-05-25 Thread via GitHub


chaokunyang commented on PR #1646:
URL: https://github.com/apache/incubator-fury/pull/1646#issuecomment-2131319006

   Hi @theweipeng @PragmaTwice @LiangliangSui , this PR is ready for review, 
could you help review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org



[GH] (incubator-fury): Workflow run "Fury CI" is working again!

2024-05-25 Thread GitBox


The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded.
Run started by GitHub user chaokunyang (triggered by chaokunyang).

Head commit for run:
8e3fcf8acab9e645c18121e6b822527b36130e9c / chaokunyang 
format code

Report URL: https://github.com/apache/incubator-fury/actions/runs/9236558714

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org



[GH] (incubator-fury): Workflow run "Fury CI" failed!

2024-05-25 Thread GitBox


The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).

Head commit for run:
d810129dd72a889e070a1e59b97e8e5c74d75197 / chaokunyang 
format code

Report URL: https://github.com/apache/incubator-fury/actions/runs/9236534055

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org



[GH] (incubator-fury): Workflow run "Fury CI" failed!

2024-05-25 Thread GitBox


The GitHub Actions job "Fury CI" on incubator-fury.git has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).

Head commit for run:
9969f00041b114e791b4b08afeb723294ee3a1c6 / chaokunyang 
fix array type encoding

Report URL: https://github.com/apache/incubator-fury/actions/runs/9236524210

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org