Re: [PR] chore(java): add comments for loop unrolling. [incubator-fury]

[via GitHub]

chaokunyang merged PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org

Re: [PR] chore(java): add comments for loop unrolling. [incubator-fury]

[via GitHub]

LiangliangSui commented on PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2041108710

   > @LiangliangSui There are some conflict between your branch and main 
branch, could you resolve the conflict?
   
   Updated, ptal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org

Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]

[via GitHub]

chaokunyang commented on PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2040991342

   @LiangliangSui There are some conflict between your branch and main branch, 
could you resolve the conflict?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org

Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]

[via GitHub]

chaokunyang commented on code in PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1554535283


##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1316,24 +1316,15 @@ public int readPositiveVarInt() {
   }
 
   private int readPositiveVarIntSlow() {
-int b = readByte();
-int result = b & 0x7F;
-if ((b & 0x80) != 0) {
+int shift = 0;

Review Comment:
   I don't think it's necessary, only rolling code will be used in the release



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org

Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]

[via GitHub]

LiangliangSui commented on code in PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1549004814


##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1316,24 +1316,15 @@ public int readPositiveVarInt() {
   }
 
   private int readPositiveVarIntSlow() {
-int b = readByte();
-int result = b & 0x7F;
-if ((b & 0x80) != 0) {
+int shift = 0;

Review Comment:
   Updated.
   
   BTW, do we need to add the benchmark code (sample code above) that uses loop 
and does not use loop in the `MemoryBuffer#readPositiveVarIntSlow` method to 
the benchmark directory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org