Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
chaokunyang commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041468628 Ok, we can keep the issue open. If the demand for registering classes on FuryBuilder continues grow, we can support it later. And all similar methods such as setClassChecker/setSerializerFactory have similar issues. We should take those API into consideration too. I believe we will receive more feedbacks when we made several releases under ASF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
LiangliangSui commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041464995 It is also possible to use `BaseFury` to register classes and Serializers, but these steps need to be done after Fury build. It is best to register during the FuryBuilder build process, but currently, this will cause the overall structure to be very heavy (in order to achieve this function will lead to architectural redundancy). Currently, only one user has made this suggestion. We can also observe whether other users make this suggestion in the future. If so, we will consider adjusting the structure to implement this function. We can keep this issue for continuous observation to see if there are any similar suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
chaokunyang commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041458551 I still don't know why users can't invoke `BaseFury` to register a class/serializer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
LiangliangSui commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041296983 I agree with you, `Fury` and `ClassRegister` have a `has-a` relationship. If we don't implement some interfaces in `FuryBuilder`, then we can only repeatedly define the registerXXX function, or do you have some other good suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
chaokunyang commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041287630 I perfer not. `Fury` is not a `ClassRegister`, there is no such a straightforward `is-a` relationship between these two classes. And it's not that intuitive for a builder class to implement some interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
LiangliangSui commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2041122588 > One concern is that BaseFury already supports register classes/serializers, do we still need to add this API to FuryBuilder? We can extract all `register(...)` methods in `BaseFury` into an interface, for example named `ClassRegister`, and then let `BaseFury` extends `ClassRegister`, and `FuryBuilder` can also implements `ClassRegister`. `registerSerializer(...)` is similar, we can extract an interface named `SerializerRegister`. WDYT? @chaokunyang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
chaokunyang commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2037560969 One concern I have is that BaseFury already supports register classes/serializers, do we still need to add this API to FuryBuilder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] FuryBuilder supports registered classes [incubator-fury]
chaokunyang commented on issue #1459: URL: https://github.com/apache/incubator-fury/issues/1459#issuecomment-2037434457 Looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
