[geode] 01/06: GEODE-9817: Enable customized source set paths for ClassAnalysisRule (#7121)

2022-03-30 Thread klund
This is an automated email from the ASF dual-hosted git repository.

klund pushed a commit to branch support/1.13
in repository https://gitbox.apache.org/repos/asf/geode.git

commit cc17b3d8a12c0f79179a979debc6832693555010
Author: Kirk Lund 
AuthorDate: Thu Nov 18 16:23:36 2021 -0800

GEODE-9817: Enable customized source set paths for ClassAnalysisRule (#7121)

Adds support for customizing source set paths of ClassAnalysisRule.

PROBLEM

Modules external to Geode must be structured the same as Geode
source code in order to use ClassAnalysisRule and the
Analyze*Serializables tests. This is necessary to better facilitate
pluggability of modules that need to provide sanctioned serializable
lists.

SOLUTION

Add source set path customization to ClassAnalysisRule, introduce
a new layer of Analyze*Serializables test base classes that can be
directly extended in order to customize source set paths in
ClassAnalysisRule. Also includes improvements to some iterating
of classes during analysis.

(cherry picked from commit 5d1e91932dff296632916a6ceccfb36039357acd)
---
 ...lyzeConnectorsSerializablesIntegrationTest.java |  2 +-
 .../AnalyzeCoreSerializablesIntegrationTest.java   |  3 +-
 .../AnalyzeCQSerializablesIntegrationTest.java |  3 +-
 .../AnalyzeDUnitSerializablesIntegrationTest.java  |  4 +-
 .../AnalyzeGfshSerializablesIntegrationTest.java   |  3 +-
 .../AnalyzeJUnitSerializablesIntegrationTest.java  |  3 +-
 java => AnalyzeDataSerializablesTestBase.java} | 74 ++
 ...SerializablesWithClassAnalysisRuleTestBase.java | 27 
 ...Base.java => AnalyzeSerializablesTestBase.java} | 41 
 ...SerializablesWithClassAnalysisRuleTestBase.java | 24 ---
 ...nedSerializablesServiceIntegrationTestBase.java |  6 +-
 .../geode/test/junit/rules/ClassAnalysisRule.java  | 23 ---
 .../AnalyzeLuceneSerializablesIntegrationTest.java |  3 +-
 ...lyzeManagementSerializablesIntegrationTest.java |  2 +-
 ...lyzeMembershipSerializablesIntegrationTest.java |  2 +-
 ...alyzeMemcachedSerializablesIntegrationTest.java |  2 +-
 .../AnalyzePulseSerializablesIntegrationTest.java  |  3 +-
 .../AnalyzeRedisSerializablesIntegrationTest.java  |  3 +-
 ...eSerializationSerializablesIntegrationTest.java |  2 +-
 .../AnalyzeWANSerializablesIntegrationTest.java|  3 +-
 .../AnalyzeWebApiSerializablesIntegrationTest.java |  3 +-
 21 files changed, 134 insertions(+), 102 deletions(-)

diff --git 
a/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
 
b/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
index a5fa5a1..db50c2f 100644
--- 
a/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
+++ 
b/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
@@ -23,7 +23,7 @@ import 
org.apache.geode.test.junit.categories.SerializationTest;
 
 @Category(SerializationTest.class)
 public class AnalyzeConnectorsSerializablesIntegrationTest
-extends AnalyzeSerializablesJUnitTestBase {
+extends AnalyzeSerializablesWithClassAnalysisRuleTestBase {
 
   @Override
   protected String getModuleName() {
diff --git 
a/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
 
b/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
index 6832442..d93d8d1 100755
--- 
a/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
+++ 
b/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
@@ -22,7 +22,8 @@ import 
org.apache.geode.internal.CoreSanctionedSerializablesService;
 import org.apache.geode.test.junit.categories.SerializationTest;
 
 @Category(SerializationTest.class)
-public class AnalyzeCoreSerializablesIntegrationTest extends 
AnalyzeSerializablesJUnitTestBase {
+public class AnalyzeCoreSerializablesIntegrationTest
+extends AnalyzeSerializablesWithClassAnalysisRuleTestBase {
 
   @Override
   protected String getModuleName() {
diff --git 
a/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
 
b/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
index 96c036a..3235c7b 100755
--- 
a/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
+++ 
b/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
@@ -23,7 +23,8 @@ import 
org.apache.geode.test.junit.categories.ClientSubscriptionTest;
 import org.apache.geode.test

[geode] 01/06: GEODE-9817: Enable customized source set paths for ClassAnalysisRule (#7121)

2022-03-30 Thread klund
This is an automated email from the ASF dual-hosted git repository.

klund pushed a commit to branch support/1.12
in repository https://gitbox.apache.org/repos/asf/geode.git

commit 3a211774c34a33697de4bceca2baad2ff0229d82
Author: Kirk Lund 
AuthorDate: Thu Nov 18 16:23:36 2021 -0800

GEODE-9817: Enable customized source set paths for ClassAnalysisRule (#7121)

Adds support for customizing source set paths of ClassAnalysisRule.

PROBLEM

Modules external to Geode must be structured the same as Geode
source code in order to use ClassAnalysisRule and the
Analyze*Serializables tests. This is necessary to better facilitate
pluggability of modules that need to provide sanctioned serializable
lists.

SOLUTION

Add source set path customization to ClassAnalysisRule, introduce
a new layer of Analyze*Serializables test base classes that can be
directly extended in order to customize source set paths in
ClassAnalysisRule. Also includes improvements to some iterating
of classes during analysis.

(cherry picked from commit 5d1e91932dff296632916a6ceccfb36039357acd)
---
 ...lyzeConnectorsSerializablesIntegrationTest.java |  2 +-
 .../AnalyzeCoreSerializablesIntegrationTest.java   |  3 +-
 .../AnalyzeCQSerializablesIntegrationTest.java |  3 +-
 .../AnalyzeDUnitSerializablesIntegrationTest.java  |  4 +-
 .../AnalyzeGfshSerializablesIntegrationTest.java   |  3 +-
 .../AnalyzeJUnitSerializablesIntegrationTest.java  |  3 +-
 java => AnalyzeDataSerializablesTestBase.java} | 74 ++
 ...SerializablesWithClassAnalysisRuleTestBase.java | 27 
 ...Base.java => AnalyzeSerializablesTestBase.java} | 41 
 ...SerializablesWithClassAnalysisRuleTestBase.java | 24 ---
 ...nedSerializablesServiceIntegrationTestBase.java |  6 +-
 .../geode/test/junit/rules/ClassAnalysisRule.java  | 23 ---
 .../AnalyzeLuceneSerializablesIntegrationTest.java |  3 +-
 ...lyzeManagementSerializablesIntegrationTest.java |  2 +-
 ...lyzeMembershipSerializablesIntegrationTest.java |  2 +-
 ...alyzeMemcachedSerializablesIntegrationTest.java |  2 +-
 .../AnalyzePulseSerializablesIntegrationTest.java  |  3 +-
 .../AnalyzeRedisSerializablesIntegrationTest.java  |  3 +-
 ...eSerializationSerializablesIntegrationTest.java |  2 +-
 .../AnalyzeWANSerializablesIntegrationTest.java|  3 +-
 .../AnalyzeWebApiSerializablesIntegrationTest.java |  3 +-
 21 files changed, 134 insertions(+), 102 deletions(-)

diff --git 
a/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
 
b/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
index a5fa5a1..db50c2f 100644
--- 
a/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
+++ 
b/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
@@ -23,7 +23,7 @@ import 
org.apache.geode.test.junit.categories.SerializationTest;
 
 @Category(SerializationTest.class)
 public class AnalyzeConnectorsSerializablesIntegrationTest
-extends AnalyzeSerializablesJUnitTestBase {
+extends AnalyzeSerializablesWithClassAnalysisRuleTestBase {
 
   @Override
   protected String getModuleName() {
diff --git 
a/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
 
b/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
index 6832442..d93d8d1 100755
--- 
a/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
+++ 
b/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
@@ -22,7 +22,8 @@ import 
org.apache.geode.internal.CoreSanctionedSerializablesService;
 import org.apache.geode.test.junit.categories.SerializationTest;
 
 @Category(SerializationTest.class)
-public class AnalyzeCoreSerializablesIntegrationTest extends 
AnalyzeSerializablesJUnitTestBase {
+public class AnalyzeCoreSerializablesIntegrationTest
+extends AnalyzeSerializablesWithClassAnalysisRuleTestBase {
 
   @Override
   protected String getModuleName() {
diff --git 
a/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
 
b/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
index 96c036a..3235c7b 100755
--- 
a/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
+++ 
b/geode-cq/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCQSerializablesIntegrationTest.java
@@ -23,7 +23,8 @@ import 
org.apache.geode.test.junit.categories.ClientSubscriptionTest;
 import org.apache.geode.test

[geode] 01/06: GEODE-9817: Enable customized source set paths for ClassAnalysisRule (#7121)

2022-03-29 Thread klund
This is an automated email from the ASF dual-hosted git repository.

klund pushed a commit to branch support/1.14
in repository https://gitbox.apache.org/repos/asf/geode.git

commit 31375b759fcfa91d7df9749f3ffc556fa57f9d65
Author: Kirk Lund 
AuthorDate: Thu Nov 18 16:23:36 2021 -0800

GEODE-9817: Enable customized source set paths for ClassAnalysisRule (#7121)

Adds support for customizing source set paths of ClassAnalysisRule.

PROBLEM

Modules external to Geode must be structured the same as Geode
source code in order to use ClassAnalysisRule and the
Analyze*Serializables tests. This is necessary to better facilitate
pluggability of modules that need to provide sanctioned serializable
lists.

SOLUTION

Add source set path customization to ClassAnalysisRule, introduce
a new layer of Analyze*Serializables test base classes that can be
directly extended in order to customize source set paths in
ClassAnalysisRule. Also includes improvements to some iterating
of classes during analysis.

(cherry picked from commit 5d1e91932dff296632916a6ceccfb36039357acd)
---
 .../AnalyzeRedisSerializablesIntegrationTest.java  |  3 +-
 ...lyzeConnectorsSerializablesIntegrationTest.java |  2 +-
 .../AnalyzeCoreSerializablesIntegrationTest.java   |  3 +-
 .../AnalyzeCQSerializablesIntegrationTest.java |  3 +-
 .../AnalyzeDUnitSerializablesIntegrationTest.java  |  4 +-
 .../AnalyzeGfshSerializablesIntegrationTest.java   |  3 +-
 .../AnalyzeJUnitSerializablesIntegrationTest.java  |  3 +-
 java => AnalyzeDataSerializablesTestBase.java} | 74 ++
 ...SerializablesWithClassAnalysisRuleTestBase.java | 26 
 ...Base.java => AnalyzeSerializablesTestBase.java} | 41 
 ...SerializablesWithClassAnalysisRuleTestBase.java | 23 ---
 ...nedSerializablesServiceIntegrationTestBase.java |  6 +-
 .../geode/test/junit/rules/ClassAnalysisRule.java  | 23 ---
 .../AnalyzeLuceneSerializablesIntegrationTest.java |  3 +-
 ...lyzeManagementSerializablesIntegrationTest.java |  2 +-
 ...lyzeMembershipSerializablesIntegrationTest.java |  2 +-
 ...alyzeMemcachedSerializablesIntegrationTest.java |  2 +-
 .../AnalyzePulseSerializablesIntegrationTest.java  |  3 +-
 ...eSerializationSerializablesIntegrationTest.java |  2 +-
 .../AnalyzeWANSerializablesIntegrationTest.java|  3 +-
 .../AnalyzeWebApiSerializablesIntegrationTest.java |  3 +-
 21 files changed, 134 insertions(+), 100 deletions(-)

diff --git 
a/geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeRedisSerializablesIntegrationTest.java
 
b/geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeRedisSerializablesIntegrationTest.java
index 7c89c5b..36efe19 100755
--- 
a/geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeRedisSerializablesIntegrationTest.java
+++ 
b/geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeRedisSerializablesIntegrationTest.java
@@ -22,7 +22,8 @@ import 
org.apache.geode.redis.internal.RedisSanctionedSerializablesService;
 import org.apache.geode.test.junit.categories.SerializationTest;
 
 @Category(SerializationTest.class)
-public class AnalyzeRedisSerializablesIntegrationTest extends 
AnalyzeSerializablesJUnitTestBase {
+public class AnalyzeRedisSerializablesIntegrationTest
+extends AnalyzeSerializablesWithClassAnalysisRuleTestBase {
 
   @Override
   protected String getModuleName() {
diff --git 
a/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
 
b/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
index a5fa5a1..db50c2f 100644
--- 
a/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
+++ 
b/geode-connectors/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeConnectorsSerializablesIntegrationTest.java
@@ -23,7 +23,7 @@ import 
org.apache.geode.test.junit.categories.SerializationTest;
 
 @Category(SerializationTest.class)
 public class AnalyzeConnectorsSerializablesIntegrationTest
-extends AnalyzeSerializablesJUnitTestBase {
+extends AnalyzeSerializablesWithClassAnalysisRuleTestBase {
 
   @Override
   protected String getModuleName() {
diff --git 
a/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
 
b/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
index 6832442..d93d8d1 100755
--- 
a/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
+++ 
b/geode-core/src/integrationTest/java/org/apache/geode/codeAnalysis/AnalyzeCoreSerializablesIntegrationTest.java
@