This is an automated email from the ASF dual-hosted git repository. mcmellawatt pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push: new d7e7e87 GEODE-6143: Removing PowerMock from MBeanProxyFactoryTest (#2975) d7e7e87 is described below commit d7e7e87b32a6a6c0e0891dc9704db7d66e7deaf9 Author: Ryan McMahon <rmcma...@pivotal.io> AuthorDate: Tue Dec 11 12:26:11 2018 -0800 GEODE-6143: Removing PowerMock from MBeanProxyFactoryTest (#2975) --- .../management/internal/MBeanProxyFactory.java | 8 ++++++-- .../management/internal/MBeanProxyFactoryTest.java | 24 ++++------------------ 2 files changed, 10 insertions(+), 22 deletions(-) diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java b/geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java index cbbd516..e54ce8a 100644 --- a/geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java +++ b/geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java @@ -166,8 +166,7 @@ public class MBeanProxyFactory { removeProxy(member, mbeanName, val); } catch (EntryNotFoundException entryNotFoundException) { // Entry has already been removed by another thread, so no need to remove it - logger.warn("Proxy for entry {} and member {} has already been removed", entry, - member.getId()); + logProxyAlreadyRemoved(member, entry); } catch (Exception e) { if (!(e.getCause() instanceof InstanceNotFoundException)) { logger.warn("Remove Proxy failed for {} due to {}", key, e.getMessage(), e); @@ -269,4 +268,9 @@ public class MBeanProxyFactory { } + void logProxyAlreadyRemoved(DistributedMember member, Entry<String, Object> entry) { + logger.warn("Proxy for entry {} and member {} has already been removed", entry, + member.getId()); + } + } diff --git a/geode-core/src/test/java/org/apache/geode/management/internal/MBeanProxyFactoryTest.java b/geode-core/src/test/java/org/apache/geode/management/internal/MBeanProxyFactoryTest.java index c719fbd..73fc15d 100644 --- a/geode-core/src/test/java/org/apache/geode/management/internal/MBeanProxyFactoryTest.java +++ b/geode-core/src/test/java/org/apache/geode/management/internal/MBeanProxyFactoryTest.java @@ -16,45 +16,29 @@ package org.apache.geode.management.internal; import static org.mockito.ArgumentMatchers.any; -import static org.mockito.ArgumentMatchers.anyString; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.spy; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; -import static org.powermock.api.mockito.PowerMockito.mockStatic; -import static org.powermock.api.mockito.PowerMockito.when; import java.util.HashSet; import java.util.Map; import java.util.Set; -import org.apache.logging.log4j.Logger; import org.junit.Test; -import org.junit.runner.RunWith; -import org.powermock.api.mockito.PowerMockito; -import org.powermock.core.classloader.annotations.PowerMockIgnore; -import org.powermock.core.classloader.annotations.PrepareForTest; -import org.powermock.modules.junit4.PowerMockRunner; import org.apache.geode.cache.EntryNotFoundException; import org.apache.geode.cache.Region; import org.apache.geode.distributed.DistributedMember; -import org.apache.geode.internal.logging.LogService; -@RunWith(PowerMockRunner.class) -@PrepareForTest(LogService.class) -@PowerMockIgnore("javax.script.*") public class MBeanProxyFactoryTest { @Test public void removeAllProxiesEntryNotFoundLogged() { - mockStatic(LogService.class); - Logger mockLogger = PowerMockito.mock(Logger.class); - when(mockLogger.isDebugEnabled()).thenReturn(true); - when(LogService.getLogger()).thenReturn(mockLogger); - MBeanProxyFactory mBeanProxyFactory = - new MBeanProxyFactory(mock(MBeanJMXAdapter.class), mock(SystemManagementService.class)); + spy(new MBeanProxyFactory(mock(MBeanJMXAdapter.class), + mock(SystemManagementService.class))); Region mockRegion = mock(Region.class); Set entrySet = new HashSet<Map.Entry<String, Object>>(); @@ -68,6 +52,6 @@ public class MBeanProxyFactoryTest { // EntryNotFoundException should just result in a warning as it implies // the proxy has already been removed and the entry has already been destroyed - verify(mockLogger, times(1)).warn(anyString(), any(), any()); + verify(mBeanProxyFactory, times(1)).logProxyAlreadyRemoved(any(), any()); } }