Re: [PR] [CH] Issue 5018 [incubator-gluten]
binmahone merged PR #5019: URL: https://github.com/apache/incubator-gluten/pull/5019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CH] Issue 5018 [incubator-gluten]
github-actions[bot] commented on PR #5019: URL: https://github.com/apache/incubator-gluten/pull/5019#issuecomment-2019308523 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CH] Issue 5018 [incubator-gluten]
binmahone commented on code in PR #5019:
URL: https://github.com/apache/incubator-gluten/pull/5019#discussion_r1537160849
##
backends-clickhouse/src/main/scala/org/apache/spark/sql/execution/datasources/v1/CHMergeTreeWriterInjects.scala:
##
@@ -83,11 +86,14 @@ class CHMergeTreeWriterInjects extends
GlutenFormatWriterInjectsBase {
tableName,
orderByKeyOption,
lowCardKeyOption,
+ minmaxIndexKeyOption,
+ bfIndexKeyOption,
+ setIndexKeyOption,
primaryKeyOption,
partitionColumns,
ConverterUtils.convertNamedStructJson(tableSchema),
clickhouseTableConfigs,
- dataSchema
+ tableSchema.toAttributes // use table schema instead of data schema
Review Comment:
yes, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CH] Issue 5018 [incubator-gluten]
github-actions[bot] commented on PR #5019: URL: https://github.com/apache/incubator-gluten/pull/5019#issuecomment-2017399163 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CH] Issue 5018 [incubator-gluten]
github-actions[bot] commented on PR #5019: URL: https://github.com/apache/incubator-gluten/pull/5019#issuecomment-2017388837 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CH] Issue 5018 [incubator-gluten]
github-actions[bot] commented on PR #5019: URL: https://github.com/apache/incubator-gluten/pull/5019#issuecomment-2017385886 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
