Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]
PHILO-HE merged PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]
gaoyangxiaozhu commented on code in PR #5070:
URL: https://github.com/apache/incubator-gluten/pull/5070#discussion_r1535345027
##
gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala:
##
@@ -115,6 +116,16 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
return replaceScalaUDFWithExpressionTransformer(s, attributeSeq,
expressionsMap)
case _ if HiveUDFTransformer.isHiveUDF(expr) =>
return HiveUDFTransformer.replaceWithExpressionTransformer(expr,
attributeSeq)
+ case i: StaticInvoke =>
+i.functionName match {
+ case "decode" =>
Review Comment:
hey @PHILO-HE please check if the latest chagne ok for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]
github-actions[bot] commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2014758778 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]
PHILO-HE commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2014214223 cc @jackylee-ch to note this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
