Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
rui-mo merged PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
github-actions[bot] commented on PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2020340206 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
rui-mo commented on code in PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1539108319 ## ep/build-velox/src/get_velox.sh: ## @@ -16,8 +16,8 @@ set -exu -VELOX_REPO=https://github.com/oap-project/velox.git -VELOX_BRANCH=2024_03_25 +VELOX_REPO=https://github.com/liujiayi771/velox.git +VELOX_BRANCH=2024_03_25_ts_fix Review Comment: Could you revert this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
github-actions[bot] commented on PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2019287652 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
github-actions[bot] commented on PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2019245192 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
liujiayi771 commented on code in PR #5090:
URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1536975618
##
gluten-ut/spark32/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala:
##
@@ -857,7 +857,6 @@ class VeloxTestSettings extends BackendTestSettings {
// decimal failed ut
.exclude("SPARK-34212 Parquet should read decimals correctly")
// Timestamp is read as INT96.
Review Comment:
These two unit tests are still failing, but it's not the same issue. We can
continue investigating to find the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
liujiayi771 commented on code in PR #5090:
URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1536975618
##
gluten-ut/spark32/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala:
##
@@ -857,7 +857,6 @@ class VeloxTestSettings extends BackendTestSettings {
// decimal failed ut
.exclude("SPARK-34212 Parquet should read decimals correctly")
// Timestamp is read as INT96.
Review Comment:
These two unit tests failed because int64 timestamp read is not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
rui-mo commented on code in PR #5090:
URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1536970241
##
gluten-ut/spark32/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala:
##
@@ -857,7 +857,6 @@ class VeloxTestSettings extends BackendTestSettings {
// decimal failed ut
.exclude("SPARK-34212 Parquet should read decimals correctly")
// Timestamp is read as INT96.
Review Comment:
This message was added when int64 type was unsupported for timestamp reader.
Could you update the message to illustrate why below tests are still disabled?
> .exclude("Migration from INT96 to TIMESTAMP_MICROS timestamp type")
.exclude("SPARK-10365 timestamp written and read as INT64 -
TIMESTAMP_MICROS")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
rui-mo commented on code in PR #5090:
URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1536968547
##
gluten-ut/spark32/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala:
##
@@ -857,7 +857,6 @@ class VeloxTestSettings extends BackendTestSettings {
// decimal failed ut
.exclude("SPARK-34212 Parquet should read decimals correctly")
// Timestamp is read as INT96.
-.exclude("SPARK-10634 timestamp written and read as INT64 - truncation")
.exclude("Migration from INT96 to TIMESTAMP_MICROS timestamp type")
.exclude("SPARK-10365 timestamp written and read as INT64 -
TIMESTAMP_MICROS")
Review Comment:
Have you tried above two unit tests, and are they related to the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
github-actions[bot] commented on PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2016465579 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]
github-actions[bot] commented on PR #5090:
URL:
https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2016465532
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title***
in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
