Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
github-actions[bot] commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2113783174 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
github-actions[bot] closed pull request #5046: [VL] Not fallback for function spark_partition_id and monotonically_increasing_id URL: https://github.com/apache/incubator-gluten/pull/5046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
github-actions[bot] commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2095063881 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
gaoyangxiaozhu commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2011235388 > Can you also help to add input_file_name() function? It's very useful for debug purpose. acked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
FelixYBW commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2010595886 Can you also help to add input_file_name() function? It's very useful for debug purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
zhli1142015 commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2009700175 Acked, let me check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL ] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
gaoyangxiaozhu commented on PR #5046:
URL:
https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2009403778
@zhli1142015 current `monotonically_increasing_id` implement causes
inconsistent behavior vs vinalla spark.
looks in velox we always use one function instance when query has duplicate
same function expr call
simple reproduce:
```
val df = sc.parallelize(Seq[Int](), 2).mapPartitions { _ =>
Iterator(Tuple1(1), Tuple1(2)) }.toDF("a")
val df2 = df.select(monotonically_increasing_id(),
expr("monotonically_increasing_id()"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL ] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]
github-actions[bot] commented on PR #5046:
URL:
https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2008984659
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title***
in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
