Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub


PHILO-HE commented on PR #5127:
URL: 
https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2021997304

   Sorry for late response. Looks good! Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub


zhztheplayer merged PR #5127:
URL: https://github.com/apache/incubator-gluten/pull/5127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub


zhztheplayer commented on PR #5127:
URL: 
https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2021704715

   cc @PHILO-HE 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub


github-actions[bot] commented on PR #5127:
URL: 
https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2019852660

   
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** 
in the following format?
   
   [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
 * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub


github-actions[bot] commented on PR #5127:
URL: 
https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2019848724

   
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** 
in the following format?
   
   [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
 * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



[PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub


zhztheplayer opened a new pull request, #5127:
URL: https://github.com/apache/incubator-gluten/pull/5127

   For the background of this, please refer to 
https://github.com/apache/incubator-gluten/blob/main/docs/velox-backend-troubleshooting.md#fatal-error-after-native-exception-is-thrown
   
   In future we may need to improve the patching code by at least throwing some 
errors when failing to find a match.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org