Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


GlutenPerfBot commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1996250303

   = Performance report for TPCH SF2000 with Velox backend, for reference 
only 
   
   
   
   query
   log/native_4828_time.csv
   log/native_master_03_13_2024_d7ed0844e_time.csv
   difference
   percentage
   
   
   q1
   37.75
   38.81
   1.059
   102.80%
   
   
   q2
   24.20
   24.06
   -0.135
   99.44%
   
   
   q3
   38.00
   38.18
   0.177
   100.47%
   
   
   q4
   36.25
   38.49
   2.234
   106.16%
   
   
   q5
   67.82
   69.71
   1.885
   102.78%
   
   
   q6
   7.41
   7.45
   0.047
   100.64%
   
   
   q7
   83.82
   82.46
   -1.363
   98.37%
   
   
   q8
   85.28
   83.21
   -2.068
   97.57%
   
   
   q9
   121.80
   121.83
   0.031
   100.03%
   
   
   q10
   47.07
   44.36
   -2.710
   94.24%
   
   
   q11
   20.03
   20.90
   0.870
   104.34%
   
   
   q12
   28.41
   28.06
   -0.350
   98.77%
   
   
   q13
   47.25
   46.88
   -0.370
   99.22%
   
   
   q14
   18.59
   21.98
   3.386
   118.21%
   
   
   q15
   31.40
   33.08
   1.685
   105.37%
   
   
   q16
   14.31
   13.84
   -0.468
   96.73%
   
   
   q17
   100.67
   101.80
   1.131
   101.12%
   
   
   q18
   142.34
   141.05
   -1.291
   99.09%
   
   
   q19
   13.85
   15.07
   1.215
   108.77%
   
   
 

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


ulysses-you merged PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1994023507

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


ulysses-you commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522917510


##
.github/workflows/velox_be.yml:
##
@@ -670,3 +673,12 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  clean-up-tmp:

Review Comment:
   I think we should merge upload and cleanup into one job and it seems 
unnecessary to pull out upload to a new job. There exists many similar jobs in 
gluten CI, if we want to make it clear, we should consider other jobs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


zwangsheng commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522894498


##
.github/workflows/velox_be.yml:
##
@@ -670,3 +673,12 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  clean-up-tmp:

Review Comment:
   IMO, it is acceptable to add a new job to do the cleanup, especially since 
we will later incorporate the upload operations into this job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


zwangsheng commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522886017


##
.github/workflows/velox_be.yml:
##
@@ -670,3 +673,12 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  clean-up-tmp:

Review Comment:
   Well, if we want to merge upload action steps, here always will be a new job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


zwangsheng commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522886017


##
.github/workflows/velox_be.yml:
##
@@ -670,3 +673,12 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  clean-up-tmp:

Review Comment:
   Well, if we want to merge upload action steps, here always will be a new job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


ulysses-you commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522880119


##
.github/workflows/velox_be.yml:
##
@@ -670,3 +673,12 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  clean-up-tmp:

Review Comment:
   @zwangsheng  It seems a bit overkill to add a common job to do cleanup. The 
github action become complex.. I prefer to revert this change.
   
   https://github.com/apache/incubator-gluten/assets/12025282/68880945-5a5f-4007-8ed0-81df78a0d2cb;>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993745024

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub


zwangsheng commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993329577

   Thanks for both @ulysses-you @PHILO-HE, i will revert this commit to focus 
on Spark 34 Golden Files, after some test, will turn this PR ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993323947

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub


ulysses-you commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993313046

   I'm fine to seperate pr. @PHILO-HE  IIUC the current action should work, 
just some code cleanup leave to another pr.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub


PHILO-HE commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993302181

   > > @zwangsheng is there any block on this pr ?
   > 
   > I'm still testing merge upload step. But IMO, we can leave merge step job 
in the following PR. WDYT @ulysses-you @PHILO-HE
   
   OK to me to separate the work into two or more PRs.
   Assume the uploading action can also work well in the new CI we are working 
on. cc @zhouyuan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub


zwangsheng commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993232921

   > @zwangsheng is there any block on this pr ?
   
   I'm still testing merge upload step. But IMO, we can leave merge step job in 
the following PR. WDYT @ulysses-you @PHILO-HE 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub


ulysses-you commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993175055

   @zwangsheng  is there any block on this pr ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-11 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987985713

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-11 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987974001

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-11 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987746116

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-10 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987668681

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-10 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987580373

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-10 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987498140

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-08 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985442505

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-08 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985439736

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985214696

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub


zwangsheng commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517189310


##
.github/workflows/velox_be.yml:
##
@@ -631,3 +616,17 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  upload-golden-file:
+runs-on: velox-self-hosted
+needs: [ubuntu2004-test-spark32, ubuntu2004-test-spark33, 
ubuntu2004-test-spark34]
+steps:
+  - name: Upload golden files

Review Comment:
   Right, we should trigger this upload job when the previous job fail.
   
   And according to [Github Action 
Doc](https://docs.github.com/en/actions/learn-github-actions/expressions#failure),
 we should add this condition on job instead of adding on each step. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985071173

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub


ulysses-you commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517122862


##
.github/workflows/velox_be.yml:
##
@@ -631,3 +616,17 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  upload-golden-file:
+runs-on: velox-self-hosted
+needs: [ubuntu2004-test-spark32, ubuntu2004-test-spark33, 
ubuntu2004-test-spark34]
+steps:
+  - name: Upload golden files
+uses: actions/upload-artifact@v4
+with:
+  name: golden-files-spark32
+  path: |
+/tmp/${{ github.run_id }}/spark32/tpch-approved-plan/**
+  - name: Clean temp golden files
+run: |

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub


ulysses-you commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517122717


##
.github/workflows/velox_be.yml:
##
@@ -631,3 +616,17 @@ jobs:
 if: ${{ always() }}
 run: |
   $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+  upload-golden-file:
+runs-on: velox-self-hosted
+needs: [ubuntu2004-test-spark32, ubuntu2004-test-spark33, 
ubuntu2004-test-spark34]
+steps:
+  - name: Upload golden files

Review Comment:
   if: failure()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org



Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub


github-actions[bot] commented on PR #4828:
URL: 
https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1984956120

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org