[
https://issues.apache.org/jira/browse/GUACAMOLE-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293042#comment-16293042
]
Nick Couchman edited comment on GUACAMOLE-465 at 12/15/17 7:16 PM:
---
{quote}
I'm working on a patch for this feature. I don't have an ETA on it because I'm
working on it in my spare time, but when I get a working patch, I'll pass it
along.
{quote}
Awesome! I understand the free time aspect - developing Guacamole is not my
day job, either, so no worries there. If you haven't, already, you might want
to take a look at the Contributing section of the Guacamole home page:
http://guacamole.apache.org/open-source/
There are several resources, there, including style guidelines and information
about how "patches" are submitted to Guacamole (Github Pull Requests).
{quote}
Also, question: is there any minimum and maximum versions of dependencies that
guacamole is promising to support?
{quote}
Mike might have a more specific answer, but we definitely want to maintain
compatibility across as many versions as is sanely and safely possible. I
would say that, in the case where you're modifying guacenc to add support for
additional video formats, it would be desirable that lack of a particular codec
type not break the compile completely - that is, if there's a particular build
of ffmpeg that adds support, its fine to add it, but breaking the guacenc
compile completely just to support a particular video encoding type is not
desirable behavior. In ffmpeg this is even more true since some of the codecs
fall into, let's say, "gray areas" that all users might not (want to) have
access to (similar to gstreamer with its good plugins, bad plugins, and ugly
plugins, primarily referring to the license or copyright of the particular
algorithm). This might make the configure process a little more difficult to
nail down if you're having to check what codecs are supported by ffmpeg, but
that effort will be worth not forcing users to have ffmpeg compiled just so.
Hopefully all of that makes sense.
was (Author: nick.couch...@yahoo.com):
{quote}
I'm working on a patch for this feature. I don't have an ETA on it because I'm
working on it in my spare time, but when I get a working patch, I'll pass it
along.
{quote}
Awesome! I understand the free time aspect - developing Guacamole is not my
day job, either, so no worries there. If you haven't, already, you might want
to take a look at the Contributing section of the Guacamole home page:
http://guacamole.apache.org/open-source/
There are several resources, there, including style guidelines.
{quote}
Also, question: is there any minimum and maximum versions of dependencies that
guacamole is promising to support?
{quote}
Mike might have a more specific answer, but we definitely want to maintain
compatibility across as many versions as is sanely and safely possible. I
would say that, in the case where you're modifying guacenc to add support for
additional video formats, it would be desirable that lack of a particular codec
type not break the compile completely - that is, if there's a particular build
of ffmpeg that adds support, its fine to add it, but breaking the guacenc
compile completely just to support a particular video encoding type is not
desirable behavior. In ffmpeg this is even more true since some of the codecs
fall into, let's say, "gray areas" that all users might not (want to) have
access to (similar to gstreamer with its good plugins, bad plugins, and ugly
plugins, primarily referring to the license or copyright of the particular
algorithm). This might make the configure process a little more difficult to
nail down if you're having to check what codecs are supported by ffmpeg, but
that effort will be worth not forcing users to have ffmpeg compiled just so.
Hopefully all of that makes sense.
> Guacenc should support more formats and containers
> --
>
> Key: GUACAMOLE-465
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-465
> Project: Guacamole
> Issue Type: New Feature
> Components: guacamole-server
>Affects Versions: 0.9.13-incubating
>Reporter: Sean Reid
>Priority: Minor
>
> Guacenc should support more formats than just mpeg4 in an m4v file type. It
> should support true media containers with libavformat rather than just
> writing the encoded frames into a file.
> Because Guacamole is a web-based application, it makes sense that at the very
> least its video encoder should support common web video formats (h.264 + mp4).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
