[hive] branch master updated: Revert "HIVE-25321: Advance writeid during AlterTableDropPartition (Kishen Das reviewed by Sourabh and Yu-wen)"
This is an automated email from the ASF dual-hosted git repository.
ngangam pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new 72a5ec0 Revert "HIVE-25321: Advance writeid during
AlterTableDropPartition (Kishen Das reviewed by Sourabh and Yu-wen)"
72a5ec0 is described below
commit 72a5ec0469deed02b222b47e34a6c2550c014357
Author: Naveen Gangam
AuthorDate: Wed Jul 21 13:56:49 2021 -0400
Revert "HIVE-25321: Advance writeid during AlterTableDropPartition (Kishen
Das reviewed by Sourabh and Yu-wen)"
This reverts commit 8e98a32535706cda3a36476767a6ee049d3ea280.
---
.../add/AbstractAddPartitionAnalyzer.java | 15 ++
.../drop/AbstractDropPartitionAnalyzer.java| 6 ---
.../drop/AlterTableDropPartitionAnalyzer.java | 14 --
.../drop/AlterViewDropPartitionAnalyzer.java | 12 -
.../org/apache/hadoop/hive/ql/TestTxnCommands.java | 53 --
.../llap/drop_deleted_partitions.q.out | 4 +-
.../llap/drop_multi_partitions.q.out | 4 +-
.../llap/drop_partitions_filter.q.out | 8 ++--
.../llap/temp_table_drop_partitions_filter.q.out | 8 ++--
9 files changed, 27 insertions(+), 97 deletions(-)
diff --git
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
index 9da2daa..0736f16 100644
---
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
+++
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
@@ -132,4 +132,19 @@ abstract class AbstractAddPartitionAnalyzer extends
AbstractAlterTableAnalyzer {
protected abstract void postProcess(TableName tableName, Table table,
AlterTableAddPartitionDesc desc,
Task ddlTask) throws SemanticException;
+ // Equivalent to acidSinks, but for DDL operations that change data.
+ private DDLDescWithWriteId ddlDescWithWriteId;
+
+ protected void setAcidDdlDesc(DDLDescWithWriteId descWithWriteId) {
+if (this.ddlDescWithWriteId != null) {
+ throw new IllegalStateException("ddlDescWithWriteId is already set: " +
this.ddlDescWithWriteId);
+}
+this.ddlDescWithWriteId = descWithWriteId;
+ }
+
+ @Override
+ public DDLDescWithWriteId getAcidDdlDesc() {
+return ddlDescWithWriteId;
+ }
+
}
diff --git
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
index b727492..34667e0 100644
---
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
+++
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
@@ -31,7 +31,6 @@ import org.apache.hadoop.hive.ql.QueryState;
import org.apache.hadoop.hive.ql.ddl.DDLWork;
import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableAnalyzer;
import org.apache.hadoop.hive.ql.ddl.table.AlterTableType;
-import org.apache.hadoop.hive.ql.exec.Task;
import org.apache.hadoop.hive.ql.exec.TaskFactory;
import org.apache.hadoop.hive.ql.hooks.ReadEntity;
import org.apache.hadoop.hive.ql.hooks.WriteEntity;
@@ -108,15 +107,10 @@ abstract class AbstractDropPartitionAnalyzer extends
AbstractAlterTableAnalyzer
AlterTableDropPartitionDesc desc =
new AlterTableDropPartitionDesc(tableName, partitionSpecs, mustPurge,
replicationSpec);
rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(),
desc)));
-
-postProcess(tableName, table, desc);
-
}
protected abstract boolean expectView();
- protected abstract void postProcess(TableName tableName, Table table,
AlterTableDropPartitionDesc desc);
-
/**
* Add the table partitions to be modified in the output, so that it is
available for the
* pre-execution hook. If the partition does not exist, throw an error if
diff --git
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
index f8632c7..cbb622e 100644
---
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
+++
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
@@ -18,13 +18,8 @@
package org.apache.hadoop.hive.ql.ddl.table.partition.drop;
-import org.apache.hadoop.hive.common.TableName;
import org.apache.hadoop.hive.ql.QueryState;
import org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory.DDLType;
-import org.apache.hadoop.hive.ql.ddl.DDLWork;
-import org.apache.hadoop.hive.ql.exec.Task;
-import
[hive] branch master updated: HIVE-25321: Advance writeid during AlterTableDropPartition (Kishen Das reviewed by Sourabh and Yu-wen)
This is an automated email from the ASF dual-hosted git repository.
ngangam pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new 8e98a32 HIVE-25321: Advance writeid during AlterTableDropPartition
(Kishen Das reviewed by Sourabh and Yu-wen)
8e98a32 is described below
commit 8e98a32535706cda3a36476767a6ee049d3ea280
Author: Kishen Das
AuthorDate: Fri Jul 9 12:54:38 2021 -0700
HIVE-25321: Advance writeid during AlterTableDropPartition (Kishen Das
reviewed by Sourabh and Yu-wen)
---
.../add/AbstractAddPartitionAnalyzer.java | 15 --
.../drop/AbstractDropPartitionAnalyzer.java| 6 +++
.../drop/AlterTableDropPartitionAnalyzer.java | 14 ++
.../drop/AlterViewDropPartitionAnalyzer.java | 12 +
.../org/apache/hadoop/hive/ql/TestTxnCommands.java | 53 ++
.../llap/drop_deleted_partitions.q.out | 4 +-
.../llap/drop_multi_partitions.q.out | 4 +-
.../llap/drop_partitions_filter.q.out | 8 ++--
.../llap/temp_table_drop_partitions_filter.q.out | 8 ++--
9 files changed, 97 insertions(+), 27 deletions(-)
diff --git
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
index 0736f16..9da2daa 100644
---
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
+++
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java
@@ -132,19 +132,4 @@ abstract class AbstractAddPartitionAnalyzer extends
AbstractAlterTableAnalyzer {
protected abstract void postProcess(TableName tableName, Table table,
AlterTableAddPartitionDesc desc,
Task ddlTask) throws SemanticException;
- // Equivalent to acidSinks, but for DDL operations that change data.
- private DDLDescWithWriteId ddlDescWithWriteId;
-
- protected void setAcidDdlDesc(DDLDescWithWriteId descWithWriteId) {
-if (this.ddlDescWithWriteId != null) {
- throw new IllegalStateException("ddlDescWithWriteId is already set: " +
this.ddlDescWithWriteId);
-}
-this.ddlDescWithWriteId = descWithWriteId;
- }
-
- @Override
- public DDLDescWithWriteId getAcidDdlDesc() {
-return ddlDescWithWriteId;
- }
-
}
diff --git
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
index 34667e0..b727492 100644
---
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
+++
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
@@ -31,6 +31,7 @@ import org.apache.hadoop.hive.ql.QueryState;
import org.apache.hadoop.hive.ql.ddl.DDLWork;
import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableAnalyzer;
import org.apache.hadoop.hive.ql.ddl.table.AlterTableType;
+import org.apache.hadoop.hive.ql.exec.Task;
import org.apache.hadoop.hive.ql.exec.TaskFactory;
import org.apache.hadoop.hive.ql.hooks.ReadEntity;
import org.apache.hadoop.hive.ql.hooks.WriteEntity;
@@ -107,10 +108,15 @@ abstract class AbstractDropPartitionAnalyzer extends
AbstractAlterTableAnalyzer
AlterTableDropPartitionDesc desc =
new AlterTableDropPartitionDesc(tableName, partitionSpecs, mustPurge,
replicationSpec);
rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(),
desc)));
+
+postProcess(tableName, table, desc);
+
}
protected abstract boolean expectView();
+ protected abstract void postProcess(TableName tableName, Table table,
AlterTableDropPartitionDesc desc);
+
/**
* Add the table partitions to be modified in the output, so that it is
available for the
* pre-execution hook. If the partition does not exist, throw an error if
diff --git
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
index cbb622e..f8632c7 100644
---
a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
+++
b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionAnalyzer.java
@@ -18,8 +18,13 @@
package org.apache.hadoop.hive.ql.ddl.table.partition.drop;
+import org.apache.hadoop.hive.common.TableName;
import org.apache.hadoop.hive.ql.QueryState;
import org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory.DDLType;
+import org.apache.hadoop.hive.ql.ddl.DDLWork;
+import org.apache.hadoop.hive.ql.exec.Task;
+import org.apache.hadoop.hive.ql.io.AcidUtils;
+import org.apache.hadoop.hive.ql.metadata.Table;
import
[hive] branch master updated (e07a750 -> 389a64b)
This is an automated email from the ASF dual-hosted git repository. klcopp pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hive.git. from e07a750 HIVE-25358: Remove reviewer pattern (#2506) (Jesus Camacho Rodriguez reviewed by Zoltan Haindrich) add 389a64b disable unstable test No new revisions were added by this update. Summary of changes: ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUpdaterThread.java | 2 ++ 1 file changed, 2 insertions(+)
[hive] branch klcopp-patch-1 created (now e050a08)
This is an automated email from the ASF dual-hosted git repository. klcopp pushed a change to branch klcopp-patch-1 in repository https://gitbox.apache.org/repos/asf/hive.git. at e050a08 Update assign-by-files.yml This branch includes the following new commits: new e050a08 Update assign-by-files.yml The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[hive] 01/01: Update assign-by-files.yml
This is an automated email from the ASF dual-hosted git repository. klcopp pushed a commit to branch klcopp-patch-1 in repository https://gitbox.apache.org/repos/asf/hive.git commit e050a08f0dd16727aadf0aa19ee6054262da6834 Author: Karen Coppage AuthorDate: Wed Jul 21 15:04:34 2021 +0200 Update assign-by-files.yml Add myself to thrift watchers --- .github/assign-by-files.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/assign-by-files.yml b/.github/assign-by-files.yml index b9ef397..6bf6d98 100644 --- a/.github/assign-by-files.yml +++ b/.github/assign-by-files.yml @@ -6,6 +6,7 @@ # thrift changes '**/*.thrift': - kgyrtkirk + - klcopp # parser changes '**/*.g': - kgyrtkirk
[hive] branch master updated (67f58d0 -> e07a750)
This is an automated email from the ASF dual-hosted git repository. kgyrtkirk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hive.git. from 67f58d0 HIVE-25281: Add optional fields to enable returning filemetadata (Vihang Karajgaonkar, reviewed by Kishen Das) add e07a750 HIVE-25358: Remove reviewer pattern (#2506) (Jesus Camacho Rodriguez reviewed by Zoltan Haindrich) No new revisions were added by this update. Summary of changes: .github/assign-by-files.yml | 3 --- 1 file changed, 3 deletions(-)
