[GitHub] [hudi] hudi-bot commented on pull request #7580: [HUDI-5434] Fix archival in metadata table to not rely on completed rollback or clean in data table
hudi-bot commented on PR #7580: URL: https://github.com/apache/hudi/pull/7580#issuecomment-1368376963 ## CI report: * 363e7ec434dfac617a963387e65ffa1aa4b8308b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14050) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4966: [HUDI-3572]support DAY_ROLLING strategy in ClusteringPlanPartitionFilterMode
hudi-bot commented on PR #4966: URL: https://github.com/apache/hudi/pull/4966#issuecomment-1368376707 ## CI report: * 24ea27ad2bc29400d8e5271f8f683662d0e0a93b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14048) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14057) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7580: [HUDI-5434] Fix archival in metadata table to not rely on completed rollback or clean in data table
hudi-bot commented on PR #7580: URL: https://github.com/apache/hudi/pull/7580#issuecomment-1368365984 ## CI report: * 363e7ec434dfac617a963387e65ffa1aa4b8308b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14050) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7580: [HUDI-5434] Fix archival in metadata table to not rely on completed rollback or clean in data table
hudi-bot commented on PR #7580: URL: https://github.com/apache/hudi/pull/7580#issuecomment-1368365353 ## CI report: * 363e7ec434dfac617a963387e65ffa1aa4b8308b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] yihua closed issue #6984: [SUPPORT] hudi metrics with flink so little
yihua closed issue #6984: [SUPPORT] hudi metrics with flink so little URL: https://github.com/apache/hudi/issues/6984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] yihua commented on issue #6984: [SUPPORT] hudi metrics with flink so little
yihua commented on issue #6984: URL: https://github.com/apache/hudi/issues/6984#issuecomment-1368364615 Let's track the effort of adding metrics in the Jira ticket and PR. Closing this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit
yihua commented on PR #7568: URL: https://github.com/apache/hudi/pull/7568#issuecomment-1368359076 @SteNicholas Sorry for the delay. I'll review the PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4966: [HUDI-3572]support DAY_ROLLING strategy in ClusteringPlanPartitionFilterMode
hudi-bot commented on PR #4966: URL: https://github.com/apache/hudi/pull/4966#issuecomment-1368351877 ## CI report: * 24ea27ad2bc29400d8e5271f8f683662d0e0a93b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14048) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14057) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] Leoyzen commented on issue #7546: [SUPPORT]Fail to execute offline flink compactor in service mode.
Leoyzen commented on issue #7546: URL: https://github.com/apache/hudi/issues/7546#issuecomment-1368346154 @danny0405 @yihua Is there any solution right now? We have a source which produce 100k tps+ and taskmanager keeps crash timeout when using online compaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] scxwhite commented on pull request #4966: [HUDI-3572]support DAY_ROLLING strategy in ClusteringPlanPartitionFilterMode
scxwhite commented on PR #4966: URL: https://github.com/apache/hudi/pull/4966#issuecomment-1368342798 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] yihua commented on issue #7162: [SUPPORT] Flink stream api(HoodieFlinkStreamer) write data to hudi create much rollbackfile
yihua commented on issue #7162: URL: https://github.com/apache/hudi/issues/7162#issuecomment-1368342587 @viverlxl Thanks for the confirmation. I'll close this issue now. Feel free to open a new one if you think there are other related improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] yihua closed issue #7162: [SUPPORT] Flink stream api(HoodieFlinkStreamer) write data to hudi create much rollbackfile
yihua closed issue #7162: [SUPPORT] Flink stream api(HoodieFlinkStreamer) write data to hudi create much rollbackfile URL: https://github.com/apache/hudi/issues/7162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] boneanxs commented on a diff in pull request #7582: [HUDI-5488]Make sure Discrupt queue start first, then insert records
boneanxs commented on code in PR #7582:
URL: https://github.com/apache/hudi/pull/7582#discussion_r1059702584
##
hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorMessageQueue.java:
##
@@ -60,6 +61,12 @@ public long size() {
@Override
public void insertRecord(I value) throws Exception {
+if (!isStart) {
+ synchronized (this) {
+wait();
+ }
+}
Review Comment:
Oops,forgot to add a double check here.
```java
if(!isStart) {
synchronized(this) {
if(!isStart) {
wait();
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] f7753 commented on pull request #7582: [HUDI-5488]Make sure Discrupt queue start first, then insert records
f7753 commented on PR #7582: URL: https://github.com/apache/hudi/pull/7582#issuecomment-1368316681 typo in title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7561: [HUDI-5477] Optimize timeline loading in Hudi sync client
hudi-bot commented on PR #7561: URL: https://github.com/apache/hudi/pull/7561#issuecomment-1368283247 ## CI report: * 40361ca7dd3d4cd00a6f154c30f17f2a6a5a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14043) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7561: [HUDI-5477] Optimize timeline loading in Hudi sync client
hudi-bot commented on PR #7561: URL: https://github.com/apache/hudi/pull/7561#issuecomment-1368275507 ## CI report: * 40361ca7dd3d4cd00a6f154c30f17f2a6a5a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14043) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7561: [HUDI-5477] Optimize timeline loading in Hudi sync client
hudi-bot commented on PR #7561: URL: https://github.com/apache/hudi/pull/7561#issuecomment-1368274855 ## CI report: * 40361ca7dd3d4cd00a6f154c30f17f2a6a5a UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on a diff in pull request #7582: [HUDI-5488]Make sure Discrupt queue start first, then insert records
zhangyue19921010 commented on code in PR #7582:
URL: https://github.com/apache/hudi/pull/7582#discussion_r1059638481
##
hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorMessageQueue.java:
##
@@ -105,6 +113,12 @@ protected void setHandlers(HoodieConsumer consumer) {
protected void start() {
queue.start();
+synchronized (this) {
+ if (!isStart) {
+isStart = true;
+notifyAll();
+ }
+}
Review Comment:
```suggestion
synchronized (this) {
if (!isStart) {
queue.start();
isStart = true;
notifyAll();
}
}
```
##
hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorMessageQueue.java:
##
@@ -60,6 +61,12 @@ public long size() {
@Override
public void insertRecord(I value) throws Exception {
+if (!isStart) {
+ synchronized (this) {
+wait();
+ }
+}
Review Comment:
```suggestion
synchronized (this) {
If (!isStart) {
wait();
}
}
```
We need to let synchronized cover isStart check in case that `isStart ` is
changed after `if (!isStart)` but before `wait();`
But in this way, we will do synchronized check for each record ingestion
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
