[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-07 Thread GitBox 


Mathieu1124 commented on pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#issuecomment-670453889


   > 
   > 
   > > I was wondering can we move this implement to hudi-client module just 
like the way all the implementations of metrics does.
   > 
   > I think we can move this down the line. `hudi-client` or `hudi-spark` 
talking a direct dependency on kafka does not feel that clean to me. May be 
file a follow up JIRA?
   
   ok 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-06 Thread GitBox 


Mathieu1124 commented on pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#issuecomment-670294044


   @yanghua VC seems busy, do you have any other concern about this pr ?
   if it is ok,  can we merge this first, and file a new pr if VC  agree to 
move this to hudi-client :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-05 Thread GitBox 


Mathieu1124 commented on pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#issuecomment-669261486


   Hi @vinothchandar, I was wondering can we move this implement to hudi-client 
module just like the way all the implementations of metrics does.
   
   put this implementation in hudi-utilities, the Spark API(hudi-spark moudle) 
can not benefit from it. besides, in the future, when the flink engine merged 
in , it can not use it either.
   WDYT?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-02 Thread GitBox 


Mathieu1124 commented on pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#issuecomment-667773074


   > 
   > 
   > @Mathieu1124 Thanks for your contribution. Left some comments you can 
consider. Did you test this feature in your local?
   
   Yes, I tested  it in my local, it works good.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-07-29 Thread GitBox 


Mathieu1124 commented on pull request #1886:
URL: https://github.com/apache/hudi/pull/1886#issuecomment-665661859


   @yanghua please take a look when free



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org