[GitHub] [hudi] RocMarshal commented on a change in pull request #2745: [HUDI-1737][hudi-client] Code Cleanup: Extract common method in HoodieCreateHandle & FlinkCreateHandle

[GitBox]

RocMarshal commented on a change in pull request #2745:
URL: https://github.com/apache/hudi/pull/2745#discussion_r604791723



##
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##
@@ -179,29 +181,47 @@ public IOType getIOType() {
 

Review comment:
   all of differences above here is caused by merging from latest master 
branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #2745: [HUDI-1737][hudi-client] Code Cleanup: Extract common method in HoodieCreateHandle & FlinkCreateHandle

[GitBox]

RocMarshal commented on a change in pull request #2745:
URL: https://github.com/apache/hudi/pull/2745#discussion_r604791723



##
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##
@@ -179,29 +181,47 @@ public IOType getIOType() {
 

Review comment:
   all of differences above here is caused by merging from latest master 
branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #2745: [HUDI-1737][hudi-client] Code Cleanup: Extract common method in HoodieCreateHandle & FlinkCreateHandle

[GitBox]

RocMarshal commented on a change in pull request #2745:
URL: https://github.com/apache/hudi/pull/2745#discussion_r604785572



##
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##
@@ -180,28 +180,34 @@ public IOType getIOType() {
   fileWriter.close();
 
   HoodieWriteStat stat = new HoodieWriteStat();
-  stat.setPartitionPath(writeStatus.getPartitionPath());
-  stat.setNumWrites(recordsWritten);
-  stat.setNumDeletes(recordsDeleted);
-  stat.setNumInserts(insertRecordsWritten);
-  stat.setPrevCommit(HoodieWriteStat.NULL_COMMIT);
-  stat.setFileId(writeStatus.getFileId());
-  stat.setPath(new Path(config.getBasePath()), path);
   long fileSizeInBytes = FSUtils.getFileSize(fs, path);
   stat.setTotalWriteBytes(fileSizeInBytes);
   stat.setFileSizeInBytes(fileSizeInBytes);
-  stat.setTotalWriteErrors(writeStatus.getTotalErrorRecords());

Review comment:
   @danny0405 Thank you for your suggestions. I made some changes, please 
take a look.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org