[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2023-01-05 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1373192918

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2023-01-05 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1373007463

   @yihua, I have already fixed the CI failure and updated the 
`ClusteringUtils`. Meanwhile the current failure has nothing to do with this 
change. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2023-01-05 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1373003469

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2023-01-05 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1372218249

   @yihua, I have already fixed the CI failure and updated the 
`ClusteringUtils`. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2023-01-02 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1369338430

   @yihua, any comments for this pull request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2022-12-29 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1367682208

   @yihua, could you please review this pull request? @leesf has approved this 
changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2022-12-28 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1367089617

   @leesf, @yihua, could you please review this pull request? I have addressed 
above comments from @danny0405.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] SteNicholas commented on pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

2022-12-28 Thread GitBox


SteNicholas commented on PR #7568:
URL: https://github.com/apache/hudi/pull/7568#issuecomment-1366462432

   @danny0405, @zhuanshenbsj1, I have created this pull request to fix the 
problem mentioned in #7405 in which the implementation is a little complex. 
PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org