[GitHub] [hudi] SteNicholas commented on pull request #9160: [HUDI-6501] HoodieHeartbeatClient should stop all heartbeats and not delete heartbeat files for close
SteNicholas commented on PR #9160: URL: https://github.com/apache/hudi/pull/9160#issuecomment-1633418730 @bvaradar, could you help to review this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] SteNicholas commented on pull request #9160: [HUDI-6501] HoodieHeartbeatClient should stop all heartbeats and not delete heartbeat files for close
SteNicholas commented on PR #9160: URL: https://github.com/apache/hudi/pull/9160#issuecomment-1629585323 @n3nash, could you help to review this pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] SteNicholas commented on pull request #9160: [HUDI-6501] HoodieHeartbeatClient should stop all heartbeats and not delete heartbeat files for close
SteNicholas commented on PR #9160: URL: https://github.com/apache/hudi/pull/9160#issuecomment-1628870381 > We should also note that if we don't restart the job before the heartbeat expires, the cleaner will still roll back the inflight instant that should be recommitted. And we can't set the heartbeat time too long because clean and archive will be blocked by inflight instants. @stream2000, this requires that the recommit operation should execute within `maxAllowableHeartbeatIntervalInMs`, otherwise the recommit instant will rollback for the clean action. @stream2000, I have addressed above comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
