[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-15 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1248881741

   Hi @danny0405 ci passed : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-15 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1247975433

   Hi, 
@danny0405,https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=11379=results
 this is the latest right, seems ci will retain at least one failed record:
   
https://github.com/apache/hudi/commit/81546636356aa5b224b87087bad14a1da1a06a4d 
Azure: 
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11315)
   
https://github.com/apache/hudi/commit/f32cf8515a4984c75bc26641abd3a5b042ebe372 
Azure: 
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11379)
   FYI : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-15 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1247832138

   > Can you rebase with the latest master code and force push to re-trigger 
the tests.
   
   Ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-15 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1247733905

   > TestSavepointsProcedure
   
   Hi @danny0405  seems the failed ci record is triggered in two days ago, the 
failed test is:
   - Test Create Hoodie Table With Options *** FAILED ***
 Expected "apache.hudi.keygen.[Complex]KeyGenerator", but got 
"apache.hudi.keygen.[Simple]KeyGenerator" (TestCreateTable.scala:139)
   Total number of tests run: 186
   Suites: completed 46, aborted 0
   Tests: succeeded 185, failed 1, canceled 0, ignored 0, pending 0
   
   Seems not the recent one, the failed one is what I have corrected yesterday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-14 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1247515534

   @danny0405 Please help me review, seems ok in the last ci test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-14 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1247514620

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-14 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1246501724

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-13 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1246152006

   A little hard to reproduce, please give me some time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-13 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1244997072

   Ok, I will fix it right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-12 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1244823600

   @danny0405 Ok, I will check the CI right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-08 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1240623881

   Seeems 
`TestHoodieSparkSqlWriter.testToWriteWithoutParametersIncludedInHoodieTableConfig:868
 » NoSuchElement` not related to this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-08 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1240518290

   I will check this ci failed issue local.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] TJX2014 commented on pull request #6634: [HUDI-4813] Fix infer keygen not work in sparksql side issue

2022-09-08 Thread GitBox


TJX2014 commented on PR #6634:
URL: https://github.com/apache/hudi/pull/6634#issuecomment-1240430808

   Hi @danny0405 , after my test, I find the inferFunc of 
https://github.com/apache/hudi/pull/5815 not be called, please correct me if I 
am not right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org