[GitHub] [hudi] Zouxxyy commented on pull request #9164: [HUDI-6516] Correct the use of hoodie.bootstrap.mode.selector

2023-07-22 Thread via GitHub


Zouxxyy commented on PR #9164:
URL: https://github.com/apache/hudi/pull/9164#issuecomment-1646728236

   @codope 
   > And then there is a config hoodie.bootstrap.mode.selector.regex.mode which 
can be either FULL_RECORD or METADATA_ONLY. This config cannot be set to 
METADATA_ONLY if we are using FullRecordBootstrapModeSelector.
   
   see BootstrapRegexModeSelector
   
![image](https://github.com/apache/hudi/assets/37108074/27ef83d5-c38f-40b6-a754-e3ec49d96c3f)
   
   `hoodie.bootstrap.mode.selector.regex.mode` is only used with 
`BootstrapRegexModeSelector`, It has nothing to do with 
`MetadataOnlyBootstrapModeSelector` or `FullRecordBootstrapModeSelector`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] Zouxxyy commented on pull request #9164: [HUDI-6516] Correct the use of hoodie.bootstrap.mode.selector

2023-07-22 Thread via GitHub


Zouxxyy commented on PR #9164:
URL: https://github.com/apache/hudi/pull/9164#issuecomment-1646508271

   @danny0405 @codope Can someone help with a review? It's a bug fix. And I've 
already resolved one conflict...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] Zouxxyy commented on pull request #9164: [HUDI-6516] Correct the use of hoodie.bootstrap.mode.selector

2023-07-10 Thread via GitHub


Zouxxyy commented on PR #9164:
URL: https://github.com/apache/hudi/pull/9164#issuecomment-1630137355

   CI failure is caused by other, Can you help with a review? @codope 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org