[GitHub] [hudi] alexeykudinkin commented on pull request #6355: [HUDI-4925] Should Force to use ExpressionPayload in MergeIntoTableCommand

2022-09-29 Thread GitBox


alexeykudinkin commented on PR #6355:
URL: https://github.com/apache/hudi/pull/6355#issuecomment-1262804005

   CI is green:
   
   https://user-images.githubusercontent.com/428277/193139753-763ed18d-ee41-4e29-9eab-850c05f99912.png";>
   
   
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=11905&view=results


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] alexeykudinkin commented on pull request #6355: [HUDI-4925] Should Force to use ExpressionPayload in MergeIntoTableCommand

2022-09-28 Thread GitBox


alexeykudinkin commented on PR #6355:
URL: https://github.com/apache/hudi/pull/6355#issuecomment-1261162597

   @fengjian428 we should add additional case for Merge Into statement tests, 
where we specify non-default record-payload and make sure that it still works 
as expected. This is a regression, so we'd add a test for it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org