[GitHub] [hudi] alexeykudinkin commented on pull request #7582: [HUDI-5488] Make sure Disrupt queue start first, then insert records

2023-01-18 Thread GitBox 


alexeykudinkin commented on PR #7582:
URL: https://github.com/apache/hudi/pull/7582#issuecomment-1396402031

   Landing this since there's no material changes since last revision, and CI 
passed previously


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #7582: [HUDI-5488]Make sure Disrupt queue start first, then insert records

2023-01-10 Thread GitBox 


alexeykudinkin commented on PR #7582:
URL: https://github.com/apache/hudi/pull/7582#issuecomment-1377612744

   @boneanxs @zhangyue19921010 
   
   We should do what @zhangyue19921010 suggested in his review
   
   1. Introduce empty `setup` method in the base class
   2. Move current contents of the `doConsume` for Disruptor into `setup`
   3. Keep `doConsume` for Disruptor empty


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org