[GitHub] [hudi] boneanxs commented on pull request #7582: [HUDI-5488]Make sure Discrupt queue start first, then insert records

2022-12-30 Thread GitBox


boneanxs commented on PR #7582:
URL: https://github.com/apache/hudi/pull/7582#issuecomment-1368159010

   > But do we need to have a synchronized check for each record 
consuming(performance concern)?
   
   This fix won't do the synchronize check for each record, it will only block 
the consuming when the queue is not start yet.
   
   But I think adding a new `setup()` method is also an appropriate way. 
Pending this for a while if @alexeykudinkin has other suggestion. Or I'll add 
the `setup()` to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hudi] boneanxs commented on pull request #7582: [HUDI-5488]Make sure Discrupt queue start first, then insert records

2022-12-29 Thread GitBox


boneanxs commented on PR #7582:
URL: https://github.com/apache/hudi/pull/7582#issuecomment-1367711026

   @alexeykudinkin  @zhangyue19921010 Could you please help to take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org