[GitHub] [hudi] codope commented on a diff in pull request #9488: [HUDI-6731] BigQuerySyncTool: add flag to allow for read optimized sync for MoR tables
codope commented on code in PR #9488:
URL: https://github.com/apache/hudi/pull/9488#discussion_r1300434964
##
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##
@@ -128,6 +128,12 @@ public class BigQuerySyncConfig extends HoodieSyncConfig
implements Serializable
.withDocumentation("Assume standard /mm/dd partitioning, this"
+ " exists to support backward compatibility. If you use hoodie
0.3.x, do not set this parameter");
+ public static final ConfigProperty
BIGQUERY_SYNC_ALLOW_READ_OPTIMIZED_SYNC = ConfigProperty
+ .key("hoodie.gcp.bigquery.sync.allow_read_optimized_sync")
+ .defaultValue(false)
Review Comment:
Let's remove the flag. Don't even need to log a warning. We can call out in
the docs that RO queries will be supported for BQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #9488: [HUDI-6731] BigQuerySyncTool: add flag to allow for read optimized sync for MoR tables
codope commented on code in PR #9488:
URL: https://github.com/apache/hudi/pull/9488#discussion_r1299533082
##
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##
@@ -128,6 +128,12 @@ public class BigQuerySyncConfig extends HoodieSyncConfig
implements Serializable
.withDocumentation("Assume standard /mm/dd partitioning, this"
+ " exists to support backward compatibility. If you use hoodie
0.3.x, do not set this parameter");
+ public static final ConfigProperty
BIGQUERY_SYNC_ALLOW_READ_OPTIMIZED_SYNC = ConfigProperty
+ .key("hoodie.gcp.bigquery.sync.allow_read_optimized_sync")
+ .defaultValue(false)
Review Comment:
Shall we enable by default? For other engines, when we started, we supported
COW and MOR read optimized by default.
Also, let's track a ticket to deprecate this config once snapshot query is
also supported for MOR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
