[GitHub] [hudi] codope commented on pull request #3765: [HUDI-2533] New option for hoodieClusteringJob to check, rollback and re-execute the last failed clustering job

2021-11-22 Thread GitBox


codope commented on pull request #3765:
URL: https://github.com/apache/hudi/pull/3765#issuecomment-975401738


   > Hi @codope. Sorry to bother you. Just asking, is there anything I can do 
about this pr? Or could we land it and I will modify the docs as the next move 
:)
   
   Sorry, this slipped out of my radar. This change is good to land. I have 
created [a separate ticket](https://issues.apache.org/jira/browse/HUDI-2820) to 
update the clustering blogs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hudi] codope commented on pull request #3765: [HUDI-2533] New option for hoodieClusteringJob to check, rollback and re-execute the last failed clustering job

2021-10-29 Thread GitBox


codope commented on pull request #3765:
URL: https://github.com/apache/hudi/pull/3765#issuecomment-954694045


   > Hi @codope Thanks for your review and sorry for the delay response.
   > 
   > ```
   > Do you think we can add a time-based config to retry last clustering only 
if some configurable amount of time has passed?
   > ```
   > 
   > Sorry I didn't get it. Is that means we can let users to set a retry 
clustering instant time?
   
   @zhangyue19921010 My point of view is that inflight clustering could mean 
that clustering is still in progress and taking some time. So, if users have 
setup clustering job as a cron with retry mode then could it be possible that 
even before clustering completes, retry is triggered and the job is repeatedly 
retrying. So, that's why I thought of having some config which will trigger 
retry only after some time has passed since last pending clustering. 
   
   I believe most users execute this job manually and not as cron so it's not a 
blocker. But, let me know your thoughts about this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org