[GitHub] [hudi] danny0405 commented on a change in pull request #3912: [HUDI-2665] Fix overflow of huge log file in HoodieLogFormatWriter
danny0405 commented on a change in pull request #3912: URL: https://github.com/apache/hudi/pull/3912#discussion_r741647600 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java ## @@ -148,10 +148,11 @@ public AppendResult appendBlocks(List blocks) throws IOException HoodieLogFormat.LogFormatVersion currentLogFormatVersion = new HoodieLogFormatVersion(HoodieLogFormat.CURRENT_VERSION); -FSDataOutputStream outputStream = getOutputStream(); -long startPos = outputStream.getPos(); +FSDataOutputStream originalOutputStream = getOutputStream(); Review comment: Can we give some tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3912: [HUDI-2665] Fix overflow of huge log file in HoodieLogFormatWriter
danny0405 commented on a change in pull request #3912: URL: https://github.com/apache/hudi/pull/3912#discussion_r741647600 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java ## @@ -148,10 +148,11 @@ public AppendResult appendBlocks(List blocks) throws IOException HoodieLogFormat.LogFormatVersion currentLogFormatVersion = new HoodieLogFormatVersion(HoodieLogFormat.CURRENT_VERSION); -FSDataOutputStream outputStream = getOutputStream(); -long startPos = outputStream.getPos(); +FSDataOutputStream originalOutputStream = getOutputStream(); Review comment: Can we give some tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3912: [HUDI-2665] Fix overflow of huge log file in HoodieLogFormatWriter
danny0405 commented on a change in pull request #3912: URL: https://github.com/apache/hudi/pull/3912#discussion_r741647600 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java ## @@ -148,10 +148,11 @@ public AppendResult appendBlocks(List blocks) throws IOException HoodieLogFormat.LogFormatVersion currentLogFormatVersion = new HoodieLogFormatVersion(HoodieLogFormat.CURRENT_VERSION); -FSDataOutputStream outputStream = getOutputStream(); -long startPos = outputStream.getPos(); +FSDataOutputStream originalOutputStream = getOutputStream(); Review comment: Can we give some tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3912: [HUDI-2665] Fix overflow of huge log file in HoodieLogFormatWriter
danny0405 commented on a change in pull request #3912: URL: https://github.com/apache/hudi/pull/3912#discussion_r741647600 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java ## @@ -148,10 +148,11 @@ public AppendResult appendBlocks(List blocks) throws IOException HoodieLogFormat.LogFormatVersion currentLogFormatVersion = new HoodieLogFormatVersion(HoodieLogFormat.CURRENT_VERSION); -FSDataOutputStream outputStream = getOutputStream(); -long startPos = outputStream.getPos(); +FSDataOutputStream originalOutputStream = getOutputStream(); Review comment: Can we give some tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
