[GitHub] [hudi] danny0405 commented on a diff in pull request #7437: [HUDI-5366] Closing metadata writer from within writeClient

[GitBox]

danny0405 commented on code in PR #7437:
URL: https://github.com/apache/hudi/pull/7437#discussion_r1046617576


##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##
@@ -1125,6 +1130,14 @@ private HoodieData 
getFilesPartitionRecords(String createInstantTi
 return filesPartitionRecords.union(fileListRecords);
   }
 
+  protected void closeInternal() {
+try {
+  close();
+} catch (Exception e) {

Review Comment:
   If we do not want `#close` to throw checked exception everywhere, just 
remote the throws from the interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #7437: [HUDI-5366] Closing metadata writer from within writeClient

[GitBox]

danny0405 commented on code in PR #7437:
URL: https://github.com/apache/hudi/pull/7437#discussion_r1046617209


##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##
@@ -752,6 +752,7 @@ public void 
dropMetadataPartitions(List metadataPartition
   LOG.warn("Deleting pending indexing instant from the timeline for 
partition: " + partitionPath);
   deletePendingIndexingInstant(dataMetaClient, partitionPath);
 }
+closeInternal();
   }
 

Review Comment:
   Can we let the `HoodieBackedTableMetadataWriter` implement `AutoClosable` so 
that it can be used in the try finally block. Can we also fix 
`HoodieFlinkWriteClient#writeTableMetadata`,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org